Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

["Gao, Zhichao" <zhichao.gao@intel.com>]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jeff
> Brasen via groups.io
> Sent: Friday, July 8, 2022 2:15 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Gao, Zhichao <zhichao.gao@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
> 
> Just following up on my outstanding edk2 patches to check on status/review
> feedback.
> 
> Thanks,
> Jeff
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Tuesday, June 14, 2022 11:54 AM
> > To: devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> > support for Ufs
> >
> > Add support for getting disk info from UFS devices.
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> ++-
> >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1
> +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > index fac33b9ee9..87b82f299f 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> >
> >
> >        BmEliminateExtraSpaces (Description);
> >
> >      }
> >
> > -  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid)) {
> >
> > +  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid) ||
> >
> > +             CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoUfsInterfaceGuid)) {
> >
> >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> >
> >      Status     = DiskInfo->Inquiry (
> >
> >                               DiskInfo,
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > index fe05d5f1cc..2fc0a80a4e 100644
> > ---
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -85,6 +85,7 @@
> >    gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_CONSUMES ##
> GUID
> >
> >    gEfiDiskInfoScsiInterfaceGuid                 ## SOMETIMES_CONSUMES ##
> GUID
> >
> >    gEfiDiskInfoSdMmcInterfaceGuid                ## SOMETIMES_CONSUMES ##
> > GUID
> >
> > +  gEfiDiskInfoUfsInterfaceGuid                  ## SOMETIMES_CONSUMES ##
> > GUID
> >
> >
> >
> >  [Protocols]
> >
> >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> >
> > --
> > 2.25.1
> 
> 
> 
> 
>