From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.24809.1658131993140633764 for ; Mon, 18 Jul 2022 01:13:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XDE7nW+q; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658131993; x=1689667993; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7Tymk5kI13z9PVrmh0a1kF4XnFTj4yRhTLDQqsh80eo=; b=XDE7nW+qNB3RiEYnlH3TiJPcdFOKFilJ+X5uTePDDHJfwOOeOYhrN0f2 iSdEJau48xKPZWHnKYxexWeU4l4CSqNH7KdsTUzX7hU2C4wTdvMJ8Ej11 ApnojpELdD+/1RkNV28wBb4RsRGaNnOuAaXJjlge46AvuAwcOFcSrzNv/ TKo4F1vGN6pxjRbHjgQPr9BVH7GAa4c+q2p419CcHqNRkDqFZWf+lPp9t UeQ9/+RczeIGEvp0wiAFmOxbByW6FHYPiEngYiBgFMPHijPf0qcx4Z4dl uv7nTYraGtJjlhLmuw0i3WRuLS46rOAbn2BadjD/E/47AiSVI/VuPHeCy w==; X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="266569098" X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="266569098" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 01:13:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,280,1650956400"; d="scan'208";a="843192565" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 18 Jul 2022 01:13:12 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 18 Jul 2022 01:13:12 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Jul 2022 01:13:11 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Jul 2022 01:13:11 -0700 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Jul 2022 01:13:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W80Dwst+VQ6YAXCrwmOeZFc7NEyyNu98/PUKTAiZX3/ALyKvIYAFAlaUeyM2srFefNzN8NJoQ//5PidwoL/jAbzLzVsNIYMFmU0iXLbLKO8Y7BHb+soaa8gMhHoKHX/ucz3Tc+JuetAWmTs3g5Qfi9equY/l+EF7IC1aPvoz8PgFUl0UxlLMn9WHvO4z2RMgGoi4C5085ShhOVL4l6LvchgMLQbGo5ebLudL48LQv3BzgVnF48sfFevaFyIxsbjW87r/wbtVKR83d/zc3SqDxA/SH1u65cmfrxMyTEGTwHUE6A+nMIAXdmtl6L22GH2Tu6nAIhFQKwne6FeS2vN0tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e2Ao3Lv/EbroEhxiq17OklYfMEGFLZFoGLA1rKZCbwc=; b=hOCU2AwCeqCEn9eQ3vwjWFyU67JwneOYmCItrdpteX5GHHpzYrYbZ1yA+ZVFkxA6DIzZVypPsgkMVnYQs+XetOUq5jqbXVORWU5Jw0mnW6gn9sWcbvZ6JMfeGkhDUbkZoersrKGrbxJgdwUihwNwVDHVv2yYcAW6h5uzeutS7zWzY8s7Dv5BbntTgeVTUTS5Wzfxd2dYPaEJGsrtbDK8ocjxNLmyUXDrmROLdnYH3/3j+NcxAmmZChiGKwqP544gs/QD5CRIULYMTcXARTkYpiyzc03K5dv47d3Ct2OikyLEA8Tk7R2oy3JeUxPS2MM0VqZ0haBMrvIJ3YzcusUilw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by PH7PR11MB6721.namprd11.prod.outlook.com (2603:10b6:510:1ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 08:13:09 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::e1e3:11d:934b:47a7]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::e1e3:11d:934b:47a7%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:13:09 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "Wang, Jian J" , "Gao, Liming" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Thread-Index: AQHYgBfGcmAZTt1PkkqWgQZ8FMMOF61zWqcAgBChZFA= Date: Mon, 18 Jul 2022 08:13:08 +0000 Message-ID: References: <9c52d44c283b1c42de20ee373be1d4994c4daf35.1655229046.git.jbrasen@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ed55c742-862e-4381-12b8-08da689559a4 x-ms-traffictypediagnostic: PH7PR11MB6721:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FvZTyPqb8X1NWMW/8AX0peuOz8h0UwkpMFDDnuUnDtjMEyJnUA2v7L17wtlZFFXrzxALfiqWsZ1bEqkyuSeKhyePCCmmMuRG+0l9YoXLRjQMDDMYf5sctW5SaHGV2orFEtekhP3oWktXeHiXzMMKciH55fjARqoznJzcUlqYX20cgrvjcVkM9RXZvFFPOqgpmsyNsalFxDvvQ6VgIhQQliCzny45QZOtY32ZbA/0m3EmZUyYkPtMOI2jKAvi3Rti2QPW1M/T23oN3AgvrxyctSWiyaCZV6LfofxgTaHE2qdqYT/bnTsJJ9Fq3o7UggpCYYEzvhesnyJKY2fyPO5v0PXmExX2/U72ta+YzWRoaZYLQaWy86Z5PuKQxMVwapEL1Hg/w1JRxp8TR8YagW6Ea3x+V/9gJNN+BdH/JRjtpXwPItwoaGPivyMH3qGxLCeW/kfb/VMsRHhNvgjyuAnftO2NDOEnUIYLVxPOsP1wUncjQ8dhKs4lrF8N3HyqppT0ddRh+Pq0ZizjoLmdlmFnO+tzBYHuOBo7RVIYUayH072XlfUWDmyuh+84zLax8YxryhPzrz7cgKKkDN7RIn1zZsDzu/Nv8g0zdqSbgHGWeowvFe/nECcRldfJZi3yX3GHEsulH9ahAsU3gjchMOv8YSzQXmvsXppjkTmpm8TZ/EFEgzf8K0FWtC7aLgpBT91PdIgxaq4UI4FHT/GappSXrE7h8Mnu6MCPj9RUnsrQLMXy0fDROeNium3vZEuSL4cC0kbiDQ8bHKktlymiEZ0jczbI+j6u5mO4/XuFU/fz8MQaUYx2M3HQ+5rIdoEm5AVLUsHSpVapUb6UDN+rhxVq3mkg5RNDySOX6Ryv5ybZ4leVwbLazdTGnaEsxzWsTht6VG9RlwPKWGCFSxBWA5gpEw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(136003)(396003)(39860400002)(376002)(55016003)(966005)(83380400001)(186003)(54906003)(38100700002)(110136005)(71200400001)(64756008)(66556008)(66446008)(76116006)(316002)(66946007)(8676002)(66476007)(478600001)(41300700001)(6506007)(7696005)(2906002)(53546011)(8936002)(107886003)(5660300002)(9686003)(86362001)(52536014)(38070700005)(82960400001)(26005)(33656002)(4326008)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qLU5wC9ZuNi7lJnzdOe10TX22qtYp0YC//VxoFlX3v2ql/wYEj5LzS8TI+Qs?= =?us-ascii?Q?zVJJVXPKmr1zrFPXOod23NCs4a0/FyWAAnCnilyJkEqhLYUnBhNKMPsCrJFy?= =?us-ascii?Q?GzNIiRMT3QkMbwoOQDDhZ49S7++jOcXCz3Gt0ybNFZ/HiNB0mLIcn8VkPOos?= =?us-ascii?Q?uch6MoehuTmEdJbiUusAmXt9RM72JeuwO8M+L12K920mZtwvQXaa+5NyJz9v?= =?us-ascii?Q?g0jGb5tkkmqa29B9sjJx+lSKnVwz5Y9sNlk8Sm7mezBT3ZVnhHkdMTcQT0FU?= =?us-ascii?Q?WTUw+jpZBE5qguE5/MBKC/BjlPsDXAzptgPf2OpTytHeKO0ngyh2RwVSWGmH?= =?us-ascii?Q?xZncI8icCRXsiRG+bj5LktzgAlzQENSMt+P7llvOTrsrAuDwv3zVQxOidHkC?= =?us-ascii?Q?T5ZAZznmsH6m9+YcDxGQO4KIyFEulK15eaypWaRXI67SGWfBswLLhiYVqkeX?= =?us-ascii?Q?TKehklnsz2A4enNUUUNzkvVlbYC38KHp0GHJngNR04CoWFOX4Yeq1zYWxEMi?= =?us-ascii?Q?+YMZEKHAQ119ZxDNf1AO8NH+Difpaf3oV22Eek+2dNcUfDBcgf/COn1Wz53+?= =?us-ascii?Q?0ONsT8sPOClXEOo2rNexYucC/iMs81nH//4sK3fMq+xkntDEkMMafHaIUt4g?= =?us-ascii?Q?XhO+0+IGNDYwp3A/Yr7cLjwcG/BgEu9tSYKVfUYL4hIa9FGJUnD+vX5Q7hSe?= =?us-ascii?Q?QmRdH2uaKBJpbejv0dYRYCb1Ww27hASrMwZWyfMk/Kf3NQpfNBVUTYTpuuyH?= =?us-ascii?Q?08YJRdzb81mV5mk9bFKgpd+ZWKKcllYmmTd1a332912UbXn96mN6jrrJSp86?= =?us-ascii?Q?k3cgW3CDii7gFDxRmRUiQ4ssNlrhBYXcnCBJkwq8NoH9If6PeL2Mf7XBFbzX?= =?us-ascii?Q?TD7kTiPaL0dklYiw+HvrndfPs6fZBO45dvfPvI+dYynzuzgB1r2LvTa2zTXs?= =?us-ascii?Q?oREET7RuT7ENijN89gM6aR/bDrjCaxvPrPqTlsJxl6nUEmhi1IBSaY0SEfJp?= =?us-ascii?Q?tuWno8GZhstMU1kPYEODffoltn6Fd/S7K9GhPwqYb5YBmHdj2sjDKSL0eEa6?= =?us-ascii?Q?IiCl1JJMIZb1fjAM5ePZ/jSgl08xEUV5OHVgZj7bXWtrHs+Xf9GY5gcB2nWy?= =?us-ascii?Q?/OKSW6ZW24ZNBg8jVicgZ9V8pO6WX/1Oqftzn+tPrQ8hJDFvbNNHesepNWAA?= =?us-ascii?Q?WtiPdENzvoqR04IRAn+ctf37iA7lQgviVRoAHWHqCjJN8r3sM5Qx7qTCkgfr?= =?us-ascii?Q?Soz+m7f8I0tF3TZhpug78dlMJDc+8k00TeHC8/+62l+acG7wI3wKuYZ0dV6N?= =?us-ascii?Q?/YF8ByFe7u1r4oom6VBALqhmKekaNvIdSQXXr9vBi5isck8P9exdM8Oiyesp?= =?us-ascii?Q?LFriZtc2AAcJRMw2IgWX5xov9h3l0qMGiftVuhCTPJLpXDkkwqF8mhxKQvVz?= =?us-ascii?Q?pYacBHPgJDpsuS5zb0YBi2PqfHToSeaYRCHECo5S7SSPv0mX6b0on/pEE3uq?= =?us-ascii?Q?8UrbM8YDpB1oNPTg0F85v7x1NLDtEW7MZ3e+5bfvCYZxbAaIM4WOFdeusxLC?= =?us-ascii?Q?YjJRYG9AcahVaPZCE7yGwWwlYGhtyv1qMuRjC+r7?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed55c742-862e-4381-12b8-08da689559a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 08:13:08.9217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5fDYAU52+cOocV8d+AlecW8eiEh3f9fGl1RBXZceaAFwh/kn1Vj2aKQXSYNgV0fmBI9btQyG7mFzr/a7H2UakA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6721 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Friday, July 8, 2022 2:15 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Gao, Zhichao ; Ni, > Ray > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: > Add Disk Info support for Ufs >=20 > Just following up on my outstanding edk2 patches to check on status/revie= w > feedback. >=20 > Thanks, > Jeff >=20 > > -----Original Message----- > > From: Jeff Brasen > > Sent: Tuesday, June 14, 2022 11:54 AM > > To: devel@edk2.groups.io > > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn; > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen > > > > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info > > support for Ufs > > > > Add support for getting disk info from UFS devices. > > > > Signed-off-by: Jeff Brasen > > --- > > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3 > ++- > > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 > + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > index fac33b9ee9..87b82f299f 100644 > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo ( > > > > > > BmEliminateExtraSpaces (Description); > > > > } > > > > - } else if (CompareGuid (&DiskInfo->Interface, > > &gEfiDiskInfoScsiInterfaceGuid)) { > > > > + } else if (CompareGuid (&DiskInfo->Interface, > > &gEfiDiskInfoScsiInterfaceGuid) || > > > > + CompareGuid (&DiskInfo->Interface, > > &gEfiDiskInfoUfsInterfaceGuid)) { > > > > BufferSize =3D sizeof (EFI_SCSI_INQUIRY_DATA); > > > > Status =3D DiskInfo->Inquiry ( > > > > DiskInfo, > > > > diff --git > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > index fe05d5f1cc..2fc0a80a4e 100644 > > --- > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > +++ > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > @@ -85,6 +85,7 @@ > > gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES = ## > GUID > > > > gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES = ## > GUID > > > > gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES = ## > > GUID > > > > + gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES = ## > > GUID > > > > > > > > [Protocols] > > > > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES > > > > -- > > 2.25.1 >=20 >=20 >=20 >=20 >=20