Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/SmbiosView: Add Type 45 entry to query table

["Gao, Zhichao" <zhichao.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3796 bytes --]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

From: Giri Mudusuru <girimudusuru@microsoft.com>
Sent: Tuesday, April 23, 2024 11:55 PM
To: devel@edk2.groups.io; ellie.lewis@arm.com
Cc: Gao, Zhichao <zhichao.gao@intel.com>; Giri Mudusuru <girimudusuru@microsoft.com>
Subject: Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] ShellPkg/SmbiosView: Add Type 45 entry to query table

Reviewed-By: Giri Mudusuru <girimudusuru@microsoft.com<mailto:girimudusuru@microsoft.com>>
________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Ellie Lewis via groups.io <ellie.lewis=arm.com@groups.io<mailto:ellie.lewis=arm.com@groups.io>>
Sent: Tuesday, April 23, 2024 3:51 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Cc: Zhichao Gao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
Subject: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] ShellPkg/SmbiosView: Add Type 45 entry to query table

[You don't often get email from ellie.lewis=arm.com@groups.io<mailto:ellie.lewis=arm.com@groups.io>. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

The type field value is currently undefined for type 45 SMBIOS tables
in smbiosview. An entry is added in the query table to display the
correct value for type 45 tables.
Bugzilla: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D4733&data=05%7C02%7CGIRIMUDUSURU%40microsoft.com%7Cffd3eb0d33e4454bda3108dc63a5c7b7%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638494810879613185%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=TKB1DcLEXngmx12y8vaLsPLZPkm9uL%2Be51Ui%2FI8rwrg%3D&reserved=0<https://bugzilla.tianocore.org/show_bug.cgi?id=4733>

Cc: Zhichao Gao <zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>>
Signed-off-by: Ellie Lewis <ellie.lewis@arm.com<mailto:ellie.lewis@arm.com>>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 36f8739d6c87..d786b14f3877 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -5,6 +5,7 @@
   Copyright (c) 2005 - 2024, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016-2019 Hewlett Packard Enterprise Development LP<BR>
   Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+  Copyright (c) 2024, Arm Limited. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/
@@ -3918,6 +3919,10 @@ TABLE_ITEM  StructureTypeInfoTable[] = {
     44,
     L" Processor Additional Information"
   },
+  {
+    45,
+    L" Firmware Inventory Information"
+  },
   {
     0x7E,
     L" Inactive"
--
2.25.1

«¢êlS'âzK¢êÞqè¯y©e(tm)ë,j¬±éí¶<aSÈ+¢êU?ì?EêeÈéåSwµ×Ízöm¦ÏÿyÙ6'º.¦È¨þÝz÷¥þg¬±¨‑ÿ]|ׯLº×"?+\x13¢~oe?Ûi³ÿà®<©²*?sßõÓz½ÓÞ|ÿÎ9ã]ôº.¤ì'z·^½é~£ Þ­çdÚ
èº>"¡Iì¹»\x1c®&Þ?Ûi³ÿÞvM ®<©²*?f÷^½é\x7fº{.lb\x11 ÅQ%\x11Rhoe®<(~×(


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118177): https://edk2.groups.io/g/devel/message/118177
Mute This Topic: https://groups.io/mt/105690958/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 7853 bytes --]