From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.27241.1683622827357541328 for ; Tue, 09 May 2023 02:00:27 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IqG+En2C; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683622827; x=1715158827; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Xpuiv+L+XoQbudtMjNjDLFXQ0FhIM+MkMHOsEUmIaPg=; b=IqG+En2CN5bF/gNTCoRo1c3RhCHc+4hg3L0tejUBEBUKm1iaA6K4Z00E NM+2C7fFB7f7Qg89KQu2RxCEYiOSdTzbApkc4NCMkVJOOtDTue3Nja64W WRN6AI02dvhYLh1bYkhI4IcASsrZJH7ndpkuO7LlTj6ABRgSgrN8rxK2N mi9OUSa4mDOG5fOHjAZt4lKN1PPUFOyc2r9XfIa7js4VHsdlz9m01kAQV /5+oZYKhxU5kSA7wUEB3pDp9lFSYoVFcu/YJrutsSndAArxB2P2WdUdk9 9NN96dK2/N9E9ZR6tx+mbuR2b+xK/j4FM/cHNOrPR6vBQyubpLBRNrkvh g==; X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="377951950" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208,217";a="377951950" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 01:59:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10704"; a="768392876" X-IronPort-AV: E=Sophos;i="5.99,261,1677571200"; d="scan'208,217";a="768392876" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 09 May 2023 01:59:59 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 01:59:58 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 9 May 2023 01:59:58 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 9 May 2023 01:59:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WtSuRrqe8RZB0qi4hV08HDXWEcD9ixqgbIuYw71RjqR2nuwAnajnO05un8L1jiwKyEyC8hlZfFf0bNf10oGFdlXEx88O/49Opt2VKOcMcrYnOxRKMI2Z68ZbYQi+z6J0pME+EDvMsCMoe0m4HH9HntUMtqT1GVcqmJ2jqYNAJKmsEPFPtbsfRyf1EgvQZaf+XD7pi+thBNptvmshIso53B78vm5SOcFYmAvk60LDswOIJRcQ2UYfvane9uQCiEWO5enyyCtTPpQ+6y62vFyGHYLewLtCGHYxtCYOODen07aGtJjt16ka+w3wEzY5sjl/I8i94g0WyxGxFRdrX9mKzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yFSEf8+jtz/bDZsjPY0idTA+xNrPvSmM34HaBCdyWN0=; b=VbizMnJUrzc4WT5UkALpzk/Dg8BO1rI3hslVL18f2lL61DQYRTix4crtDujEijCBpdqhidl+6klrRjqu28JYAlpybXZgQUb/7zC7Ic/K/47Z7BANVF1DZAdOtq0DNtB6d52lgpWqDUmHLZizTfkmaACVsPtCThfz0zFKzafzS2KPhHH32qChsrSdS5Cqi2jXyB5oiwmiV6RcanDOKDNBbynIcuksVPhNzb36hHS67WIoXFKtNs5UKzAysJEQafkjEDhqF8Elr+Q+qwiZGmhG/ohCtsxQE9IvRO3hCs0JPmgMQyHKxgBPxk0RWZZtFbR0GywfXeHmUDKNFX7fstEEwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by DM4PR11MB5358.namprd11.prod.outlook.com (2603:10b6:5:395::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Tue, 9 May 2023 08:59:56 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::c785:1a9a:411b:50f1]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::c785:1a9a:411b:50f1%6]) with mapi id 15.20.6363.032; Tue, 9 May 2023 08:59:56 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "nicklew@nvidia.com" , Thejaswani Putta , "Ni, Ray" CC: Nick Ramirez Subject: Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Thread-Topic: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate type0 Bios Size in smbiosview. Thread-Index: AQHZc+zGrv5i7K9SukewsUvlvSCuz69KRAmAgAd876A= Date: Tue, 9 May 2023 08:59:56 +0000 Message-ID: References: <20230421010023.25867-1-tputta@nvidia.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|DM4PR11MB5358:EE_ x-ms-office365-filtering-correlation-id: 1299c5da-c8b0-4c72-adf2-08db506bc2f4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CQtYdeeXRsQXuGGM2xdGz+uLKrZOZr0+fmRdjteYzZ1At9bBbv8PKt+qFiyInpj2zXzpLsJ64ofmQQwnimuHsB7iaWJAWyf2uuLOMwbao3hoGmTIkkMawMy77W3WYwCk6HibRpp6wwoqybmlj535DNXgwSuNA5p7ulwRxLCut9/qMtk1zR7c7Wz4jVBrKksWEquSwXpKBZAeYv79sKBJcgnKLY1R419yaH/BPgfFzJkT7u/UstZKqBryC5anLNjcX+9yxwCGcaEpIIZ3SK55yWww0J2sfeNyvBOlimj9lQTjSHJMxZrTEYFcAuPi3XKrzrwYL/HNqu90dAlhKYtG09G+S4+RMJ1kLt5o9ScF0lqMBEL7tFcpdog60SHESN2b6WqnkLxQnwJoNEaAxvw7W46KEcsPHOnkJZIHvM5u3tKRnuD2YwSBT1+Bm3IZ29COiBFMxSckeCQDSx3DNCK4Xd176bu3F/jh/63Ol/lfYCJSdiOyLD6ZLnWR6hqh5RhZ8JhPz2LMzhqUE6G/+DX3pL3PPE/WChwhYp3/5bPwCf0tcLmI8JKc4ZATWna4w7cB+jBIlyliOXXysbZt5DdD8kb0QoiW9G29dl7vXopNCWBxVmvFm8gDqqhvieuz3v4qohOcmxyTyMuBEXz2OVUFgA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(376002)(366004)(136003)(346002)(451199021)(6506007)(9686003)(53546011)(7696005)(83380400001)(55016003)(38100700002)(76236004)(33656002)(122000001)(166002)(86362001)(38070700005)(82960400001)(186003)(110136005)(41300700001)(2906002)(4326008)(6636002)(64756008)(5660300002)(66556008)(8676002)(66446008)(66476007)(478600001)(8936002)(316002)(52536014)(76116006)(66946007)(71200400001)(66899021)(1406899024);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lR21m0X6WOe3NDjwQs0oV8lSRd31+iThlg2dEKIAYhpIff5KhkDxFjLh20sP?= =?us-ascii?Q?cgwnqy5oqjirE+aWi7pSEMHSIsBxNVO/A5Q1KndWPc6e6KEDGMDuEuG/tWT0?= =?us-ascii?Q?EMHzToWj7bSrAPeLN8qofvRCXjamnxaKMfOPidYe6zvO6IPUP+G6WGATn38a?= =?us-ascii?Q?GLSHWwmZTNo3/0/teBk0TAke/nRjTs4silF5XhS7Dt8vJJRP47Eg3ExFVSy7?= =?us-ascii?Q?JEcXRCG1q2N+WpAMO9kQ9l2ONhqxZ3OizcIDvy3Ua6HPqYg/pVuGerx4/h5y?= =?us-ascii?Q?1z5DszVlXY1oUgsqG9TIThQ4SuLVJFQnXb6HSlum5rXiERZKD2bpW/PTPjL3?= =?us-ascii?Q?hudMOmb46z8RkEKUwlia80vBS9xMW4yy6p3758eIfUsc/bUwZt0s5rqevSGN?= =?us-ascii?Q?XgFxLMDfvKQcNfguWYdZQbFJQXD8ISDDBCkYgXAp0WQl94Xyhasg/bfct7g6?= =?us-ascii?Q?sDY1Rw4M1pYRHhqvdCtpCKqPLf3yBBEDkKjZJqHPJqbWP3P9+it9qnH2v0tY?= =?us-ascii?Q?VaFasBidf2/lktcs2ht+KrBCdlvBtgni4Taw9bz6neroJsb+rUaTdSpCK2BM?= =?us-ascii?Q?SYEzEMGjBQe1ys3rKmcpad0uIKY0uQzGfr3I5xCdf1hiRT9pqrRtbCyqi9KN?= =?us-ascii?Q?8D7WdK435io6dJ1sWgQx0WV82xZ8FEN3kGeq/E3dUPt1gip6DWcxAoKNMVhQ?= =?us-ascii?Q?OHqwBzC7UjBSILJf14cCH4sXsxqBUHD194jxO595FMrZBCwQ5up2iabhvNGh?= =?us-ascii?Q?Z/0OCpzILi9rJWjkt459cMQ5cA2fqGuxXtqhHS85KFpJZbI6jXmyDGnyX2fH?= =?us-ascii?Q?7BOtZMkKNsbcdj8HSu3SlfiQ4y5U6cMlH4tLpzQ2XbimBhwxuP4sbiQovEoh?= =?us-ascii?Q?sSHYA1M2CBx7Wq3oElTfrkBDIv5xkUAU7tiUdaPHoK+m3oCBCf62D9Qt5uLP?= =?us-ascii?Q?QJhvba29wVNdWUTEBhCY079t3iYzL1I4ySjyWrBJGN+WmPBmUP/PJLsFRcAO?= =?us-ascii?Q?+3emz4iEQaAMTlm7aFe7fn0Hw9jgt3ZkF714DfHtDQzf0Gm1duLw2IoC580M?= =?us-ascii?Q?y2syfwX+/8A63RoID2F+zdDT3zt3ZXjbVi7CqDOajR4H6zkHf3AboEkz4obE?= =?us-ascii?Q?VbzN9QR0S9N7L/JC+PUgWnXEz4ip9m/kpK9l28fOkTxfjAZ+PHloxX83axaF?= =?us-ascii?Q?c/IrK0XOzKnrzROdwyU2yudoFq5mfsDhCm1cKfug8UWn6vTf2exIZamTJ1BQ?= =?us-ascii?Q?vTSo1tehoLT1PE2xvqDRJ4w3wz35G6qWP++TEwyt+2iONHChvzqp5XLgBo8w?= =?us-ascii?Q?1lhw2R3c4TXL/6FakSShBzwEj4SrLzSPV8TC8lfODL1ionXysfwBibxNtK41?= =?us-ascii?Q?7onmId0IC4XO/rz/NGmuq2eu1hYwVm+ODG23CuWSP5VzhGgkk1P7FSP4tAq/?= =?us-ascii?Q?9dXCQ699iE1Sk2kGTxQjHu5+RKSbG1QvUsQs1J8TXTl+onsUGo8DKm5le7N5?= =?us-ascii?Q?ysAkBsxGVd4VjdcbNVE6HEXBwPNuEYzGaR+QeLrPbrWVU2Dc0fTNGdvZaS7l?= =?us-ascii?Q?KH8TFOBjXjXtFJ7XlzM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1299c5da-c8b0-4c72-adf2-08db506bc2f4 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 08:59:56.5014 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gWk/xsYyGPfNUQsJgAGD9s0xXG2YERbTZyvOzuune2rIdgVj0rmOdR2IXfI5v7GjEzt658IwUMd3Fh83lMmnDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5358 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR11MB63773C95CA2147FC68681A45F6769PH7PR11MB6377namp_" --_000_PH7PR11MB63773C95CA2147FC68681A45F6769PH7PR11MB6377namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao zhichao.gao@intel.com Thanks, Zhichao From: devel@edk2.groups.io On Behalf Of Nickle Wang = via groups.io Sent: Thursday, May 4, 2023 10:37 PM To: devel@edk2.groups.io; Thejaswani Putta ; Ni, Ray ; Gao, Zhichao Cc: Nick Ramirez Subject: Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accura= te type0 Bios Size in smbiosview. Hi @Ray Ni, @Zhichao Gao, Could you please help to review this change? Thanks, Nickle > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Thejaswani > Putta via groups.io > Sent: Friday, April 21, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Ray Ni >; Zhichao Gao > > Subject: [edk2-devel] [PATCH] ShellPkg: Add a condition to print accurate= type0 > Bios Size in smbiosview. > > External email: Use caution opening links or attachments > > > As per the SMBIOS spec, in smbios type0 table, if the Bios size is greate= r than > 16MB, extended bios size is used to update size information and bios size= is set > to 0xff. when this data is printed by smbiosview, both bios size and exte= nded > bios size is printed if the smbios version is beyond 3.1, which is incorr= ect as Bios > size is set to 0xff when rom size is more than 16MB. > > To fix this bug, added a condition to print bios size only when it is not= set to 0xff > or if the smbios version is older than 3.1. > > Signed-off-by: Thejaswani Putta > > Cc: Ray Ni > > Cc: Zhichao Gao > > --- > .../Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index 1811cf0c44..5448abaa22 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -339,7 +339,9 @@ SmbiosPrintStructure ( > ShellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (S= truct, > Struct->Type0->BiosVersion)); > ShellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", St= ruct- > >Type0->BiosSegment); > ShellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosStri= ng (Struct, > Struct->Type0->BiosReleaseDate)); > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * > (Struct->Type0->BiosSize + 1)); > + if ((Struct->Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x= 3, 0x1))) { > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShellDebug1HiiHandle, 64 * > (Struct->Type0->BiosSize + 1)); > + } > > DisplayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(St= ruct- > >Type0->BiosCharacteristics)), Option); > > -- > 2.17.1 > > > > > --_000_PH7PR11MB63773C95CA2147FC68681A45F6769PH7PR11MB6377namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zhichao Gao zhichao.gao@intel.com

 

Thanks,

Zhichao

 

From: devel@edk2.groups.io <devel@edk2.gro= ups.io> On Behalf Of Nickle Wang via groups.io
Sent: Thursday, May 4, 2023 10:37 PM
To: devel@edk2.groups.io; Thejaswani Putta <tputta@nvidia.com>= ; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com&= gt;
Cc: Nick Ramirez <nramirez@nvidia.com>
Subject: Re: [edk2-devel] [PATCH] ShellPkg: Add a condition to print= accurate type0 Bios Size in smbiosview.

 

Hi @Ray Ni, @Zhichao Gao,

 

Could you please help to review this change?=

 

Thanks,

Nickle

 

> -----Original Message-----

> From: devel@edk2.groups.io <deve= l@edk2.groups.io> On Behalf Of Thejaswani

> Putta via groups.io

> Sent: Friday, April 21, 2023 9:00 AM

> To: = devel@edk2.groups.io

> Cc: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>

> Subject: [edk2-devel] [PATCH] ShellPkg: Add = a condition to print accurate type0

> Bios Size in smbiosview.

>

> External email: Use caution opening links or= attachments

>

>

> As per the SMBIOS spec, in smbios type0 tabl= e, if the Bios size is greater than

> 16MB, extended bios size is used to update s= ize information and bios size is set

> to 0xff. when this data is printed by smbios= view, both bios size and extended

> bios size is printed if the smbios version i= s beyond 3.1, which is incorrect as Bios

> size is set to 0xff when rom size is more th= an 16MB.

>

> To fix this bug, added a condition to print = bios size only when it is not set to 0xff

> or if the smbios version is older than 3.1.<= o:p>

>

> Signed-off-by: Thejaswani Putta <tputta@nvidia.com>

> Cc: Ray Ni <ray.ni@intel.c= om>

> Cc: Zhichao Gao <zhic= hao.gao@intel.com>

> ---

>  .../Library/UefiShellDebug1CommandsLib= /SmbiosView/PrintInfo.c | 4 +++-

>  1 file changed, 3 insertions(+), 1 del= etion(-)

>

> diff --git

> a/ShellPkg/Library/UefiShellDebug1CommandsLi= b/SmbiosView/PrintInfo.c

> b/ShellPkg/Library/UefiShellDebug1CommandsLi= b/SmbiosView/PrintInfo.c

> index 1811cf0c44..5448abaa22 100644

> --- a/ShellPkg/Library/UefiShellDebug1Comman= dsLib/SmbiosView/PrintInfo.c

> +++ b/ShellPkg/Library/UefiShellDebug1Comman= dsLib/SmbiosView/PrintInfo.c

> @@ -339,7 +339,9 @@ SmbiosPrintStructure (

>        Sh= ellPrintEx (-1, -1, L"BIOS Version: %a\n", LibGetSmbiosString (St= ruct,

> Struct->Type0->BiosVersion));

>        Sh= ellPrintEx (-1, -1, L"BIOS Starting Address Segment: 0x%x\n", Str= uct-

> >Type0->BiosSegment);

>        Sh= ellPrintEx (-1, -1, L"BIOS Release Date: %a\n", LibGetSmbiosStrin= g (Struct,

> Struct->Type0->BiosReleaseDate));=

> -      ShellPrintHi= iEx (-1, -1, NULL, STRING_TOKEN

> (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShell= Debug1HiiHandle, 64 *

> (Struct->Type0->BiosSize + 1));

> +      if ((Struct-= >Type0->BiosSize !=3D 0xFF) || !(AE_SMBIOS_VERSION (0x3, 0x1))) {

> +        = ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN

> (STR_SMBIOSVIEW_PRINTINFO_BIOS_SIZE), gShell= Debug1HiiHandle, 64 *

> (Struct->Type0->BiosSize + 1));

> +      }=

>

>        Di= splayBiosCharacteristics (ReadUnaligned64 ((UINT64 *)(UINTN)&(Struct-

> >Type0->BiosCharacteristics)), Option)= ;

>

> --

> 2.17.1

>

>

>

>

>

 

--_000_PH7PR11MB63773C95CA2147FC68681A45F6769PH7PR11MB6377namp_--