From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"lichao@loongson.cn" <lichao@loongson.cn>,
"qiandongyan@loongson.cn" <qiandongyan@loongson.cn>
Subject: Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch
Date: Mon, 22 Jan 2024 01:34:37 +0000 [thread overview]
Message-ID: <PH7PR11MB637749BC0F1DA1099DB1B2C4F6752@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <124d7ef9-47ea-4753-a9aa-6d2ea6a84a8e@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 4123 bytes --]
Reviewed-by: Zhichao Gao zhichao.gao@intel.com<mailto:zhichao.gao@intel.com>
Thanks,
Zhichao
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chao Li
Sent: Tuesday, January 16, 2024 8:13 PM
To: devel@edk2.groups.io; qiandongyan@loongson.cn
Cc: Gao, Zhichao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch
Looks good to me.
Reviewed-by: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>
Hi Zhichao,
Please help review this patch.
Thanks,
Chao
On 2024/1/16 15:11, Dongyan Qian wrote:
According to SMBIOS spec3.6, LoongArch information support has been added,
so this patch is submitted for display as information in smbiosview.
Cc: Zhichao Gao <zhichao.gao@intel.com><mailto:zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn><mailto:qiandongyan@loongson.cn>
---
.../SmbiosView/PrintInfo.c | 68 +++++++++++++++++++
.../SmbiosView/QueryTable.c | 8 +++
2 files changed, 76 insertions(+)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b6968cb36a..ba6e7b15fc 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (
Print (L"RISC-V RV128\n");
break;
+ case 0x258:
+ Print (L"LoongArch\n");
+ break;
+
+ case 0x259:
+ Print (L"Loongson1\n");
+ break;
+
+ case 0x25a:
+ Print (L"Loongson2\n");
+ break;
+
+ case 0x25b:
+ Print (L"Loongson3\n");
+ break;
+
+ case 0x25c:
+ Print (L"Loongson2K\n");
+ break;
+
+ case 0x25d:
+ Print (L"Loongson3A\n");
+ break;
+
+ case 0x25e:
+ Print (L"Loongson3B\n");
+ break;
+
+ case 0x25f:
+ Print (L"Loongson3C\n");
+ break;
+
+ case 0x260:
+ Print (L"Loongson3D\n");
+ break;
+
+ case 0x261:
+ Print (L"Loongson3E\n");
+ break;
+
+ case 0x262:
+ Print (L"DualCoreLoongson2K\n");
+ break;
+
+ case 0x26C:
+ Print (L"QuadCoreLoongson3A\n");
+ break;
+
+ case 0x26D:
+ Print (L"MultiCoreLoongson3A\n");
+ break;
+
+ case 0x26E:
+ Print (L"QuadCoreLoongson3B\n");
+ break;
+
+ case 0x26F:
+ Print (L"MultiCoreLoongson3B\n");
+ break;
+
+ case 0x270:
+ Print (L"MultiCoreLoongson3C\n");
+ break;
+
+ case 0x271:
+ Print (L"MultiCoreLoongson3D\n");
+ break;
+
default:
ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
}
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 82bb7a41f0..f57093c91c 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -3652,6 +3652,14 @@ TABLE_ITEM ProcessorArchitectureTypesTable[] = {
{
8,
L" 128-bit RISC-V (RV128) "
+ },
+ {
+ 9,
+ L" 32-bit LoongArch (LoongArch32) "
+ },
+ {
+ 10,
+ L" 64-bit LoongArch (LoongArch64) "
}
};
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114127): https://edk2.groups.io/g/devel/message/114127
Mute This Topic: https://groups.io/mt/103757733/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 11754 bytes --]
next prev parent reply other threads:[~2024-01-22 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 7:11 [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Dongyan Qian
2024-01-16 7:11 ` [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch Dongyan Qian
2024-01-16 12:12 ` Chao Li
2024-01-22 1:34 ` Gao, Zhichao [this message]
2024-01-16 12:11 ` [edk2-devel] [PATCH 1/2] MdeModulePkg: Dxe: add LOONGARCH64 to mMachineTypeInfo Chao Li
2024-01-31 7:00 ` Dongyan Qian
2024-01-31 9:56 ` 回复: " gaoliming via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB637749BC0F1DA1099DB1B2C4F6752@PH7PR11MB6377.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox