Reviewed-by: Zhichao Gao zhichao.gao@intel.com

 

Thanks,

Zhichao

 

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chao Li
Sent: Tuesday, January 16, 2024 8:13 PM
To: devel@edk2.groups.io; qiandongyan@loongson.cn
Cc: Gao, Zhichao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] ShellPkg: Update smbiosview for LoongArch

 

Looks good to me.

Reviewed-by: Chao Li <lichao@loongson.cn>

Hi Zhichao,

Please help review this patch.

 

Thanks,
Chao

On 2024/1/16 15:11, Dongyan Qian wrote:

According to SMBIOS spec3.6, LoongArch information support has been added,
so this patch is submitted for display as information in smbiosview.
 
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 .../SmbiosView/PrintInfo.c                    | 68 +++++++++++++++++++
 .../SmbiosView/QueryTable.c                   |  8 +++
 2 files changed, 76 insertions(+)
 
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index b6968cb36a..ba6e7b15fc 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -2610,6 +2610,74 @@ DisplayProcessorFamily2 (
       Print (L"RISC-V RV128\n");
       break;
 
+    case 0x258:
+      Print (L"LoongArch\n");
+      break;
+
+    case 0x259:
+      Print (L"Loongson1\n");
+      break;
+
+    case 0x25a:
+      Print (L"Loongson2\n");
+      break;
+
+    case 0x25b:
+      Print (L"Loongson3\n");
+      break;
+
+    case 0x25c:
+      Print (L"Loongson2K\n");
+      break;
+
+    case 0x25d:
+      Print (L"Loongson3A\n");
+      break;
+
+    case 0x25e:
+      Print (L"Loongson3B\n");
+      break;
+
+    case 0x25f:
+      Print (L"Loongson3C\n");
+      break;
+
+    case 0x260:
+      Print (L"Loongson3D\n");
+      break;
+
+    case 0x261:
+      Print (L"Loongson3E\n");
+      break;
+
+    case 0x262:
+      Print (L"DualCoreLoongson2K\n");
+      break;
+
+    case 0x26C:
+      Print (L"QuadCoreLoongson3A\n");
+      break;
+
+    case 0x26D:
+      Print (L"MultiCoreLoongson3A\n");
+      break;
+
+    case 0x26E:
+      Print (L"QuadCoreLoongson3B\n");
+      break;
+
+    case 0x26F:
+      Print (L"MultiCoreLoongson3B\n");
+      break;
+
+    case 0x270:
+      Print (L"MultiCoreLoongson3C\n");
+      break;
+
+    case 0x271:
+      Print (L"MultiCoreLoongson3D\n");
+      break;
+
     default:
       ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_PROC_FAMILY), gShellDebug1HiiHandle);
   }
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
index 82bb7a41f0..f57093c91c 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c
@@ -3652,6 +3652,14 @@ TABLE_ITEM  ProcessorArchitectureTypesTable[] = {
   {
     8,
     L" 128-bit RISC-V (RV128) "
+  },
+  {
+    9,
+    L" 32-bit LoongArch (LoongArch32) "
+  },
+  {
+    10,
+    L" 64-bit LoongArch (LoongArch64) "
   }
 };
 

_._,_._,_

Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#114127) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_