Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

["Gao, Zhichao" <zhichao.gao@intel.com>]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Shang, Qingyu <qingyu.shang@intel.com>
> Sent: Monday, March 11, 2024 4:41 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao <gaoliming@byosoft.com.cn>; Gao, Zhichao
> <zhichao.gao@intel.com>; Chao Li <lichao@loongson.cn>
> Subject: [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and
> ReadKeyStrokeEx
> 
> Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED
> to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx
> and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().
> 
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Chao Li <lichao@loongson.cn>
> Signed-off-by: Qingyu <qingyu.shang@intel.com>
> ---
>  ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c
> b/ShellPkg/Application/Shell/ConsoleWrappers.c
> index eae11370e4e0..dbffae30cdf5 100644
> --- a/ShellPkg/Application/Shell/ConsoleWrappers.c
> +++ b/ShellPkg/Application/Shell/ConsoleWrappers.c
> @@ -67,7 +67,9 @@ FileBasedSimpleTextInReset (
>    @param[in] This      A pointer to the SimpleTextIn structure.
>    @param[in, out] Key  A pointer to the Key structure to fill.
> 
> -  @retval   EFI_SUCCESS The read was successful.
> +  @retval EFI_SUCCESS      The read was successful.
> +  @retval EFI_UNSUPPORTED  The device does not support the ability to
> read
> +                           keystroke data.
>  **/
>  EFI_STATUS
>  EFIAPI
> --
> 2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117081): https://edk2.groups.io/g/devel/message/117081
Mute This Topic: https://groups.io/mt/104886872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-