From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 12807740034 for ; Mon, 25 Mar 2024 06:12:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z+zloBM75LR/2Ut2svSg0DOCo3TtvaRL41edAzAIua0=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711347164; v=1; b=0OOOmdNMGtMxIBjdWHbgg702J9TrumBKsPlcnFwLmZ0bbDeeb1MCervlrADhc0HvRJUpWD/q eSO6TS+AQw4MjWGrtDv+DCXeRHpYFyuC68tzEDrFKFP/3nGf5QXZ9QsLUU8WMlybodLqI3VuEz6 Uym3bjFXuThdPC5ReMOWlE5tCrlBDdugAvveilEVqjsqDpSr0e7lD1nRGMrpiATaCcsxWIXjHIn I7YagAfcl5G08V4oRmZUu65COknkOVRANDfGywZH6CU3zDzDCsk9zdUMYBYRH0K3mdESxQ1oIac vgIrqAg/r8ZaPeqqKbaJtWTaCxwfraPQI9HLZ5x8mlyHw== X-Received: by 127.0.0.2 with SMTP id Mf8hYY7687511xOMwDTNvmUV; Sun, 24 Mar 2024 23:12:44 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web10.45845.1711347163882665729 for ; Sun, 24 Mar 2024 23:12:44 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11023"; a="6189398" X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208";a="6189398" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2024 23:12:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,152,1708416000"; d="scan'208";a="15535634" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Mar 2024 23:12:43 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 24 Mar 2024 23:12:42 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 24 Mar 2024 23:12:42 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 24 Mar 2024 23:12:42 -0700 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by SJ0PR11MB6693.namprd11.prod.outlook.com (2603:10b6:a03:44b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Mon, 25 Mar 2024 06:12:40 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::7005:a300:1628:70d4]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::7005:a300:1628:70d4%4]) with mapi id 15.20.7409.028; Mon, 25 Mar 2024 06:12:39 +0000 From: "Gao, Zhichao" To: "Shang, Qingyu" , "devel@edk2.groups.io" CC: Liming Gao , Chao Li Subject: Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx Thread-Topic: [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx Thread-Index: AQHac4/5W/WWCj0sy0W3e4p13jp2LrFID6Zg Date: Mon, 25 Mar 2024 06:12:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|SJ0PR11MB6693:EE_ x-ms-office365-filtering-correlation-id: a890190d-6d1a-4c63-42dc-08dc4c92931b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lP0OPllVmjJJv4LNLtraea6xyHmvI5uYm+WBMhULAa6bZEUNUWnltt3vC/ERMaKQXGn8CUVY1rIujOQCl93HYLNdJvl5WXPwf+n2Q0TssdcY9JcUB2IV7AeANbCdzpP98KLAtCGxGy7OKqQ16f2KOgdrA5I263NbJY+Tjw+zzMyzuNrOP0WR7KzJZyyh1hwQu9J3FogRPzMY5s2sC6h2sFb/sn31FCtsIPm/Jl/dkWW8g0DIOWIRxjcR4wRXIJdkECJpNGgOm4mD/RIuf0D6mro4FuKyqCnLlodLV2kULFn6uRtqnnq0H1JicbVpp47lIF+JGoWlJvvBpVFF5JNPkLfoGJ+QMIL4v0LC7CXR0lJr7DtguTWVeOolx5YV/u9OTjzHy1YJmZl5cGXS9neeDeHOR9dojaTPG6F0Thj1tB78/It0Bw9RUbc7y+757xRSs0vJbipS1Ijdz3PE0prsxfXo8m5gN6ii1mxShSjb8X9gc84UxdCLOCPBWJ9Me3F5B40jzWI53WWDmzmk/TtNdad2gl7iUWjzNY/MbPQcmVlDLyRzbDmEWEt+Rud8RTm2hz1rkUmP2apMObkHAjK+uJPVA8IaU9mSc05uuUoyv2SElbGkpMok3v+zo5OkSE1mLoN1U4zhrPJCbhZCz4XMlVAHGfZNAAzKhomO4uEPfDb05m5wdjNCQvFt+rqVfhcEHtS4UlVNQg62TD6okwerbqMU/9m2vsRBjDKfhXz9oM4= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QwyKwhxQNYRW0NX8StLGBbRwruIHjSIUI4eqt3Rqort1IMFpcRFxgzvopgkQ?= =?us-ascii?Q?FHHJNS1PucF6M0M6PIzrYZcjj0dhaJLwga1lPTDQcVuQyVOND20OstjvGXy3?= =?us-ascii?Q?7QwWQY34vktPGQT87Ys0Lz2JKLdNtLcKcZTHimTtQL4NIewELVk85c/oZ2L9?= =?us-ascii?Q?2ZsPsFOsCT72QTFEZDBHibIuuY8kohlucxB1Cnj2BgB6mM59BpXJ4i9K2QTL?= =?us-ascii?Q?o7/l8q0InPuD6nCaFKZIffQ7PHXaJMyYMlDoOaP2G2P586MjoB1ZhU2SkZCp?= =?us-ascii?Q?jXeV6/II4SR97nalFAqDPZgrwjBU1wQkYhkM9zBhl1udWu1pm/rTOjEPAQ8D?= =?us-ascii?Q?0SxVT67F8kNTwaJVCSZpu5kRFPfru46AJHVV1yKh8xuroFNtVSNGmPa0n0AX?= =?us-ascii?Q?ng9+VZmES9NAGLkecb5G6g6aemc8GHavo7rw4FhWFnC7UpexW8DtTS3LhCav?= =?us-ascii?Q?EtJgImZ6l/L3zc+OtfMfzQrOTVCxuUepUq4CPWLS99lpfljYnhviTFtAW2hT?= =?us-ascii?Q?kwb784XhxJU80aCcO6zTv/zuSB5056d5WFQvxrRd2xnekct8vBLcesZ+8Fcu?= =?us-ascii?Q?HeQoM/mYHPfknLmaIOfpNVpdv0ifjKmJGhQIMzQ8j4ttpuCEOWrz1L49O2/j?= =?us-ascii?Q?zdZ4H0m8Vjx+V5e+XVwmiAAW93HPKjI3KCarv9tzYRPu+mEBB7RrDSA5KD+G?= =?us-ascii?Q?AVNizNLecoTpo/hLEmjdvTZM2Sdi8KyXaSKjI0WmyPKclM+/ImSGCN4FlSOm?= =?us-ascii?Q?tTVXh1GP+b4ZH/unfkHCzU6zc20cxVpSE5Wl7n3cDnAqKjkJbI31SwrNB5kR?= =?us-ascii?Q?fKg2Zg2T2n4GAc1aAQoJaXKj0FFDAY1b8LwGscH0jGg78k21omvGbTat+6Nk?= =?us-ascii?Q?2KFPtvAdsrMSmg4nJLh+Tof7JNYg6nczV3dNQueWzbCLtSbJQZRMGmH3/h4/?= =?us-ascii?Q?kSqaDbb1z4KKL85FJaw5V+jd8PboEmZlrKRxZxAf2AGBAb9YamFE9/s3pN++?= =?us-ascii?Q?eWgPQ4cRFPYWeuWW2dU/F5JzpQOZntPgF5Csms+ECBPY8iPG6ZNeMAuXTPuE?= =?us-ascii?Q?0jGA+ckZLHbwfosBFafN9HystyHrfInpobb/9009eOt/T/wVfQEtYcG/qGk4?= =?us-ascii?Q?b7KZTAaqjS3RiBF67/37FNCJgjeJVM1cpUSKU9w1MdsdnTOVJrBPDG6BNLrr?= =?us-ascii?Q?DOAPqAoe0mLNmNca4OpV7+xRWaS9GkXOuUyYIigPuQxbSKlqbt+JULF+UgS8?= =?us-ascii?Q?Q4HrYGL81jN3Bs4NSG9xdQ86osiGDWFuNDcmelBf1z+8FLYb/8mToB0Rz+9S?= =?us-ascii?Q?PUGKg4UBN9vCxDkDZVU7ONxOSKoiChFj5BHYw10JuCOiTEaWcITmMKuXdzzH?= =?us-ascii?Q?fJOsgB2MJ4vwnI2OcCOPnn7lzRPF2RWKL1eVxfPawaR0gxzQL4sQdte0aSA8?= =?us-ascii?Q?6u8MsXxhMAK8UcNbX/vlJPcfCdTBDvkZzllbCx7yaWdoGoIXbHP8s0S/Xx4H?= =?us-ascii?Q?ooprr8SNiQyIsxMGV62At4EjBGYFkAJml+1hJnfZkOppqsm2pFO8r5zSjsMy?= =?us-ascii?Q?M2DJ73+GVLr2Qujpc2f53dKFJWzovZ0brcg2tNI6?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a890190d-6d1a-4c63-42dc-08dc4c92931b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2024 06:12:39.6328 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g7qizCOYkvKbxMZj+V6OUyw/FS8B+CkCRIVKED0fCggoPnPCIzq/chHkuLfiYU44Ut9h/o+/kwEM/Y/hAyHgIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6693 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 24 Mar 2024 23:12:44 -0700 Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Jes99FlDhJBNTuVwXgfpB2gRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0OOOmdNM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Shang, Qingyu > Sent: Monday, March 11, 2024 4:41 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Gao, Zhichao > ; Chao Li > Subject: [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and > ReadKeyStrokeEx >=20 > Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED > to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx > and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). >=20 > Cc: Liming Gao > Cc: Zhichao Gao > Cc: Chao Li > Signed-off-by: Qingyu > --- > ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c > b/ShellPkg/Application/Shell/ConsoleWrappers.c > index eae11370e4e0..dbffae30cdf5 100644 > --- a/ShellPkg/Application/Shell/ConsoleWrappers.c > +++ b/ShellPkg/Application/Shell/ConsoleWrappers.c > @@ -67,7 +67,9 @@ FileBasedSimpleTextInReset ( > @param[in] This A pointer to the SimpleTextIn structure. > @param[in, out] Key A pointer to the Key structure to fill. >=20 > - @retval EFI_SUCCESS The read was successful. > + @retval EFI_SUCCESS The read was successful. > + @retval EFI_UNSUPPORTED The device does not support the ability to > read > + keystroke data. > **/ > EFI_STATUS > EFIAPI > -- > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117081): https://edk2.groups.io/g/devel/message/117081 Mute This Topic: https://groups.io/mt/104886872/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-