From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5FA0CD8046F for ; Thu, 27 Jul 2023 02:49:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XiR9O+KGJ21+ejuV5WzEoYdgjRNWBFPhzIfj11cV5c8=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ld-processed:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Tr ansport-CrossTenantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690426176; v=1; b=HCX8/TPW7cppMzpRnbd50UlckSwZfPl3HnpZJt0mUrinhg/I9W9m5UIk9LumfkAYkLfUOhxP /Uk/lTiWPKAEfgj6H+49sG5dCimUTyLIBdbQ/1/A1eMh3zocpU0LYqtgL+eYCD24BaE/KNzn3L5 L1TmuaDsmx+Wv+npK6tnxsWo= X-Received: by 127.0.0.2 with SMTP id 4DkBYY7687511xwWACh5ZxOV; Wed, 26 Jul 2023 19:49:36 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.4621.1690426175855489264 for ; Wed, 26 Jul 2023 19:49:36 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="353088532" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="353088532" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 19:49:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="756467679" X-IronPort-AV: E=Sophos;i="6.01,233,1684825200"; d="scan'208";a="756467679" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga008.jf.intel.com with ESMTP; 26 Jul 2023 19:49:35 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 19:49:35 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 19:49:34 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 26 Jul 2023 19:49:34 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 26 Jul 2023 19:49:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fUH3cmBOVeFE4xyI8TRo+OvM+XuUrjtteytC9lwg30oqM7xCUVWzP3/EkNjrdpA3AAVJUF1lQE9p3Wm4gSLveDbRRZ8un5iu5FYy1dYq0n6pKhsUjWHeC1QDOMfddr7R3Lldj9NIKGe+CvnttNv2HfEVo5yygW48bXosF4CEeTOdZ1YOw/k2kfaW2mO8ZKQAcA8I1WiK09u5O5ix4WfjSrLlYIWwKiz0x9YHCvtnpFsseyMwTWCMp0bRutkpnsDK4ejOFRkk8JwDapFk5TupWa5g54aMRAihBlvaf1K15ZEcH+Z8YL/KJ5a/kXZ+AwLYaH1ZbyzbPSZ4UbnXGHky/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VwPh1lLiwbMPXv/yQ9hitoF8MRNV/VQFu1TklsgB9jo=; b=QpA7fL/9QHB/OqDJj/zLD0uCM5RaAIhTMueQLy5eAHpaVWKJpM3rOgoYtkgb7gQat+Pt5TQGlZnSPs25/C2aAwtR1VZmk/EX5lMElgUX6ahshoT8GCqGI11SuiLUZD/p+s9SAj5lYvQF3IMlwwU4fxVbUQCRd7LxeOv1UJW264g1wv3usqBUfkHjGE+iK9AHy1KlmqPI8rwnAiXH5cSvJFy7VpK03/usBqxJNyfwVCrvJ4L50Rh7vlAdEz78PH9eboPTMI4mfG/NsVcZyrWT7jVk7KuljG6379UTED7MozJ+C8Zq5PrgB2tFJmRPWgVP8UBm0ZqCkQmhBxnoiaNbdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by SN7PR11MB6601.namprd11.prod.outlook.com (2603:10b6:806:273::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.33; Thu, 27 Jul 2023 02:49:32 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::b49a:f660:202e:6276]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::b49a:f660:202e:6276%5]) with mapi id 15.20.6631.026; Thu, 27 Jul 2023 02:49:32 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "jbrasen@nvidia.com" CC: "Wang, Jian J" , "Gao, Liming" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI Thread-Topic: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to work without ACPI Thread-Index: AQHZq3ilT70myzzqsE+Y4A+h40jkhK/NEtFA Date: Thu, 27 Jul 2023 02:49:32 +0000 Message-ID: References: <25ff522f4d049a9cf48a3698ebe4dcc0f7a94e21.1688141699.git.jbrasen@nvidia.com> In-Reply-To: <25ff522f4d049a9cf48a3698ebe4dcc0f7a94e21.1688141699.git.jbrasen@nvidia.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|SN7PR11MB6601:EE_ x-ms-office365-filtering-correlation-id: ce9736c5-19f9-43d5-3800-08db8e4c1ad2 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: noQWZCx9LsFUPprAHVzM0V3+dpUofzscM99XjR8t1IzkIVihPgI//3zyZjQcJP+6/qioZ1n3D1nKDCGe8gclWZv3wrSMLXumxKEKi8hFo3dI4OQ8wjdtZcDV3/m8t+kcX6MChB2PUYbuDliU6LMMsusDvZRL8Mvv80qo0qyCTSrwoxIGHAyuYI/K/klWDP+y1iH+qbOBLdJm0CM2t+OKIj/zSB7kkfoUJBjySep6GiZ9tJVwX2/Dzy8xHBSSMn54PjO1z9khEmbGALA+Rkytz0ldN6HzgvJk4mr4ad9U+jD0NBMiEm3wBxqrpcxPV3VGJ3wNHHBoOEk07pNCLIevUS/wl93bLkL5f2s274E4ag/krLna2FNEIULIPfZFm+BvmUNQ+/9yuG4hchAxONfCC6K+lVoMLmiZhK09fIkiqAi/vpWiyo8qf9qnw4QIGx+nr+lEPy2KTIGNuQ96qbkFk4Sd75uNSmcwBnsysnhDQ/f8TNsk7FG/N/QX3eTlmabeME9pwJ8StY1yMJKO6EBELLxYcM5Ug/rn+rJQ06mvUMT3rUZVV0qaXAPX16QJerCvbEbwIR7B7WtaHNB/hvwVlacHnjMoqEmdTeaI3XUKwDUlwe3/OXwYAICzsJEVFmdKAO6uzrfM9yylLVWUyuRrmg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xfnXD86q4ryswdlE9aZM1sZ9n5omxZxeZ+dOPWkT+Ks/RDp0ZUtm4IMoECD2?= =?us-ascii?Q?3wTRP+ASmSqQ0QcrMGHCWhev+ODwBzxnER8mGolo7OJl2Pwwq9gXfUHaylT0?= =?us-ascii?Q?ddUXuCZmxupWJHS9FE872Ms7qI7yxpzGQTs41h0YfmUCIDSCe4VfJZkHlIdq?= =?us-ascii?Q?+z3+yIPAoVNHRl2EcmnsstK294Qq/6oPp38VjghRuxDC2OlCln3ZJDW5Negx?= =?us-ascii?Q?ywhYN8khv7f10kc82Giy7TfIftYwh/lZ1A6H9jHiGLr+F7WJGDlotK8/5qFU?= =?us-ascii?Q?90ENQ0iL/+tJwts9+E0Be9h1dqdQ9s8V5oKcXxcw5DzrbfRWR1iYMu5YkRse?= =?us-ascii?Q?xTBctZFO0K3AkSB3xY/jqobrRK8HtEyuubOeTUEbL4Bnp0CVlLPRsyfNNoGc?= =?us-ascii?Q?FpZyM+YkXxrAY8IYzuXQBnZlwpv1EZ9oLx3TnkPEy1CQDyAsWb8TmmsSTchf?= =?us-ascii?Q?7vXhpFfjowbM6QbQEIi7DlzmjCd5+DOyRkmGTg7RGexYwP08XK26KFyFNPxc?= =?us-ascii?Q?uSq/JW+nM/65vLUMafCZLhXkitS6mbQwGQzmx3PFlgLJWhjTPkMgv/RBd1rH?= =?us-ascii?Q?2AxoAmoHcPOwTBio68aW2kuWPV0wE8Emlj2Fq0xzi02BmDWAhbOV4IehKx0U?= =?us-ascii?Q?GZaPmQhJWrkAavQRSUtAjN0Aupfry08imQauU2gwv+MftGhv9eF+sX52Qo9B?= =?us-ascii?Q?ypQYLQ4yjuiv9BkUkYnCeSQ7Ms8LC/3u+V7JzO3eNyLFUKAK1vCkb3yw9f4X?= =?us-ascii?Q?yk7j8vtcxYl8Pu1DTyYVGmJFdPVxva0hElNy/WBSTtL7osAwgOnhs7Ru0SVj?= =?us-ascii?Q?Q9MjeMN2GVOuRRuF5dS8lr7KESnxhvZkqEO1FjlwBGkcj3+oE4EuXM0l89oz?= =?us-ascii?Q?zfCSq0SFe7yIce2zG90Ct4FjLkI1Rj2tWUaZDu4OhAP79deSoXe1FjseTOb5?= =?us-ascii?Q?59JWWpT8hQZJOCT5VvO8+MiYzWle4IJEt04Z0fgL50gVjCG8NWu3+qzl/jhs?= =?us-ascii?Q?eNDQiCy8SiaTIHo9qJCcIFlR90w5HIxHfOvOx1dxmRxXVVJnK+lq9tjKfrcM?= =?us-ascii?Q?4cmR7tzRYSRjCdKuXry1N9NyPe90rEJM6x/v8W29GqQ2jWc/vpoAvA2bfia/?= =?us-ascii?Q?4oblI4Dyb3Kyug5pMtYWRhRzAXqKkyYQurHIq/phrlIcIxiJck/D3oXJ2zKO?= =?us-ascii?Q?f4jLDk3SahBR95ZTLZ2Yv/Pjj1oWbufSe27Por8cSW9HK6R4zPb5lSyAmcka?= =?us-ascii?Q?+s6ScXY5aa5kAeyunrfGOfIR6n1yRXhdlVPPMa0vyp7S30bW7XKCJ5A3NXms?= =?us-ascii?Q?zdM4bbe7IVHQW++wTevMDim+qBP+cv2U4cZGZfcP9NnX4GvJIJ8AroOZ3OxP?= =?us-ascii?Q?Udqnv4YH1QWvIllKf2RcO7LpGD6K/tNwL2HylDfYuADCsiPUdXd1J10Z7DF0?= =?us-ascii?Q?xvy1y06tzsSAmZChJBd+fL3EQTf2Br8tEz1xSErXoxob5shTVczmJDh8lj3H?= =?us-ascii?Q?T11g8ARa5zlKBmAPOUKRUxuUfW3QvVSbMG7kai0wBwKRih/pR1oCGhmAtXEd?= =?us-ascii?Q?3pXC9eKM6UqJmfR2cXgvvHapGd9oK3gHzMh/ixEu?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce9736c5-19f9-43d5-3800-08db8e4c1ad2 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2023 02:49:32.1199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iFzPnSjUNHmw8D4lkbo2aPDjtjM9/mCZ4wI41+x69IX1QEKQMl6EMQJ5h3PkYtizKPCyc6ccLTfdnESeYKDpYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6601 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: S3KbLdqR8BSiZhPt3NzulvFLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="HCX8/TPW"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Jeff > Brasen via groups.io > Sent: Saturday, July 1, 2023 1:30 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming > ; Bi, Dandan ; Gao, > Zhichao ; Jeff Brasen > Subject: [edk2-devel] [PATCH v2 2/2] ShellPkg/Dp: Allow dp command to > work without ACPI >=20 > If the system does not have ACPI setup use the configuration table to get= the > performance info. >=20 > Signed-off-by: Jeff Brasen > --- > ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf | 1 + > .../DpDynamicCommand/DpDynamicCommand.inf | 1 + > ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 11 ++++++++- > -- > 3 files changed, 10 insertions(+), 3 deletions(-) >=20 > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > index 4a58286b8c1a..d9e1c23a1ee7 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf > @@ -54,6 +54,7 @@ [LibraryClasses] >=20 > [Guids] > gPerformanceProtocolGuid ## CONSUMES ##= SystemTable > + gEdkiiFpdtExtendedFirmwarePerformanceGuid ## CONSUMES ## > SystemTable >=20 > [Protocols] > gEfiLoadedImageProtocolGuid ## CONSUMES > diff --git > a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i > nf > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i > nf > index 013bdbd4a07e..2723fee7066e 100644 > --- > a/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i > nf > +++ > b/ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.i > nf > @@ -55,6 +55,7 @@ [LibraryClasses] >=20 > [Guids] > gPerformanceProtocolGuid ## CONSUMES ##= SystemTable > + gEdkiiFpdtExtendedFirmwarePerformanceGuid ## CONSUMES ## > SystemTable >=20 > [Protocols] > gEfiLoadedImageProtocolGuid ## CONSUMES > diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > index 512a146da6dd..98c84d2ef938 100644 > --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c > @@ -129,17 +129,22 @@ EFI_STATUS > GetBootPerformanceTable ( > ) > { > + EFI_STATUS Status; > FIRMWARE_PERFORMANCE_TABLE *FirmwarePerformanceTable; >=20 > FirmwarePerformanceTable =3D (FIRMWARE_PERFORMANCE_TABLE > *)EfiLocateFirstAcpiTable ( >=20 > EFI_ACPI_5_0_FIRMWARE_PERFORMANCE_DATA_TABLE_SIGNATURE > ); > if (FirmwarePerformanceTable =3D=3D NULL) { > - ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle); > - return EFI_NOT_FOUND; > + Status =3D EfiGetSystemConfigurationTable > (&gEdkiiFpdtExtendedFirmwarePerformanceGuid, (VOID > **)&mBootPerformanceTable); > + if (EFI_ERROR (Status)) { > + ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_DP_GET_ACPI_FPDT_FAIL), mDpHiiHandle); > + return EFI_NOT_FOUND; > + } > + } else { > + mBootPerformanceTable =3D (UINT8 > + *)(UINTN)FirmwarePerformanceTable- > >BootPointerRecord.BootPerformanceTa > + blePointer; > } >=20 > - mBootPerformanceTable =3D (UINT8 > *)(UINTN)FirmwarePerformanceTable- > >BootPointerRecord.BootPerformanceTablePointer; > mBootPerformanceTableSize =3D ((BOOT_PERFORMANCE_TABLE > *)mBootPerformanceTable)->Header.Length; >=20 > return EFI_SUCCESS; > -- > 2.25.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107288): https://edk2.groups.io/g/devel/message/107288 Mute This Topic: https://groups.io/mt/99877763/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-