Re: [edk2-devel] [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to Dmem.c

["Gao, Zhichao" <zhichao.gao@intel.com>]

You didn't resolve the feedback from: Stuart.Yoder@arm.com.
All the address parameters are not used, just check the null pointer without use them.

Thanks,
Zhichao

> -----Original Message-----
> From: Sam Kaynor <Sam.Kaynor@arm.com>
> Sent: Wednesday, March 20, 2024 3:11 AM
> To: devel@edk2.groups.io
> Cc: Stuart.Yoder@arm.com; Sam Kaynor <Sam.Kaynor@arm.com>; Ni, Ray
> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to
> Dmem.c
> 
> v1->v2:
> - Changed how the Conformance Profile Table is iterated
> - Changed how the Image Execution Table is iterated
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com>
> 
> Sam Kaynor (3):
>   ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c
>   ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c
>   ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c
> 
>  MdePkg/MdePkg.dec                                                          |   7 +
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.inf |   3 +
>  MdePkg/Include/Guid/ConformanceProfiles.h                                  |  57 +++++
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         | 269
> ++++++++++++++++++++
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.uni |  30 ++-
>  5 files changed, 364 insertions(+), 2 deletions(-)  create mode 100644
> MdePkg/Include/Guid/ConformanceProfiles.h
> 
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117230): https://edk2.groups.io/g/devel/message/117230
Mute This Topic: https://groups.io/mt/105030764/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-