From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Sam Kaynor <Sam.Kaynor@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Stuart.Yoder@arm.com" <Stuart.Yoder@arm.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Liming Gao" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to Dmem.c
Date: Fri, 29 Mar 2024 07:39:48 +0000 [thread overview]
Message-ID: <PH7PR11MB6377611FFEE08E3BAAB9FACCF63A2@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240319191104.2368822-1-Sam.Kaynor@arm.com>
You didn't resolve the feedback from: Stuart.Yoder@arm.com.
All the address parameters are not used, just check the null pointer without use them.
Thanks,
Zhichao
> -----Original Message-----
> From: Sam Kaynor <Sam.Kaynor@arm.com>
> Sent: Wednesday, March 20, 2024 3:11 AM
> To: devel@edk2.groups.io
> Cc: Stuart.Yoder@arm.com; Sam Kaynor <Sam.Kaynor@arm.com>; Ni, Ray
> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to
> Dmem.c
>
> v1->v2:
> - Changed how the Conformance Profile Table is iterated
> - Changed how the Image Execution Table is iterated
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com>
>
> Sam Kaynor (3):
> ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c
> ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c
> ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c
>
> MdePkg/MdePkg.dec | 7 +
>
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.inf | 3 +
> MdePkg/Include/Guid/ConformanceProfiles.h | 57 +++++
> ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 269
> ++++++++++++++++++++
>
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.uni | 30 ++-
> 5 files changed, 364 insertions(+), 2 deletions(-) create mode 100644
> MdePkg/Include/Guid/ConformanceProfiles.h
>
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117230): https://edk2.groups.io/g/devel/message/117230
Mute This Topic: https://groups.io/mt/105030764/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-03-29 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 19:11 [edk2-devel] [PATCH v2 0/3] Adding support for verbose UEFI Table dumping to Dmem.c Sam Kaynor
2024-03-19 19:11 ` [edk2-devel] [PATCH v2 1/3] ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c Sam Kaynor
2024-03-19 19:11 ` [edk2-devel] [PATCH v2 2/3] ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table " Sam Kaynor
2024-03-19 19:11 ` [edk2-devel] [PATCH v2 3/3] ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles " Sam Kaynor
2024-03-29 7:39 ` Gao, Zhichao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6377611FFEE08E3BAAB9FACCF63A2@PH7PR11MB6377.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox