Re: [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment

["Gao, Zhichao" <zhichao.gao@intel.com>]

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Friday, July 15, 2022 12:50 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; Alexei.Fedorov@arm.com;
> pierre.gondois@arm.com; Matteo.Carlini@arm.com;
> Akanksha.Jain2@arm.com; Ben.Adderson@arm.com; Ni, Ray
> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; nd@arm.com
> Subject: [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to
> preserve alignment
> 
> Some field names in the IORT table parser were longer than the
> OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of the
> output print alignment. Therefore, abbreviate the field names.
> 
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> 
> Notes:
>     v6:
>       - No code change since v1. Including r-b and resending   [SAMI]
>         with v6 series.
> 
>     v5:
>       - No code change since v1. Including r-b and resending   [SAMI]
>         with v5 series.
> 
>     v4:
>       - No code change since v1. Including r-b and resending   [SAMI]
>         with v4 series.
> 
>     v3:
>       - No code change since v1. Include r-b received          [SAMI]
>         from v2 series.
>         Ref: https://edk2.groups.io/g/devel/topic/83600717#7665
>     v2:
>       - No code change since v1. Re-sending with v2 series.    [SAMI]
> 
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c |
> 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index
> 81bfacd83added87a867cf365a56d4b7a1410ef2..44d633c5282463078a4cc990b
> b24ca1992f95634 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> +++ er.c
> @@ -1,11 +1,14 @@
>  /** @file
>    IORT table parser
> 
> -  Copyright (c) 2016 - 2020, ARM Limited. All rights reserved.
> +  Copyright (c) 2016 - 2021, Arm Limited. All rights reserved.
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>    @par Reference(s):
> -    - IO Remapping Table, Platform Design Document, Revision D, March 2018
> +  - IO Remapping Table, Platform Design Document, Revision D, March
> + 2018
> +
> +  @par Glossary:
> +    - Ref  - Reference
>  **/
> 
>  #include <IndustryStandard/IoRemappingTable.h>
> @@ -144,15 +147,15 @@ STATIC CONST ACPI_PARSER
> IortNodeSmmuV1V2Parser[] = {
>    { L"Span",                          8,    24,  L"0x%lx", NULL, NULL, NULL, NULL },
>    { L"Model",                         4,    32,  L"%d",    NULL, NULL, NULL, NULL },
>    { L"Flags",                         4,    36,  L"0x%x",  NULL, NULL, NULL, NULL },
> -  { L"Reference to Global Interrupt Array",4,    40,  L"0x%x",  NULL, NULL,
> NULL,
> +  { L"Global Interrupt Array Ref",    4,    40,  L"0x%x",  NULL, NULL, NULL,
>      NULL },
>    { L"Number of context interrupts",  4,    44,  L"%d",    NULL,
>      (VOID **)&InterruptContextCount,  NULL, NULL },
> -  { L"Reference to Context Interrupt Array",4,    48,  L"0x%x",  NULL,
> +  { L"Context Interrupt Array Ref",   4,    48,  L"0x%x",  NULL,
>      (VOID **)&InterruptContextOffset, NULL, NULL },
>    { L"Number of PMU Interrupts",      4,    52,  L"%d",    NULL,
>      (VOID **)&PmuInterruptCount,      NULL, NULL },
> -  { L"Reference to PMU Interrupt Array",4,    56,  L"0x%x",  NULL,
> +  { L"PMU Interrupt Array Ref",       4,    56,  L"0x%x",  NULL,
>      (VOID **)&PmuInterruptOffset,     NULL, NULL },
> 
>    // Interrupt Array
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'