From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web08.35853.1658195167248589209 for ; Mon, 18 Jul 2022 18:46:07 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GktC+VIT; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658195167; x=1689731167; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Dd5aQsXGsy+42bFFyESVn9vWJHQDxxuiotCts67mje4=; b=GktC+VITCJkK120KjX1QVBBCVCjqAvTzF4lAc9OXmQSVBvpmhKB1bI6q MxNpVHIB2tWAyAqmZsV366ww+eZjNYBdfK9WZGjomx3kmjzJ12aS/WTeV hqrJNMu+XdMXWAChzydw6mB94i+EKFXvPI61hcYONF081G+Y0hCq5OElo kj04Rr8Ja23TNGI/eHqrXOgDTODmX7AHWE+qARY7Y+SN7KAOKmCSBre98 5mkVfS9rKN2DqPEJm2xUkDSDnIDs6RkwuoUGhO3aV8FjpG6QabVBIrTxd 2okDDn1scNJ2ln7l60atcT5yi2CKSDOTqzjTNS0IoyhAPnwB5FkrTe+/l Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="312047164" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="312047164" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 18:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="700244470" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 18 Jul 2022 18:46:06 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 18 Jul 2022 18:46:06 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Jul 2022 18:46:05 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Jul 2022 18:46:05 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Jul 2022 18:46:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a30/7fq0A8DYWu4jbTF8tImyxVnXCxI7vjsCFrTnetcAkEQkwRTzfzWDnjzhmcrNzsTSR76e4giqYF1a460qAK1HpBV9yf/i7gJssRz2OPQjWdzHfvNwb4qZodAsbxIGWfpVwH7tmuWb6ty8dGVzwoflIAYVCTiz8JX50iE/xveMsP+prfjtzqX5//LPGARx1SWEOMYgcowxrHAoI0lkz32ER9/hnxrJVFyLBItAXohyBCLXHGC6go4q5loL/Xf9UWTrcG8AmOLfMtzZQceVaWBXCgprLOEL8bw3T3vwOdg7jqy0OKxud5QJx5F3lfrFocnRr7bDN+0kRcICJqvzsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbhHuZmv60Z6Ne/p2wOgajtvg0+FTCQ2WMwkjz1Z7ZQ=; b=Z9/TwXyTFr4F1ZE4dNC47g450dACQx0ca3a1RzLNrpZ6QqWTvaAo3S01NHwmpww1HwG4ylMBe1Aj3Dwf5SyKccAnffaIkWgvxPkn/OzQdulXwpAl+1dnxCzg+/Gj2etIC6/CY9FJUNgtsMnhlKWxOLwe0pnEWvg9+7cNWnSDuAhqPnilRCsR767D45RHX6nFoKTFx9svWPE4MRReQyqDOuAC2Wdj6LdjpqAy9munLb7c2WHiJqLM/GuvizxjjFJoFNZtUuMScT0G2MSpyIVhXXVW/l31SVYmEUWw/yEjJi/8Z6TtsALQZlXwfVS1UanomLIrWfdLd1adsQroPPuHUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by DS7PR11MB6037.namprd11.prod.outlook.com (2603:10b6:8:74::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 01:46:03 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::e1e3:11d:934b:47a7]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::e1e3:11d:934b:47a7%6]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 01:46:03 +0000 From: "Gao, Zhichao" To: Sami Mujawar , "devel@edk2.groups.io" CC: "Alexei.Fedorov@arm.com" , "pierre.gondois@arm.com" , "Matteo.Carlini@arm.com" , "Akanksha.Jain2@arm.com" , "Ben.Adderson@arm.com" , "Ni, Ray" , "nd@arm.com" Subject: Re: [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Thread-Topic: [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to preserve alignment Thread-Index: AQHYl6H6YKlmeUCW5UCEWdm6qkCP1K2E8zpg Date: Tue, 19 Jul 2022 01:46:03 +0000 Message-ID: References: <20220714165031.42640-1-sami.mujawar@arm.com> <20220714165031.42640-2-sami.mujawar@arm.com> In-Reply-To: <20220714165031.42640-2-sami.mujawar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0366cb0d-f67f-4811-38f0-08da692870a6 x-ms-traffictypediagnostic: DS7PR11MB6037:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FmAymmY45167HcQ9dY69Gz+yKZQUAJRyQg1HCleCaH7Y4jICtBs0diPLf+M5n8mZNiVRrwC6OpbEef1vL57wXMJN9Pv2xFEdSbwrtz4t1dFqylQR/qRLOLeHD0Rghzq9c3iRwUlud/pFcoiejNtFGSLJQYiJZBAivRoc6bSMbP4LIK/QYUFHB2y3dPRGgvEV74ZYUU0xmg1iuYkrqSoWkNFlyw78JXed1dBcGqYQtiqezaKUI/8GEDcqKreo8M+qwBLLCbnf8zMhjH2VHw/w5/SMlhwg+dt6LCIhLIpohaLVmwjTshRMpFKvCQtpstqtCoLyDZIyM8BUTEzvJuGNno+bdL35GOdGROBQOGfj8uWEtihNSls9nX39UPFRCRoQwLAn3uRdxo/nPyNxGNR0ZZF1K3hqASRi2N8ycR4YrLX4kcabb0gam+BzF6XvWkWyu/TlRQKllNOx8Swa17W8MwNF5RV4/Mcc2+P77F3nxVqX3kU/Dur6ohqlqa918ZtcDYNElSCbfrI1ZDsGlfp/fmmjzjJLYuBhKdrXME0qJBwk+TTMIk9TmPrezkzWXJldVypgwrNX+Ry0AqApp6YMxMSdq8bBoSBgNNQrOxHe6qXavAHPkw6lm0ybVLFIaAUUYtk25pqog2zx/l9vDliUsfBlD4W/MPQ7M1Ij9vBmdETodJVkpC9jRAAwe3xvRD6iZKDua6VqMg15K0caFxOJVCtG52LPZYOGaYk+FOE3SP9CXrrsxoW11hbzxIb7RbIBSVzLco39wbfuEN5ZvI+gKnHXs550wWxQlOoaLQgx4+gzpr4ZI+pwCpqprLrnv4ryyvgBoigDJKX0EhV2yBZoLQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(39860400002)(396003)(376002)(71200400001)(86362001)(966005)(38070700005)(82960400001)(478600001)(41300700001)(186003)(6506007)(9686003)(7696005)(53546011)(26005)(110136005)(316002)(83380400001)(54906003)(76116006)(52536014)(66446008)(122000001)(66556008)(66476007)(4326008)(8936002)(5660300002)(8676002)(66946007)(2906002)(33656002)(38100700002)(64756008)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CT0dEaq4ff+QiJ6zTrPOkImKRLPAG8XIqyBwx4sdSEJ4uoRvWRo8v5hjogob?= =?us-ascii?Q?dYYWDihuqEYB1RCpLfy6hLyLpmcUNBHZ3pHJGJu+uXkp09rboiGNErnKNENF?= =?us-ascii?Q?vTuQfS/ABIrSyFHJmiOVuuzu3SAdOpVgZoM3wh9CeqOUU+NCKuLENzFfEBqr?= =?us-ascii?Q?8qRaFfPt6soi+gQrcWSLikc2stKwZKDsan3ByPUcWXeq6ESG+O7JH5lZMJS8?= =?us-ascii?Q?vbRoy9DPYsVx1eqSAIinuuMU24X0aZRs3f/6N8RFfNccjeVWcLIFbxU7oYHb?= =?us-ascii?Q?2UH0MIsO/vYi4Shg6s6AYw3Gey2WsyrvzJ3KTDGjoHr1Jd0HoAhugd2RWLkO?= =?us-ascii?Q?5hvi8JFDg6391Dz0rhFhdWQZYFiyfKG918gt+g1BBxXBJgTqxByOycWKNJ+C?= =?us-ascii?Q?WsqRUcWzaOsUudfNbDjHMZcUtS7JXRUqwjUJUy2olgpKyNiMTyimR8cJc9p6?= =?us-ascii?Q?n7KRmeDv1L4/KihPu0xRHBzEL8HlxZNTci2GBToWJgJ7hmBL/KVrj2SKWOFf?= =?us-ascii?Q?GjtGAQPr65xtKY2PYnfOO4i2fgggNh1scxnTHH1XIoKetgkyJjYzAzns9VB7?= =?us-ascii?Q?iNBqFJgGxibol5fzmAozopHw2fe0D4yGxVx5U5PvNqxahrVFWCMCLgy+X1vv?= =?us-ascii?Q?fKClOrJz4IAYqUzF2lz3vuQzVYjr6oVO+Ndag8OVzJpwVcUc8CZ7cJNyLoY5?= =?us-ascii?Q?Zi56SEuyZ0QvXkXgiWXvJrGTfywK118A1liINT3J0zL3fg+HCvshDKKYrFlT?= =?us-ascii?Q?prWeA/rcNzrtDaN75dzIMPBbiUITdUq/2YZ4oCOsvv42v0VpXttJerDAl3er?= =?us-ascii?Q?LOVnnV//5ZZvSPPULSfrX5+4WlA5mdVAQETLOrerKP8s37IJ9uTL/OGexP9B?= =?us-ascii?Q?wrZDTQ9OWBvWtRE7oMT0pstAmqoTACLHQgJN6+/J+1/3EGgzQQyvTxpFgR08?= =?us-ascii?Q?MQtF5oB8vYotEQbkziiA3j63+4atJp+PNDt4QhB520/cNQjhoBZOaV8BmD/X?= =?us-ascii?Q?Ue2KbuEgf6PvOHUX74qkVX1NxGzy/RdmU0kofet9qWmzbwfp27HcoKprmW+c?= =?us-ascii?Q?VDnttmbRhaNRjUmHS1ZGC106RZh4GjfgWFl9i2zgTVpTfWJiHG2cn4Jzu3V0?= =?us-ascii?Q?SUZ12rTL1d2Cju55227I1UkFyvOnZY9R68vuycsbF0CBh+OJmGASNRQvoYe4?= =?us-ascii?Q?3R+NaR1da+USEt20DSqSd53mzHIBae0/8qeQvg0MonJKSLWN2jlQyvQXGVMP?= =?us-ascii?Q?iQqOInBWycbqMJTLR7fOXF5eyutZLqUtbqMB9sv4CpC37Rav40RcZnCW5SNh?= =?us-ascii?Q?xboE+PHECCAfB/RgfTeqjVqNDRvInEjzbtPyTr/jz5R56hA/JsJnUQLRqYlX?= =?us-ascii?Q?PorSvX4ifsUfqx0ARSfNlN9c/o0mJVSSJ9rINqEduhsM0HxkmrqmWvTgfeWv?= =?us-ascii?Q?0ydFNp+JZUh+ffk18cidj55ePYzXnhgsihpNGTpCuuVz9y4ABn2srEXc0OmK?= =?us-ascii?Q?qAOB9bl554itWlSqmN5QvmuZjJKmH9Ydq7WAO3amkHd1jHynyIh0yx6NzDeP?= =?us-ascii?Q?46I6j6/ByCs7dEZWoF1mkxVfGI8BB9V0+3/AEPzH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0366cb0d-f67f-4811-38f0-08da692870a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 01:46:03.5427 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nlqhxAkPv5D2JAmuEqFlWL1p7iM297dbin1tf0F1BbaRjo2tPbrRLnKOxrMFF9ZSVkdX3ORC47YUaTd3cpb5qw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6037 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Sami Mujawar > Sent: Friday, July 15, 2022 12:50 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Alexei.Fedorov@arm.com; > pierre.gondois@arm.com; Matteo.Carlini@arm.com; > Akanksha.Jain2@arm.com; Ben.Adderson@arm.com; Ni, Ray > ; Gao, Zhichao ; nd@arm.com > Subject: [PATCH v6 1/8] ShellPkg: Acpiview: Abbreviate field names to > preserve alignment >=20 > Some field names in the IORT table parser were longer than the > OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of the > output print alignment. Therefore, abbreviate the field names. >=20 > Signed-off-by: Sami Mujawar > Reviewed-by: Zhichao Gao > Reviewed-by: Pierre Gondois > --- >=20 > Notes: > v6: > - No code change since v1. Including r-b and resending [SAMI] > with v6 series. >=20 > v5: > - No code change since v1. Including r-b and resending [SAMI] > with v5 series. >=20 > v4: > - No code change since v1. Including r-b and resending [SAMI] > with v4 series. >=20 > v3: > - No code change since v1. Include r-b received [SAMI] > from v2 series. > Ref: https://edk2.groups.io/g/devel/topic/83600717#7665 > v2: > - No code change since v1. Re-sending with v2 series. [SAMI] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > index > 81bfacd83added87a867cf365a56d4b7a1410ef2..44d633c5282463078a4cc990b > b24ca1992f95634 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > +++ er.c > @@ -1,11 +1,14 @@ > /** @file > IORT table parser >=20 > - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. > + Copyright (c) 2016 - 2021, Arm Limited. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > - - IO Remapping Table, Platform Design Document, Revision D, March 20= 18 > + - IO Remapping Table, Platform Design Document, Revision D, March > + 2018 > + > + @par Glossary: > + - Ref - Reference > **/ >=20 > #include > @@ -144,15 +147,15 @@ STATIC CONST ACPI_PARSER > IortNodeSmmuV1V2Parser[] =3D { > { L"Span", 8, 24, L"0x%lx", NULL, NULL, N= ULL, NULL }, > { L"Model", 4, 32, L"%d", NULL, NULL, N= ULL, NULL }, > { L"Flags", 4, 36, L"0x%x", NULL, NULL, N= ULL, NULL }, > - { L"Reference to Global Interrupt Array",4, 40, L"0x%x", NULL, NU= LL, > NULL, > + { L"Global Interrupt Array Ref", 4, 40, L"0x%x", NULL, NULL, N= ULL, > NULL }, > { L"Number of context interrupts", 4, 44, L"%d", NULL, > (VOID **)&InterruptContextCount, NULL, NULL }, > - { L"Reference to Context Interrupt Array",4, 48, L"0x%x", NULL, > + { L"Context Interrupt Array Ref", 4, 48, L"0x%x", NULL, > (VOID **)&InterruptContextOffset, NULL, NULL }, > { L"Number of PMU Interrupts", 4, 52, L"%d", NULL, > (VOID **)&PmuInterruptCount, NULL, NULL }, > - { L"Reference to PMU Interrupt Array",4, 56, L"0x%x", NULL, > + { L"PMU Interrupt Array Ref", 4, 56, L"0x%x", NULL, > (VOID **)&PmuInterruptOffset, NULL, NULL }, >=20 > // Interrupt Array > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'