Re: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4156

["Gao, Zhichao" <zhichao.gao@intel.com>]

Hi Liming,

I have created the PR: https://github.com/tianocore/edk2/pull/3647
But I am not able to add the push label. Can you help to add it? And why I lost the right, or is the progress changed?

Thanks,
Zhichao

> -----Original Message-----
> From: Wu, Jiaxin <jiaxin.wu@intel.com>
> Sent: Thursday, November 17, 2022 9:49 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; Zhang, JuX
> <jux.zhang@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>
> Subject: RE: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4156
> 
> Reviewed-by: Jiaxin Wu <jiaxin.wu@intel.com>
> 
> > -----Original Message-----
> > From: Gao, Zhichao <zhichao.gao@intel.com>
> > Sent: Thursday, November 17, 2022 9:27 AM
> > To: Zhang, JuX <jux.zhang@intel.com>; devel@edk2.groups.io
> > Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: RE: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF:
> > https://bugzilla.tianocore.org/show_bug.cgi?id=4156
> >
> > The code change looks fine to me. But I would adjust the commit
> > message when I send the PR.
> > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> >
> > Thanks,
> > Zhichao
> >
> > > -----Original Message-----
> > > From: Zhang, JuX <jux.zhang@intel.com>
> > > Sent: Wednesday, November 16, 2022 3:13 PM
> > > To: devel@edk2.groups.io
> > > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Wu, Jiaxin
> > > <jiaxin.wu@intel.com>
> > > Subject: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF:
> > > https://bugzilla.tianocore.org/show_bug.cgi?id=4156
> > >
> > > Refer to the latest SMBIOS v3.6, SMBIOS Socket not completely defined.
> > >
> > > SMBIOS v3.6:
> > >
> https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.
> > > 6.0.pdf
> > >
> > > Signed-off-by: JuX Zhang <jux.zhang@intel.com>
> > > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > > Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> > > ---
> > >  .../SmbiosView/QueryTable.c                   | 36 +++++++++++++++++++
> > >  1 file changed, 36 insertions(+)
> > >
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > > c
> > >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > > c
> > > index 2e62ae3a34f8..edb46817e422 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > > c
> > > +++
> > >
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.
> > > c
> > > @@ -601,6 +601,42 @@ TABLE_ITEM  ProcessorUpgradeTable[] = {
> > >    {
> > >
> > >      0x3F,
> > >
> > >      L"Socket LGA4677"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x40,
> > >
> > > +    L"Socket LGA1700"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x41,
> > >
> > > +    L"Socket BGA1744"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x42,
> > >
> > > +    L"Socket BGA1781"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x43,
> > >
> > > +    L"Socket BGA1211"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x44,
> > >
> > > +    L"Socket BGA2422"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x45,
> > >
> > > +    L"Socket LGA1211"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x46,
> > >
> > > +    L"Socket LGA2422"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x47,
> > >
> > > +    L"Socket LGA5773"
> > >
> > > +  },
> > >
> > > +  {
> > >
> > > +    0x48,
> > >
> > > +    L"Socket BGA5773"
> > >
> > >    }
> > >
> > >  };
> > >
> > >
> > >
> > > --
> > > 2.26.2.windows.1