Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

["Gao, Zhichao" <zhichao.gao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2578 bytes --]

Good catch. Please update the commit message. Then take my R-B.

Thanks,
Zhichao

From: Chao Li <lichao@loongson.cn>
Sent: Wednesday, March 13, 2024 10:13 AM
To: devel@edk2.groups.io; Shang, Qingyu <qingyu.shang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>; Gao, Zhichao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx


Hi Qingyu,

It may not be my domain, I think what you are trying to say is "Refer to UEFI spec 2.10 section 12.3.3",  not 13.3.3, because the 13.3.3 is "Number and Location of System Partitions", see me comment below. I recommend fixing all of the patch commit messages in this series.

The changes looks good to me and would recommend Liming and Zhichao to check again.

Thanks,
Chao
On 2024/3/11 16:41, Qingyu wrote:

Refer to Uefi spec 2.10 section 13.3.3, Add a new retval
It should be section 12.3.3, not 13.3.3.




EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx

and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().



Cc: Liming Gao <gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn>

Cc: Zhichao Gao <zhichao.gao@intel.com><mailto:zhichao.gao@intel.com>

Cc: Chao Li <lichao@loongson.cn><mailto:lichao@loongson.cn>

Signed-off-by: Qingyu <qingyu.shang@intel.com><mailto:qingyu.shang@intel.com>

---

 ShellPkg/Application/Shell/ConsoleWrappers.c | 4 +++-

 1 file changed, 3 insertions(+), 1 deletion(-)



diff --git a/ShellPkg/Application/Shell/ConsoleWrappers.c b/ShellPkg/Application/Shell/ConsoleWrappers.c

index eae11370e4e0..dbffae30cdf5 100644

--- a/ShellPkg/Application/Shell/ConsoleWrappers.c

+++ b/ShellPkg/Application/Shell/ConsoleWrappers.c

@@ -67,7 +67,9 @@ FileBasedSimpleTextInReset (

   @param[in] This      A pointer to the SimpleTextIn structure.

   @param[in, out] Key  A pointer to the Key structure to fill.



-  @retval   EFI_SUCCESS The read was successful.

+  @retval EFI_SUCCESS      The read was successful.

+  @retval EFI_UNSUPPORTED  The device does not support the ability to read

+                           keystroke data.

 **/

 EFI_STATUS

 EFIAPI


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117082): https://edk2.groups.io/g/devel/message/117082
Mute This Topic: https://groups.io/mt/104886872/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6989 bytes --]