Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

["Gao, Zhichao" <zhichao.gao@intel.com>]

Better to update the commit message with specific SMBIOS version.
Others looks good to me.

Thanks,
Zhichao

> -----Original Message-----
> From: Nhi Pham <nhi@os.amperecomputing.com>
> Sent: Friday, August 18, 2023 2:54 PM
> To: devel@edk2.groups.io
> Cc: Nhi Pham <nhi@os.amperecomputing.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system
> slot ID
> 
> This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond
> (0xC4) to cover modern PCIe Gen.
> 
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index f55d5f953c04..b6968cb36acb 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -3105,7 +3105,7 @@ DisplaySystemSlotId (
>        break;
> 
> 
> 
>      default:
> 
> -      if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) &&
> (SlotType <= 0xB6))) {
> 
> +      if (((SlotType >= 0x0E) && (SlotType <= 0x12)) || ((SlotType >= 0xA6) &&
> (SlotType <= 0xC4))) {
> 
>          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle,
> SlotId);
> 
>        } else {
> 
>          ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
> (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID),
> gShellDebug1HiiHandle);
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107911): https://edk2.groups.io/g/devel/message/107911
Mute This Topic: https://groups.io/mt/100816049/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-