From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9E3357803D0 for ; Mon, 21 Aug 2023 07:01:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GVq0Bo2wuILuuXx75gyBH1Zdw1XSgI09hrFSUac8NdM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1692601309; v=1; b=Mf7F8CiCPG+dPFmEzRbkszHEdYe5fhTSXsKM1i/7vdm2f/XhSFLs0FaUc9Ee68tOfztnmeO9 UX0nmI4d3NY3ffQM+1hAxR3m1KMEqROu925x2KKbvxlA+pO5zBZJa9Rta/nWRxBj5iHgpk88grW p5NnKXfGJjO1ofq5JWSFND+M= X-Received: by 127.0.0.2 with SMTP id lS5xYY7687511xVj2Xj9WGhu; Mon, 21 Aug 2023 00:01:49 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.5627.1692601307573645105 for ; Mon, 21 Aug 2023 00:01:48 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="353828851" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="353828851" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 00:01:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10808"; a="982366747" X-IronPort-AV: E=Sophos;i="6.01,189,1684825200"; d="scan'208";a="982366747" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP; 21 Aug 2023 00:01:29 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 00:01:28 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 21 Aug 2023 00:01:28 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 21 Aug 2023 00:01:28 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 21 Aug 2023 00:01:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cc1Q10ntzCIWLyLrz1Qw4X+LamCWesRnlvQeO/KoTp/+RBuaixCM9ctMlh+PFUsENBbie1wGCLY+OAQbe528SNxZPkmpftGwCXe53PDHbD3WQwytBA8QHIWvA/kG5eSkeT4fbaFarAhW/hjqhR3IJPTt8dwngAkhW9P3vRF6JDAEABA4Le6WsXFn7efrSDWQ5gWkpPb+/O9SS38WBddYO7mMbD3CMnu5DDvvoNRYJUesFLTnmHVEzsU+hb0Wo+JUt6WfnQ7zIeyIgfq5QtsfUbv+cvYB2OEUyjzly38kV2Z5WzTQuia7Y/jUo0wJHbwlPuf5snwfFA2Xg78/Iz730A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sP8/aKjvL7pwGshYnNprwUUYqjUes28cebtMlvLRMB0=; b=XOviSHBXxJLQchQS3n7ThhVfvD0pgUDIo8XA2ZZeY5Yre93fkCwv/IXUxxZ79tBHWy6VrDxzUEGadi5b5PnYQUOODEFUoNXB9CdV3K/VE4SkbTI9eVuoskUV6/aLLnfTLJ7UQnYSkIRPUtcrLM3hLocCkbVe5eGHVQXpR1YwrVeK3h18agnGVWGc9Ct/8MZdPL3pbL+jUppnxPG6ybo0y/D31hYAK2IFhboK9+WylJDWfOnDctF4Y7mHn3kTrgQ++z4fd4T8RBw/jZLf0Pzwmh8Ox63gPlaxGJRb27Fd/y00wPpQ/vy47+bqsIv4tXlCXT4B4KkDDqnxcorwdL0O8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by MN0PR11MB6012.namprd11.prod.outlook.com (2603:10b6:208:373::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20; Mon, 21 Aug 2023 07:01:26 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::b49a:f660:202e:6276]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::b49a:f660:202e:6276%5]) with mapi id 15.20.6678.031; Mon, 21 Aug 2023 07:01:26 +0000 From: "Gao, Zhichao" To: Nhi Pham , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID Thread-Topic: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID Thread-Index: AQHZ0aENFPDDnFa7KkGClYWcUr/Hk6/0VweA Date: Mon, 21 Aug 2023 07:01:26 +0000 Message-ID: References: <20230818065347.436331-1-nhi@os.amperecomputing.com> In-Reply-To: <20230818065347.436331-1-nhi@os.amperecomputing.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|MN0PR11MB6012:EE_ x-ms-office365-filtering-correlation-id: c419de61-f200-4694-a3d3-08dba2146ff4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: oq9YsgQvhxyHPFDxiMo0d7vxprNAHTeNEXEUObRjPywkLvce6FZBbXEYNWasm70PQD3E5AA5CRqRMYVjYwIiIhzY5qJJHqfgUjSbVLkSYdkdafILt662+AJUQGkVJ+V2qU6X3XzzrdTFFXERBiYzrl+gLNdJp25ywFU0v+0/ZGCESTzjmzp5U+CN5VFFyBkdL4pv9L4lH8AhMAwkX/si25w0o+h4YB/tjJrIrxpys6vVGUzj0kOCAZiGa3kHJOGwQjDtvKQW6UrULKChkWjvWxwBV8dbD7NlCqmWKIJd+uVgoBDJKVtBIvxyOgXCJD4q8Zpr0O6p+Nk8MBxoANSU4EUuCu90r5dz2UNoZ45OZEC35up++LLuU+wu924LMOm6rx9BzEG4Xc+hAY4oKz/kQyQBgo4ut0kdIYBLT7Nmws14WUbSTFK/D5TzMylY20fROq3WWv1lJwnqjpVVBoMfePMWaO7KstkXH5lZ2Ph4k+YYGSP0oyLzAZDqK5oMd95QoIx8BbqecLIYKpRrYm3kdDH/4trHWCgsKXoRr8aNAFGdqVfuNm+Ftyhs+rqqv/B/BB1dHoVhWE1W4lCUU1QZfBMTyZKwTa0/wNNtfY63jhaFaFCEsq9ajvq72pJ2PkrT x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kxjR/9jm/cRTxuJNVqPrySofjLSuWi8Q8K0ndfBevuYAXNauAW62jgJfgG2J?= =?us-ascii?Q?SzgYLjeMqFZyuqgLdJ/jMENhspjz2GDjLal43a86vAQcbwE64Bae2nR4vlZA?= =?us-ascii?Q?JlfN8FDp8cYfB/bwxJIyxcoABwcmk9Yjbh0k9gPx4umeaknQqvo+woL3nd2T?= =?us-ascii?Q?pb0Go/XpM/DMy5sJX9JsKhYjXV0BQB0R+DyTUR0y5qZSzOxU8W9NbYhykFEn?= =?us-ascii?Q?uVHOwUZQhvUjZ9xISqGoGARwyM2qJsk747ZPvJ2xJmzA5yTIw6pO1LJDjxRo?= =?us-ascii?Q?W6ihYv66DhT4iOCRK2SHrd/0s4z+9QUQZdU5WHnMwctjKcFPr96YsADJlDid?= =?us-ascii?Q?IcFImZJXJVrs7z9Losvq4bj3pKjXeHzQyRGBmvH5ijr2AXMBIjDez2xbNw5v?= =?us-ascii?Q?ez878Ed7uBLlZZEUpdNeiFtxIDljt7sLjAhi6hptpjKc5v17jeA2Ay65NV9Z?= =?us-ascii?Q?dD/Wc//DNZBsqo8v0hZ6VdDJjcDDqOHB3eK+PAMO54ySu8ErOEAL6hKRJgA2?= =?us-ascii?Q?6HVCGEet+jpn/53NGoq11VStLZ59iEmIYyR08LTLYoNK2rM3AoiqwC4QPZkw?= =?us-ascii?Q?e2wFDnMLcBqfLqtGeRE/J+8UcVBoa9JBc6pp2nef6T5m1RdBZHIFSehBLGOs?= =?us-ascii?Q?sACRZCEjIhnul2mw0AWHbJn7kC7+JCj57VtRLAbcKLx078aJDKLMNMtXM/KK?= =?us-ascii?Q?/ROzE4hUT9ygiLuHDfHbfgZYcEmv4dEtJX1/gsehwInXu2m5egAbRmIKYgF/?= =?us-ascii?Q?jm+eQFJY3PPkLtJf+SK9kBden1nW9StcRp1q3gNa17q6vZE8879zkC+3hlzv?= =?us-ascii?Q?AYXwG6E69sMn4mT7Lm6LgASfYt39pVIWyH5Wl00MATiw7jBR3QIkrZyCnqOc?= =?us-ascii?Q?KAYsR19a/m6welOcDvIYurVVuVPGtL3HlQ5Yo7Xk2FiamtSBz2nlnLiYGRHM?= =?us-ascii?Q?+Bbspcqj9Cbsj6JHd/MeICqtmYFsBzAEc7VENyYBYV8ZQe14STKFimePuC43?= =?us-ascii?Q?bDfB60XhZ6i//Gqc9CSDQSTkrTM7lBIq3K1POrvgFQkjf0ESObwu2KBTtA6a?= =?us-ascii?Q?UJZrBsuFyUSJOJcMtWmM9I0zGH3KNhR1UuOD5NcLqLBYhZZlVYMPKSPl+n9/?= =?us-ascii?Q?XdUUXlu+Vhe5i9PZ8P+KZHuW9NmiFAW9GwkjxQVlS6jtK4kCaXH8EWwCLNQD?= =?us-ascii?Q?E5uiIzJG1AyZrKnHF4iaV+YjPDOGGJCbkTBDNFwK2W4yCRtcuG7gcmSUlbKg?= =?us-ascii?Q?ZEO0RoQuIbnxIo0Yn76WiWZ8YFgEDzwbAQdjlSpc1KpNcmba5G+mtG23z9+E?= =?us-ascii?Q?Ro+Kq3ceIJY3LL+L/NCXnnHCABuFU8VNQqxfJyjsfTsCHWTIR2W6pF1cRcAM?= =?us-ascii?Q?dq5BCZVOOeid26/fKE3b2opvbaE61UmTHuEygOSior8f9ySB2OgrQYKjNNGe?= =?us-ascii?Q?c8+awwqsj2tksC6SA4f8lTz8kK2kC8bPsOqWiJlK82BdtUu1J/znRxudsL2U?= =?us-ascii?Q?C3KzIc8vEdUf7sZ/J6Lwd2k3lR0FFQS9hGFgD5wwbWwd8lsGsFgDVEohpcgt?= =?us-ascii?Q?d8JpnRba3sDboAeYA/XxZ7eGQg41rqdkJ3wflKht?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c419de61-f200-4694-a3d3-08dba2146ff4 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2023 07:01:26.4065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: brtCI+dgvKenEO7zlo510ClTB8u54dWa2ESwAFEHZaXM5kbQwB5kImX2rk1K3lrGOasajokpXKbljoef46MxaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6012 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: GpcyutLZBuDKGJzX4GwU4OBLx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Mf7F8CiC; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Better to update the commit message with specific SMBIOS version. Others looks good to me. Thanks, Zhichao > -----Original Message----- > From: Nhi Pham > Sent: Friday, August 18, 2023 2:54 PM > To: devel@edk2.groups.io > Cc: Nhi Pham ; Gao, Zhichao > > Subject: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system > slot ID >=20 > This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond > (0xC4) to cover modern PCIe Gen. >=20 > Cc: Zhichao Gao > Signed-off-by: Nhi Pham > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 > +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index f55d5f953c04..b6968cb36acb 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -3105,7 +3105,7 @@ DisplaySystemSlotId ( > break; >=20 >=20 >=20 > default: >=20 > - if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType >= =3D 0xA6) && > (SlotType <=3D 0xB6))) { >=20 > + if (((SlotType >=3D 0x0E) && (SlotType <=3D 0x12)) || ((SlotType >= =3D 0xA6) && > (SlotType <=3D 0xC4))) { >=20 > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_VALUE_PRESENT), gShellDebug1HiiHandle, > SlotId); >=20 > } else { >=20 > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_SMBIOSVIEW_PRINTINFO_UNDEFINED_SLOT_ID), > gShellDebug1HiiHandle); >=20 > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107911): https://edk2.groups.io/g/devel/message/107911 Mute This Topic: https://groups.io/mt/100816049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-