From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.36735.1670293037843574601 for ; Mon, 05 Dec 2022 18:17:18 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=D5AohaGN; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670293037; x=1701829037; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vAbHWCzNJUMoEp3E0Qr08Y2TbWg2vFWD4MEwP+aWMOU=; b=D5AohaGNnHp5BVSIrUcgotBQwI0Zr808BXc7aACfGNqGM1m5VNuDvb8Q W1aCyPyyNMm9FyGXBhYQQdsuGAdag9ZU5OunAV3K2oOLuicTPE1h5GO7y yKu2JThKGEJ2kC685E5P/Z2Gd5JFB9TDnt9CSZcud0FG3CVKg1yqoUEAV wjkS08Ssnoc+tU1v8Os0EeSXE5geNtJ+77xkqckj3eGzSNsqljyvbmfsv +3NzHyOw/aSlndR33l5Of0Qa/JjsZPOPt0To5dqarYEtm9tawseMxiaqk OzOjikz2NWEL65VYR3eCCXc3Les5W3xDE2YuTs0Zn9NNrttmlm7+EDGND A==; X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="378678301" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="378678301" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 18:17:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="646048187" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="646048187" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 05 Dec 2022 18:17:16 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 5 Dec 2022 18:17:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 5 Dec 2022 18:17:15 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 5 Dec 2022 18:17:15 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 5 Dec 2022 18:17:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IoEsIBQWiN392gOETCnRuFE8Uaeni6HVBeKvAEsN9ifqypzY6DWLd5L9OejbXwzQfQCKPunS0JSH4RlhB4IeTYj2l7C3+FxsxtXdz6JrJmNQ9LklyWi8EyQYyfppJlqLNP7Y7UyG+AGTqVQJg0mxnAzZ9rzZIqyybM5NPTJ7JLHHWLSyoKiNrDRsCBP5lLkHz3KwxdSGcQK73r67cTxgFmqmqY7amu4je2/upnDNGsDQrTsSSwXuR7/oPqa1wxOTTWIhHX29UnJXL9iA3D/502ulchhQVnKuBMV3GbmbcavCTHjs/15GCqrneq5j7p3I5NiqnTNhc/eSG4xWN7FZLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3IIKE1IOYTQFoC8QIiAtKos6elLAiKJ//fnZMLOLK/A=; b=NbV57j57jLIfEnhRRWG6TzfsXOWwLHbakipYialOu4SqWHe+F63vm1WurT5319wR8/W+gPPYijLZS2UYKUxAvMv6V+H7VTlW2pY2N1DDKWTMpAXXQC4bm8B4qyLZPPUwg+isQuetztjWTef6lM5A+FhHIkHxI9lSpHipHwTcI6/QHXyEKrI+ICVRH8w+10ZUFlChDmsCTK2Rz+FK9xV1bKhSUheV82qW+OzUXMAIGKPklZJ70Gy6bylQ/UsvZeQJvsBm0ewXz4FA+vDZaM/Tqy7XSfHs5p3D3paO/5q7D5jCte8NiAX0QiThmV2CvOCPKBPA6plzDpc9BkYpHTd9Gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by PH0PR11MB5829.namprd11.prod.outlook.com (2603:10b6:510:140::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Tue, 6 Dec 2022 02:17:12 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::3954:c74b:44ad:a9de]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::3954:c74b:44ad:a9de%6]) with mapi id 15.20.5880.008; Tue, 6 Dec 2022 02:17:12 +0000 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "quic_rcran@quicinc.com" , "Ni, Ray" CC: Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time Thread-Topic: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by adding equals sign after time Thread-Index: AQHZBdCCGpoCveUG60isnGg9Gq3nza5gJenQ Date: Tue, 6 Dec 2022 02:17:12 +0000 Message-ID: References: <20221201214935.67205-1-rebecca@quicinc.com> In-Reply-To: <20221201214935.67205-1-rebecca@quicinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|PH0PR11MB5829:EE_ x-ms-office365-filtering-correlation-id: 4e99d0d2-f073-42c4-061a-08dad72ffc51 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 362+u6FWZTkJ+UqWjueBjG7NB3D4BZ1rH+czC095dTQQj/UBRE6w592QCY2stgnqr9fqJBypbz0r+YwObe2+9IoYGitKhJ/942eV+hnTiQMTQwlrjpM4Y8z/T6AfRBEZrUO0qTbaD77OmswARBtkBRr43jTO9CVJs0Sek9c7BkxzavFAGeNId8UReNwpmURwnqBWg1RWEoMtARmX75EtECh1UgMC+zHOyutAsNu/FRAfsX/98o3S3x479GjKbCqa2HkkjXtN0j2XR6iaEjz/YciZWAtgNU5dfpZZHyads5IqbHL39kBXxXg8Nbw+MYM5LWX6viMBeLcTKeq6mEX7raKzN6XXBib01vOUftA+N5V3urZrlB9k9aJo+3fr9ERDjFo8HE1WBYGqlUZCJUckluhrLXh10HN0AjGFEG5Z4Nby8MP2IAp9s9GbaQTuopKSe17ggsCRj6F7bMWhG9ab9PNZpoEb4WLPTQ+vgwLyJJZaeUdndT0qT+kNTWNYmCnwZNToAijk9mI5VLhc1FeFdPqI+ooNdEAPwtokuIeozx5JfqrVU22G0GogqSD794e8DfnYTMSbPllLSUqtJ4T8ECECTHWxwZTUEobv1kAFMFUG6Vb+z2/UWWctHR8lDdNN+QGWU/PBVpKShyVj+uzRqw6TpHq0XAaGeapZRsOB49oXMjtRxJBdbCO5r1kic0CJqT2DR/N4ejuF5TjsPSnwNsYpgDWm+ZuEqedGnWIDnJgxoXSLVL+vu3Igaz9Fh8pAeWceU/jo3Seq78GaQ9xtxw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(136003)(396003)(366004)(346002)(39860400002)(451199015)(82960400001)(186003)(83380400001)(38070700005)(38100700002)(66899015)(478600001)(53546011)(7696005)(9686003)(6506007)(26005)(41300700001)(55016003)(71200400001)(66556008)(2906002)(8936002)(8676002)(4326008)(64756008)(66446008)(66476007)(52536014)(76116006)(966005)(66946007)(5660300002)(33656002)(122000001)(6636002)(86362001)(316002)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A8b8Hmq760cTcucct63kgJRk7JkgwKLVPaRHpAziTz4CC8Iyo+FiUcJ+ZvzO?= =?us-ascii?Q?J/yV2kvxpM08E0VQkvoPgNZMYE4VuC4zXsK7UMcO/47Kkv+6I4MDq7XPXKXq?= =?us-ascii?Q?Kn7Ya3yhsn6Bx4eJfdaE2Ku7IdxmsAwR3nimUb9IoXI+eXYkqbMIIWm29Itf?= =?us-ascii?Q?OgiMS/80UMuxVWNi0715UQT62OvCNdCAZyqKR8WXhItOd3NDbS7ov2UwWEBD?= =?us-ascii?Q?cPGXu+23k/U16Mrc3BXa8r3znbGIvNe6nS2zK0WiKxFiqhHBF64sDa8Fb9SS?= =?us-ascii?Q?Iub2PSJ8+NJqGb54jg8jgE0AGzU8YuDfw5INIjWlXkiGHklLeKaezxbRrGHj?= =?us-ascii?Q?1hDPc4dTnSuFPTUQOG12UJANhhSeQ7u+/xfQeDITzW+lVW1utK5SAteeDcff?= =?us-ascii?Q?EqtdeqWugRPKNlYIHdz9e5K8YpN+HmEEtSwksHzj2BGolh3/dNyOMPmT2F8V?= =?us-ascii?Q?V4+haBxHUbUKtSk7XdJywTEO8wuW2IXDQd/EzJk9ukSSTpzjn5lJjgt8GaDB?= =?us-ascii?Q?DCeXL6CAtevTZ2lR0B6arQmkzs9Zad24dswvHI3IBSf1mPZeSkyg0FWXG+fd?= =?us-ascii?Q?qPWvQFpVgEmeMEuo8JrH2kH42S8A1aOe2xMeskfd6/5y3ofh2Z8mGbJpNQ/p?= =?us-ascii?Q?/+J1cQ9E4A10cwGVqDFqm0qTPpG8gbHF4GVdFZXwGTum89wLc4XX4h9owqdX?= =?us-ascii?Q?15FCwdMGqlDX2FBQrSWwM37mBPgYq+F4LpWSFkVqOYD/v1MqQ4NhzVXKkw4c?= =?us-ascii?Q?MtHNe8FWLy+PuS490Nimbwdn+EMI6rDQT3mh9lZ2T12RSFICUFTt6HuoNqgq?= =?us-ascii?Q?8wW4lxiSZM7jENPS4cOn/DPxrWJXdMxKjix/PPLHRvKcAgfxHvM21gWe0CGI?= =?us-ascii?Q?S3tdvyOh+iBSpbiYX7Glx1kht4gZHuXb1xaT/VWNdsxWpfXIqzjvXXVkh6bZ?= =?us-ascii?Q?TK6tdpMh0FQycAPlS+/fRMQoRJPEeiAiwGsxe15UFmVFcCVZrcIG5Ur41/Jb?= =?us-ascii?Q?iqa0nNERl4WdEihbT8Q0IDnYNZShU1DXbKlK9fxCmRM6UJZvKsIKyneXWsa2?= =?us-ascii?Q?w7QtpeaFPc3MxuQgMDUnwPCJX73OInwVoLK4fQu8+oqmOHWYNNqyNMY2+hhF?= =?us-ascii?Q?f1VlnlmafoSkqlwKGLKnzZd4dfy4ajHG7HeWKoTyo9GqaSvKLsI0omXrIk/C?= =?us-ascii?Q?H+33M8iFg87tOizqZvE1i0srsn/PWEvENGn+npCL1rcqMEcMb44H17Sb30HM?= =?us-ascii?Q?IChhNXTbPWWweFvEkbThWrS6Sy8QpDBjOm+QuqrlwFazdEI26Lb40Ak4iSTf?= =?us-ascii?Q?EU02m/TdoRV9kufIRTWklyk28xEMbrIE6+mTtPT/rO1kE6CV0rwmf9NdJUMy?= =?us-ascii?Q?5MxMSvON+xzq7CxNH+Dzpkp8pbLpuzmyoy6F5XGZM1J2LrnHLmkYLNEFYUSs?= =?us-ascii?Q?a/ylXGtk0D6NexsTQ6Bcy7FU2c1h/TxZhR/HsNv/lYFditKya8c3NXvRg5wU?= =?us-ascii?Q?Jgybzn4vwn3bGups45I2fAHDmS2kR54tlbdO3bWN/TXe8QXWr89JNwjAQF6X?= =?us-ascii?Q?GV20v7whidvEkNvTdL1ziTBOc+x5WrJnB0Nvnio/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e99d0d2-f073-42c4-061a-08dad72ffc51 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2022 02:17:12.2481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rilsw7+QjGc44IB7KNVtPIZPXc0iFfpg3ll2w3BXKNkI6T6iDcIwW4qZUNeicT2O/M+F9AFMzfq48xJUdwj7yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5829 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Friday, December 2, 2022 5:50 AM > To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao > > Cc: Rebecca Cran > Subject: [edk2-devel] [PATCH 1/1] ShellPkg: Improve "ping" output by addi= ng > equals sign after time >=20 > The output of the "ping" command shows the time without a space between > the label and the value. e.g.: >=20 > 20 bytes from 192.168.0.1 : icmp_seq=3D1 ttl=3D1 time1~2ms >=20 > Improve the readability and consistency by adding an equals sign for the = time > value: >=20 > 20 bytes from 192.168.0.1 : icmp_seq=3D1 ttl=3D1 time=3D1~2ms >=20 > Signed-off-by: Rebecca Cran > --- >=20 > ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Comm > andsLib.uni | 2 +- > ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Comm > andsLib.uni | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > index 73cf96d9e614..37fd4a11929c 100644 > --- > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > +++ mandsLib.uni > @@ -52,7 +52,7 @@ > #string STR_PING_NOROUTE_FOUND #language en-US "There is no > route to the destination '%B%s%N' from the source '%B%s%N' was > found.\r\n" > #string STR_PING_START #language en-US "Ping %s %d data > bytes.\r\n" > #string STR_PING_TIMEOUT #language en-US "Echo request > sequence %d timeout.\r\n" > -#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > icmp_seq=3D%d ttl=3D%d time%d~%dms\r\n" > +#string STR_PING_REPLY_INFO #language en-US "%d bytes from %s : > icmp_seq=3D%d ttl=3D%d time=3D%d~%dms\r\n" > #string STR_PING_STAT #language en-US "\n%d packets > transmitted, %d received, %d%% packet loss, time %dms\r\n" > #string STR_PING_RTT #language en-US "\nRtt(round trip t= ime) > min=3D%d~%dms max=3D%d~%dms avg=3D%d~%dms\r\n" >=20 > diff --git > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > index 30913ae5b583..cb9d39a33fbe 100644 > --- > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > mandsLib.uni > +++ > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > +++ mandsLib.uni > @@ -33,7 +33,7 @@ > #string STR_PING6_NOSOURCE_INDOMAIN #language en-US "No > sources in %s's multicast domain.\r\n" > #string STR_PING6_START #language en-US "Ping %s %d = data > bytes\r\n" > #string STR_PING6_TIMEOUT #language en-US "Echo reques= t > sequence %d timeout.\r\n" > -#string STR_PING6_REPLY_INFO #language en-US "%d bytes > from %s : icmp_seq=3D%d ttl=3D%d time%d~%dms\r\n" > +#string STR_PING6_REPLY_INFO #language en-US "%d bytes > from %s : icmp_seq=3D%d ttl=3D%d time=3D%d~%dms\r\n" > #string STR_PING6_STAT #language en-US "\n%d packet= s > transmitted, %d received, %d%% packet loss, time %dms\r\n" > #string STR_PING6_RTT #language en-US "\nRtt(round= trip time) > min=3D%d~%dms max=3D%d~%dms avg=3D%d~%dms\r\n" >=20 > -- > 2.30.2 >=20 >=20 >=20 >=20 >=20