From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.4523.1668648408251939289 for ; Wed, 16 Nov 2022 17:26:48 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=EmocNtS6; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668648408; x=1700184408; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=s9NQlpnwFFwvUQ2sFpdzQhSKgXFK7lVCQzQxq3Y7ezA=; b=EmocNtS68N35tdMit6QV1LgARcl0Ejyge7wjM4d1/PHFkr2aWhVyv/c9 ppSB93Hw3XOEo+bYUi2VXtDCXw1iQhcUh5wLC+SpzDYNuiKXRXZhOz9h3 z1m1mgYu6l76sb+AyRDaJ1DaWS9e7gkYE6m8k20GZCjlGgqAQVTXive3g /BnREfh7zEnyoULs8CtRX5vD3Z8YlfVh00FZHfhB4DKImonYRvY/PDrpJ pxt6jtTfPjoZfr9OTNC9cg+MSEwY7sXn7Z8DcBt5u2Kd8v903Tauh57CN UiN9PRhAaCBrkV2BBV3MSu0UOGp48MgUneP8DIt/+0rn+PYF5VMOz70v8 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="293115909" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="293115909" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2022 17:26:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="639589036" X-IronPort-AV: E=Sophos;i="5.96,169,1665471600"; d="scan'208";a="639589036" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 16 Nov 2022 17:26:47 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 17:26:46 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 17:26:46 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 16 Nov 2022 17:26:46 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 16 Nov 2022 17:26:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzVe1ZdEBeKM2OzvGKYZRpF9WHhs9qwDe82ZKOrwHj8D+GXBamsDWI/9DTaE8lgdf9HzsGgejCPg+A2HA32jVw0rJcedBHH/Pqx8LsnCXCy2RibdIib+5sH9v9xB1R5G+uyq/4y4F+NpASFpE2je1DclOuzou5YV+GvQXGJmZ/a1UoOimiBisFiXreVdAEKiRCH1BEaBbju6VPaiEy8Ax+n6tjXI5956TCI17D5U/zYjPC9IeTS9hDtBNzIvrSMCElvatS77uq+nvDfdAzv42obiId4LXXsKDhHkHrpNPh5MkXr9nvgwjufiGFr017bMTKvMT0SMSeeMTGsnSgGRQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyPySUq/Yb4vvDBPJ60a2vMkU/q2KBxCssEWEhAInew=; b=XzB4+O0+ieznrZrx3rJY1mb6vETm/id/wUibdFBm9YNIZZFILMqRtbtgl9ISYHHM1H2XLk8w0GHtmBKXa7SE1mZ+zaSlfHvqZjPxuvCLrQikYAWxJ2WBurGKbYNP6AYYoDzxA3u/sm/Z80HDpvHr/D5wGrs6zzj0+1ceoiDZ3hF7AYABgDzng2kCJBN8XECyLmz3pWNTZVz7WXUpRsXAffHRMpBNPZU7QT6cm8VMyrTtby+8R7XE9BOgU9I1Zt28WQmKqD9h1u5sm9/5IGzjJHJUu+UPj8DWKoopyh5wiO8JvVwJfLlGAhmPoEVXtZf8knvYU2D99oRK6LB4dmDEpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by DS0PR11MB6448.namprd11.prod.outlook.com (2603:10b6:8:c3::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Thu, 17 Nov 2022 01:26:44 +0000 Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::6a3:d470:3867:1403]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::6a3:d470:3867:1403%5]) with mapi id 15.20.5813.017; Thu, 17 Nov 2022 01:26:44 +0000 From: "Gao, Zhichao" To: "Zhang, JuX" , "devel@edk2.groups.io" CC: "Wu, Jiaxin" , "Ni, Ray" Subject: Re: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4156 Thread-Topic: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4156 Thread-Index: AQHY+YfnjxIlFIZw2ky1lIj+h3NDWq5CVDsw Date: Thu, 17 Nov 2022 01:26:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|DS0PR11MB6448:EE_ x-ms-office365-filtering-correlation-id: e18589e9-05db-45f9-6b17-08dac83ac98b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JmQXAcicBV7vp9jN38BdwfGY9AgK73+hPC9CQaAQ7SthD/LtrKZ938YyVpkZtTrisCAua06+Mc6j3Hse8oxI2DW59sDqqyDAd8cdUWnVAlel7sSFcmRtIQYj3cxs+3FyrPbx2pY4hamuZQg47l9PtCwKKLgQm3ezWUwkCYXy4y0+I+94G6ycl120SBBaMPz/eqGbyP/776h7lZNDgmw1igCrPeQgYmUNrKfOc9dv1WjU0Zc5d6wVyQuDhEPYv/EQJZQ29lZQpq0lm8b+/jzYERE42IO+vftsAseoaFqQwc0GGojpdB47rydD8251pnq4yp9mBvjBGCLLpaOZEPDLeKFPhQdmyASfuNWeYmVpzjHmqW1Xz9uJS2mqFdPCzEJaGuzM30OooKCzHrtg4onFVDe5L0gokjMIdVBBBQgREBIFfALTwxARtSKF5WmI4f/EK0xCqEI/JVGUKzuR9M8/9WAjBoxOJ3N9kTPgPSGk3LizsAbRkTFjvzYmJuNa830+mB+OeuEWwtB0+7GuEc6trudg71qjTjZqqLuq3RjkiF9X9mvI3hBonlpKfjeKgJpBPgu5wTndWPJcR9d+6TAwC69tyKPzAeTxVl6XDkx7VsD6KhH2SKg2YNjBnnm/0rsHtcP4Vh9MiRByKfCryv8HKlyPAZ3kGPwcJUzuJh1ajQanEZvpAB1ggpvpWPvZsRBN6078UwdZKrj2XldoKM+/gO3yLNb5ncglSrImiPUMDMCt4WFQganyCgw5jk0K6h22NFjUphASQlDgWHmu7YiIqJAVwjKCfU48oQ1BGzLcEoYqTIrA40YUCwdPgU6YjoTTrZ+gjTrMOFETmPGLDGu/ng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6377.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199015)(26005)(8676002)(4326008)(9686003)(76116006)(64756008)(53546011)(316002)(66446008)(5660300002)(66476007)(6506007)(52536014)(186003)(66556008)(8936002)(15650500001)(2906002)(66946007)(7696005)(38100700002)(86362001)(122000001)(38070700005)(83380400001)(82960400001)(33656002)(966005)(71200400001)(107886003)(41300700001)(110136005)(55016003)(478600001)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?T6E638+6CN/qsgmVFO7xF7/QhPvvAzTgdJBRmr6k5fG1C8yj96sSxILh/G+1?= =?us-ascii?Q?HUqUWSCjUzqfAfXxHL4ehBviRbhJgETPUlLpSjADF7ZLrq8GpMNDFQ2Pu0Zk?= =?us-ascii?Q?gfRYP9G3DCnzVy8rNbeDQQJK1Avek/kuDt0s6yUXvRN9PezXvr5FADsNu8dp?= =?us-ascii?Q?SNY2AVVHmelXWheX7Ar6DL3l+Piu3QXJoFDrpi2D+mYs38Kkh9JGrsdyjUd+?= =?us-ascii?Q?GGUH/C3ca+wyaPTGsHvQxiPrw9lENbv4tRpdZLLNUrAL/JfOSPdmn0/RT4oQ?= =?us-ascii?Q?3DpNWt5CJt1u4MHBF4Gna8c4+kYB4A9xkvvDr5+huBkhPztsa9ceE+bjgjTI?= =?us-ascii?Q?yiw8DSPVA9m+d0ayv//cgEzBtbpIhX2AkM3shiKR951cyr0ak87Wu475HKGk?= =?us-ascii?Q?3+zV7dUuxRbf2BHvaPYiqOf5VQgdM774FB6PvE0xLRDXYYxwfHb3L2owrL/b?= =?us-ascii?Q?py/gSSoD/mjw3YmxYa857fsHx2IbLbvCN9vTlhtANdTpMX1r8m7H7orm5+1/?= =?us-ascii?Q?YQgufnm+53wb5Ijqynwn0eBoxTRmg/e7FCRIGgBBGpaDSvKaqF1tc5vL9p+C?= =?us-ascii?Q?hBHBeQKtE9Pp8IDf8nv2eNSXW0cFesJo7I4WFma2s/juzrIUFqGujm7IaEax?= =?us-ascii?Q?JKvmN/BgaK4advzK5+y1gr6n3T8VzkjOTBrCFz5qa2L/PvQpAZoR3h3Vq3RG?= =?us-ascii?Q?BjhV/rC0pHUc3gQssc+RET4d7Ve0z35AWPIsA9c9XCBVCP+vqEpNL7JU9OaL?= =?us-ascii?Q?9JL1R/3dcztSAGG8wVFN8djhBIdjXyEx3EL5j5fHoK1Gx5+C8q06imNxwYDu?= =?us-ascii?Q?mM0pCoecDBvlfIhgYCnKijvNfK3Lcc/M6w/CEKlMiOZieIcsmvqwUnWGHwqV?= =?us-ascii?Q?a3jJSpGpEINOewc1s/VC42kaTMF3Y5MoWXRwtuF4DeaW+W9edpQ/l1GKBBch?= =?us-ascii?Q?ZjC6WWWY3LoNg8v5CVK4ThgQ/HNylfK3AH+OxeBxuJl/2SYVmZSa8i9srsg9?= =?us-ascii?Q?VZssdftNP1vt6xdxO2YEnVgJ+3UoSCnEhnYG3UNnqamElo+4iL1I5yDLOfcp?= =?us-ascii?Q?rigZQMqU7mcl1UZrGxdtpmlYYiYSH/znTtjAA6gLyTPszevZSTASRJTH0kp5?= =?us-ascii?Q?6q3cmKmYpefEWvJE3q9lRWTuX4H5DoTwUnRxAwfeMfUcYjXdk62Axpe+wBGS?= =?us-ascii?Q?4iyloPEZHz58ewxKa7nosFLw+gkf4IiqCWUUgaKPQmU5c2YmPzw6VyoSxrlQ?= =?us-ascii?Q?h3GOGOjQEAnvyFfRaiZoEUPgwTdnYTL3HnuqixjxiaBomjhZ5TGofuuhAlXq?= =?us-ascii?Q?MUznq7ImUTRsLtb7o7pt2nklUTRtABr2rkGUPO7CfBQIv1r6fTjQWQM6S3z5?= =?us-ascii?Q?b3REr6re1T1mRgMNU9V2/55Cd925Xeq1/nP8bIiex+lll9MWlMSkzjpzn4M1?= =?us-ascii?Q?LSWUYsPqzTlaSkjb924noHru3dhvZ+/R/0Pe1ADXagF7F1ajFd67RUwWqyBB?= =?us-ascii?Q?m8hx9kZkKn0A8r8XiDaAcyQn1MQBky2wxGqzefmG1a9qFDFLDRzQN9QwWwnQ?= =?us-ascii?Q?YFPKBIw+Xn43s34CFOeDoAi6G4eqx8qbYB3BpnW2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e18589e9-05db-45f9-6b17-08dac83ac98b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 01:26:44.0893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QoY91hRJgX96o5/Ps3F717dx0qaoAWfuHJphcQ90IBOSfydfx0Nezw26Mj9vwOwRIw6bxlGD79ATriRePDTFcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6448 Return-Path: zhichao.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The code change looks fine to me. But I would adjust the commit message whe= n I send the PR. Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Zhang, JuX > Sent: Wednesday, November 16, 2022 3:13 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Wu, Jiaxin > Subject: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4156 >=20 > Refer to the latest SMBIOS v3.6, SMBIOS Socket not completely defined. >=20 > SMBIOS v3.6: > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3. > 6.0.pdf >=20 > Signed-off-by: JuX Zhang > Cc: Zhichao Gao > Cc: Jiaxin Wu > --- > .../SmbiosView/QueryTable.c | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index 2e62ae3a34f8..edb46817e422 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > @@ -601,6 +601,42 @@ TABLE_ITEM ProcessorUpgradeTable[] =3D { > { >=20 > 0x3F, >=20 > L"Socket LGA4677" >=20 > + }, >=20 > + { >=20 > + 0x40, >=20 > + L"Socket LGA1700" >=20 > + }, >=20 > + { >=20 > + 0x41, >=20 > + L"Socket BGA1744" >=20 > + }, >=20 > + { >=20 > + 0x42, >=20 > + L"Socket BGA1781" >=20 > + }, >=20 > + { >=20 > + 0x43, >=20 > + L"Socket BGA1211" >=20 > + }, >=20 > + { >=20 > + 0x44, >=20 > + L"Socket BGA2422" >=20 > + }, >=20 > + { >=20 > + 0x45, >=20 > + L"Socket LGA1211" >=20 > + }, >=20 > + { >=20 > + 0x46, >=20 > + L"Socket LGA2422" >=20 > + }, >=20 > + { >=20 > + 0x47, >=20 > + L"Socket LGA5773" >=20 > + }, >=20 > + { >=20 > + 0x48, >=20 > + L"Socket BGA5773" >=20 > } >=20 > }; >=20 >=20 >=20 > -- > 2.26.2.windows.1