From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Tan, Lean Sheng" <sheng.tan@9elements.com>,
"Rudolph, Patrick" <patrick.rudolph@9elements.com>
Cc: "Dong, Guo" <guo.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Rhodes, Sean" <sean@starlabs.systems>,
"Lu, James" <james.lu@intel.com>, "Guo, Gua" <gua.guo@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX
Date: Thu, 16 Mar 2023 02:08:20 +0000 [thread overview]
Message-ID: <PH7PR11MB6377A833E9CBAFEB8F304B20F6BC9@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMWxwJ1c4w0TpAfKeQGADvFRgwaB_p8Tky-_xCjvGeqFJCuXUQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
Did you make sure the change would really fix the issue?
Just add the DEPX would only make sure the protocol is installed but not installed to the image handle. The return value would be still error code.
And the issue is still there.
The HII image related protocol should not be the MUST have for the application. Using the DEBUG ASSERT is not appropriate. I would suggest to remove the ASSERT instead.
Thanks,
Zhichao
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng Lean Tan
Sent: Thursday, March 16, 2023 12:54 AM
To: devel@edk2.groups.io; Rudolph, Patrick <patrick.rudolph@9elements.com>; Gao, Zhichao <zhichao.gao@intel.com>
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james.lu@intel.com>; Guo, Gua <gua.guo@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX
Added Zhichao.
[-- Attachment #2: Type: text/html, Size: 3500 bytes --]
next prev parent reply other threads:[~2023-03-16 2:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 8:37 [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64 Patrick Rudolph
2023-03-06 8:37 ` [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64 Patrick Rudolph
2023-03-06 8:39 ` Sean Rhodes
2023-03-15 16:52 ` [edk2-devel] " Sheng Lean Tan
2023-03-06 8:37 ` [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX Patrick Rudolph
2023-03-06 8:39 ` Sean Rhodes
2023-03-15 16:54 ` [edk2-devel] " Sheng Lean Tan
2023-03-16 2:08 ` Gao, Zhichao [this message]
2023-03-15 16:45 ` [edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64 Sheng Lean Tan
[not found] ` <174CA58C1DBF1462.24874@groups.io>
2023-03-15 16:51 ` Sheng Lean Tan
2023-03-15 22:16 ` Marvin Häuser
2023-03-15 22:50 ` Ard Biesheuvel
2023-03-15 22:56 ` Marvin Häuser
2023-03-16 0:05 ` Ard Biesheuvel
2023-03-17 14:07 ` Patrick Rudolph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6377A833E9CBAFEB8F304B20F6BC9@PH7PR11MB6377.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox