From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Pierre.Gondois@arm.com" <Pierre.Gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 19/24] ShellPkg: Remove duplicated words
Date: Wed, 24 Aug 2022 05:34:46 +0000 [thread overview]
Message-ID: <PH7PR11MB6377CF7332D1B5766405743CF6739@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220823160031.991072-20-Pierre.Gondois@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> Sent: Wednesday, August 24, 2022 12:00 AM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois <pierre.gondois@arm.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 19/24] ShellPkg: Remove duplicated words
>
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> In an effort to clean the documentation of the above package, remove
> duplicated words.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
> ShellPkg/Include/Library/ShellCommandLib.h | 2 +-
> ShellPkg/Include/Library/ShellLib.h | 4 ++--
> ShellPkg/Include/Protocol/EfiShellEnvironment2.h | 2 +-
> .../Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 2 +-
> ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | 2 +-
> .../UefiShellDriver1CommandsLib.uni | 2 +-
> ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 2 +-
> ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c | 2 +-
> ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++--
> 9 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/ShellPkg/Include/Library/ShellCommandLib.h
> b/ShellPkg/Include/Library/ShellCommandLib.h
> index 7a97b203f1ff..de7db40a1525 100644
> --- a/ShellPkg/Include/Library/ShellCommandLib.h
> +++ b/ShellPkg/Include/Library/ShellCommandLib.h
> @@ -87,7 +87,7 @@ SHELL_STATUS
> If the ShellSupportLevel is greater than the value of
> PcdShellSupportLevel, then return RETURN_UNSUPPORTED.
>
> - Registers the the handlers specified by GetHelpInfoHandler and
> CommandHandler
> + Registers the handlers specified by GetHelpInfoHandler and
> + CommandHandler
> with the command specified by CommandString. If the command named by
> CommandString has already been registered, then return
> RETURN_ALREADY_STARTED.
> diff --git a/ShellPkg/Include/Library/ShellLib.h
> b/ShellPkg/Include/Library/ShellLib.h
> index 10cf7f4fefe0..cd0c3bccc89f 100644
> --- a/ShellPkg/Include/Library/ShellLib.h
> +++ b/ShellPkg/Include/Library/ShellLib.h
> @@ -1354,9 +1354,9 @@ ShellFileHandleReturnLine (
> @param[in, out] Buffer The pointer to buffer to read into.
> @param[in, out] Size The pointer to number of bytes in Buffer.
> @param[in] Truncate If the buffer is large enough, this has no effect.
> - If the buffer is is too small and Truncate is TRUE,
> + If the buffer is too small and
> + Truncate is TRUE,
> the line will be truncated.
> - If the buffer is is too small and Truncate is FALSE,
> + If the buffer is too small and
> + Truncate is FALSE,
> then no read will occur.
>
> @param[in, out] Ascii Boolean value for indicating whether the file is
> diff --git a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> index 8b7c86dc24fc..59714c1b589b 100644
> --- a/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> +++ b/ShellPkg/Include/Protocol/EfiShellEnvironment2.h
> @@ -541,7 +541,7 @@ EFI_STATUS
> /**
> This is an internal shell function to enumerate the handle database.
>
> - This function resets the the handle database so that NEXT_HANDLE and
> SKIP_HANDLE
> + This function resets the handle database so that NEXT_HANDLE and
> + SKIP_HANDLE
> will start from EnumIndex on the next call.
>
> This must be called after INIT_HANDLE_ENUMERATOR and before
> CLOSE_HANDLE_ENUMERATOR.
> diff --git
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> index 4a19794b9fe0..0f33d52a67cc 100644
> ---
> a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> +++
> b/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c
> @@ -1252,7 +1252,7 @@ BcfgAddOpt (
> }
>
> //
> - // Shouldn't be possible to have have both. Neither is ok though.
> + // Shouldn't be possible to have both. Neither is ok though.
> //
> ASSERT (FileName == NULL || Data == NULL);
>
> diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> index 36cf46fb2c38..75fa81f7e448 100644
> --- a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> +++ b/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c
> @@ -119,7 +119,7 @@ CommandInit (
> }
>
> //
> - // Find the best matching matching language from the supported
> languages
> + // Find the best matching language from the supported languages
> // of Unicode Collation2 protocol.
> //
> BestLanguage = GetBestLanguage (
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index fc4986c8c62f..ba4dbc4e8b48 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comma
> +++ ndsLib.uni
> @@ -171,7 +171,7 @@
> " 1 - Manufacturing Defaults.\r\n"
> " 2 - Safe Defaults.\r\n"
> " 4000-FFFF - Custom Defaults.\r\n"
> -" DriverHandle - Specifies the the handle of the driver to configure.\r\n"
> +" DriverHandle - Specifies the handle of the driver to configure.\r\n"
> " DeviceHandle - Specifies the handle of a device that the DriverHandle is
> managing.\r\n"
> " ChildHandle - Specifies the handle of a device that is a child of the
> DeviceHandle. \r\n"
> ".SH DESCRIPTION\r\n"
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> index f92cfa502df1..f88c9e547943 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c
> @@ -9,7 +9,7 @@
>
> #include "UefiShellLevel2CommandsLib.h"
>
> -// This function was from from the BdsLib implementation in
> +// This function was from the BdsLib implementation in
> // IntelFrameworkModulePkg\Library\GenericBdsLib\BdsConnect.c
> // function name: BdsLibConnectAllEfi
>
> diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> index f3c888edd48c..3b06246d3e95 100644
> --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c
> @@ -122,7 +122,7 @@ SearchList (
>
> /**
> Determine what type of device is represented and return it's string. The
> - string is in allocated memory and must be callee freed. The HII is is listed
> below.
> + string is in allocated memory and must be callee freed. The HII is listed
> below.
> The actual string cannot be determined.
>
> @param[in] DevicePath The device to analyze.
> diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> index a72767bd869f..b2819f964a77 100644
> --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> @@ -4338,9 +4338,9 @@ ShellFileHandleReturnLine (
> to hold the next line of the file (as a UCS2
> string, even if it is an ASCII file).
> @param[in] Truncate If the buffer is large enough, this has no effect.
> - If the buffer is is too small and Truncate is TRUE,
> + If the buffer is too small and
> + Truncate is TRUE,
> the line will be truncated.
> - If the buffer is is too small and Truncate is FALSE,
> + If the buffer is too small and
> + Truncate is FALSE,
> then no read will occur.
>
> @param[in, out] Ascii Boolean value for indicating whether the file is
> --
> 2.25.1
next prev parent reply other threads:[~2022-08-24 5:34 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09 ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29 ` Leif Lindholm
2022-08-24 13:31 ` Chang, Abner
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55 ` Chiu, Chasel
2022-09-01 23:18 ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24 ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31 ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32 ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24 5:34 ` Gao, Zhichao [this message]
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24 0:50 ` Wu, Hao A
2022-08-24 1:06 ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11 ` Sami Mujawar
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25 3:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB6377CF7332D1B5766405743CF6739@PH7PR11MB6377.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox