From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AE5F0D804B8 for ; Thu, 7 Sep 2023 02:48:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7mO1oGXz8m+1kpuQcK8ig5FRCUsrX0rp0BKD1aSf8yg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1694054929; v=1; b=NFOfWtdSRPlb4RDETU33/6A7CfSnRDAoGHj0tjxe2T4psKIfwW/kPTr8puE1ejINMQP4ZVVm 1/Opk1aL5mTmKMaV+A/lfEsaPsqolQYRAKKRyV48yP/OmiyzbBQGa6KapYvX9CT+KrsPXPrHGHj BCLuKyuXzZ5QWSejUhivyQvs= X-Received: by 127.0.0.2 with SMTP id ibweYY7687511xDmEn30c9kY; Wed, 06 Sep 2023 19:48:49 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.5318.1694054927949947414 for ; Wed, 06 Sep 2023 19:48:48 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="441228076" X-IronPort-AV: E=Sophos;i="6.02,233,1688454000"; d="scan'208";a="441228076" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Sep 2023 19:48:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10825"; a="735312340" X-IronPort-AV: E=Sophos;i="6.02,233,1688454000"; d="scan'208";a="735312340" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Sep 2023 19:48:38 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 6 Sep 2023 19:48:38 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 6 Sep 2023 19:48:38 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 6 Sep 2023 19:48:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=laW6o0a7wUMHA2+p5AzD4RX3BMfUo7rnMsRjDAT7Xrl7fn3Iw648ZOifuD5I+E/qv/uN3IxHZCl2iD0iBQZ+kLCL1uYex+4WRSDs5zMcGRvr8zp5vNweRkAr4cgK4xu7yJr2w/Ja+mVnZKh7HDN9rJ69fo2FSlwr3nR8dp2aNciYhpu1l/Z+JKzOXXvYn4Kfaw4Kx/08wtD4RJCEGPaCyXz8ktGjQtDXCpVw9MMGJLaQtY0E9neSL8Q0payDpPHh4w7yuPuzSUKWbMjsGGit2OTwnKAny74n+Jda3r3Nh7Z52mt+u7XWLETfJ8ssN+yc4Ax6hOvg57SdsuW6xNHaiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HsGCDyqSRmqTH7L8WMGAHtddOVBmCpWNj99MPYW9Bec=; b=XM3Hx8Lcxs9txpZZSQyvgESaTj4AEhCXuDFhWijPBMwjTW5IOQjlYCgqzOuhyD8WvLzeozMN9bxU8hINcvaBY5cQxwDRX9ViEYNadGbsZzkvs8HL7Y26ssQhXTsHmdlXy4js61wk1Wznp3kmwTW0NVZuris2ebiDuRk6Fapr0l5zADqle5cY4zdRvCbSDPVUKQDn4qpVIgumxvS9yxqGaTiukmoMBSniYsGKUGRdthmXhEYKmP10dlIEOmeggRcEN3blg80W+vl968VoKonOUVUUjUCyRJGF581+leYQxri20aG4v13f0E9D2cZX32mBv918gHspNrZGks0n+jnxyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by CO1PR11MB5137.namprd11.prod.outlook.com (2603:10b6:303:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6745.34; Thu, 7 Sep 2023 02:48:36 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::6d2a:92af:3ea8:a440]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::6d2a:92af:3ea8:a440%7]) with mapi id 15.20.6745.035; Thu, 7 Sep 2023 02:48:35 +0000 From: "Gao, Zhichao" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellNetwork2CommandsLib: Check array index before access Thread-Topic: [PATCH v1 1/1] ShellPkg/UefiShellNetwork2CommandsLib: Check array index before access Thread-Index: AQHZ4OlSM8P52QCsoEipM1WDhnwFA7AOqZbw Date: Thu, 7 Sep 2023 02:48:35 +0000 Message-ID: References: <20230906174033.1878-1-mikuback@linux.microsoft.com> In-Reply-To: <20230906174033.1878-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|CO1PR11MB5137:EE_ x-ms-office365-filtering-correlation-id: 689a93dd-eda7-410e-2889-08dbaf4cee25 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 0KHy72ozlDB5iR69/LbAD5nucR/ZbfX8G/gO/E93dYi0tGc0jViWd81YYOf7RmxAZUh46n7ipycXn2sQbwQGkjzCda+V6nmRNdSWrQOUrqzCGvD60ARrZhKdA1CaoR5Y0sSVfu7n/yhLQl505174nok18hcxfj9h5xvvCbw9Q7HVgqLbrht9lhOt63vP56gh+W6HLqxe9c0bRAdjRZFe70Mkk5Qi8v6vTAYaQnLWxuPBJF87AG8aEUrAF31tgZ3ahtXKckI4ymAxnWJv2jhUKUDM6DBZGFBzuhjNH5SRUlETo2XJ9lLD9JAXjiDYCEXmchbDB7HGF0e1pj0O3RJhbMpzIJnERUtjFYpslZqC6klGhkLQbz5R8Grry92Onp836huRA4f+2u3MH4qALuXiT0veHt+C5S2WsDoeK0BCXjPDudzT3IIvXjP8neOaeaYKERCv5IQ6R+HYEkttXNes0enwojdggEIjnq30ATgyiT2U4RksWki23emQBbYYoWLASTCokoVYyB4bkt7dshkhH7iaz1Qs8kmNqLY9aDl9fKa0piyguul/tN/ykJIskL1BOEyN8J1kMHSCASiWUgvMjxcBlrAqaMnY8H9j/2TTB16wrK9Y6Gs9Beh7vTMf1RDG x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YVDdyuIBd8i/gwRCL9uglNG1nUvWtzgyhHANy2zq8Qy2R9goFZOrh0T+3m3A?= =?us-ascii?Q?X+k37LUcTS6OvNGbmVlL5L0TSka3SPpptQQqO8ISMzbA6sRNT/gHuDDpgyoy?= =?us-ascii?Q?ZPOmyzjg7Qfg7QRMYD2kVyHIqi4AdoNqRYWjCWjDHL5sVpvtmpu0kpdkB/Eu?= =?us-ascii?Q?S7IxYs+MdRLnhEvc1Pq316J1Yop1WH68S+7kHYCmRwqFNIEvX30e53iq1JwZ?= =?us-ascii?Q?o2dd3M4aBb94yY9VnWyed7C2xCn/7krUP6kTMSABfh27ou84KQxDuftfOefU?= =?us-ascii?Q?aMDoYpb4hi1gW+Ji8TlXoz4o29aqy3cgPyfWKo0hfAKb2WzC5tF9TQXH30v5?= =?us-ascii?Q?dYakBisGVuIDOlOwRR6td9uAjvBh44oEsQ5Q4D1UbCkFPLQEEJ7XerJe0Ryq?= =?us-ascii?Q?CSRnvLhj6jB69/uaMZUC6/Wz5RxdL4LizXWyGSChAQDrqZJsKPFi0e3VWL/P?= =?us-ascii?Q?NcG1YEwmKqYnisCex7V66r/JBiTo4FGqbooGPa43MXIjLvlEN/fQCEdiut84?= =?us-ascii?Q?VWmTCml4jz0cXE8+LhGY3M1QWJNfFE64HxdfC+wsPIUiztODp34a0seZwkAo?= =?us-ascii?Q?W/ZGzhrXzKAI/Er7gAmIV6BmTnygtQ4tTobLifnm2uToLupnvR8tzHmsskP8?= =?us-ascii?Q?sZc8+ZeJE6drrh7dw+Se90VodjZ3josvSJvIi7CpghQH7P91GbEww+RGKicp?= =?us-ascii?Q?pL0H6GBv0N3juY8X6l+idfc0zpiFJeAGyJvQH3Lcy45cnrcswT/09DLHbO8H?= =?us-ascii?Q?BoZcwGikUzCpdoV4U8DuJyUpZmtiSicuw0FNjgOf7NqcgAOdvjAOYz3cyUJC?= =?us-ascii?Q?RSqq4k1sVGdQooLi1+OtC3i1o8MaK50BXOQiTqqUNr3Fk7s984FWh2EyKaeO?= =?us-ascii?Q?zVAhrTCouRtgwkHDtYa+tkWSUG1pAO6JgTN1ao0SaxQajVulL+rbEIXOsUIJ?= =?us-ascii?Q?GQ/3w1Kxzhpr5ZqU5WNctx0d/Csc/phu1LwHExhK2aMsZ25goahFJTNzLd8W?= =?us-ascii?Q?hwEMSIjvqdoa9xLLoI3HHkfQZTv+ssUU5HQ6Qmv0M7GR1rN6dinT5W4eqdMt?= =?us-ascii?Q?WWzrKoYeWJ4nuGVuHCWCkmn/H+IToOQBaCAPVafb0f74AO7j0WCqR48e0Sw4?= =?us-ascii?Q?S2AUkHCyA01e052dZ/0wYIw7LXWTAB0ODs7Ml84BK2HV+Wc/cBP758Hot4mq?= =?us-ascii?Q?jICxuI7JJDbgnzhejkT1tdXgQ7cD1/V01jGZtdjLzzNe87nB8oY0LuGYMMbt?= =?us-ascii?Q?i48FjhwL0BH694D7STvKQLQus+taNp0Zc3pjWZqgy52s0+mmACz3QTQOueXi?= =?us-ascii?Q?zidMIvoY9nlDyQCdpCrY9rg7pB4IThbZQoFz43y2VtY0BeVQRXEBC/v0OQtu?= =?us-ascii?Q?qWQ5sl5wLO7yMMGStxnU9/cckCa5Gzo8/7EXuc+ypNi/jwci1FqADkRPIRTr?= =?us-ascii?Q?IADvwslZlzObwGFjn5kXzlMZsmIuIzYCJ49u2z2rWhca+KA/MeVKfH2cfwcH?= =?us-ascii?Q?LeXfdZ7b58rL6J2n31k2UbxSaMAayfwwhG8XzfOIeNEfR+lTTcIEBme84zfr?= =?us-ascii?Q?A7HrqmJQdZVhOPEtnFk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 689a93dd-eda7-410e-2889-08dbaf4cee25 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Sep 2023 02:48:35.0760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZGT4/JPDJjI05jaHzNtbNKXWmfcNNO0CN1T5u/UVHBgSLvSWCa6LKvedHyL6SLwumUgLIbJehUE/PZdMiHuiNg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5137 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zj3ptHXoMrNwlgWNIgGocHvIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=NFOfWtdS; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Thursday, September 7, 2023 1:41 AM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Kinney, Michael D > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellNetwork2CommandsLib: Check > array index before access >=20 > From: Michael Kubacki >=20 > Moves the range check for the index into the array before attempting any > accesses using the array index. >=20 > Cc: Zhichao Gao > Cc: Michael D Kinney > Signed-off-by: Michael Kubacki > --- > ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > index 7c80bba46581..5cb92c485b47 100644 > --- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > +++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/Ifconfig6.c > @@ -382,7 +382,7 @@ IfConfig6PrintIpAddr ( >=20 > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG6_INFO_COLON), gShellNetwork2HiiHandle); >=20 > - while ((Ip->Addr[Index] =3D=3D 0) && (Ip->Addr[Index + 1] =3D=3D 0= ) && (Index < > PREFIXMAXLEN)) { > + while ((Index < PREFIXMAXLEN) && (Ip->Addr[Index] =3D=3D 0) && > + (Ip->Addr[Index + 1] =3D=3D 0)) { > Index =3D Index + 2; > if (Index > PREFIXMAXLEN - 2) { > break; > -- > 2.42.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108355): https://edk2.groups.io/g/devel/message/108355 Mute This Topic: https://groups.io/mt/101198333/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-