From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D8085AC0C6B for ; Tue, 21 Nov 2023 08:51:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KjqmXzcfNBLtFvzD5beQZAEfpha+8y1KBAGhPRJd7vI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700556667; v=1; b=jxcCpxAAUP7TNauZayxv7Zemr0CCMolquYy5zYCi88zNlnHGeztG0rTRcA2BkXGKVLdtYtye pSrgRcMdhkiEnXKX3ffhiFOMR0NCKV4g7Gn+UDraLTSZa9Im8/TOoSfVr7VlYngXO21cIXP1YrQ 7aSdXIlqsXzU3rrkXEbm/G2M= X-Received: by 127.0.0.2 with SMTP id w1YRYY7687511xdUo2veGvOI; Tue, 21 Nov 2023 00:51:07 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.35118.1700556666224428035 for ; Tue, 21 Nov 2023 00:51:07 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="4989118" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="4989118" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 00:51:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="7835305" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Nov 2023 00:51:06 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 21 Nov 2023 00:51:05 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 21 Nov 2023 00:51:05 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 21 Nov 2023 00:51:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FbAKee31TLgzNlbwFb90XKIQe8cML/hszpCT5esVfME79Mi5Nyy7SidFxDcRlHwX5l56L4qMmdUdKCRZx6uqz9YYpjT3x6/VHpM7at4E56UMd/JhmqxNPajmP9IYriqCIpjq2uFlhq8J4idZPUYR/xeTzDnNeDxi23iYNnuBaXNQFY8iovTW2208kRc6Wvf7v9zyVk0NKF5/5lHO52jm+W5QWRh+GfJatV/r2XNBzUwp/DwiPKRN17TWxAunCvFGft+2920V/QqsZUHi97Yhc/Ya7+GJvDAp1K7h1QE2RKj4MExga+dATdcfeihaEuCPF1VPd6fCtXitx1CObT3xPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B4Fp+Kcz6ljZuCSao1KJP4zDUS/y04DZiaSNs3J67j8=; b=mr5RZMJlVmy5dfjCber8ighe0zhWJCwv6l+vba5kONHY5jxmJypjI6m94+Wb7HpYZriyl7o10XWK768jUEtFh2wkSVZjoA8UNGTVHPnN9mJO577sk2pPvzJmsByVhoEMu9Ik0j62HKhWtK8ib3JQosuad+UbDQC43NeJfY81Dqj2AJwoypUuc8Wc8R8y1QiRZboVmRpQaBokGxH7FIRsMZjwkbQY5uHNDG4c9sVTzt+jtrZy8PNGf05Ac1wwzvIpWJTDlh/JxfRttBk5LiaOPQIxFqqgYd0M2R9Rsj7qqAebWV0Czp7uaMEVclJrUdz3LsdlBmWQ3jQVovsVkXu3zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by SJ2PR11MB8585.namprd11.prod.outlook.com (2603:10b6:a03:56b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Tue, 21 Nov 2023 08:51:02 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::72ff:2c94:80d9:4145]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::72ff:2c94:80d9:4145%5]) with mapi id 15.20.7002.025; Tue, 21 Nov 2023 08:51:02 +0000 From: "Gao, Zhichao" To: Laszlo Ersek , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Thread-Topic: [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Thread-Index: AQHaEwU6VuoJXYbX1UKllVbmcM/+iLCEiRVw Date: Tue, 21 Nov 2023 08:51:02 +0000 Message-ID: References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120628.55913-1-lersek@redhat.com> <20231109120628.55913-3-lersek@redhat.com> In-Reply-To: <20231109120628.55913-3-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|SJ2PR11MB8585:EE_ x-ms-office365-filtering-correlation-id: ddf84bcf-ee0e-4b66-d02f-08dbea6efd9a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 2JNuc7ofjzTncCvt0nQbrMTdRqoNnqvxSV1ttM62EfsIB+2Ro0iCBlSCO+vlkYTmOZA6RQxRlClAlAFGTDTtPCYQXpl+YWn3qh5mmS/q/VsoWqMJRtn0cKaRbDf2uTvPbHdT45X9CpCUKspsGJqq8sh9rJ3iI7HVwhvjFzLhAUkobc7F32qkBZt1crsSert/8Ytpy5V/pWmI63r1m2RGYLFzUHq6l1owhaNtRT+9m8w5RqF3U5ZN5iim744Qm1iXXS7YhldV4JsnF5q4Oc7/Ao0eLpsX8nUhgzqGjX3vRubIVkr5gful3Ea1fYd1+rGAGsu6rHw/Rls+qPrX/keBSC23PS9oOI500WYm+Gw4fk25zOd4J+napO8Jmn5i64gOHhlazmqukfQU+Nz4tdfO1Y90kQo/1nHUwIqnukXQem7fzaWpnvi0AIAOTlrui9Rux/VwrnmPmToLwYPUtFE9+LcTeBxWASnPwS+XartahyAAWRSCSpYVMBM6CCqejxytvuBkWZrSlm/pwQEZeLPe+Nn14Bja/tzMTYBQPP5n1xbe+MpIq2hx2Dzm52E+t1EHkPtzrNDMWQuLPxwRczlJkqpBm+PhMZxwgv8Ris6Jcyn4vSlxv/PHVNdyRK77cnRH x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hE/yuaN3C6xpf6+7LW3xHXgywkHDgNYv44H+C3Ovs3c9JJJQBOWo6sTs/Ira?= =?us-ascii?Q?asVL72v2fQlCCg1fPbAf8QRRxmaIig77s6kpoTbxGteDdiSU0mWAGRK3IdOB?= =?us-ascii?Q?4xxhMnJzarD3nePM6kqzsETWTf6NR/5IeCXpATQt4bo0q0iD+5Oji0hR48eG?= =?us-ascii?Q?JZBwraqraN9hO31KZU24a96Q1W5ptSR/qFb7tYMWrxxQXH5H7r7U0NX+XaRv?= =?us-ascii?Q?Z49JJqG0ovXtkatEEsA9/rlotdg2W9a1K5ts4MDNvLceP1tN8l0snnUYUV0k?= =?us-ascii?Q?qRH6jJxgbzRoclWtj3Kr7H2/iodsk9UAtYAiXUnXU4v8jMxmiCw3vMScZKCd?= =?us-ascii?Q?P4wBoilt7Kodycv439LVj0VF14Fio23e2jLYuIyQn/V1xObM3jAhcuhrY7Td?= =?us-ascii?Q?vXNEmVbAlY6SGQfpFaIFV8RjoFTi1iHXmWpa7wXVGe6ioIGV0cEOyNohSBy2?= =?us-ascii?Q?Qbue3quEa/XEs+vIM4qDHtZGA22qE2lUBcG/wPk00wxXLH9WjAX0ghsRSfME?= =?us-ascii?Q?TyyIJ5UVywtlm2CdkAX4EO/K+CMDovmEIVBb/KvxwqnfieRWUaEJaIa/FXgX?= =?us-ascii?Q?vXouDJxB2M715U4597cwjyzevSe6/ZHDG4BAhxLg48YTsBK5jijhckBPX92j?= =?us-ascii?Q?b64TNF6ww2I4p7vlORIeK4LEkIR8c3gdqJU0MzYvD08fhWAj+uK7oZLMeIPT?= =?us-ascii?Q?t/HnIcLO/56qeejZoH7oDFvLF/499LR/urHxfLjozLgqeAgKdVwagehYDyk3?= =?us-ascii?Q?xb5SsVnaL2fvXvhVXOQlr2Lj4bXhT/qblxPQTw/8NyC0B9jAOpIKxdzTmPY1?= =?us-ascii?Q?hT67MEp2sNckWsHROynRKvt2QGmtGRykUZQdu+OfR9yKVSZwwINLsMoDSTrc?= =?us-ascii?Q?L24mEyncx+7ZrZM3sEzivvh7rbccE3DmzKusXnIoRsLryYYbxe2NjGCckxjb?= =?us-ascii?Q?mOD2GBTEbX3itOOKlLCCRX7piX3HdnSIMDF/nMjM5u+5m0JWyCSyjxNH0MO1?= =?us-ascii?Q?yLevEgWcy21CtppOEtR/6QNU5qmG7AR95POQTTepGTLnjTeB4j0xuAmtnK/R?= =?us-ascii?Q?BrcktiiD7nlAqRHntRVyISqMNVHUqEv2cKl6AqKF0Wb+cxpuiMed4FobBscr?= =?us-ascii?Q?wd6m40Z3rML6X81sUObYH6g/r9aSwdxGhmBupzMWOFn4ZWeutrLWOQQ0mmJg?= =?us-ascii?Q?t/x9Ahk/O0ROBOU3O3+ZymdsjJDQFGYz/pXBDZbpBpfUli1ewtMR4ezJ5uEX?= =?us-ascii?Q?DmdwyodMcWSm5vm6y0OjwYYrjSpUoKccq4AtHB00/8BLW2ABkf7kdzm1NkL7?= =?us-ascii?Q?vcS1bEs3BUkQODktf/9I5spjZIjcwIyGRm6OLHhDxkV0a5kms2ZNuneGOpbT?= =?us-ascii?Q?/knatRTGPNAZLW1r0qMxgZKBvm3ZWbmkK37t/hRx8WF2NrWaX7Uw+XEnUQux?= =?us-ascii?Q?qDaYJRK0tC2n4ZMromVnjBcX859tvtSiSd5gul8RcwTjXvsgjBnZ93TZKWQt?= =?us-ascii?Q?8g+7Mhjfq6hJDU89DLtpdURUCPj9wuL9af0FU8EuXY5ZNGlo76My3m+VkSWP?= =?us-ascii?Q?L97YmIaMFCH692TlxuWoEZro0ZyVcQdcNkWXZzPw?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddf84bcf-ee0e-4b66-d02f-08dbea6efd9a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 08:51:02.4920 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Cpgr9HoTTSzvp0OH6LJEuP8QwH5JGzBUDsNUUrZ4als9jnE+7vz1YLJXy3nkCv+RR9WLtyFIFwFWqBMgTx8OWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8585 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bA8NpYaB0BsTCEDdAmahxFB9x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=jxcCpxAA; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io I would leave the decision to the right owner of LegacyBiosMpTable.h in Mde= Pkg. Once pass review on MdePkg, I am fine with this patch. Thanks, Zhichao > -----Original Message----- > From: Laszlo Ersek > Sent: Thursday, November 9, 2023 8:06 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao > Subject: [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove > gEfiMpsTableGuid ref from DMEM >=20 > We're removing . First, remove the > gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM > debug command. >=20 > Cc: Zhichao Gao > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 > Signed-off-by: Laszlo Ersek > --- >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.uni | 1 - > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.inf | 1 - > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c = | 9 ---- > ----- > 3 files changed, 11 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > index 4041f0cd483e..155efc1a82f1 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > d > +++ sLib.uni > @@ -112,7 +112,6 @@ > "SAL System Table = %016LX\r\n" > "ACPI Table = %016LX\r\n" > "ACPI 2.0 Table = %016LX\r\n" > - "MPS Table = %016LX\r\n" > "SMBIOS Table = %016LX\r\n" > "DTB Table = %016LX\r\n" > "Memory Attribute Tabl= e %016LX\r\n" > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > index 3741dac5d94c..2074cb7d96da 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.inf > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > d > +++ sLib.inf > @@ -127,7 +127,6 @@ [Guids] > gEfiGlobalVariableGuid ## SOMETIMES_CONSUMES ## GUID > gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable > - gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable > gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > index a609971f345e..39a59c195512 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > #include #include > @@ -113,7 +112,6 @@ > ShellCommandRunDmem ( > UINT64 Acpi20TableAddress; > UINT64 SalTableAddress; > UINT64 SmbiosTableAddress; > - UINT64 MpsTableAddress; > UINT64 DtbTableAddress; > UINT64 MemoryAttributesTableAddress; > UINT64 RtPropertiesTableAddress; > @@ -190,7 +188,6 @@ ShellCommandRunDmem ( > AcpiTableAddress =3D 0; > SalTableAddress =3D 0; > SmbiosTableAddress =3D 0; > - MpsTableAddress =3D 0; > DtbTableAddress =3D 0; > MemoryAttributesTableAddress =3D 0; > RtPropertiesTableAddress =3D 0; > @@ -224,11 +221,6 @@ ShellCommandRunDmem ( > continue; > } >=20 > - if (CompareGuid (&gST- > >ConfigurationTable[TableWalker].VendorGuid, &gEfiMpsTableGuid)) { > - MpsTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > - continue; > - } > - > if (CompareGuid (&gST- > >ConfigurationTable[TableWalker].VendorGuid, > &gEfiMemoryAttributesTableGuid)) { > MemoryAttributesTableAddress =3D (UINT64)(UINTN)gST- > >ConfigurationTable[TableWalker].VendorTable; > continue; > @@ -292,7 +284,6 @@ ShellCommandRunDmem ( > SalTableAddress, > AcpiTableAddress, > Acpi20TableAddress, > - MpsTableAddress, > SmbiosTableAddress, > DtbTableAddress, > MemoryAttributesTableAddress, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111541): https://edk2.groups.io/g/devel/message/111541 Mute This Topic: https://groups.io/mt/102483865/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-