public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Simon Wang <simowang@nvidia.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.
Date: Thu, 8 Jun 2023 06:41:34 +0000	[thread overview]
Message-ID: <PH7PR11MB6377D6B19E3540FE24BC8CB3F650A@PH7PR11MB6377.namprd11.prod.outlook.com> (raw)
In-Reply-To: <14502.1686204763208077845@groups.io>

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

It should be same with my PR. But you miss my Reviewed-by.
I just rebase my PR: ShellPkg/SmbiosView: type 45 and type 46 support. by ZhichaoGao · Pull Request #4528 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/4528>
If you want the maintainer to push your patch directly with your PR. You need add the Reviewed-by in you commit message. And the maintainer can easily add the push label for CI to auto merge.

Thanks,
Zhichao

From: simowang via groups.io <simowang=nvidia.com@groups.io>
Sent: Thursday, June 8, 2023 2:13 PM
To: Gao; Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support.

Zhichao,

PR, ShellPkg/SmbiosView: type 45 and type 46 support. by wangsim · Pull Request #4482 · tianocore/edk2 (github.com)<https://github.com/tianocore/edk2/pull/4482>
Just finished CI/CD check.

Thanks,
Simon

[-- Attachment #2: Type: text/html, Size: 3322 bytes --]

      reply	other threads:[~2023-06-08  6:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-04  2:34 [PATCH] ShellPkg/SmbiosView: type 45 and type 46 support simowang
2023-05-09  1:32 ` [edk2-devel] " Simon Wang
2023-05-14 13:40 ` Simon Wang
2023-05-19  2:09 ` Gao, Zhichao
2023-06-01 13:01   ` [edk2-devel] " Simon Wang
2023-06-02  1:22     ` 回复: " gaoliming
2023-06-08  1:22       ` Gao, Zhichao
2023-06-08  6:12         ` Simon Wang
2023-06-08  6:41           ` Gao, Zhichao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH7PR11MB6377D6B19E3540FE24BC8CB3F650A@PH7PR11MB6377.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox