Re: [edk2-devel] [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to Dmem.c

["Gao, Zhichao" <zhichao.gao@intel.com>]

The function looks good to me. But still have some coding style issue: "Always put space before an open parenthesis"
And for patch #2, the comment of GetBaseName is incorrect.
With the coding style issue fix and comments correction, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Sam Kaynor <Sam.Kaynor@arm.com>
> Sent: Thursday, April 4, 2024 5:20 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> Stuart Yoder <stuart.yoder@arm.com>
> Subject: [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to
> Dmem.c
> 
> This adds an additional option to the dmem UEFI shell command for verbose
> dumping of a couple of UEFI tables.
> 
> The tables specified are the RT Properties Table, the Image Execution Table,
> and the Conformance Profiles table.
> 
> Supporting objects are added in the .inf and .uni files relating to Dmem.c and
> an additional header file for the Conformance Profiles table was added.
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
> 
> v3->v4:
> - Resolved crash when RT Properties table isn't present
> - Added output to help command to include -verbose option
> - Changed Image Exe Table output to more closely match spec
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Stuart Yoder <stuart.yoder@arm.com>
> Signed-off-by: Sam Kaynor <Sam.Kaynor@arm.com>
> 
> Sam Kaynor (3):
>   ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c
>   ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c
>   ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c
> 
>  MdePkg/MdePkg.dec                                                          |   5 +
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.inf |   3 +
>  MdePkg/Include/Guid/ConformanceProfiles.h                                  |  56 +++++
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c                         | 266
> ++++++++++++++++++++
> 
> ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands
> Lib.uni |  31 ++-
>  5 files changed, 359 insertions(+), 2 deletions(-)  create mode 100644
> MdePkg/Include/Guid/ConformanceProfiles.h
> 
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117543): https://edk2.groups.io/g/devel/message/117543
Mute This Topic: https://groups.io/mt/105318207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-