From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 67886780425 for ; Tue, 9 Apr 2024 08:01:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZpUtGAHlA+MtvPLwLmPnlkmoPTYJtFUlxODrOk17df0=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712649699; v=1; b=UAQ1RMo3LW6nyf6wGlGpIfjvUPuMktBHUpcMp2YcRFDgdDpkuX4rnfeKFM2h1WwnB/Zrb120 JD5jp6ZbTQVD5HRs0f16SduD85PO6KgRQDfD94rWhug/0hPcfE0ONYczLZmKpTm8BETvrjnegZp M3bO8FJryLLs8asQ1uqNgt+ILHBajSuk7+WgX8vybGtlyjJiIEIGzzQDUUQHMPJ1aQG7z3Au8Iv 8Nmt8/bOvqrwFOPraXgvmG4be5BDKXXOMzhRXTUxHpW0/j6Fh6R1YuWwsVgrvsk/vT104j3gnL6 0g0jwup0u/r4OHX3boQ7RjtIgXVVeVuG6brgeRopJXJwA== X-Received: by 127.0.0.2 with SMTP id r8vkYY7687511xxTdEfSzW24; Tue, 09 Apr 2024 01:01:39 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web10.130809.1712649698495076577 for ; Tue, 09 Apr 2024 01:01:38 -0700 X-CSE-ConnectionGUID: z4tr1R6bSRihL2ZrZOCl6Q== X-CSE-MsgGUID: EGgdtdQFS32rW0VGYsMXaQ== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="7798831" X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="7798831" X-Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 01:00:45 -0700 X-CSE-ConnectionGUID: s4/N7b1CQxuak4/naNqV6g== X-CSE-MsgGUID: RS5Ey561R0iew8qQg+TmXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,189,1708416000"; d="scan'208";a="20598311" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orviesa006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Apr 2024 01:00:44 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Apr 2024 01:00:44 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Apr 2024 01:00:43 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Apr 2024 01:00:43 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Apr 2024 01:00:43 -0700 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com (2603:10b6:510:1fb::13) by SN7PR11MB7637.namprd11.prod.outlook.com (2603:10b6:806:340::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.23; Tue, 9 Apr 2024 08:00:41 +0000 X-Received: from PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::71c8:68c8:8486:492a]) by PH7PR11MB6377.namprd11.prod.outlook.com ([fe80::71c8:68c8:8486:492a%4]) with mapi id 15.20.7452.019; Tue, 9 Apr 2024 08:00:38 +0000 From: "Gao, Zhichao" To: Sam Kaynor , "devel@edk2.groups.io" CC: "Ni, Ray" , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , Stuart Yoder Subject: Re: [edk2-devel] [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to Dmem.c Thread-Topic: [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to Dmem.c Thread-Index: AQHahgy4IpS0Zw9CmkqNBNsu+1u5TrFfmp8A Date: Tue, 9 Apr 2024 08:00:38 +0000 Message-ID: References: <20240403211933.1662236-1-Sam.Kaynor@arm.com> In-Reply-To: <20240403211933.1662236-1-Sam.Kaynor@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6377:EE_|SN7PR11MB7637:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: VhKoMJ74hrsmp1i/MG3vhj8WLyDpP5x8EifMItn6zRWnwsoRIzOLc4gTRNq3dgGl6m6jfeaNYEr2rj83A14N4jyl+ZfnXzZ7UvPCZmGPJd8ydce92a4w17QQBUk0Cve8cn3VbDly+Yfss9SkjK6ITXT24kdQ2rtV2yc7nBuAqtdKhS6JtuA//DMrrhISge5Zcq4Pu0vAfObUrRtpnLcITqL8d5IFTXUrF7rttpzl6Srol/pcj5hGmvNa5B1eB6yTw8cKWqRM7dEw3yV5McqoeF/qsVfvAazIDd6EsdXvxueRpww629NbjEVmsgD4PaOJ6888o6js6+F/+RVXKM7g2ogxHKeoYqXDTmzYoKLp/yaAIlSO6Ld5jZRZTHoCasPZUDbdKl+CQAyp/SXG+qdrihmP/gpdd2ijX2kIiU0ff+DxfHZPRQx+HMhQFqDkmhH88HG0S/t7En8hIzjWZT/MdzlYXV0UsKx2XUWoS4JvCCmMROxHL6YHTCXeCRCkSurzCnz6Z4Aa1gjx30fFiPvI3gRI432JioEf9XI+xIGj8tL/BKyo4bv8gBcvDak5O5pVYVFk9psWHiZeLErTqKeIhmQ2547DZDGBr07xtp36bsU= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9lS70tJWY/QR4BBNuTc2T9lG9x4xDcx63CQlkxFaiDRGLxbfNk2kDo0ec4Fa?= =?us-ascii?Q?XB/g7bG40xRn4s9MRXn1k6wKsIzeMkoOnbdmubrgJX8GaoaqUHJo8Bh1l+As?= =?us-ascii?Q?hAWhzR81y12mNTJEyc155k0f2k/NsOGgk2TUFBkUxImiZ5tP2nXH16WBrnI6?= =?us-ascii?Q?GpFtBJJec5B2lIqATaCF1RbpRNhuOC9SyFHPJ6MMYrUf3Lv70eH/+UBVDR/O?= =?us-ascii?Q?aOhKN+I/WP3lJ8/UeDVpyCg/ZLgBEvncWK3qEnzQMu6KJtKDTSZ/VKQ0FZUG?= =?us-ascii?Q?1hwhKYC1MVKVDDpqv6LDIlND+GrKeGYBsXYipCsXkK0JIAaql3sNyWSSREEJ?= =?us-ascii?Q?bwoL2oeigPB7ZBW/PBha0LyMWHXdlx86H0AIdbL/mc+mA2iP1/gUdDX+Ocmv?= =?us-ascii?Q?UI8XLlawAnQ73qYCXe113iiuu6G5obDAYfzp9TrZr/NnUZmwQ0MTzS719fkA?= =?us-ascii?Q?eAZKStgp2OE2JkFFAxGzav6t0Ca+Ebv5T+2/Mfr26aSxJ5HPNf8Uomva2rIQ?= =?us-ascii?Q?6ALXM+wS8ll+tNrK5fX0Cu6E4gnmW4wwQBRQKhEIzAyRb86DtyT7FmklvSZm?= =?us-ascii?Q?qiWryRwQ5EDHgKTJ9HsB4v0zcwUacTdhWRRs2llckrBWEYCiPilBBumT9xat?= =?us-ascii?Q?Z8y383mxv4j1mwZMpBQGALEiEhI/KCnjC7BWdAL1JchhnjVH+mzZ+P6sTePs?= =?us-ascii?Q?b8m/3cM66pFdci83eEiHgCX61Jz3FRnIcOXYAhO/8x+2hN8mGeadFARpcJ0e?= =?us-ascii?Q?yUfdF/3f0up3eRWK++731uaCrcK12IYQeVywo+AO2WEw18qvjvzI0eCsB/Tg?= =?us-ascii?Q?Qa0uWMNF6RS/xOJ4r75OSsOtZNLEqQZ+IiDK6IoeQd3ZF2pQevqMpyXn2dq0?= =?us-ascii?Q?XHVzZafBjACQude6gEcLFhuDPYOkWnLt1SZm08SWhb/ZNUcRvkErFRvXCDb+?= =?us-ascii?Q?K3XUGKd3/0XKKRdDRtNvc2Mr8XXKo3qcjI7J+QfxKTrgbPZ75IjfBEyTt4A8?= =?us-ascii?Q?a8aUPJql/T+oozL2R/8AMH+9uUJzsccuVJXw51zoLlxLSbv/LyHJe7yOgXzW?= =?us-ascii?Q?vaAlvry+SeFMjdAN2EwggFIrkc31e0RpU1K7np/7T/2OsEIWO5OPC5aV6+jg?= =?us-ascii?Q?eVcq8+JAp5O0HQaOTJ96+WtYn+qT23CFMRfgbMslg+ccvN8ntqRn7oDKacZj?= =?us-ascii?Q?sqZ5a8+lzoQ89NfX8SaxixyDD1Ae1lZMDQcCvNm31rusgVckoCVbc9GjfzXp?= =?us-ascii?Q?KvV7otwcg2FJX68wZS8PHkpo3klK98yMUYNZc3LoVnd4KOWYtyj0Sx3bydtu?= =?us-ascii?Q?+5jsSar+HPBXlSBSQNmSPwSHxVgZZdckavdKUI4q4oFq8eFxgbTBL/p1Wsrd?= =?us-ascii?Q?jU9rcqUPvR2VmQFW9o87MP2te5qKJbpoft2TdWceLdfKSNmkwkYdJtOkubH5?= =?us-ascii?Q?d+08dX0kETj3Yb16zIDgEzOQFxZBpZIeP1biTez6zwL6E8pwV7lqP8wPwJRb?= =?us-ascii?Q?+abcD6CG4mKBy409OA9mtQ6sX6A0Baj/L9eDhRzLI8vFTXxG8Vvd2XvW5/UM?= =?us-ascii?Q?r8OqP28xHqt7lJPjbN0C2v9ht9hlYckgy6bdyvBm?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6377.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b806c723-7860-4693-aa99-08dc586b2535 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2024 08:00:38.8192 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iYvSuMd2EgfmtI9gV+V7sMu0H4nKzPyA6oIeBfsODVyDtS0KgYXBVju6CRIUJKAgAsO/SS7mfNAi5wRTvLLfvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7637 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 09 Apr 2024 01:01:38 -0700 Resent-From: zhichao.gao@intel.com Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: m6y0nNFHryREe7WZ3IFe63Ssx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=UAQ1RMo3; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io The function looks good to me. But still have some coding style issue: "Alw= ays put space before an open parenthesis" And for patch #2, the comment of GetBaseName is incorrect. With the coding style issue fix and comments correction, Reviewed-by: Zhich= ao Gao Thanks, Zhichao > -----Original Message----- > From: Sam Kaynor > Sent: Thursday, April 4, 2024 5:20 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Kinney, Michael D ; Liming Gao > ; Liu, Zhiguang ; > Stuart Yoder > Subject: [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to > Dmem.c >=20 > This adds an additional option to the dmem UEFI shell command for verbose > dumping of a couple of UEFI tables. >=20 > The tables specified are the RT Properties Table, the Image Execution Tab= le, > and the Conformance Profiles table. >=20 > Supporting objects are added in the .inf and .uni files relating to Dmem.= c and > an additional header file for the Conformance Profiles table was added. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4352 >=20 > v3->v4: > - Resolved crash when RT Properties table isn't present > - Added output to help command to include -verbose option > - Changed Image Exe Table output to more closely match spec >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Stuart Yoder > Signed-off-by: Sam Kaynor >=20 > Sam Kaynor (3): > ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c > ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c > ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c >=20 > MdePkg/MdePkg.dec = | 5 + >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.inf | 3 + > MdePkg/Include/Guid/ConformanceProfiles.h = | 56 +++++ > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c = | 266 > ++++++++++++++++++++ >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.uni | 31 ++- > 5 files changed, 359 insertions(+), 2 deletions(-) create mode 100644 > MdePkg/Include/Guid/ConformanceProfiles.h >=20 > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117543): https://edk2.groups.io/g/devel/message/117543 Mute This Topic: https://groups.io/mt/105318207/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-