From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 18A0D78003C for ; Wed, 7 May 2025 06:37:01 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=8tq1pdnFhJ7c0cVNb7YRtRCGWUJ5UJQxxeOf+cXyc1I=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1746599821; v=1; x=1746859020; b=KScdMKl3MY3jsdBPvdKmXUmQxIUPUf9etKb37bx9ydqupE1H5VQRK6InAFeXZsuM9y2FNseb m5x/GEiGj6YuQYI2eAXWGDP9ZVZL4qnfnkN4laylGOl2gzJlXUZnuMOwu+geSm4xCca+8nkBcGb CjoeUA/iisDZs8k6CLDStweW8w93AyqWulFOOb4B5XNQnWXZOFHJJur9v0tEaxdV9CV+RYQriLp N4hhEyOjuI8souirawxZvinCbzjRBOvypy18xrYT/i36DN+v5zE44In29lfPQU33DC84yW8W3+p lWHe+muSjyj9yGmVG1l+DEZjggxGN+5hF4uF4COSxrOzg== X-Received: by 127.0.0.2 with SMTP id 7U9UYY7687511x182NXXkpX9; Tue, 06 May 2025 23:37:00 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.2181.1746599819802748518 for ; Tue, 06 May 2025 23:36:59 -0700 X-CSE-ConnectionGUID: p9zHZx73QvOXVjBaCPpdwA== X-CSE-MsgGUID: J6NyrdtcTpaAXfk/Kp4gXA== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="48457660" X-IronPort-AV: E=Sophos;i="6.15,268,1739865600"; d="scan'208";a="48457660" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 23:36:31 -0700 X-CSE-ConnectionGUID: dUxYFwtLT/6J2DpHeL3fig== X-CSE-MsgGUID: STcXfqWhT8mmaEeRDMvSWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,268,1739865600"; d="scan'208";a="136259275" X-Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa008.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 23:36:30 -0700 X-Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Tue, 6 May 2025 23:36:29 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Tue, 6 May 2025 23:36:29 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Tue, 6 May 2025 23:36:28 -0700 X-Received: from PH7PR11MB6673.namprd11.prod.outlook.com (2603:10b6:510:1ab::13) by PH8PR11MB8287.namprd11.prod.outlook.com (2603:10b6:510:1c7::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8699.23; Wed, 7 May 2025 06:35:47 +0000 X-Received: from PH7PR11MB6673.namprd11.prod.outlook.com ([fe80::f2a9:16d3:4b0f:c961]) by PH7PR11MB6673.namprd11.prod.outlook.com ([fe80::f2a9:16d3:4b0f:c961%6]) with mapi id 15.20.8699.026; Wed, 7 May 2025 06:35:47 +0000 From: "Zhou Jianfeng via groups.io" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Ni, Ray" , Gerd Hoffmann , "Liu, Zhiguang" , "Tan, Dun" , "Kumar, Rahul R" , "Zeng, Star" , Liming Gao Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix SMRAM memory leak during S3 resume Thread-Topic: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix SMRAM memory leak during S3 resume Thread-Index: AQHbvoWnh/RfdbQanUu6aM5VDECDWrPGtoyAgAAAMYA= Date: Wed, 7 May 2025 06:35:47 +0000 Message-ID: References: <20250506125059.3343414-1-jianfeng.zhou@intel.com> In-Reply-To: Accept-Language: en-US, zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6673:EE_|PH8PR11MB8287:EE_ x-ms-office365-filtering-correlation-id: e0d9ecf6-d4dd-4dab-527d-08dd8d3166b8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?IABXGG89HlfcYM09lgt3WoL537zPFfQzMXmasvDnGqUbJbAnqUgt1f4l9q10?= =?us-ascii?Q?ScqslYMf1PI/Rx5DRcM/CrBoWA6lAUK9x1LXiQIrlV5IhodLs+DIcoG+G9M/?= =?us-ascii?Q?Ku9OyfwnJBw/Kmivn4Czhp1oJT+YBfOIm7vEZ/5lhefS9j49UCStuJ3BP2Ue?= =?us-ascii?Q?U5u3uLhne7SfpZEKpsVC03XU6iuNlsGVOOmKoVLD3nOBxdB6It0B5DulORHC?= =?us-ascii?Q?aualq+9s2JxKtqAraEWIwsMjwC38CdOOe2wu7xVhg164VutkB2ftqoPMIe9e?= =?us-ascii?Q?WvO8XkJnf1tlK70Fl9orS+bSg3k1d1qiLp2rpWHgu/pXLJbTZQE1AVJkxpcN?= =?us-ascii?Q?6EivnxfAbgUjwNPUNNyv71QdmszeG0iGrMIap275g8pe7MN9dD1Fn2V2/fFz?= =?us-ascii?Q?pwKv2YJS5oAFIFRtyQkE9ZRfh2ZaqTlb4i3/0bT87ZalGvNhOLICXCcuynm6?= =?us-ascii?Q?jvmvFYhQdeJlfqeBLnNCpN177neVLeesNl6xUGv8rLNJw+JInQAH1UGpkoZf?= =?us-ascii?Q?sFWeSQ7uTr3mLxCfxLBWnBOykL0e6ZEKpp0ojgorSuiGppjO0Nfv2zxB+vaS?= =?us-ascii?Q?ZnyiAL/TGdivckTCzQ0cS8uEDfeBeXP2ka6MG1tHZgezFj02/Fx+MtORvgn4?= =?us-ascii?Q?IpvU81Asv+1lrnUfjWzdnJHSY63bF9Jc3uWE6SAftt0T6+rbjJY1jA44OeXh?= =?us-ascii?Q?ybRKxfB146/0E0vLauUCzxCV2TVHnEByVBgyE+lggkN3wXDNM/uDpiAXv5fZ?= =?us-ascii?Q?KYNbeiVGDBMvIIw/3rN8Kx9j2Jv1jwZ/bQvM4DeM5LkuPKE6ct8vIyD0U8XO?= =?us-ascii?Q?Nyntlc7U7B4C8SnaAPdeIqO+JtdQROcoV8Uh4g6KeqQndAIHvjZD1G4XB+tw?= =?us-ascii?Q?aY84NW08AI1dU/A9nQF7CfdZXiaBO7TihKrHztMglWuCoX+Uz1d8uCc3ZO4I?= =?us-ascii?Q?DNmsZEYN6v+quhSyHxMptak8SpLYiS6z879x+4t8x9XZbewyrsbe9JjSwhS5?= =?us-ascii?Q?jFsJk/J1yLTkPMFfXiaq8XjB9An1n/ZeSm9v9cUfDb8UysthDO3oGgv75555?= =?us-ascii?Q?X+nOm+H8iqpOfw30HBA3yo6Epane8Ktie2w1hDtmCTUJZmYqBTII10Hnwj75?= =?us-ascii?Q?8duhzMj2e9DCqwqZEwcSgKj5YGGCV+HLU1U+NI7nj5d13MVMaFDPPAs4NYSp?= =?us-ascii?Q?ldS6U6BprT+tSr4+PsLJYOdc7xsv22ZTwX7FxSWg9fYfmNxRqxbdkpIuNZIR?= =?us-ascii?Q?XyUKt9MJYDLt1yTts9BTOweyY5DV+TtJ2u7RyI5UJ/MmOv605hXV0r2taMhC?= =?us-ascii?Q?r8nLE+BNt6tRojvdMp7LDS4dmKoFBv8/lKHbJmqukwJjDN34Ak69DIMY6rv+?= =?us-ascii?Q?2p22kVRBriAR9YDkuNU+WXz/odGkEJS3+vRii5w0eJt0AI4gJID4J1PcB2D0?= =?us-ascii?Q?+wcGOCH1LQsofOaliO68bzbYFI2u32l24EFH+i/HFqGGjvxjgkiE7k1oQCUI?= =?us-ascii?Q?KuzUcwQ1WCo2E54=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pzK915jfjOjcI/iJnYWT5dpHOxEMZJ0Zvw36g7MzrZSnAEpPIdoEQGL8UKP7?= =?us-ascii?Q?nbGSmc426/8DnTYH8SX41Rt8bX5JYTXtz1v9AxWOmFR4vXZ9+jy1oOCVhp0c?= =?us-ascii?Q?LL14VgcJ5OBAf9ILK4gmGOI7uFr4XSWkAAx+er4bdOorG740OQZC+ct0rWOp?= =?us-ascii?Q?6eSseNcUv3p1FAqap5mT5P9w1Q8o6vts63a+QXHcQez/HG431IcQ1Y+uRoRn?= =?us-ascii?Q?PkSmmTqR0ljZkiWXyrxuGUAE3H3oLSNA0hn6qXhGWiB0w/fW8Xn6pIuR8XQh?= =?us-ascii?Q?aEjMjDDfAMkEl/LTG4kfjwaNpZbAGQXUdRyPBXhohpeNSXYkfh8rgBVv8zBB?= =?us-ascii?Q?js13wmufuXPD/4+Nej6zE9FpwvxesFSjqD5K2dl9CZFks0wFBPIzde9nBCnX?= =?us-ascii?Q?DO0nFzfqwS7qLtUxT2lCZlgmw6uIkcJLeNV/OQ9hPhUu7+g0uDNnYICVe/3X?= =?us-ascii?Q?2ZWFlRC47KzTyq6QNDo9QQbORkX5vmTNl6RdmRn8zHlf4vtUHyeNOFE4XXXB?= =?us-ascii?Q?ZLXyAhXbDBgHVmP2mNuWArAFEmc6I2TOY5fMeb/1QCC3xOSJuaX1RnszP+Fh?= =?us-ascii?Q?LAAjC5UefRew3ZYbMWqRj7l8IVPaqToI1AbBy2UmHFE28ME4VLbkbIhtWm3K?= =?us-ascii?Q?aq3b/DZfq/1T3CHe1KLjo4mJxDAiOihpC6UIAKH1e0DUjp8aMziUEYSevb8q?= =?us-ascii?Q?JanooSRz2gkwSgTmPlNMrRh/spiA6I7p6Fw6iBOUc0OBEJSf2KiVGLQwSpE4?= =?us-ascii?Q?7KjUnPZkzznNKpHvor7/sWNQp7R+vhMsr7i9AMLxlgcHFGczOatGDQUqYugv?= =?us-ascii?Q?T9QuPqzL3Sf8DzWEwNQbUHg5ImRBx8pUx/5JnzVTUG3WILLAic1JiNTQo0bD?= =?us-ascii?Q?huj/kncu2KGU44lQ7/Z1jD9AVjf3R9CDixkWr/UgxcSzLEivOBw9TegcSzrj?= =?us-ascii?Q?JRQpdo6yyLDb7aBCT8KD6KkB1MPkCnNmEk65ZuoC9nhMcaYdipjjjvbGYqTb?= =?us-ascii?Q?xctmQnjiysHt4Jlf59TG8orBEsXG8BbLyYM7M3pY8IE0dxnrp/JMLM6hGmre?= =?us-ascii?Q?y43AuOTDAEp5CeLGS6XNE7E5G6vz8fkWlH9xKsi5NHjncxdicKdgfKoekXvx?= =?us-ascii?Q?tYHFaR57g2+CnZdUSyrUHxZ0wvuEJxg8BQCR2ntsQoQRZGzZQ4f0ICGi4mU8?= =?us-ascii?Q?+XfOsCZre5f7ezNeKx6Zk6vjZr9yZFUgjgb2sJUKd+Em/M1XM9vc5gosfZmq?= =?us-ascii?Q?D54f34cWECg0sd5gxxIB3N+MUj/iGGseP7I4TiH2cpsQM3O+5XqpGYrZf4v1?= =?us-ascii?Q?lxAAcgkJpZ2cSzh9MdveR7FmDd/slivI/03gUzUYtEmecJe/zLEBCAC25fH+?= =?us-ascii?Q?xgMluyZZ/VLgb46oCBNbHvrS5i/rn38gJGwapHZfjGCHlC3dKehR1GSc9U1U?= =?us-ascii?Q?kx5VJ6BNwcNJd1YXGEoVJtMumEXMuHwugfkdnQ9WQX9luxd7urHruRUDGGe5?= =?us-ascii?Q?J/xh8C26bmClzCyTcBPYvlvrWN6yoFnG1GqLsWDcvNlPATqV2jmv7IPI6RA8?= =?us-ascii?Q?ZW4qhanheiVoMdKpLYnzSYPKVCH+UX7ZXB6dRXYB?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d9ecf6-d4dd-4dab-527d-08dd8d3166b8 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2025 06:35:47.2236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: loXmXPrxFQ5ZEf0l3GqoLLeOsfA88Li4Ys8aNruVB+e1mzVmvupcRZ7aSemrhCVkQNai55jAprWBM1B7qkQ2nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8287 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 06 May 2025 23:36:59 -0700 Resent-From: jianfeng.zhou@intel.com Reply-To: devel@edk2.groups.io,jianfeng.zhou@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UHOH98V6XeGgx1ftMkhkQtjnx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=KScdMKl3; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Sorry for inconvenience. I wrongly sent this patch because of misunderstanding. I submitted https://github.com/tianocore/edk2/pull/11024 and it has been me= rged. Thanks & Regards, Zhou Jianfeng -----Original Message----- From: Wu, Jiaxin =20 Sent: Wednesday, May 7, 2025 2:32 PM To: Zhou, Jianfeng ; devel@edk2.groups.io Cc: Ni, Ray ; Gerd Hoffmann ; Liu, Zhi= guang ; Tan, Dun ; Kumar, Rahul = R ; Zeng, Star ; Liming Gao <= gaoliming@byosoft.com.cn> Subject: RE: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix SMRAM memory leak durin= g S3 resume It looks good to me, Jianfeng, can you send the PR to the edk2 directly? Thanks, Jiaxin > -----Original Message----- > From: Zhou, Jianfeng > Sent: Tuesday, May 6, 2025 8:51 PM > To: devel@edk2.groups.io > Cc: Zhou, Jianfeng ; Ni, Ray=20 > ; Gerd Hoffmann ; Wu, Jiaxin=20 > ; Liu, Zhiguang ; Tan,=20 > Dun ; Kumar, Rahul R ;=20 > Zeng, Star ; Liming Gao=20 > > Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Fix SMRAM memory leak=20 > during S3 resume >=20 > SyncContext of SMM_DISPATCHER_MP_SYNC_DATA was dynamically allocated=20 > from SMRAM. The memory was not freed before reallocation in S3 resume=20 > path. > This could lead to: > 1. Memory leak in SMRAM. > 2. Potential S3 resume failure after repeated S3 tests due to SMRAM=20 > exhaustion. >=20 > This change releases the SyncContext memory before reallocating it >=20 > Cc: Ray Ni > Cc: Gerd Hoffmann > Cc: Jiaxin Wu > Cc: Zhiguang Liu > Cc: Dun Tan > Cc: Rahul Kumar > Cc: Star Zeng > Cc: Liming Gao > Cc: Rahul Kumar > Cc: Zhou Jianfeng >=20 > Signed-off-by: Zhou Jianfeng > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index b19906b610..7bc68087ad 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1868,6 +1868,10 @@ InitializeMpSyncData ( > UINTN CpuIndex; >=20 > if (mSmmMpSyncData !=3D NULL) { > + if (mSmmMpSyncData->SyncContext !=3D NULL) { > + SmmCpuSyncContextDeinit (mSmmMpSyncData->SyncContext); > + } > + > // > // mSmmMpSyncDataSize includes one structure of=20 > SMM_DISPATCHER_MP_SYNC_DATA, one > // CpuData array of SMM_CPU_DATA_BLOCK and one CandidateBsp array=20 > of BOOLEAN. > @@ -1968,6 +1972,7 @@ InitializeMpServiceData ( > mSmmMpSyncData =3D (SMM_DISPATCHER_MP_SYNC_DATA *)AllocatePages=20 > (EFI_SIZE_TO_PAGES (mSmmMpSyncDataSize)); > ASSERT (mSmmMpSyncData !=3D NULL); >=20 > + ZeroMem (mSmmMpSyncData, mSmmMpSyncDataSize); > RelaxedMode =3D FALSE; > GetSmmCpuSyncConfigData (&RelaxedMode, NULL, NULL); > mCpuSmmSyncMode =3D RelaxedMode ? MmCpuSyncModeRelaxedAp : > MmCpuSyncModeTradition; > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121317): https://edk2.groups.io/g/devel/message/121317 Mute This Topic: https://groups.io/mt/112647890/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-