From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F276CD80F71 for ; Tue, 9 Jan 2024 15:04:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0T80DFCjC0npjDg9MHRReqPqg/V6b6TAVozCyI7306o=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704812697; v=1; b=UgUrtJe5bX/Vlxdtqvdre70th017BSovmb1TtzdcpIh5STrfv0yyTReVLCMrLhBr7S64sfPD V/8DcP4FcHb6zpG9spl+f/vIj6j+SSnlVop8m2Lb9sDtYY/p2s20oNNCbjRGNo7t5fdDq3atUrp h8ZOzHzLipXUrn2+o5IkysuE= X-Received: by 127.0.0.2 with SMTP id l7o5YY7687511xTPK5xtmWNa; Tue, 09 Jan 2024 07:04:57 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web10.32517.1704686061026358293 for ; Sun, 07 Jan 2024 19:54:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="19290051" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="19290051" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:54:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="757497690" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="757497690" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 07 Jan 2024 19:54:07 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 7 Jan 2024 19:54:07 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 7 Jan 2024 19:54:07 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 7 Jan 2024 19:54:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c76hue8wdq/Vt2/6xK+afpT5WJa14Ks+fALey+mV4Uk40MSoohSmfjzy8j/vDKmRhZwRlQzpvcZfu9DvklW1qJnGJRXq1QwPACRNVKrD38aEpqmtbZ1hdU1ItqFP2SehspN28BuIh8HpQ6Dq/RXuHT8BpDEILbXWuNVLNxN48ZdkScNZIAXGYm2WpE4xNIfJIL9hZKJZ1s+zF/ZP+M/xn/hkSCHhzl+pQ7cpGTBvPNOgpJ5OUBAQ80m5tyUU0mPcHZcxbBP20z6YKDxs661/8qtt6DPH0yx+rf+EQ90iY7d1tf4IdaA+cQ8AZ2MV6XonVre+L9wNrkzgz44KPTXg/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fPUdfcFAPKwkodVdPSP1Inc/8l5Ln/lg0AstUNEm8ZM=; b=G/QhD3QalyNwewd09BeBFaTIKlDZsi/igztnNQdrBGyX5AW9NnfZKRQEWiHlAea03LTM4993+n0t0GKkT18wFcieJw/2MgK9XFOcINopnwrfTQBXa3Lb7cjzy5roQZQEC3vIpGeG4wxioTc95C/fj5rWljmsxX8It6psoCQKXeX/vs9GJzqGVaIbypVH/NMGx+uaCnv1bhSeeQS63fM02x/C52qwuXTrilwctuaQ/cvloyhLrCzHkWUpF3q56a6GwVGsPBANwDQU64lPMbjmJ73WOd5d+Ln+J+Xr9rg+9zfQaNivENy1Bl7CRrxzfcGqsko9GAlypPCh0nlFhzXtMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB7662.namprd11.prod.outlook.com (2603:10b6:510:27d::19) by BN9PR11MB5499.namprd11.prod.outlook.com (2603:10b6:408:104::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Mon, 8 Jan 2024 03:54:04 +0000 X-Received: from PH7PR11MB7662.namprd11.prod.outlook.com ([fe80::a3a1:5fdf:967c:9cc5]) by PH7PR11MB7662.namprd11.prod.outlook.com ([fe80::a3a1:5fdf:967c:9cc5%3]) with mapi id 15.20.7159.020; Mon, 8 Jan 2024 03:54:03 +0000 From: "Chan, Amy" To: "Chen, Christine" , "S, Ashraf Ali" , "devel@edk2.groups.io" CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Chaganty, Rangasai V" Subject: Re: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Topic: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Thread-Index: AQHaN0b+uLXMffukiEC3JDloIWLscrDPJOiAgAA46CA= Date: Mon, 8 Jan 2024 03:54:03 +0000 Message-ID: References: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB7662:EE_|BN9PR11MB5499:EE_ x-ms-office365-filtering-correlation-id: b05465b9-eb09-4be6-8651-08dc0ffd74ba x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: yCc5L20QBn6lK0kZpAxtoMfSVQpbyP/bQ1vVvac3wgmRxY6qui1WBv7aOLFQ/RESLygW2Czdw4ovt74nLp8ilY0khJ8h+E8a3kCpY2pvDGPhuOcCveE+PFL1VYyQmCT6D7ZBjCGSB2SGrAAMru77jNeJZe/9l+bXcMduEQEV2wyuMqNWqmVgVkSXAlRf9UFI78gqXxKAex1IkybhHU8w03bwycfGN7yiMwr1LXvPJiBOIoRaSj5lDrNyHGSG8/JIVL6a5oyBPAYn6HJuENXXaM/z6uzixnkwoaKWH/oVXlsJTS3xeNP6ZZAT5tXbNOrdsvTX3xrIZ938xKwvtLKZuMRvCjDI1yN+F/6IqMGVBQzBtjKNGnqC2BCxOJ2/oxlFUSniUPnYKLOloRPOqg+EhS0uV/tBR3p4OkqD/Dyn0gRb/f2buLi/g8PkxIztg2Sw7bVqslkdIBcQUnFDKU8p9XDmqg04FE+H2eXWX1W+XyrFAjUU1s5+FLCDrOyU7O80/U+xGqZ4vQDN4EhTm/tkzZ60m0AXKSwKhMKHLIg/qdz3Mu5G5FQp+vu1qfkFEgABxpgDsvExp50S+GZFF8l67OUmJrFlWnvQxABoStJssAJoi1TRblqUUpHJIFq/hOAp x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KqPXeYOBIcPsjx50k0r3Wq3e1KEpSHlM0Q2bs2yKnNLclBPd0TBxZQm2nGm7?= =?us-ascii?Q?1FzEeCivqTyYmeP7aeu1JshxHS2xtQ1ZPi4DkKDkEiMJJP/f5VxW2BB/9bDh?= =?us-ascii?Q?csoi7JgzawRXLGwRwa8DUgxu+GL/IzdNL1+Ze7Gu5q0EIDgMc471XDWNBqlB?= =?us-ascii?Q?1HfHH/JE+OGsEUDEq/QhjaDR6oloGNi04Z0qlMrjpkCpbUE9arXM3aBVcXsz?= =?us-ascii?Q?YTKQtzh3ZCJjQ3wFfW0u49k4Ip80hLJsFBz9ovd/VkYO6Wz53DJ+lL8U30wD?= =?us-ascii?Q?TQa1CYN0ScDHaNv1OTTmY6mTb3GjntMoz/jtT5ttga38kHUBxwjzdtMhqJPs?= =?us-ascii?Q?hbKOHIsoJjZ9Z4m5MHyseSBedbjSw4BeX2mOFYelzSHje4fNzCfi6wfOWonR?= =?us-ascii?Q?ugxH9j9Pmr7rmVa0gj70ui+/hdxGHDS6fo6GTQ76b3CZbFItbzJ28gUs0+GP?= =?us-ascii?Q?UZ63dSfjbaZYzvXDt6gkr09SZw40I8ePm/XofQoFWwkAHgNf5AJz2IeD1PO8?= =?us-ascii?Q?+uESHIjHSH63ZXp7sYUWzZk2muNKG8USOg4mM9scmo2iSzb3T9nVaKP+HTDQ?= =?us-ascii?Q?iN3fxwwauqbJqI/1EXtdZdDN7pa3N/Pm+rSvB6COGCNPlI6IkmpxgMX8ZeRb?= =?us-ascii?Q?VuC1XjA0mgYxAkGNjKoW4d5ZIs3/tpQSp5wLbxz7oqKtbxpTJEoJxG4nxc/6?= =?us-ascii?Q?yQnwRRiUJ+e8EeeHaK4KqR45TNGR3itFmigRbFs0g39Eyth/3s7FY55dl2lQ?= =?us-ascii?Q?Th9h+7XS8XA1/14ZktCcJ0VPID8KAKmLkPhBd0OVTPrT3UUnD5Nzsvtf+25A?= =?us-ascii?Q?x+c1hEwOymRAhIqZO2lPV8ZsXpPObd3kl9CvpLBFgiukgdAFb++KDLzytIub?= =?us-ascii?Q?P0sVycvV13Wn3+QIDOh81NZ5rdNhQfk03dZYNFwcmordKkM8Qkq1SuPkquEB?= =?us-ascii?Q?VCDeSdIm97uVSrOKHemlhWc7m/fVPnpEkKhMAWkC0FfzOskwmme5oreRCrd4?= =?us-ascii?Q?REabo9cs7K3CYWC46cknxd7LSBZto/Wx22pcxFnoFJfrGsg1IfS/EQCSskm1?= =?us-ascii?Q?JCl2wuIQ9HLVKPcWvUxoMXTt+CDSyW9PIZ79oypAn7XC6WxhVSS5a1rRFFx5?= =?us-ascii?Q?BZSSTnOmEpbmBIjUqn1HxegtDuoqTa3x7s4g8Iwi7um9reXdY59wLz6pw/Az?= =?us-ascii?Q?6CB4dncSHgMLTK9EfOtwPH5wqq8iRBAfx98JD0MLM68D4YSlPamF+5yLwfVT?= =?us-ascii?Q?utFcDiEcozddXngZYcNWDGi0JgYALx8uOALuSrEXyJp49XOUoRAuEe0XHBO9?= =?us-ascii?Q?hJOjtP5GeJhnrToWTh3zDZgVoLP0QKJb8O8Sku/YlPdzFmps6qUtnBBHl2VU?= =?us-ascii?Q?iIcUyHsZ037VCM3V7iBUCTl9wKB8/pfMwf4CtoGpJ2HbugzMPVejaU/+j/Iu?= =?us-ascii?Q?hKOglIcuiYzQ+GyxIohh8TX9SuwuuvhjVrT/yFp3TDmXCLmFpgaWIpRgzrE1?= =?us-ascii?Q?W3wGdBK43t3UjW04cQr22cdxUPnKiDHqOVC64ugBCyH3wN1cPn9efdnGWkQI?= =?us-ascii?Q?WjU5o2hANQn0p6cWObL7UZUS2ATkiumm2uRz01Ek?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB7662.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b05465b9-eb09-4be6-8651-08dc0ffd74ba X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2024 03:54:03.9057 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EdB+l+C1IwFIlBfXUQEEnVRSKP1l1Q0jRfD4N1Xt3H2IxAi6tcYxvyD0Mx8dOPLDnuRbyGC5Nwl9l84cuqN3nA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5499 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,amy.chan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: L1Bs7DF6mQxbXenoRzF9NaV2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=UgUrtJe5; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Amy Chan > -----Original Message----- > From: Chen, Christine > Sent: Monday, January 8, 2024 8:29 AM > To: S, Ashraf Ali ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Chan, > Amy ; Chaganty, Rangasai V > > Subject: RE: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuI= d > from allskuset >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: S, Ashraf Ali > > Sent: Monday, December 25, 2023 11:28 PM > > To: devel@edk2.groups.io > > Cc: S, Ashraf Ali ; Chen, Christine > > ; Rebecca Cran ; Gao, > Liming > > ; Feng, Bob C ; Chan, > > Amy ; Chaganty, Rangasai V > > > > Subject: [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId > > from allskuset > > > > Currently when the platform has many SKUs then allskuset will be having= so > > many duplicate. and while parsing the allskuset will take longer time w= hile > > assing Pcd.SkuInfoList. > > This patch is to eliminate those duplicate entires to reduce the build = time > > > > Cc: Yuwei Chen > > Cc: Rebecca Cran > > Cc: Liming Gao > > Cc: Bob Feng > > Cc: Amy Chan > > Cc: Sai Chaganty > > Signed-off-by: Ashraf Ali S > > --- > > BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > index 592d4824a4..dac81454a9 100644 > > --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py > > @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): > > self._DynamicPcdList.extend(list(OtherPcdArray)) > > self._DynamicPcdList.sort() > > allskuset =3D [(SkuName, Sku.SkuId) for pcd in self._DynamicPc= dList for > > (SkuName, Sku) in pcd.SkuInfoList.items()] > > + # Remove duplicate sets in the list > > + allskuset =3D list(set(allskuset)) > > for pcd in self._DynamicPcdList: > > if len(pcd.SkuInfoList) =3D=3D 1: > > for (SkuName, SkuId) in allskuset: > > -- > > 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113451): https://edk2.groups.io/g/devel/message/113451 Mute This Topic: https://groups.io/mt/103360241/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-