From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1F904940F2B for ; Tue, 8 Aug 2023 01:44:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fOOEWfsZ2fknMakAZ5EZ6HfRqIb+SZXtMBJ5JlrkFEE=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691459081; v=1; b=AkyHkJJlvMld/UdkLhtDcj3JQJZFMbhPzb36SWMKNBj0k6bnVxgO7MDM92E4Gk8wMKnjYacM bFVp6PcKdPAoFp2TDHSFyairU+5vsbR084JKt3E4WTfdhkMGXrrWE4jGwt9lhkkmQmeW+vP9Yme Hw/65SprnM0JaOOxloEos6Zg= X-Received: by 127.0.0.2 with SMTP id dlfhYY7687511xPdLFR9Soz4; Mon, 07 Aug 2023 18:44:41 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.52348.1691459080948063506 for ; Mon, 07 Aug 2023 18:44:40 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="350995494" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="350995494" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 18:44:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="760717980" X-IronPort-AV: E=Sophos;i="6.01,263,1684825200"; d="scan'208";a="760717980" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 07 Aug 2023 18:44:37 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 7 Aug 2023 18:44:36 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 7 Aug 2023 18:44:36 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 7 Aug 2023 18:44:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mcF0VrN9i4fcEbZ/eGqFQUe1IoOrlF7ZvJp9I1kRp3EMNdjpXWSilcpx6HUho84NUXZT9QZYjxP+Fa7A0tbtIukUJHsfc29xc9plx+hueiT65OO3giq0rASz+Ur0EmjW/JuUconNCOlemN5uWqz/HhKDTetMMon8C3NoORpPvOYqlR6poRs3sMoUASuSyLvB/ZhFfK2NdR3Np2rrmNBZ5+WJSu7SaP47ZSeujQ74PIlLtImMRNqC7e0NpDAJIlN9jcHh8U8W3xxvOrIbMK3inVvGqwv4y4dAweeMfIGEd9fQukcLKUAV/aKqj/QJ29sze6NznqZJBwMWNNqGJ/Jtpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nsYrfGev4LI7clfAlCJDauApPSGY4NbXQIp1GIEZoZs=; b=lSWVog1iCq9Ss+HlPdbMoc7V4wwng/ZI4XNvefPBtPIqBRq+Mkp3u8a3ZN4GMG4CxfjVlGvlZ5yPOp2p+AHflV6TvL0kSPJ0vNCBy/vnDY1Jf7qW1HS06ILkvcbxttBKOVozG0nhDnEeZ48Ek6yLmakfr8PesTk1sk9NuJgi1/uZOgCglPZZCGa9ZUsD6VChojsBGGGzTwSsH4WyeLZlKo1YvUJEbuzWxLQcQSs7QC5M+y/CInY3FLN60VgGkNsqFATHcOfz31gZh0bBosSz8DEs67B6bBXN8E0eaFvs345+lWLAyOG60RTroMtow2+iv8sbudWchnsXLPKIALZ8XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH7PR11MB7985.namprd11.prod.outlook.com (2603:10b6:510:240::16) by CO1PR11MB4979.namprd11.prod.outlook.com (2603:10b6:303:99::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 01:44:35 +0000 X-Received: from PH7PR11MB7985.namprd11.prod.outlook.com ([fe80::2226:1ebb:6c81:d]) by PH7PR11MB7985.namprd11.prod.outlook.com ([fe80::2226:1ebb:6c81:d%4]) with mapi id 15.20.6652.026; Tue, 8 Aug 2023 01:44:35 +0000 From: "Wang, Yin" To: Sunil V L , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch with EFI variable Thread-Index: AQHZth5YdJmuHIrXdUSUCGeiz1odjK/e4byAgADlHSA= Date: Tue, 8 Aug 2023 01:44:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB7985:EE_|CO1PR11MB4979:EE_ x-ms-office365-filtering-correlation-id: 4350f16e-4eb2-4f0c-273b-08db97b1052f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: O5BTJ0D9dAmRaj9tS9YpBIXTJupYVTyrWNzFtYrw+1S+v+5Mc8icWMBj+0VC5/EC0cKf1vS9U1UhNSPcsKA2svKGyv0OgFYI/eDG/Y+dpGHR1BxgG9ny0XwQVmHfLGDLlKYtEh0BImFSIR6x58pWc+OgfThhqpRT3v/Fcca9gcdUlCd+xQCMrMgR7Q4FZOQm1d1VegxuB4tR5avMc0WqdViBAMs72fgtKCk6o5IuGsbEDSTZ1MGi+1g/MNX58XOP8mW2Ok3+1plVgaCAXkBZotJXmtsDo/XVAtetlfcW9pXopWJ1r+hJAR7MIkq7wnlgq+uOjwr364PBfwgExGJjyqF/WU9xHDbS2baFegJX2EseDxW+bKoIcTxJL/4E+klNzSuYITU0RiwhFcT2+63YRGFzr/vARYwLvPwdJ6n270vHbcQS+F57+WaX1gNKcThSw1IZUca+uwlZdw5GTcn3RdofqoKtZtTQjSk7ntNOA7CaQrEENG8R8Tsl8nLcCiUxBAnsCrp01385j3weetzR3oRtelm0JqjWOIV4eD7P3577iP7XeeQ/iVRXcG4PX+goWWkLgrTshiak8ssmY/mKMD0txPX9yYpwpYvBMoy5ijt4PBMKlPp7r1WWGR6qLq2p2vn9wN0mm2+kKCe9XgXV2JAzwg4USkseLWXkXn4yQ6/nbH6WIOlh456HRxOkoZUJ x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ANC7l60Vu9suYjt+E8M7aMDWIKeK1fRZaKzvyzGgJsEOo7IACf7nSjpSennP?= =?us-ascii?Q?Bu73/SX+cyzYV4cijY1zmiskb3kUncysHEj+EtID6/M7HpXOQPu70LmeuMYv?= =?us-ascii?Q?l1NepR/Ui6wshcXjNkyKV6KHm1SCHcqzpqmYc/zH01LhBMH2TsclsNKoq2Uq?= =?us-ascii?Q?tg78lVcIgmjUZP8a/2/b3PXxJJGBee2uQZ1etRCMuHG10gNCLQ2ypIMvQst9?= =?us-ascii?Q?7Y0D+d0TTMMc5MewZCO2cx3u+qxt7zgz6joQzXrAJjc/98kh/V1shPOGgN+y?= =?us-ascii?Q?aPStqeAPRsLKwiruHdUXuYSalrzPAbj4oKS4Esx40kA9jglf7OZtvAAH4ccE?= =?us-ascii?Q?r8MkHVDjEmHe6JXi9zugHlzRls2dkRTpexD5QLO7PM2MH52wVMsXD9FkJVYk?= =?us-ascii?Q?xM3pzZEKg2zkCuWPaItIK3B+LvQpgvbPBITnYKP26X1mgqAChNj7c6LaP0nd?= =?us-ascii?Q?myCT+zmvXdRJW6qZ5mqQf1Ja+Nbit/7PKA2rX664MORd2AtB0g3aHyOpFpxL?= =?us-ascii?Q?AzR+liFJhtzVU57255qqgexElTVjkgWN6CCN258kRJBAN+zhUYA5YC1kl5ck?= =?us-ascii?Q?fGgqZBCs96xbvDs/Sz5WPB1U3lInyNrZM6esHHItp0Ib7EY3kA4mkr5t9UR/?= =?us-ascii?Q?K0Q4/7ap631gP5UeQmMS2KSUkdwATJ8jZ53SXH89semuJbnKAoU75M8oiB1Z?= =?us-ascii?Q?d2KE2rsM+T9tRsTCCS9Ohcsj6Mx5qd5aeVnp3tf1fRS9+Phc/UXtUNbnJNIu?= =?us-ascii?Q?LOcz0bM1DE2wa51hT3PRtwii+AkbhwNIQarzB/pRoPIwV3MAqLy2C8bo/39j?= =?us-ascii?Q?hZiD8ORay5MQoCo/PTgaY/7xsGvxZRZYU91xNOeeTmX2teW5xd2Pm5zTE9Cy?= =?us-ascii?Q?96JFfbzileEeVioD2cU9rKBZANSdUR+hJA/AYDjC1KqrwEa0LjjxrkpOx/WK?= =?us-ascii?Q?N1tmX0ArtGX3xoGyvynoRvXjtJZcVa9rJyco392DV/Q0/XAVMlurEWqTPiLP?= =?us-ascii?Q?qqyS4coyZ5WrxmekUjxgdvLBuE1ADTcJRYsYu6GxSZTTMpdBC8aQ71VZ54H6?= =?us-ascii?Q?d2Ndriex8oYb2nA2qiDintF7E15VUbkYNGBpgP5trV7PtvaudTXAu1lTHR4q?= =?us-ascii?Q?p1x7AAsorBkEQSWusKFToiGVTo/PrnR4OukaX5e8dMI1v8ZuVD8XdrOjM96s?= =?us-ascii?Q?ihRX1LxSQXmrp/Tw2SY67qQtzshb3avXNHAJ3oe6l0ERW2lCozQn6vCwUDMe?= =?us-ascii?Q?qXG6+EDLEU/QCXDV7oCNGvRmaCcuhJO/WhUZD5ugQ6JysqlS85wumo9CIhcV?= =?us-ascii?Q?t9mSAZNhsKyBsE98VnxkZh45V4O57Q1XxJSqKRN+ln2/k0o8LOUoM/zE7m5E?= =?us-ascii?Q?ncVcqd89Sk8EYi4mj26U/fSnnF6UrWZLBM6+zmgxM3TFIcu3A3/Tvf8e8LfR?= =?us-ascii?Q?loG2rYSdbIk4zOoylard4nIunPO2Uccj9xI48CPQyh1/ahMys83rx9CGSMAR?= =?us-ascii?Q?ZIrTFVAbVp4xpExIJAyQjhB7aN1msyEAJu9AHol/AkgZwpcnerkKWacC7il1?= =?us-ascii?Q?3ZZxHJIGh3srASvd0ko=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB7985.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4350f16e-4eb2-4f0c-273b-08db97b1052f X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Aug 2023 01:44:35.4735 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cyGTLAHCbMvFgn7SnoDrZXybO7JgNgYKhHkcq3zaiglWj0ljMU2IwvXhMyxTW8/qckU8kE6WKHcrvM9SfhvJHA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4979 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yin.wang@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ZmBe8ajg1IV4oAp8DnQYNjkvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AkyHkJJl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Sunil, I will be providing a detailed update soon, along with a new version. Thank= you for your careful review and comments. Best regards, Yin -----Original Message----- From: Sunil V L =20 Sent: Monday, August 7, 2023 8:02 PM To: devel@edk2.groups.io; Wang, Yin Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg:Fix Hii form name mismatch wi= th EFI variable Hi Wang, Thanks for the patch! It will be good if you add versions to the patch subject. Even if you go ba= ck to v1, better to send as v3 with the change log. On Fri, Jul 14, 2023 at 04:59:48PM +0800, Wang, Yin wrote: > Onemore need change beside fixs:16acacf24c ("OvmfPkg: fix=20 > PlatformConfig") fixs -> Fixes? Why don't we need "Fixes:" tag to either aefcc91805fd or 16a= cacf24c2c? I think it is better to have commit message with exact error or information= on what is the issue instead of just pointing to another commit. > Find by sct case:ExtractConfigConformance fail. >=20 > Signed-off-by: Yin Wang > --- > OvmfPkg/PlatformDxe/Platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/OvmfPkg/PlatformDxe/Platform.c=20 > b/OvmfPkg/PlatformDxe/Platform.c index cd3bfd554c98..c32439683d83=20 > 100644 > --- a/OvmfPkg/PlatformDxe/Platform.c > +++ b/OvmfPkg/PlatformDxe/Platform.c > @@ -279,7 +279,7 @@ ExtractConfig ( > // > ConfigRequestHdr =3D HiiConstructConfigHdr ( > &gOvmfPlatformConfigGuid, > - mVariableName, > + mHiiFormName, > mImageHandle The code change LGTM. Acked-by: Sunil V L -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107628): https://edk2.groups.io/g/devel/message/107628 Mute This Topic: https://groups.io/mt/100142143/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-