Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

["Attar, AbdulLateef (Abdul Lateef)" <AbdulLateef.Attar@amd.com>]

[AMD Official Use Only - General]

Hi Leif,
How about adding a separate entry?
Currently its generic to adapt the MinPlatformPkg, later will add more specific platforms.

AMD board and platform
F: Platform/AMD/BoardPkg
F: Platform/AMD/PlatformPkg
M: maintainer1
M: maintainer2

AMD Seattle
F: Platform/AMD/OverdriveBoard/
F: Platform/LeMaker/CelloBoard/
F: Platform/SoftIron/
F: Silicon/AMD/Styx/
M: Ard Biesheuvel <ardb+tianocore@kernel.org>
M: Leif Lindholm <quic_llindhol@quicinc.com>

Thanks
AbduL

-----Original Message-----
From: Leif Lindholm <quic_llindhol@quicinc.com>
Sent: 17 March 2023 21:39
To: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>
Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote:
> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
>
> Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
>
> Signed-off-by: Abdul Lateef Attar <abdattar@amd.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt index
> 747191366070..bb8ab643e090 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/
>  M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>  M: Leif Lindholm <quic_llindhol@quicinc.com>
>
> +AMD Platform

Annoyingly, I'm now going to ask the question I have been avoiding up until now. What does "AMD Platform" mean?
I mean, you've placed this straight after the entry for the Seattle platforms.
I think the name, and package names, are too generic.

/
    Leif

> +F: Platform/AMD/BoardPkg
> +F: Platform/AMD/PlatformPkg
> +M: Abner Chang <abner.chang@amd.com>
> +M: Abdul Lateef Attar <abdattar@amd.com>
> +
>  Ampere Computing
>  F: Platform/Ampere
>  F: Silicon/Ampere
> --
> 2.25.1
>