From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.81]) by mx.groups.io with SMTP id smtpd.web11.17641.1683871686285933261 for ; Thu, 11 May 2023 23:08:06 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=oSb8yXib; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.244.81, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVEXhwKhoQbFK/HE9tij0Z02jhs2ebp5qojAbZ3BFiiFbfpkysqDKyrYFLDrlc5/hy8q7DidGs+G63KDipyy+PqVkuRiXHFIr7w7HJ69iYEdf6d2bhZ5X904frkKH9weK4d9FylacLle/IdyJr6o1749cJgvYggcU7bFk5S7znrCFvLUf/jRZWPRiOLwM5tRaVIf2Xkm0iKiIeYebcx7otqr9ccjaFd2oe0tKm1qPou+ElyEbOVN4/Y/3ByFGYbjKDuWnMhJQ5ImROK2+rL8+XinAvBzYkRXSby8YmuBKD33ncgbG0qTAlDHjRHOtXEA3Bfp0ss3hW3BOzQtyq7fNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g98/xSaQpIcCDJAn5qLNDkLIsRHoHOkF5lwQGUhuxbY=; b=KfSoafoC3MYG8n2BFH768E2olqyMGj6PUfCxgbEOZUtpHBbxTuLZFfk6J5bdDwrhZA+3CHRFtcVZK6gfR9f+ziFtBBE2IHzu+mLiEbsD3HeaeWtK2WsCsXgmGGZXbxL4m8SHBnspT8jMd30ootm0ZBPL5qROJ78zT0ppdO/8WFdsU12EpPo1V++dZD9BcrREQPkc6sTeZCqEbBtt+aAMKysCMtXhFvPFDyKM1jCreZJccND1am0BVHZbj7SyaC48EZl2l/MImxKdAZpXiWmmvo1s4lyMvaDXaIsdVU0ZnMev64cUam1EM182t+Azx6qsoN3aJ6n0FQOAzBF6wuPVDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g98/xSaQpIcCDJAn5qLNDkLIsRHoHOkF5lwQGUhuxbY=; b=oSb8yXibHnr4NlZD9a9Aa1whA53tCNENBrgm2wfbxKbNR2+S5JdEEQoAff1HGIpZ8C+O+dYQuQc4nEhQZGnmFZYV3vKgxDkWwyni1us627z2vMiOweqmUb+9Z2NQgDhBwZqmnDEIYVhp4CZnYje23P54lX0cF4s6ZD3rJyta4II= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by DM6PR12MB4974.namprd12.prod.outlook.com (2603:10b6:5:1bb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.22; Fri, 12 May 2023 06:08:03 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::9837:e9ae:f203:bb7f]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::9837:e9ae:f203:bb7f%6]) with mapi id 15.20.6387.020; Fri, 12 May 2023 06:08:03 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Ni, Ray" , "devel@edk2.groups.io" , "Wu, Jiaxin" CC: "Grimes, Paul" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , "Holthaus, CJ" Subject: Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZf9A9mVwJ9eSVXUK3TumT2JO6ta9UnaGwgAFokbCAACnkcA== Date: Fri, 12 May 2023 06:08:02 +0000 Message-ID: References: <175E046BB9198A76.32438@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a79e203c-29cf-412b-9a32-83ad7bb6bc9d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-12T06:06:14Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|DM6PR12MB4974:EE_ x-ms-office365-filtering-correlation-id: 98ca6977-ce52-4509-37ad-08db52af3eb5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wZL8CphdAQmG8J+SI/qc5LLHyCg2tHZL84Q5e2SmzYPrS9Vnh/CGijCxj5D6DTm72hVUMX7ZkwZXGHKxx49z/7F5COsjdS2e6hEiO/BCQXc9uuYvNj91sJw0GHRoqN78uX7DTKqK8FmRb5w/hHqzC7O0Fk8kKo9C7+4CTgxW7wmmJW6zSllge+MioINQ/biQaAQH8l1AE8u30+bfmhvmMzjF3kcU9VbGdPKxEdcmUMzxL70/vFM70Z6nTAFGB4K81ksjzu8f93Q95884JE2ZvWrOvDJDTgPTE6YR6UgXS2Zi34/txDcr0gqZfshS2V41BgwW87ZSzfijYWX7459qZvI6cPnZBHTk40V5GspVNBr7eDahyntrzUEhWWu89jkya7oyT6Q5D9TALhweOXuE5XRZYnm387sPaWc0w8uIJ9bxbkjXdrsVKqivTsRjdmqdH6toTxA9lO+/qcLpiK0LUHzVQgTqQSMALXx59+ZNImR9qXLnfk0bYPipzZi0OMHlepA5bdDrbCZY9EsZg3/NrvT8/lGwKhx+ubW+/XvH6L1z+NoxiA+RznZ078975jsAtg2q332ljT8GJuYSQnpAuvt7I2JFeoKdtBxIPtFLfSr1kjPYwef5fJjI0QrUMMCVi0E6Tksd0kzuofET+RXjz+qjODu106ZxZmQq1i3ZXvk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(478600001)(66899021)(19627235002)(110136005)(54906003)(7416002)(52536014)(5660300002)(8676002)(8936002)(86362001)(33656002)(38070700005)(2906002)(66556008)(66446008)(64756008)(66476007)(4326008)(66946007)(76116006)(316002)(122000001)(55016003)(41300700001)(38100700002)(6506007)(26005)(53546011)(9686003)(186003)(83380400001)(71200400001)(7696005)(966005)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xyjvMOBUR9bH40rWCqK8NU3JbUJKN1ktspdFEynmsfDnsrCYLo3yPxv3YRAD?= =?us-ascii?Q?r3nz1kfTHNjS1FnA1AF3by/UlcuRMbUFStAaNb4oPVc+S9WvHMJBdC3bLVCj?= =?us-ascii?Q?ytcD6hB5wF1Ymn75a6MTd1lssKClDmefs05Gqioefde0ZrU08wfuK3TXTBLC?= =?us-ascii?Q?4OVAKrW7bYMijKuOfGuhAoFdg7DN5XtILM8YioFCcg54m99hz6ZMdVX4Hu7f?= =?us-ascii?Q?xCbCJTgQ2+PSBnMGn5ZpRyEwljgtIQSHAyjy/PQteDf4yCdFYq9IZnbLk2aF?= =?us-ascii?Q?dkZM3UKc2rtrOTeCBCcD8ankiFVycZWDzSdtpW0A9Hd8zdqezH0UsaX6mV2X?= =?us-ascii?Q?B1JqorkSV4DSzK30fT+ys1vxGtL43sU1GpHmhjp7gar8NLVR7J2If1rpe5fX?= =?us-ascii?Q?Ad3vWSCwiGQEoxeqY3EZL6MRGo25ZnkEb8epCu/9ggwICQxB73DM0l+LaNyt?= =?us-ascii?Q?fmGssHMjfgNZyImDJoo1dZN55Y4k9ZS0RYDxx08HU8V4nQ/7b5iHga/p7L4y?= =?us-ascii?Q?55/SbCYNkoRyH9Kkipm6xFhgQCGZtnA3xAmi6dJO/0jeno88o1X0d9+nanRg?= =?us-ascii?Q?b2k6s2jEh8l/egC7A8WYkpms279XMcVMrPIQUMIDE0By27csxAoToHReFB+A?= =?us-ascii?Q?V93YwaZgF/k5AFEJUTWACGpElO7bKt7sbolzKty/zU5upAFOVKgBIyIyz11J?= =?us-ascii?Q?E/d3I3LmFanbN+01ushT+e4o4EDfJvmic27o8R1bem/GZUYMO0KiCQone8wS?= =?us-ascii?Q?vKx/E+LPvRBg3SDCw0j73jYXDOy5ylDmBdIBIKzx22kBGrrRm7FoAlxSUujB?= =?us-ascii?Q?8bX0GSufFtzNInD0vgwh1equvxgBeZUGi0biKBaP8kZxfxUwZZsJFGgpdTvP?= =?us-ascii?Q?Yd69rVdihiJ46oCibojo2CsYXVcRVVDgiGNNJNiwE6qyouROkyhKxg81H+C+?= =?us-ascii?Q?pveIhTWo26ccNoRsbBiTkGPEoJ2B9HZbVWoZEMeV2zZQKrHAhMBFnz3VpQd0?= =?us-ascii?Q?VIK7LudmVuwYWwD5ogMoXWbihTOSYF8WigmNsdq0B5MrzPvQusfoVmymYtlX?= =?us-ascii?Q?x876mpOqydWNarN814Pat+KcRlIbGSjtT4eC5mmckbEvd0xf5GDMgZe2Ezie?= =?us-ascii?Q?PvJwNeoyhltfzU37M8gXs6B2aWzvamF4+1AEdSffGVinlIqec9q1c5pySmrl?= =?us-ascii?Q?41uMDjSQ0eAAwpnruHUYH616I2FuNDAHZFWWs3KX9ChLi29a1TfTi92vao3Q?= =?us-ascii?Q?RFDJIcJa4Olj5NKiVhcrKq4Kiy1BipA3zejfDylYm58a2qa2VsepHYexc2KF?= =?us-ascii?Q?kJvwrXvy91zlifYliYKHz1d0OYWhVoYnLD0aK17BB3hCQQ5Gr0AMFl7BLbaf?= =?us-ascii?Q?xwz3uB4qhWwNpEZV+Y83Be3lGh+WgA5NhzysAQ2wOhsXp9sX8kJRU4aDTa/n?= =?us-ascii?Q?OJMmOc7OwSbundnH4HL+Kd+av7C/u4OuLAb0ig3uwXSqazGSEI2qnijep6rA?= =?us-ascii?Q?i9s6T5dZP+xSbkr+tlTfwX9UAQRE8jtuCxPtaxKvU3gfxMGcrdYlYL2okvca?= =?us-ascii?Q?g/a13NSJyLNoSXwpjl4=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98ca6977-ce52-4509-37ad-08db52af3eb5 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2023 06:08:02.7705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GiFDgz4YhLKT/k8t0sHKijKnyhtTSP/UJl4cDmsuHwYqNHP22lXJzp1++WfHvtXdW59mCGngmiSbSLyVYWArgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4974 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Ray, Looks like some issue with my mailbox, I saw your mail after submit= ting patch V12. I'll rework and send V13 patch series. Thanks AbduL -----Original Message----- From: Ni, Ray Sent: 12 May 2023 09:11 To: devel@edk2.groups.io; Ni, Ray ; Attar, AbdulLateef (A= bdul Lateef) ; Wu, Jiaxin Cc: Grimes, Paul ; Chang, Abner ;= Dong, Eric ; Kumar, Rahul R = ; Gerd Hoffmann ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L ; Holthaus,= CJ Subject: RE: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and MmS= aveStateLib Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Abdul, I checked your V12 patch. It seems none of comments I have for your V11 are= not addressed. (check my inline reply below) Can we get aligned firstly then you send out next version patches? This could also save my time on downloading your changes and reviewing them= one by one. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Thursday, May 11, 2023 2:56 PM > To: Abdul Lateef Attar ; devel@edk2.groups.io; Wu, > Jiaxin > Cc: Paul Grimes ; Abner Chang > ; Dong, Eric ; Kumar, Rahul > R ; Gerd Hoffmann ; > Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; > Holthaus, CJ > Subject: Re: [edk2-devel] [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib > and MmSaveStateLib > > > UefiCpuPkg: Adds MmSaveStateLib library class > You can take "Reviewed-by: Ray Ni " for this patch. > > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > You can take "Reviewed-by: Ray Ni " for this patch. > > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > One comment: can you please change the BASE_NAME in lib INF to > "AmdSmmCpuFeaturesLib"? > The BASE_NAME guides tool to generate the .Lib file in the disk. > Choosing different BASE_NAME for Intel and AMD lib instance can avoid > one LIB file is replaced by the other during pkg build. > > > UefiCpuPkg: Implements MmSaveStateLib for Intel > 1. MmSaveStateLib local functions should not have "EFIAPI". Please > only add "EFIAPI" for lib APIs. 1. not addressed in V12. > 2. MmSaveStateGetRegisterLma() doesn't need to carry "CpuIndex" as > parameter. Can you please remove the parameter? 2. not addressed in V12. > 3. MmSaveStateGetRegisterIndex () returns wrong value for Intel > processors because it uses Offset ( =3D 2) but Intel implementation uses = Offset ( =3D 4). > > (I remember comments #1, #3 were both raised last time when I reviewed > the > patch.) 3. not addressed in V12. > > > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > You can take "Reviewed-by: Ray Ni " for this patch. > > > One more comment: > Can you please avoid FILE_GUID overridden in UefiCpuPkg.dsc for Intel > instance of SmmCpu driver? > AMD instance can override the FILE_GUID for sure. 4. not addressed in V12. > > @Wu, Jiaxin, we will need to change the close-source SmmCpuFeatureLib > accordingly (separating the SaveState access code into a different > lib) when this patch series are merged. > > > -----Original Message----- > > From: Abdul Lateef Attar > > Sent: Saturday, May 6, 2023 12:07 PM > > To: devel@edk2.groups.io > > Cc: Abdul Lateef Attar ; Paul Grimes > > ; Abner Chang ; Dong, Eric > > ; Ni, Ray ; Kumar, Rahul R > > ; Gerd Hoffmann ; > > Kinney, Michael D ; Gao, Liming > > ; Liu, Zhiguang ; > > Ard Biesheuvel ; Yao, Jiewen > ; > > Justen, Jordan L > > Subject: [PATCH v11 0/8] Adds AmdSmmCpuFeaturesLib and > > MmSaveStateLib > > > > PR: https://github.com/tianocore/edk2/pull/4341 > > > > V11: Delta changes > > Drop the OVMF implementation of MmSaveStateLib > > V10: Delta changes: > > Addressed review comments from Abner. > > V9: Delta changes: > > Addressed review comments. > > Rename to MmSaveStateLib. > > Also rename SMM_ defines to MM_. > > Implemented OVMF MmSaveStateLib. > > Removes SmmCpuFeaturesReadSaveStateRegister and > > SmmCpuFeaturesWriteSaveStateRegister > > function interface. > > V8 delta changes: > > Addressed review comments from Abner, > > Fix the whitespace error. > > Seperate the Ovmf changes to another patch > > V7 delta changes: > > Adds SmmSmramSaveStateLib for Intel processor. > > Integrate SmmSmramSaveStateLib library. > > V6 delta changes: > > Addressed review comments for Ray NI. > > removed unnecessary EFIAPI. > > V5 delta changes: > > rebase to master branch. > > updated Reviewed-by > > V4 delta changes: > > rebase to master branch. > > added reviewed-by. > > V3 delta changes: > > Addressed review comments from Abner chang. > > Re-arranged patch order. > > > > Cc: Paul Grimes > > Cc: Abner Chang > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > Cc: Gerd Hoffmann > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Abdul Lateef Attar > > > > Abdul Lateef Attar (8): > > MdePkg: Adds AMD SMRAM save state map > > UefiCpuPkg: Adds MmSaveStateLib library class > > UefiCpuPkg: Implements MmSaveStateLib library instance > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > > UefiCpuPkg: Implements MmSaveStateLib for Intel > > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > > OvmfPkg: Uses MmSaveStateLib library > > > > UefiCpuPkg/UefiCpuPkg.dec | 4 + > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > UefiCpuPkg/UefiCpuPkg.dsc | 14 + > > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 28 + > > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 28 + > > .../AmdSmmCpuFeaturesLib.inf | 38 + > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 70 ++ > > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > > .../Library/MmSaveStateLib/MmSaveState.h | 102 +++ > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------ > > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > > .../Library/MmSaveStateLib/IntelMmSaveState.c | 413 ++++++++++ > > .../MmSaveStateLib/MmSaveStateCommon.c | 138 ++++ > > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > > .../IntelSmmCpuFeaturesLib.c | 70 ++ > > .../SmmCpuFeaturesLibCommon.c | 128 --- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > > MdePkg/MdePkg.ci.yaml | 4 +- > > 24 files changed, 1812 insertions(+), 1508 deletions(-) create > > mode 100644 UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > > create mode 100644 > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > > create mode 100644 MdePkg/Include/Register/Amd/SmramSaveStateMap.h > > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > > create mode 100644 > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c > > > > -- > > 2.25.1 > > > >=20 >