From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.48]) by mx.groups.io with SMTP id smtpd.web11.40567.1679486381663656942 for ; Wed, 22 Mar 2023 04:59:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TB3HyBWI; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.212.48, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GgGlwiBuC2Y6rlTUyvajdG08wnD899kf2vXS6AUuZA/4nXPg2jDPA8uH2BZel5rR+wMfoGZ75clwFi8oWhcLjmCs5YqCP1ejNVKqafVGyFt/N/uZ63BOK45EtC587GffJG6osFnNRJsS/D4xmqQOLKWcy7KL94z+/8VYxVeDOznZbt3VzYZMgXkr0CzzAXXZWcXot2/vN0EyDJdnoKmnmfM738h5v/xuGECtVVID95Dfvl8LkGbgjD91ECEL7txq01HfuV6jb/Z6B/N8Wi4ZmPJNXc+UYLw7fH+zhRaUzcPLRrcBi0yvKXNR4jdxj79UMcnWBUAGu+uykT7tIDhyAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BtrJQyIGmFYCUXw35GMdXmFYmId+l4Y26DMNshnIl2Q=; b=kc1v2ZY4zDFtkGSLRVAJxbvcXR4qlub98MB+JVQIGK+Zu5wWNH6CIoxLk9DwAksWCdwis/C/sISJHiycUQWNz5zwerwo4lVWxzClOx0EKQ4TpgOH1t0PkmpvqXWRrv6kUjRE141smtV3LZTbw6SW2iNsQAwVgVveT2Vy/Wf/I8hKJqTB0skLKYwRzX3pB1SSTnRGNUSbyFCpmD2xAVy7n92dMGeMmuZ4qiWDSq/mnqfxct7hswYyLLoj3kZUF7lIfaPMUSrNq6dKGxzeZ8gq9M1SIMV3uiL5VWDQ6X0f+TsPO0L4o0fD9yU6rfKAVXQ0F3/IMevD4A+/RYtxTPbgJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BtrJQyIGmFYCUXw35GMdXmFYmId+l4Y26DMNshnIl2Q=; b=TB3HyBWIk//n2aFH9GovQgP6x+OBnr1U8861rj30Ot+9N6s18fueolwnXdCN6ylbzbdljmk1xbnnYoT6RgvOmGIaYzOPZYtxCKY2kSfxLbWgazYN/gLJnFKafsSB9zV2GeCXSFYdydI007aOMAKJxRTfDOewuvGpAjNm3KnzQZg= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by CY5PR12MB6131.namprd12.prod.outlook.com (2603:10b6:930:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Wed, 22 Mar 2023 11:59:38 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151%2]) with mapi id 15.20.6156.027; Wed, 22 Mar 2023 11:59:38 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Chang, Abner" , Leif Lindholm CC: "devel@edk2.groups.io" , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Topic: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Index: AQHZWJzKDkfAJvIrQU+EQVqwCIH2Ta7/JFoAgAEfA4CAA2SUgIAAC+7ggABHOoCAAJQv4IACCDcAgAAh5gA= Date: Wed, 22 Mar 2023 11:59:38 +0000 Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=8ea52482-022b-486d-ab0e-e873e8c79176;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-03-22T11:56:51Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|CY5PR12MB6131:EE_ x-ms-office365-filtering-correlation-id: 202ae276-d11e-4e71-75fa-08db2acce97f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pjDykTiAsVKvZFFcifj+NcDnJHCdTsm1kywDNHMu4aJtfHWIRnoQKU8Il/ea9QkoJ8Nu64A/MV8pNkwUCpVD99P0MW/uFBDImpNBloSD5DEQfRlJdkiPifNaw3yZFQ02uWNKDzOzOyqZspSP+5JTyu/u4MBhv9RUB79KHYszXhjI4/vxT8n8uzCEKSTCue1lLsxgqOrIBOt7DkyxsE+saYise1atmRakH9d8jqWsN4DCkAJEHRj795dL8gtODbQo2FtthIfyzcMpbetrcBhwxc2hkvu4N62Qd9806LClWQujiU46GrH5AmGxQi/YFS/vyVbYVEl8wbejSmZQVP4AUvOu/k5H6O57t09K3JsdHipICazPrdOpJSTb9tzjFwPqWa4JuUkRbCyAgZCt1eddB8Lx8fwxr/S9RFij0r0LzzV4v/1Wo/EVa8QO4afBOMumJFxTVXqX/Q8AQI8zur/0dJbSXA780vsybOoBGwJtjTO/edHKCBgvd0ukMd/VzuGzDE8fzSnT60krP6r9Bcw4io52FvqeprdfvTSBHrjfcfV/C4vwmNm74aPupB+HHFOVop/K7J1cnTcwnY3/UpqwEIQqK/nvGadZrOZRuuNqv5+3mwYcxD4MviNqqHXCCOdQ+h6R/+vFI2CHXi48b/GF2ltw+02f70FKURXHtWzee1paXj5KZxJK37Ug0JzK20jZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(451199018)(7696005)(71200400001)(5660300002)(966005)(86362001)(33656002)(6506007)(9686003)(26005)(54906003)(110136005)(478600001)(316002)(19627235002)(186003)(53546011)(66899018)(83380400001)(64756008)(4326008)(66946007)(66476007)(66556008)(41300700001)(76116006)(66446008)(8936002)(52536014)(122000001)(8676002)(2906002)(55016003)(38100700002)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ndf8cxb8/JYiP915Iv+V+haVmiUDJddDQ7Kb77ScWLxPAOhwHjHq7gWs2wcJ?= =?us-ascii?Q?+D4+VzHOrR/NolhNVVHE026YwnNaJ06YO73TUHAXI5JaWzi9VDPxpbXh4i59?= =?us-ascii?Q?AQf+Kp80KRr1F59xdgbDlIL+w9UfSr0MgjgIFFoQaxUyfTKJoTfcsADSxnXE?= =?us-ascii?Q?pKTzrMuSpfN6kCtXzLNrQiVAWV8Z7N5Gd0Ut2h4TJIWl2bLctUeEBSpXSJWt?= =?us-ascii?Q?ic1vCXq+0R0wirXiSoKQBmcKJt0H0RUi4xSRMVJit9ycJALhcsloPSjP4MRx?= =?us-ascii?Q?zjVEgEV4xB5lxqObI7MHShp0SCMTwuE7zUZodOnP5Lc5S0HXknOdiT7fv2pq?= =?us-ascii?Q?BUnbp1MjegD2jZ4hPCWI1Q8khRnk0AtNu7/P3QQZ8/5WFPLmtTtxSOGQ7H20?= =?us-ascii?Q?dzzJY2ljCwnuwmvMruud9vjIuLp0N4kZPAHraEcXgqz+X3bL66s8Lve2jN0U?= =?us-ascii?Q?ir/FMnoYN48Nkdtn65t7umsz8QZ4c94mQu6mQohzzyNcNrBVPY9OhXRysV88?= =?us-ascii?Q?5cPea4jp39fyUx1OLEYY8HY8wPx4RXSibk0UOQq7jEZrBV7BSeUQDfvQlX/M?= =?us-ascii?Q?XRovbm21FulkgXdrpi83QME5SYaYv3GJjwJKqAN4f4qGHkP/PQY63WXV970Z?= =?us-ascii?Q?5NDrI4x+RuQI2ZUA7uImOY/MiyBK18EpH0PF/vGd3PUEEZIGOlBDYyuyRSfH?= =?us-ascii?Q?yvw3+WUggDmhY++Pg8eTJBvZDz96liMhGZ+Jx4hZMiTlTTIhPUaVMY9v1PNb?= =?us-ascii?Q?sF/r8B9NMOhZXfvrzK30gMbRReE2QNDYR2IOzhEMjAzoiXVP+jam/pOQw2sj?= =?us-ascii?Q?jObLUFSHsB+Eqxyh/1OeT2gk0EHvY4p/cyQc4d9emf5FezgCdah565TElQxq?= =?us-ascii?Q?YANJJixZKoZRq9zvVdUmGh7VUH0ECHJNot/QdmrTnrhOn7Jtaixb/vy27NZL?= =?us-ascii?Q?2OQWb9GcLYtSVsdYyl1QMA2f60ifsl+YGAQoM7+lNs0lSJ/ExbC0+HKJ1f27?= =?us-ascii?Q?mJfrrQX5IhdxHsQGiioRE35UEnMAYnGTRrVIFRfDi8zzl+cZlM0yf9ruba5s?= =?us-ascii?Q?JZiB2KXtxwBLO0g//HNsRTHtpceIG97HUxpyA2+3YTq8rWG+0QQJZLLHDugY?= =?us-ascii?Q?tqnvsf3+MOnC5+WzP1ETJQlEZ1+kmanwWiieBPjmJsp7tu2+KRJsbOrov2Jm?= =?us-ascii?Q?RyCIW5PT/8k+T8aBifQaGStfsQX86uHYNUHA0dBY2V1Qbv5jMeL8+/A4Pe75?= =?us-ascii?Q?AAiDXN5jKJePNLPtPgwSNRVJullDCZn9rr0EWpVuP49xGwe8RTAICzGvgvy+?= =?us-ascii?Q?NPBlO1SQgI6NI8sRhA2hAuisVj2AG3qRYEvutmOlZ8mU0r60k81UMYZdsudF?= =?us-ascii?Q?Lw4bAtvTaecVU0SaSnHMOjbVctUb+hlelSAcYfuRBWihEYn36cQAoe5EXA1e?= =?us-ascii?Q?pyVUUwqLDCbziv0hl9ujtpoWGYpJC+sOi5jUlZck33shYwAkfEfDvQYkiDnm?= =?us-ascii?Q?K3IYBfm8RJsnzZtFjMrBSoY1u585apYRHUdgh0VtzhPuVfLLXup2OtEEEjH3?= =?us-ascii?Q?a+f4LmG5kL/kwICqUPCm7WzPnme3D5Yya90QQd77?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 202ae276-d11e-4e71-75fa-08db2acce97f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2023 11:59:38.1884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RQDsaAaVSQzOz8/kYXTax5akoKXs7BcH8606KdcdLvQ+cdqLDzYi+d/A3QHgDZ3kYN5AuT/gvLPY5K+8gliHKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6131 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Hi Abner, That's right, Platform/AMD/MinBoardPkg will contains all modules/li= brary/drivers required for AMD boards which are based on MinPlatformPkg fra= mework. Thanks AbduL -----Original Message----- From: Chang, Abner Sent: 22 March 2023 15:25 To: Attar, AbdulLateef (Abdul Lateef) ; Leif Lin= dholm Cc: devel@edk2.groups.io; Ard Biesheuvel ; Micha= el D Kinney Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/B= oardPkg and AMD/PlatformPkg maintainers [AMD Official Use Only - General] > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) > Sent: Tuesday, March 21, 2023 11:01 AM > To: Leif Lindholm > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > Biesheuvel ; Michael D Kinney > > Subject: RE: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > AMD/BoardPkg and AMD/PlatformPkg maintainers > > [AMD Official Use Only - General] > > Hi Leif, > AMD/BoardPkg will implements modules specific to boards(one or > more motherboards). > It will not contain any module specific to Platform or Silicon, which > are part of MinPlatformPkg. > > How about just Min prefix? > AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in > AMD folder). I am good with this naming. So we will have AMD boards that leverage MinPla= tform under MinBoardPkg. Those boards which are not Minplatform based can j= ust stay under Platforms/AMD (e.g., OverdriveBoard.), is my understanding c= orrect Abdul? Abner > > AMD board package for MinPlatformPkg > F: Platform/AMD/MinBoardPkg > M: Maintainer1 > M: Maintainer2 > > Thanks > AbduL > > -----Original Message----- > From: Leif Lindholm > Sent: 20 March 2023 23:33 > To: Attar, AbdulLateef (Abdul Lateef) > Cc: devel@edk2.groups.io; Chang, Abner ; Ard > Biesheuvel ; Michael D Kinney > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > AMD/BoardPkg and AMD/PlatformPkg maintainers > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > Hi Abdul, > > On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul > Lateef) > wrote: > > AMD/BoardPkg will contains the modules/drivers to support > MinPlatformPkg framework. > > BoardPkg will be generic across all AMD boards which are based on > MinPlatformPkg framework. > > It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg". > > We will gradually add modules and libraries to it. > > So, if the purpose is exclusively to support MinPlatformPkg platforms, > I think that should be part of the name. > Like Platform/AMD/AmdMinPlatformPkg (for example). > > > AMD/PlatformPkg will contain the modules/drivers which are generic > > to > future AMD platform. > > Currently we don't have complete platform, we can drop > > PlatformPkg for now till we have complete(reasonable modules) > > solution. > > It will certainly be easier to reason about what the preferred > naming/layout should be once there is code to look at for examples. > It may be that parts of it would live more naturally under > Silicon/AMD, for example. > > > It's better to not touch existing AMD/OverdriveBoard, restructuring > > requires changes to .dsc and .fdf files, might break backward > > compatibility. > > No problem. Config files occasionally need to be revamped, but that's > simply a mechanical exercise. > > > How about having just BoardPkg like below? > > That, too, is a completely generic name that conveys no information > about > *what* boards one can expect to find in there. > > Regards, > > Leif > > > AMD board package > > F: Platform/AMD/BoardPkg > > M: Maintainer1 > > M: Maintainer2 > > > > Please let me know your thoughts. > > > > Thanks > > AbduL > > > > > > > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: 20 March 2023 18:35 > > To: devel@edk2.groups.io; Chang, Abner > > Cc: Attar, AbdulLateef (Abdul Lateef) ; > > Ard Biesheuvel ; Michael D Kinney > > > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: > > Adds AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > > > > Hi Abner, > > > > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrot= e: > > > I don't see any modules under OverdriveBoard, is this package > > > still > > > > The code is split between Platform/AMD and Silicon/AMD/Styx, the > > latter > also being used by SoftIron/Overdrive1000 and LeMaker Cello (although > that one is pretty much defunct and should probably be dropped). > > > > > in use? Do you still remember where is FDF and DSC come from (as > > > there is AMD copyright 2014-2016) back to the moment when you was > > > introduced this package? > > > > As the git history tells you: > > --- > > commit f4d38e50c0f24eb78eb003a94f583025621c63db > > Author: Leif Lindholm > > Date: Thu Aug 3 12:24:22 2017 +0100 > > > > Platform,Silicon: import AMD Styx SoC support and platforms > > > > Common files for AMD Overdrive, SoftIron Overdrive 1000 > > and LeMaker Cello, as well as actual platform support. > > Imported from commit efd798c1eb of > > https://git.linaro.org/uefi/OpenPlatformPkg.git > > --- > > > > and the initial commit of the platform in that repository is: > > --- > > From: Leo Duran > > Date: Thu, 20 Aug 2015 13:30:24 -0500 > > > > Subject: Platforms/AMD: add support for AMD Overdrive and > > Lemaker Cello > > > > This adds support for the AMD Seattle based Overdrive and Husky > > platforms, > > and the Lemaker Cello which is derived from it. > > > > This code was tested with upstream EDK2 commit 758ea94651. > > > > The binaries in this branch are based on SeattleFDK 1.0.0.2 > > (Linaro SeattleFDK commit 4b419f2ef2) > > --- > > > > Regards, > > > > Leif > > > > > > > > Thanks > > > Abner > > > > > > > -----Original Message----- > > > > From: Leif Lindholm > > > > Sent: Saturday, March 18, 2023 12:09 AM > > > > To: Attar, AbdulLateef (Abdul Lateef) > > > > > > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > > > ; Ard Biesheuvel > > > > ; Chang, Abner > ; > > > > Michael D Kinney > > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > > > > > Caution: This message originated from an External Source. Use > > > > proper caution when opening attachments, clicking links, or respond= ing. > > > > > > > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > > > From: Abdul Lateef Attar > > > > > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > > > > > Signed-off-by: Abdul Lateef Attar > > > > > Cc: Ard Biesheuvel > > > > > Cc: Leif Lindholm > > > > > Cc: Abner Chang > > > > > Cc: Michael D Kinney > > > > > --- > > > > > Maintainers.txt | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > > > 747191366070..bb8ab643e090 100644 > > > > > --- a/Maintainers.txt > > > > > +++ b/Maintainers.txt > > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > > > M: Ard Biesheuvel > > > > > M: Leif Lindholm > > > > > > > > > > +AMD Platform > > > > > > > > Annoyingly, I'm now going to ask the question I have been > > > > avoiding up until now. What does "AMD Platform" mean? > > > > I mean, you've placed this straight after the entry for the > > > > Seattle > platforms. > > > > I think the name, and package names, are too generic. > > > > > > > > / > > > > Leif > > > > > > > > > +F: Platform/AMD/BoardPkg > > > > > +F: Platform/AMD/PlatformPkg > > > > > +M: Abner Chang > > > > > +M: Abdul Lateef Attar > > > > > + > > > > > Ampere Computing > > > > > F: Platform/Ampere > > > > > F: Silicon/Ampere > > > > > -- > > > > > 2.25.1 > > > > > > > > > > > > > >=20 > > > > > >