From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.89]) by mx.groups.io with SMTP id smtpd.web10.14951.1679321354628144372 for ; Mon, 20 Mar 2023 07:09:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=cjV0g+9a; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.237.89, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nVr4cKnjfeLd1POHKq35TC9V1dmUrSg/yz4FAUxNhxmGPBLDAoZ0ebFLZbNPP4kL3DIVDPN2PhWx2JNJjtuZGkBBCWDgnET3vnhkdhQy9hnToNlr6JM+QFiqoUCd+9e15U4XB0rm0GLv0SnAKBSIMPvxrCE3FEaD46e9asIlCpV3EmsMaAupWgVNAKaMnYRn8rrecOYB869BrTAQe7wgx1/VinShlpVpbdcwtp/yhAbkdp8R9V5zEfcuQ3QGDY1gSWmx3J24eLDQZjVD9h6HY00dTt3n48yDSdRZ1kE9H0MFg6Peda8JoR1K2ogdrmKfhlQzFVsUjxKC+MOxpxpXAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/e84qGeNcKmFufcIhshimW8wIeGKjdO8Dg1e5Qp7Yk=; b=nS/2DsQ0S0aKrohNa6OosMnJTXABKhKY7SkjRPTLIO9lPg+1189uqvXQexGGUtbAexcNkrIbkEJUyU4qtnXOgdbPh0zYrl1GY0RkzaYw/LWaZKYYBYMxqZ7Ynm8AgkmrdeIKRhmeUeuGe7RAZMREz1TvBTzqqPz9PlCOF4iPpE7DLgNyoMOUaV9vkp3h4RZpBhKPKmKFaHUpkhbmIjEDFDWhFf2MdiB+SIXiAszvZcKn8fWwVOkWRPD8KXsWcfPMLEKU4HLZ0ffaTFtFRu+sOelOioGSbEp2KRpcSD5kO5XK4xMJjKm7hwY7+Cz4z9Shab4NyH2BdVgndNP1HbERAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/e84qGeNcKmFufcIhshimW8wIeGKjdO8Dg1e5Qp7Yk=; b=cjV0g+9a4B0qTy/jwlyqoZ/ysN0pCgsTmmGtwft87OZyocRWSxrypwg7dNBB/yahAAjj0wki/Ng4PuFpgDKr/4KO9F/Y2h/pIRcA5yJhfIo0szmjUUsAFIuwUJ4sXwdtuuXEYQQNu7dDuv6ZHvUWvkxy6MIWO/X4Y2dwj8mz62I= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by DS7PR12MB5885.namprd12.prod.outlook.com (2603:10b6:8:78::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 14:09:11 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151%2]) with mapi id 15.20.6156.027; Mon, 20 Mar 2023 14:09:11 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: Leif Lindholm , "devel@edk2.groups.io" , "Chang, Abner" CC: Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Topic: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Index: AQHZWJzKDkfAJvIrQU+EQVqwCIH2Ta7/JFoAgAEfA4CAA2SUgIAAC+7g Date: Mon, 20 Mar 2023 14:09:11 +0000 Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ActionId=9ee60cc0-7832-4274-844d-0957c36e2916;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_ContentBits=0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Enabled=true;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Method=Privileged;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_Name=Public-AIP 2.0;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SetDate=2023-03-20T13:48:11Z;MSIP_Label_d4243a53-6221-4f75-8154-e4b33a5707a1_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|DS7PR12MB5885:EE_ x-ms-office365-filtering-correlation-id: 3a327559-8183-4218-050c-08db294cadff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wAJWXfYmnuH2V1XLrRRYghk0/r3SPj4HCNAj/qvvwvrIywjUn8FCKzgbStKYYF9YzWeqOsRVm3AekygRkTfOvvOt4os8COaZZchQ/LwdJq49VDCfaj5LObkAPxq5lJaMtdejVJlJB54bVy+vJJ2TxA0IMH5Y6ld9wYOBPse985k4EIVgYFfGeZxvHrTWHbnPeA8YDaipA3ZxKWNfJtEFWuniKJS/u87Z00Aws2hIhuHWMQEawX6H6Phl6CsL3tR61gMR4SS75xbPxgcpdvs1jxHPUGtU3KQius2QZhxGpoUPV0aZ8V6qW06ApsmnlmvEKQgX+MZAzWOzLOzM/d39SkOV/8p/WM87PLAowrb/SEnuZ5kJFxIFPr4rP7apuIN7nAv1R5UC4Xu5LhbrqNoJCBG0DCo9FiHiNwub6EVwqAIk4IAqTonReARKD6hzbgxemzEANPHiohXoLP2GaW5Zb5tEHlZ3IFMiUGJ0eY726xnR7SqHd2a1ZrsIPvGKE5gnRsnMd7PlP4AGP2cGgHN0Qg3dEQOiAkGwSG7CfULxtKIUfEGhLJZ6F9Q9AIyW3q2Ves8KUtLDvlfZ0mk89/YS/AhCf893upZbZ3qWMbF+HnaRuzOmDscsUj3UrSouIgZWtmgMRvZ3lG3TIO3ZSWTYhB5j/xEhUaDF9mD3SdmMdXH5VMvoTpZsivfw9MDvg0jg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(451199018)(8936002)(5660300002)(41300700001)(52536014)(55016003)(86362001)(33656002)(38070700005)(38100700002)(122000001)(2906002)(4326008)(966005)(83380400001)(53546011)(478600001)(71200400001)(7696005)(186003)(19627235002)(26005)(6506007)(9686003)(66899018)(8676002)(110136005)(6636002)(316002)(54906003)(66446008)(66946007)(66476007)(76116006)(64756008)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hlma8U1f+1nKFNvOiobPlZ5wYAWytO1kDewPwja3oomDlzMUsRGgLqjthvoM?= =?us-ascii?Q?u7bgzTM+NIDLTA1aDZ2CnW1GL85SXYBVBm6kzaAfdDgtwXP5oLVt9gSyPd8I?= =?us-ascii?Q?jFlDF98gkdUwNL8C9F2asxj8qZWJNzPLl1N83L8AiGrGnnp0wSIpYXxTbl5h?= =?us-ascii?Q?aQxrgRZu2Jde4JrzXiKhk2hbRJyRVxa6GaX1Y3DrH2Uk5RIkm1FHM/eEq2Ej?= =?us-ascii?Q?Dg2xLcvd3f7nnGDPx3yD8+qxa4HbKuTBxKxx7yr3kZQW1zOBcbX9Us5JIacZ?= =?us-ascii?Q?ltspRltwf+Ci9eHvc7DD9J4VOWKkpxlRyHoXUbE92wfcEFjX48aSGdevivZq?= =?us-ascii?Q?Ciapo+lDsfzWNHyWHmXBg1xEDo7jJZQrErb4yfPOrZ1t4fNWBr/X26XYUbJ0?= =?us-ascii?Q?4k3tcAXWBqZ3zxactUz6lQkItWZ8WsBtHnTJcNQZPlexNqEb8pKmEpC6V2oW?= =?us-ascii?Q?HDA8509FkiEHD/HasMlX7VOl93Rk7xAVRM/ImNgjbag+sksTjTDVatbWZOBo?= =?us-ascii?Q?Erv5lITRHmZUbPx2gqsGxMQ9uRjHXe6TZFJmKVHjWRTEqUF6U6ubYzk9yUnu?= =?us-ascii?Q?+vqAH4eXaJtyViDz9v7m41uXNIzUuZFjGlvWL3qZ155+wTc3UrijoWGibIoS?= =?us-ascii?Q?89JCcHLB7PebesJKPpSGaIqVq0CARe9PtPD30SIFKC7LUUDoz9vxxvgVky4Q?= =?us-ascii?Q?S/Qt9aCWpNuAkHLKjk/D+bEyaKFEJvhxAMy9WZXevYn3JORzNEkRAhYlP3lx?= =?us-ascii?Q?bC4xlczJ+l9c++XIv2Kp6cGNHbg1apTBpZEgnIU40PWFZgjNjZL69pK+Tx8J?= =?us-ascii?Q?JcdnkbnsjFHuQXFDs3K9oeFVJjlBPbbBIxA1ktvwpvOJT8NxNWg7icYcmXaB?= =?us-ascii?Q?IV+ry0OsufC1hkbdACi5U0UkBM0qT85bv6wkKKDk0E8bGdTi3UMcGkVay5FO?= =?us-ascii?Q?APt3UL5GZeQrWTd0cQVFipw5pVbOp59cj4ejNDq2HSfC4/jyTqHnw+IxWPvC?= =?us-ascii?Q?ONbvrrXct3MrAHx3ctGP2IodD20SHulZmZr9HL9tZ5KIzWIKimpfxygiJ1kl?= =?us-ascii?Q?yNJJDfGZoCFd/RSYZYAj/D+jx9oVPJdGSgpZT2o9kAehLr8llqP8JGpmNQoX?= =?us-ascii?Q?tlOYEvaRw2V1ERuBd7vtQU8D7uzKY+XsNipDNABNsrohaP9fBqdC4zvWz6Au?= =?us-ascii?Q?AkoW57kv963xATcKcEh8yG9tzL9EdilCHU8Cp0Y8tgNs50cOzE8xNN9Cx78O?= =?us-ascii?Q?lRkym3Mx0OtRlHdSmU9fdAAOAgyRh3epBSh1wPnF3x2EnQL6d1YzK07FGg31?= =?us-ascii?Q?Qh1Av5imShfZdTQZYFV6jdFAjv8/1FVGT31Cj1TKSo7lfB8S4tHnVI4wgHbt?= =?us-ascii?Q?qDYZvT+ag/e53BAQNPakLNEfrk+bJHa4d+cNBndj8jYwRGqSsuGDBUIRaXNB?= =?us-ascii?Q?Xe66T9KBedDyp5R+fRMnjf8JXTSr/QnTBsFyNKdDSgU5zSdYWMtZK5RJYEKz?= =?us-ascii?Q?qmnsNR+4XkPv/zLaVOVjSr0tlUAyBxbTOEeKcs93Me854LvTEjwrs24F/fJf?= =?us-ascii?Q?Ck8zhMqhqGFVsxxqHJx9iBI+D+AaHdEYJVANd2r9?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a327559-8183-4218-050c-08db294cadff X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 14:09:11.6013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ol4elIBhY4p/LJiBDCHJWkFRS78rK+nnU/f8CN8lckFXVIcaTvy62fhjDRR6KymP/ZJd18R1xOf+jlX9MO4v4Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5885 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [Public] Hi Leif, AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg fr= amework. BoardPkg will be generic across all AMD boards which are based on MinPla= tformPkg framework. It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg". We will gradually add modules and libraries to it. AMD/PlatformPkg will contain the modules/drivers which are generic to futur= e AMD platform. Currently we don't have complete platform, we can drop PlatformPkg for n= ow till we have complete(reasonable modules) solution. It's better to not touch existing AMD/OverdriveBoard, restructuring require= s changes to .dsc and .fdf files, might break backward compatibility. How about having just BoardPkg like below? AMD board package F: Platform/AMD/BoardPkg M: Maintainer1 M: Maintainer2 Please let me know your thoughts. Thanks AbduL -----Original Message----- From: Leif Lindholm Sent: 20 March 2023 18:35 To: devel@edk2.groups.io; Chang, Abner Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard Bies= heuvel ; Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/B= oardPkg and AMD/PlatformPkg maintainers Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote: > I don't see any modules under OverdriveBoard, is this package still The code is split between Platform/AMD and Silicon/AMD/Styx, the latter als= o being used by SoftIron/Overdrive1000 and LeMaker Cello (although that one= is pretty much defunct and should probably be dropped). > in use? Do you still remember where is FDF and DSC come from (as there > is AMD copyright 2014-2016) back to the moment when you was introduced > this package? As the git history tells you: --- commit f4d38e50c0f24eb78eb003a94f583025621c63db Author: Leif Lindholm Date: Thu Aug 3 12:24:22 2017 +0100 Platform,Silicon: import AMD Styx SoC support and platforms Common files for AMD Overdrive, SoftIron Overdrive 1000 and LeMaker Cello, as well as actual platform support. Imported from commit efd798c1eb of https://git.linaro.org/uefi/OpenPlatformPkg.git --- and the initial commit of the platform in that repository is: --- From: Leo Duran Date: Thu, 20 Aug 2015 13:30:24 -0500 Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker Cello This adds support for the AMD Seattle based Overdrive and Husky platforms, and the Lemaker Cello which is derived from it. This code was tested with upstream EDK2 commit 758ea94651. The binaries in this branch are based on SeattleFDK 1.0.0.2 (Linaro SeattleFDK commit 4b419f2ef2) --- Regards, Leif > > Thanks > Abner > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Saturday, March 18, 2023 12:09 AM > > To: Attar, AbdulLateef (Abdul Lateef) > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > ; Ard Biesheuvel > > ; Chang, Abner ; > > Michael D Kinney > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > From: Abdul Lateef Attar > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > Signed-off-by: Abdul Lateef Attar > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Abner Chang > > > Cc: Michael D Kinney > > > --- > > > Maintainers.txt | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > 747191366070..bb8ab643e090 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > M: Ard Biesheuvel > > > M: Leif Lindholm > > > > > > +AMD Platform > > > > Annoyingly, I'm now going to ask the question I have been avoiding > > up until now. What does "AMD Platform" mean? > > I mean, you've placed this straight after the entry for the Seattle pla= tforms. > > I think the name, and package names, are too generic. > > > > / > > Leif > > > > > +F: Platform/AMD/BoardPkg > > > +F: Platform/AMD/PlatformPkg > > > +M: Abner Chang > > > +M: Abdul Lateef Attar > > > + > > > Ampere Computing > > > F: Platform/Ampere > > > F: Silicon/Ampere > > > -- > > > 2.25.1 > > > > > >=20 > >