From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.78]) by mx.groups.io with SMTP id smtpd.web11.25739.1683615444847655736 for ; Mon, 08 May 2023 23:57:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=kgDtTqgn; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.94.78, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXv+OcGFLRQUZfhu70Fj3OXMi3R8M8CpqIRiR8Kic2b7RyznoESsTyYD+GbYgQrdUdnrf43glYcdSdGQPdcScSodw1j/l8GOnCrcaxMkhu636kv6soGOszGY9zXFxKa6sVzfW7XmmcbPa75OgMIqsaGlMfxwMls71NtUDRICgIMyuWbnFZWMZRYQLCTebAOhr9CuU8SKdc/VeByNUV/kJ82Tk4E2OjBW0pHfUsaFnHWWCI9ufqW2EUw3gioWW/bsEf5DmbQyEZeucl0toHrs/t4r/8BHxgWnfxSRGnjnjp/dXYC7lVYcW+FZkGf7J+Gyq9LYTP0VRIazqkGYJrKXrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uauvXxyzIspE7k6IH1wKIueb2AXGlUd+eW4WEroLYZ8=; b=eb+eELTvnRutQlEVgQdHtjNS7UItjxHD85tMm7dJgh3p8+/NrB7GU/TJEnuE/AghPgV0x3+xIr2hiNMUNOXA6wkTI9fCJ/T9iC4+QE1dzBnLbw0iQRvdbmn8CsGynyoV/44nQLWIa4++bH9ngPSY0mTEnlYdSK5fh9NjnBDUWM97SFEARMueKJZWki46tMDHnxYEkGB2Y1rt8Te19NPckfTBr4RZPa5cBRB1AMpBgmI7mOpxtLJjgJY76QouZTKezjDpIbB+pqgRx/7qDIH6FO4/ckdUdstM2ygMvyxZE8Jobhaor2Xdjy7ZF5+vSLbnh3H0uZMJJ6Ov+Q+qppxb8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uauvXxyzIspE7k6IH1wKIueb2AXGlUd+eW4WEroLYZ8=; b=kgDtTqgn8S4FIQw1WbYt155E/VQYb2nMAsK6SLQfRSMnj2E0WjmhTdSFExEf4LfXVsUp0n+dVuNB0ipkwVRu2gmxedLo/rdFcVx6TRgyjVC3fRoWCu9hvPjoFQFbVNty9/UxUlrv/xg1Iqu8fdhEJl921ZZiWHI69zyoL+AlVEc= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by CH2PR12MB4039.namprd12.prod.outlook.com (2603:10b6:610:a8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.33; Tue, 9 May 2023 06:57:20 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::9837:e9ae:f203:bb7f]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::9837:e9ae:f203:bb7f%7]) with mapi id 15.20.6340.030; Tue, 9 May 2023 06:57:19 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Chang, Abner" , "devel@edk2.groups.io" CC: Isaac Oram , Nickle Wang , Tinh Nguyen Subject: Re: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add IpmiCommandLib to package Thread-Topic: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add IpmiCommandLib to package Thread-Index: AQHZfxH03XP7og2unE+Mt9po9cuJz69RiKTA Date: Tue, 9 May 2023 06:57:19 +0000 Message-ID: References: <20230505052424.729-1-abner.chang@amd.com> <20230505052424.729-2-abner.chang@amd.com> In-Reply-To: <20230505052424.729-2-abner.chang@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=bde99ad1-3d31-4702-9010-294634569c5d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-05-09T06:56:34Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|CH2PR12MB4039:EE_ x-ms-office365-filtering-correlation-id: 2ae8829d-24fd-44a8-48da-08db505aa1f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j/pu4CzZ7GxksvrsqfITy9bfXmWG/ZOB6yeT708pmXnzmBBBvLOR925klg+LNivIsbQGs/koDfdNikGlLSmknDK68bgPyvJhU2s8uabFTLt+BEumsGgDSnaDXn0rFSiVeVnuDoU8gfqsqchYGLLDNcv3IGgXxhNH/KqFOtYorqpSP4s6+DFd7opNjS6b3ycMOn/pAX4GC9gouvzE9ROHplyeEJWWvbIQ6ojYYCSBm3mAlThGUtxtpzpRBp54QNPZkg6qGoa3MXKV9uSpiGlP0qeR485pgnyfKg4HZXmLsie9upPfiownRtNIp/oZA8dPiMc+LM0ahALma1hSmY2DHm93g6Nn9eFmE8IzRSV3s7c15iHNxmQfsDoq/oWkENIZwrvnVBrDvNXuLIzpERkEzfHMH6RmgFJs0VForlRNsZXoYGmd5FgVtdqpMuC/AJvdm60mgil2rTtaXyiGTiyw+gpGC9g34DeIWHfHSpwAmFDyNf0ld2InHjHiOLvm4naq0I+Zy3oJwWjcf0ZaLiLsBCb/taCD0YbdGO8khXDh87tX3Ga3FtbINeQSo5/pF0ss3qGeHImdDQDgjo9cNu7voZCdJlLcfEfkMF1whgy5txfyVsnkiKF1PG+EZecQVoeQ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(376002)(366004)(346002)(136003)(396003)(451199021)(83380400001)(186003)(2906002)(38100700002)(86362001)(33656002)(38070700005)(122000001)(55016003)(5660300002)(52536014)(8936002)(8676002)(478600001)(66556008)(66946007)(66476007)(4326008)(66446008)(64756008)(76116006)(71200400001)(7696005)(41300700001)(316002)(54906003)(9686003)(6506007)(53546011)(26005)(110136005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/Vwm80RzhtL/v4ibCGOlff6X0ksa0jMAvgcFjMPyzBjgR6T3N89MQSai0Njj?= =?us-ascii?Q?6q+z9bQ3IpOTgBVBf+k4ObyX98kRIv+885tfefgezB+Rs+8iGM5C1xt7AZAT?= =?us-ascii?Q?AZoA4sQPQuwxbVQ8gFrAKMlbEp54DaFyv4/dsIfN+cccFoMVWt/uSo7AE2HT?= =?us-ascii?Q?6OByxD8NCZvYtMP/4DvdAPpU+2EkW9fx9TTTKa5T7RG0jFBM+FZt1+bplRBY?= =?us-ascii?Q?Nokv377P56S3zzzmGb+D6uiDw+Awx8wpFWX8Hj+zYWsdltQbTpYj+cxCrYjH?= =?us-ascii?Q?Xcc7gUBrPACoOAzPBRXQFEHDfAqh0NrYuwGGAYDemhdnyKIXKZBpycDHGxRl?= =?us-ascii?Q?byiwZCOg0ujD27BdAKFEw96v1ak9Vp0C4jjbUztRm00frkj5UHboGsYdW9D4?= =?us-ascii?Q?+kZ0DNEKM5R+6lMf++jn2PDg7ktF66gTEF3lsYOxhlx+rSmxx8Ddkt1Ap/1D?= =?us-ascii?Q?TuCaLDLbY+b/LCRj8fCg5wxqBRQta6V6wQa2K2KSsrHYt4arCHihXbu3kqLd?= =?us-ascii?Q?9FYolq3VrngHtVYoOSaswaH8rM2Ur1ZWFDqusfUHvECaxySzcycly9RHCM9V?= =?us-ascii?Q?bZmK/3lpTNndk3vQ1mIhWsMRpFQmXHrdY73tZxaWRrKIgA41EO8Acg55IKzN?= =?us-ascii?Q?Bp00XP4pswInA8Jns19K1YDc/b3m/umaf5e1battAQAkz6VxbQ6wwL2WPQK8?= =?us-ascii?Q?2VOXcQBQDUTF4ekg3346ZW/z3hPgyoNW8gmiJOR4XY9Bjd/KLq2H7gzIlMD0?= =?us-ascii?Q?47L5aDlE1+dpFY7CnEi77NtvWHZcDSEVF4lvlzPUZ2FPFnXdBmu6KwA7WgiN?= =?us-ascii?Q?BvEgQfqb6rxN53JQZ+aIC1H7QtragkLPyOhpqxwaT0YyUHquDkfiIKz75yzD?= =?us-ascii?Q?WGc0tHniSHURS4Mm60sgmBtqNa5D/7luLFuREVlx1GgzAGBJSISohmkXYD3v?= =?us-ascii?Q?2S9dFy3UDLevw1XUBkzntcHByYwj/T3irO6x3f8NbtkAqSR923v3TKdce2hX?= =?us-ascii?Q?eE/o6KBjAVoX5y1HzwglX2MbZBLFssF7Efxcho+9/zTKfeMLWkl5zmhQ59qU?= =?us-ascii?Q?6SWWoyEiO6g8h52uhs4I6WvXYC/2LoALe1sic4yp5kviQlAqvCNlFzwlFjO3?= =?us-ascii?Q?Q0jGF6JAw6q2aR/XEUgrKA6fm3k/RI7Z12a663Nz+7F74jScNjchkYaxDMDP?= =?us-ascii?Q?0o0JeN1aLOi1A5aUkvsGEEHqGkPEM1gylUmZjJUxSkjbErz1xZ61nxc/Lu8H?= =?us-ascii?Q?fYi6YFtyg8bvpMKeWN2GAI8CIExJ2UWfn3yrju7bTGIuC9wV7fdohfu0Ygcm?= =?us-ascii?Q?04goEetuWS1ZqDnS///Hj0ZSS7MgAmXzaz9D+VZMt3QykB9z/7ml2nk2VEgl?= =?us-ascii?Q?K68Ucwqa2lTUqXFtVTYjkxqfZPr9Jn6xQ31albh3SLFwWAKtf2Jb5y7EeE0E?= =?us-ascii?Q?JY456inGDG0XUI2F10DWnIATWIqyGkETJBAdCTL5oXuu6sQM8YRtsVBY/zCc?= =?us-ascii?Q?cDrlgOnanAzwKMv0F0AbTgouCUwnJQd0o1ydw17cLlCMKR1UJJCKaiVf0j4n?= =?us-ascii?Q?KV/IlUIyp0au6Qfgm1c=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ae8829d-24fd-44a8-48da-08db505aa1f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 06:57:19.6769 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5dTUc/N9hLjEpOD7GHiGzS61YYT+Trlo/kuz35gkwcIinIYZo4pAeJnk3uaXe5Rmvy/jS+TaEHQacFDfaBmJ+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4039 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Reviewed-by: Abdul Lateef Attar -----Original Message----- From: Chang, Abner Sent: 05 May 2023 10:54 To: devel@edk2.groups.io Cc: Isaac Oram ; Attar, AbdulLateef (Abdul Lateef) = ; Nickle Wang ; Tinh Nguyen = Subject: [edk2-platforms][PATCH] ManageabilityPkg/IpmiCommandLib: Add IpmiC= ommandLib to package From: Abner Chang BZ #: 4444 Add IpmiCommandLib to ManageabilityPkg package. Signed-off-by: Abner Chang Cc: Isaac Oram Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Tinh Nguyen --- Features/ManageabilityPkg/ManageabilityPkg.dec | 4 ++++ Features/ManageabilityPkg/Include/Manageability.dsc | 1 + Features/ManageabilityPkg/ManageabilityPkg.dsc | 1 + 3 files changed, 6 insertions(+) diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/Mana= geabilityPkg/ManageabilityPkg.dec index 6f58ab4f45..38813c5f48 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dec +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec @@ -18,6 +18,10 @@ Include [LibraryClasses] + ## @libraryclass IPMI command library + # Provide the help functions to send IPMI commands. + IpmiCommandLib|Include/Library/IpmiCommandLib.h + ## @libraryclass Manageability Transport Library # Manageability Transport Library definitions ManageabilityTransportLib|Include/Library/ManageabilityTransportLib.h diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc b/Features= /ManageabilityPkg/Include/Manageability.dsc index 5e7cdb885f..a432b0ff26 100644 --- a/Features/ManageabilityPkg/Include/Manageability.dsc +++ b/Features/ManageabilityPkg/Include/Manageability.dsc @@ -7,6 +7,7 @@ ## [LibraryClasses] ManageabilityTransportHelperLib|ManageabilityPkg/Library/BaseManageabili= tyTransportHelperLib/BaseManageabilityTransportHelper.inf + IpmiCommandLib|ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLib.in= f [LibraryClasses.common.DXE_DRIVER] PldmProtocolLib|ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmPro= tocolLib.inf diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/Mana= geabilityPkg/ManageabilityPkg.dsc index a0712d1c0a..e3baf27f2a 100644 --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc @@ -49,6 +49,7 @@ ManageabilityPkg/Library/ManageabilityTransportKcsLib/Dxe/DxeManageabili= tyTransportKcs.inf ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/DxeManageabil= ityTransportMctp.inf ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolLib.inf + ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLib.inf [LibraryClasses] ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTran= sportNullLib/BaseManageabilityTransportNull.inf -- 2.37.1.windows.1