From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.85]) by mx.groups.io with SMTP id smtpd.web10.10792.1681211573260167759 for ; Tue, 11 Apr 2023 04:12:53 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=YT4af4SP; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.85, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=an21Bzf6H+DUIYNUTTjCFmlZ4QZEjcHimrjYIYe1MHGhppUYaGwi1vqFraRfrloS1ur9kNS8PsSYfhEujgi6YuS3JPmxQ4eVGIixZzCKd1Q4zERrOdNCuRQxvtV+Jc70D0bVF4dwVOAhAiY7NFBQxsT352Fk2YDFSA5IZzgzln7TmXvCLdQUgD9w5eFqd/A4G9nHLLeG0Cf9ANihZClDTWRz5m6P8gRsZg0pGUgcE0hUohlx9Zh8Y0cA4XHMpjCnP7sPJmMuIWAmsorSikB4SmFOyBjlLZKApju5E7WSz63hPDnUvyTBlivapZybaOXVe9HLGZ/t8NhSaBejMzQSpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DMZKdJTgSHiIQzC7N0i5r5otuRaAEzzvAjrw+weCPAs=; b=SNvTtjdBHTBjAIWt67wH9fjvFBNu81X3FT8kp2EVUv0E6Fw/Oh1BTuJ2xzg2bDWWY24ppL/riJ500QzHkjPRiYzE98tWZFk3BObPvikaZa5pPBcCh270yZI7bfHXJn1hQJR3U7puvNyB2R9c2bHhe3+ofW2VMkUO+wR1yGMg5IbYEPYEDAX575T37RGwAfqUbwHxDVjZSX+BTCIFnaYxG5FxHmmZiw5xKo3+f3hzt3I4XOi/bReCWXfyBCzkrn/5b7Dl4yD22UdAFGybEIoNkriJycvV4k3qhsmdAGFYC5MIn7+QuSZt6dUlaXCZLY/rrh/MrcidjEnbFGxSutwjtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DMZKdJTgSHiIQzC7N0i5r5otuRaAEzzvAjrw+weCPAs=; b=YT4af4SPoFyFcuMuJ8rARHd4UUXR73BNfP9mJxgqDHoPeDYgtTrqKqgTYDtNezy+h8bSBV54gIUsgXJ7q5miJ8pLU/nnMUh/LhHzoJ4K//lzwSTwffoVM4nkBx1POXzo0tfduhIfhT0UEnCaXlpCoBL0htYV9/+fglf9KEWTD44= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by CY5PR12MB6597.namprd12.prod.outlook.com (2603:10b6:930:43::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 11:12:51 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151%2]) with mapi id 15.20.6156.027; Tue, 11 Apr 2023 11:12:50 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: Gerd Hoffmann CC: "devel@edk2.groups.io" , "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , Eric Dong , Ray Ni , Rahul Kumar , Ard Biesheuvel , Jiewen Yao , Jordan Justen Subject: Re: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa51EnHlhOEhRRk+9qGtfJZI3Sq8l3L6AgAAX/lA= Date: Tue, 11 Apr 2023 11:12:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=ed52cc87-4f32-486e-ab3a-32156fa2b016;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-11T11:08:44Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|CY5PR12MB6597:EE_ x-ms-office365-filtering-correlation-id: 08ad6901-6df3-481f-83a4-08db3a7db056 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pDR6Vo1McZyM6TA/8qlsLSxEoxIAz1WGGlSBngLjU8havHAJ8v31mfqO1QiEfhIVy9yaO8Dykh8cz9q6+kmvWEGkwxjGhowOB9lW6Q7popytR3IJg6pDeiQ+5MpjpJJ038BnRNuoPNBj139JDdv1iDlnsnISL68LMCtEdg7JCOTCsozdJ2uPuT1KCgq1+TQJw9HT7JpHw+qXP/wtmEqshSoEpUpELpjHr8YHBxbMErFR9EOpYiaaR2PjVOBGn0G4PKK/irn9tpJvks6MwFzk7WP8SOrX7nHUggEwuPo9syNq0yWI9wKUq5YHutSuGB06iMPIUU2/6gwCm0oWsmaLMIsDXI/lS4rxQ5P6HncpT9H+ts8AOTXR0bv90ZTRjfxQyQc5QTGcanI25pNCTYPbPpkRviZTtyz8ZP9QVO9bmppZwNFIdm3qbBvd3Uk3XT6gJoC//elId7hjJqfKiORoTR2Q2GN4U1TEONSmi+/LZye2YuFkLMifw3TF3OTSaYMTggU38rv+/10/NriXQI8KIISFwpIRMPI7vmyz09vv5O8GnwzVTdw7sgLFvWxSzy/PDOFOWf2VE5Nmb64eCTHPT3Frx9mris0DalZrOo9Zqz7auyHitFj59Irfv4t7RxQUzEZIBkML1FgDs5oQm61tng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(451199021)(71200400001)(83380400001)(66556008)(64756008)(6916009)(478600001)(54906003)(66446008)(66476007)(7696005)(4326008)(76116006)(66946007)(41300700001)(316002)(33656002)(86362001)(26005)(6506007)(9686003)(8676002)(52536014)(2906002)(8936002)(5660300002)(55016003)(38070700005)(122000001)(38100700002)(53546011)(186003)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?b5XQPpzYGFVwOdo866ig4RRz4kMJ6pSQQ8UrAMrH2pNlD7LGwV/qxoofpVJb?= =?us-ascii?Q?D1uMPD4CSk24sOqfBm/kuLybJLEYkx9KQvkA6fmM9kDvBWU45glu03tkFAgy?= =?us-ascii?Q?57pRSl7w8tLDyO4Il9TppwRYRYBB88wbKmOu3YvRT1+hjUCxQOOWkGZrkvxB?= =?us-ascii?Q?qqvbRM64xlOLfZkFywzK4Vo9l+xKe4Zm1tlW81+1IPA0SgC8s1oMCo8fyG8E?= =?us-ascii?Q?ckppyKXVvQZeYwlT/xTq/jipnWnqVkNVZF1HmEGk+q2QW9D022pB3rE7QYa+?= =?us-ascii?Q?wmc/cvcsi2wQMj5ZCYB2C7DzgBSRZKRiIPYhwa9/Ac1cZHr/XVn0hlw0BYsz?= =?us-ascii?Q?WaWrLGWxr/UyAxpJ8k6cM8jP4+AjsWSe20OiyDxK5xEHlVTulcN5q4V7eodr?= =?us-ascii?Q?dvGsGqJI0l/HV17Axc7xYXp78mdQq992VcBgAuA11cQeKlz9Oc7fXff0aKzi?= =?us-ascii?Q?r/tjx78W1BHZizqeWLZSRdvvXIUlsUekZcXlFEBeosRDRv4GELngWAYmBDvD?= =?us-ascii?Q?ptZr/tVBC3BR9rOXupktzVEkzjNCJDZzFCw+08+7PqLRBKWVHm+hZFwllCYQ?= =?us-ascii?Q?P389IOKdkN0BBYp9mTO0mZhFFVQmi7ptqhvmlC9OoiGquNQuaGq7/nBE7psh?= =?us-ascii?Q?QKChKxvwEBd9mPVIX/A4KPPH6dSV78ijhRPD7+Iztc4nFYo63xbtlv8NS6uH?= =?us-ascii?Q?0jsAVAW+NhspPCmBxejYisU9rV+y1w+ndR/3F5IXdNCe3fCS9avxfjpM176T?= =?us-ascii?Q?Drs3OAPYy5AgKHil7Igzejl8fI2+V4qk+oQJMq0ucfdK/X31nIFuJxKbAIkn?= =?us-ascii?Q?uel0Phg/8NpSu7QWCkH79/4fZzWFBBffGwoQ3gg0pSo/4y1XXPs+dRFG9Ptn?= =?us-ascii?Q?vcT8NT10uvBl40+69CStooj155JyL1NnNdnTJXwwSXrhr9/t5MlNjZ+Gm/PG?= =?us-ascii?Q?x2Eq2igfTe5zDRNCHaz8GHVQxnT86mFQ7K5t4T4uzjXyHnHP7ujWC0ZhBLQF?= =?us-ascii?Q?1j6a+Df+eP8uYKa09D/C8reB39FuIkENmmCL3fZ6erccXIn11OMaCJKNX4kR?= =?us-ascii?Q?QlW6HcUMtmz39t4RZ/ikmO0oTZHIjWpp6fNK7slM0BRPTrVl/GY7NzUaY4rW?= =?us-ascii?Q?UsHaEvNrwDCmF9Ve8gvYQGPaQRStOTEqwmFiR7B5qv8zdBOJYjnppm9X4gnE?= =?us-ascii?Q?Kvm0dFMR7Sb9uLYb9jg3x7jhBYg7QMPa8WJkltxYYk4Jbw8C7a3v4rhJ6BX6?= =?us-ascii?Q?QOxXb92Dwk1LIw/Zk/9wOu9r4XL1EZjpdTWqolXJgm+Pq0/9DIwVOD+SISRW?= =?us-ascii?Q?Q3EGBKwf2M5JKbH/XFizGLHCeRAa0e0fF7Ibq0Kpt2AWDgNC5EYAjQlfTvtc?= =?us-ascii?Q?7RmfA08CosyrKmuq5rDA1Jk95ssDzgeo3IR0pkAgAEAIFgVPfH2K9g120xbI?= =?us-ascii?Q?sHx/UN85zQSW9igRQRmyGC+15Kdb0oJi8gkL3SmANf4IEII06gXIv+CybAGb?= =?us-ascii?Q?5mVuMtFPMGuefDuZRcx2CxqLItgLcPe+bDMyv5tqs77EmRflfRULt30YDtZC?= =?us-ascii?Q?hoRUXV/5licE9ZD36lA=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08ad6901-6df3-481f-83a4-08db3a7db056 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 11:12:50.6527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TAEIsSLxieLlXcS1f2iEMehIyOCQT5BgflsZn1AzkeW+/XLI/iweBXzTrAV5kUYMvahGmoOlLo9cJvwo2lMfgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6597 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Gerd, I think CI was failing with the message " SmmSmramSaveStateLib libr= ary not found", I didn't preserve the CI log. Thanks Abdul -----Original Message----- From: Gerd Hoffmann Sent: 11 April 2023 15:13 To: Attar, AbdulLateef (Abdul Lateef) Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) ; Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Eric Dong ; Ray Ni ; Rahul Kumar ; Ard Biesheuvel ; Jiewen Yao ; Jordan Justen Subject: Re: [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. > Uses new SmmSmramSaveStateLib library, which fix the CI failure. What is the exact failure you are seeing? > + > + SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/IntelSm > + mSmramSaveStateLib.inf This should be the AMD version. KVM uses the AMD smram state. Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use actually u= se the new SmmSmramSaveStateLib library, and once this has been done it sho= uld be possible to remove OvmfPkg/Include/Register/QemuSmramSaveStateMap.h take care, Gerd