From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.40]) by mx.groups.io with SMTP id smtpd.web10.10867.1681211827820630312 for ; Tue, 11 Apr 2023 04:17:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=hFbKlY9b; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.40, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VwLsk9sf0WEwhb7MEy87jJCCdowZrtpo1PJdpixwfhm+OXpirCwGShs8eXZUqqOL8Du/LWiEuVrMzVTemFZHgBEDvHzRPrw9wxQYVA2gO3OYAX+vtrPHSxyKItzEx0I590/xnopHNpkGTbnpjB5EPcqh3URxSu5HAyZnbRn224ahNBdr6stLJJWpqebDrSmr4/bqFjqb++ldZEKDD9yvZe+J3QRt1klSpBe8LvEPr9LX335XtFzjvxDnMnHrpCd24MTXKBtG+rcj0tm5v9+Dk+FzUmoLat3FCXNMdiYQoVKsPw7becMY7sseWFubfa3l/Is1iVFi3pWsbvxu01lzDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZU5V1Hm6OBGsUgF6gTUqb3EB+NyTvaTeejvracDaoH8=; b=jwoAkwHC1CuEnWZR8AyBVKuNsWa0EnoL8svJWJsiDPf5gXgggSL3en4z5iJ4aLplLZ+CZ9/bb5GjajswdJRiO2qAUCF63HfPINK2Nwa/WPjyc2SHY+NlzQvUbn0MoZbsKlAKm98hR22KFel3ZugF5suSe3iLW9zD9okgh9iMe8CW+ibTNuKITVvNzZRlIV7TwTbEo0/JzVz+CagkiV80XXOxlbednyuKwXNBIUxYrqVgVmsJSWBpR0/iM2VkI7hbDEN/fSgEfEcNPCtUa1rAJVTm3WBxGroUVT3svp9/bNw4zRIsf5xjiZPQVK9jbTHAj2bUlhRove/T+0zJ7+uhMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZU5V1Hm6OBGsUgF6gTUqb3EB+NyTvaTeejvracDaoH8=; b=hFbKlY9bLaWo9wT8P3cgNMcDgC/wLuTHLGOB5j2eyMwUMtzO6om294T2DlnjRUqZTpOcTVopuH/shIBq6GRu0Gkp4tvV6joJM9pYsEc7fRWR4J5KsuLbJp+zbpm+B4n2wJ2gIYsMFrfkp7nIfmlJNzWsnMK3ne8jjUONc9Dfwww= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by SJ2PR12MB8134.namprd12.prod.outlook.com (2603:10b6:a03:4fa::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Tue, 11 Apr 2023 11:17:03 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151%2]) with mapi id 15.20.6156.027; Tue, 11 Apr 2023 11:17:03 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: "Ni, Ray" , "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa51EnHlhOEhRRk+9qGtfJZI3Sq8l3L6AgAAHk4CAABJa8A== Date: Tue, 11 Apr 2023 11:17:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=00e854ad-0b60-4781-864f-9e8023e26e9d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-11T11:15:40Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|SJ2PR12MB8134:EE_ x-ms-office365-filtering-correlation-id: 4295e8da-b70f-425a-f81f-08db3a7e46df x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uOGIgn9b6FG8X2+btBnUrw5LhgnNewag8fHMsVlZkzahSSDwyu8frs5NJntEgW6Rj6WyzX99WgJE8WL5W2EYEWCqaB1pbYlTVnpf8X5Yrqv5w78suOLi3l/s8eywDfjJSNxTa+zdh61gxLYSnEbzssNhXG3YpGixc6JIR65Mv0roQHbJOQeaEyap3SKFtLogtjtadVbgR85fH++EB1tutUuXhVIEgzrJzGiTQLS/+yUhBPelHaGV3pP7GTXiHHkH4/d69xCW8TsghtoUN+0rKcUO4pkdiT9QIy8x7EFuMkVOdlCGHAAh0+delnk8sGhVRjaFWFDb7redMcfjaU/3awnTP+u10gML4XgioX4zRR3WVGtmlN8ZbrAMefTTt047BlIQRYh/XHWQ1oA2eYPun2KI/lnFWFrR62k32+BS8lQhEQfjwVsMgd3UFs8Vkvi9mNULrkm3PHaYhWiC9bFLqPHgYAovyuHEtO60CTWeBmc9WW9/F3YbvMmGM//mjFtT6ysU2EZmuil0abbwt6vQNWxXYL6vKPdj3y0/Oe9DUFTC6+GtXX6lv2qCQ4cHLkMKy5EY1AadNcJ2sWgb7QtZAjO0TpiwLRfrlxOBVHT567Kn3sFAGhNLgpgHS8K51YPT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(451199021)(6506007)(9686003)(53546011)(26005)(122000001)(38070700005)(38100700002)(83380400001)(186003)(33656002)(316002)(41300700001)(8676002)(8936002)(4326008)(52536014)(5660300002)(71200400001)(7696005)(86362001)(55016003)(966005)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(19627235002)(2906002)(478600001)(110136005)(54906003)(66899021)(213903007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?owqp3IwOpOQh1t8s03jDImhP9ZaUyfKePYtqyWFQJHrr/X1zBS6lWl9xhz5H?= =?us-ascii?Q?k7WHiMpd0obyIMkZzlJ/Ena849O8sC8R2tH8g6D5qwh2VOIRXlM3GQ4hrfZI?= =?us-ascii?Q?aUtDO0XMKYcc6ybHuXAWvEFdoedNpKiJaOamce3VMvMvbk+NRNrr5PF65hGS?= =?us-ascii?Q?hUEoRoDfyuPm2Y7XI4iWhsTIfuo/ioq9wnKqA1lbOUkwA+8buSoor18JqX3M?= =?us-ascii?Q?lKqU2KUFy44HdD+vPe31t9oICGYIe+cVaYRuI1YtgK09KSJ1Oq6EJSj08biT?= =?us-ascii?Q?JNxOKnOPK3stNwoCe27Z0nHpK5A1YD3fBQ74HUCV5Nz2rwAvxD5+wIxBXG8I?= =?us-ascii?Q?KgR/IqH0e7Nbp9IHjtNVnhhlBDUhZt1C0VLNqDEEfnL0V5bQAXlzhxwo2Ic4?= =?us-ascii?Q?zF6RipFDvfWvGnOmRy/oG3pZVEmLWVzL4VS+70eE9v2/T9cXyY0EmtYdt41P?= =?us-ascii?Q?AAu6uN8Q/hYS+Ivpl5zY7/51eOsdsKCQtwNgGQ2BPoKOz4kDQ8w0+lufvNOb?= =?us-ascii?Q?T6PbCOK2i9ZdbgbjgVYWGCTvgkseuAKmfbbJLGISyYawolaJVEsVNcvxboJx?= =?us-ascii?Q?aeIDS0bwInmf5Ma4SUvhD/wL/e9ThrYFq3iHbjBcwtbiEkvOIIjzy794KrMn?= =?us-ascii?Q?1Wcg82NcpfVWbcPPl9xQfMg4X9Zr0JA6f4FpVrD7KzpbJad2VROCdWIbA1N1?= =?us-ascii?Q?C8cwiypx59DBR8YGbcBWFvuw4Ea/PU6d2Y6T4DH5GDG6IElZbO6IdhXwlUQh?= =?us-ascii?Q?dBF8r8zrpPnlyMN7CeEGtAX/j2avxvSlKK2JS3gIqAvTmWqgWxzyVutR+x8Z?= =?us-ascii?Q?JaPwk8b7oO9CpcATknFb/PYHN8ph7PRrtwcBogFwBgFUIc5n1nUIFJATwqYm?= =?us-ascii?Q?CSshY+lwu8jOPFHIqkuAuQp7VoQaqCkHWmNMHgsXcJfWqC32EOKQemM3DX6i?= =?us-ascii?Q?mbi3egEDm+6L/BheyQWM5tLX38QejSTzOGCxgwF5YCvgGHQ/0O3UO6Dz5ogo?= =?us-ascii?Q?+YVWYG65T61BZ0mqbGb2YcwBNdAeGNgqabo/4XFbx1fe8OpraAy7fqxyDWNU?= =?us-ascii?Q?KcOa+IYxyZVABsl1GXRg9e7DcEAx08eU2qjRk1J+2hfN++nKafdndVHzWSHg?= =?us-ascii?Q?3V7P4Wpl7Ex5O+2ImyWK3LnB7IRJPGKiN/J6m11LknD/tZxTmIppF1DHrEH/?= =?us-ascii?Q?selVj8UTyEl+9A6afBBRAGlF8ik7E4OPoUivy3RySBrwZvaYgwpb9Q1UJ01n?= =?us-ascii?Q?RADbKx8MomYmkiGV5dyNLJM0lXe0CpxBSqdOjDZW2DgRC42UdmrVnM/sr6P6?= =?us-ascii?Q?9vCRxT0NVqVScgE4LjrSVk4Wx6rGX2FShFOXq+u8aTpSCtXJxV1sozuUq5h5?= =?us-ascii?Q?vo/vt3r8ktI8JMXkYzgwepV/7wjmCJ6v5T39zy3D+2taaEsCmoAofKvYdrY4?= =?us-ascii?Q?ot8VMLX8fAz17bSA6kB8E5dTsB1DpqndrDI0f8ZQDQ0U8yjnAvDpjJiVUbYC?= =?us-ascii?Q?eX/4QZERZruKIXn3vrqDF3KNXLyt0TBwjHx8lwz1uC2Bk0JhRLnYpxlJGTlV?= =?us-ascii?Q?qtZn00XwaMH0GBGxQyY=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4295e8da-b70f-425a-f81f-08db3a7e46df X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 11:17:03.1962 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MxxY78HMvPnyzg7U431ZfUNb/h5Ut6oYBfZ7hUgm9Mt0AQM20t/r6ypf1GRTGz/pO112DkAXK0H4iWXoKdJi8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8134 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Ray, You mean directly call the SmramSaveStateReadRegister instead of be= low code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ? Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width= , Buffer); if (Status =3D=3D EFI_UNSUPPORTED) { Status =3D SmramSaveStateReadRegister (CpuIndex, Register, Width, Buffe= r); } Thanks AbduL -----Original Message----- From: Ni, Ray Sent: 11 April 2023 15:40 To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Late= ef) Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes, = Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Ku= mar, Rahul R ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > Cc: devel@edk2.groups.io; Abdul Lateef Attar > ; Paul Grimes ; > Garrett Kirkendall ; Abner Chang > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library > > > Uses new SmmSmramSaveStateLib library, which fix the CI failure. > > What is the exact failure you are seeing? > > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf > > This should be the AMD version. KVM uses the AMD smram state. > > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h > > take care, > Gerd > > > >=20 >