From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.40]) by mx.groups.io with SMTP id smtpd.web10.4455.1679367636678387401 for ; Mon, 20 Mar 2023 20:00:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=IPSrnKcX; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.40, mailfrom: abdullateef.attar@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=faPG5YMIJoEm9TKeVpHu6Ujung+5vKuFHTz5aq4t1Wr/hti20m6ae4YnfACuFGYaL/tq2PYCC16pPcPpZTB2/iGfmjimU0B8OKLZk1UoqKBt4Thy06u05oIu/Z3DGs41DbsS+PICnaptWrytpQypUwLRFRbGztoNbUKRo/42aJ0jW//PGYwgvcqc57/cwVA0l0nsRW2zGFJqs3wFZqVvgbxxYuwWfHwRT0MU1KejttIX3bADi+C7bPs5ivJbFh+/rDUJGBS+m7MHqWOw/75o0Vspm+ASaJOyxpFBNpk1SPuUn+hd1RVe2GAKpBJ4ciAbhXtahFmCjbWEFZLgtfcyjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aaer8NQa5YIoD+At93M7LSP4KHX0fR7TbwDDg7yGngc=; b=GI6uy6GGkoR41kfaQmosRJ4/niebsWlift99quznmp+Bc4N6Vh32Z3/SPybxyZqzZytH4ZPSA7c9BHiT4v9TwZK/K/o8k0x5eiZMaePolrnV9tGcqc0XduHozqcd4+9Ruo1AOIDl6we9bZjbKvHPYx1J6N9YUNbOLygXIAW5BX1qJwv3wee6777xRYDPTFp5aWSvhXHRt6urvJkJ+bFuivaBX6cHVaZ7PNG1vqGnlmKPDE5ZRRdFAdnmtEFULskWAFC0/UEbmfM2RC+zhEI1RRRZ0BLMBb7YM+9rQuUNeNrJePQzcS1Ey4F5n6FAHB7XRA+W3WXbsoOxINicbzZPGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aaer8NQa5YIoD+At93M7LSP4KHX0fR7TbwDDg7yGngc=; b=IPSrnKcXzpwemoUDkYes+7AZdiBlic+YB67n4ZdzB9Z0dTZwtbCU+X3V0KMhm+j9tumF/nc8HZ7wPs15hgNeyc31o8mlRAy2FxfUTr0R19NUp/p6uc8/4QqDhI41hYUFCyXzXJNC/ZF25a6OyTIh8gHUGKQ4HKSIkFMgwjY9I2E= Received: from PH7PR12MB6466.namprd12.prod.outlook.com (2603:10b6:510:1f6::22) by PH7PR12MB5879.namprd12.prod.outlook.com (2603:10b6:510:1d7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Tue, 21 Mar 2023 03:00:31 +0000 Received: from PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151]) by PH7PR12MB6466.namprd12.prod.outlook.com ([fe80::127d:946f:b238:1151%2]) with mapi id 15.20.6156.027; Tue, 21 Mar 2023 03:00:31 +0000 From: "Attar, AbdulLateef (Abdul Lateef)" To: Leif Lindholm CC: "devel@edk2.groups.io" , "Chang, Abner" , Ard Biesheuvel , Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Topic: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers Thread-Index: AQHZWJzKDkfAJvIrQU+EQVqwCIH2Ta7/JFoAgAEfA4CAA2SUgIAAC+7ggABHOoCAAJQv4A== Date: Tue, 21 Mar 2023 03:00:30 +0000 Message-ID: References: <3c02d9dae4384688b596a6617a8bb05ce84bade7.1679035605.git.abdattar@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=a879256c-26c5-40d4-91ca-74381dbf7b36;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-03-21T02:53:02Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR12MB6466:EE_|PH7PR12MB5879:EE_ x-ms-office365-filtering-correlation-id: ff1a8d5b-3dc9-4ee8-3225-08db29b86e94 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dArR6CWQ4ZrQoMJ9uSaxYEVAHGK956QpjYKnev+ogfEysINj7AqxYh66XRCMliutut4vxxtNfxsRwcnVz7wUI8Z5Z0O+Yu0ixjuXNfEO2h/ou3wJkFS2XpzikDqdr+JQ3EzVByHwYinqO/ml9wYy2DGrZnVRLunVGYMZsnkEdC28/WgvX3OfiMs0la1Dg6jkDXReoRj9XERSYbjocy8/4AyBLevPa1mEWuSskYvuS7BS1jI8ny+4aP9yS4LxUrggvT4G8xGekQ8A8t5buVgdCTGSXJWqbLMABiES5tQ5jpqfdZDrrWH+GvcDDNRdTER4Fgq7/REIeT4ntJcbDoUy+CSv57H8mcp9HB8FdLW7lCz25bMJoQHge3reVWVZuMBprf20PmcigRu6XKyQl+gfC0/UJfi0emHU/Jzt44Oe89DJmiXBtbhqY6jOs7ov9gIfTUe2aVGgWt6K5yD5rrRXPopBkPl7k2Dy2MwkavE1JxgoB0D0ODZcwJcGyJavE7nZBp+yL3uo0ElLr+/kGNY0zvwcOIosT4pktRp4RdtcN34UDz3DJIf+wIkKtgqkMzZl3gjqc6oH6HMVycgImp8GdJ34Xr637y/4Rb6tnZdIaDffwOa2Nj0OQAp3sZZE4P4hwh1OYc611Tk3u01XOY6Z6cKI80WD4TELqLBX9zyv6zNlawj/5N4VDCrdf7W5IwIE x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR12MB6466.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(376002)(346002)(39860400002)(396003)(366004)(451199018)(86362001)(55016003)(33656002)(71200400001)(83380400001)(66556008)(64756008)(19627235002)(316002)(6916009)(4326008)(76116006)(66946007)(478600001)(66446008)(8676002)(66476007)(186003)(54906003)(9686003)(26005)(6506007)(53546011)(966005)(38100700002)(38070700005)(66899018)(7696005)(8936002)(5660300002)(52536014)(41300700001)(2906002)(122000001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4cjca47lBCun4joARGJOvmCd7PoAPL8ejLcqeRsZvya9fQpGOSPbqRX2dFq+?= =?us-ascii?Q?EeHU+x6tIJr+cN1zlwvOBL9PjfrE0sOakatju/qkrH5oQ7mzv1D8gf6zTnsg?= =?us-ascii?Q?NvQ85MZ+WRySfusVvALSWa0wwDzettJSTuFzCxl4zVUB6Ry3EmblQnAe2R94?= =?us-ascii?Q?+lgkoUeOYsNdAr/r2wwIxaDWbwWsQlBWDfBD68V0ny4KBIpLI9w6bRP1Eo6t?= =?us-ascii?Q?uAeKWP4qL+ebYt2hnowyCCzQhp1HfYLm/WpvtLFW9Rdg7NcwLSbbb43qhArW?= =?us-ascii?Q?ZL1p+r/rPjpE7rrJcAy/CxXMnJiRDwwptul26onLjzBDm7AxO43yVU2ArTeq?= =?us-ascii?Q?0pMobMP54CmPRsDsN+z3f5JpFj1puOuQqnsFhtRNqyW9RVbCjUmD7dgtXqSG?= =?us-ascii?Q?tZTJC611YySrLJ6EdcbpgUu8UDpDnYku5b+kCQx8n0zKzRUNEwLqU0CbxjQt?= =?us-ascii?Q?qO8QlfQEiEgA14ZsEVcgliCkvK9u4xmKmsoq6fb2EabHm2RL63MthDjGYsN7?= =?us-ascii?Q?vIszsMk5vOwx7B0QvcmOv8p7htI2r0RKlqU9nEicTXOI2lb/qgx/vPzMOj02?= =?us-ascii?Q?IXdMnEyR+7bevlEAHmiZ9jGdbQ8Etu2p8J23NaMrjUo1jEboQoXArYN3V/ic?= =?us-ascii?Q?p5YoRVh9ChylGIOIvVCHwC6iw3ZRnHT5e73EWpnjrvIbG17mkZeTbItX5aqT?= =?us-ascii?Q?xj+fB+/ilOcg6L92Pt6+++VkZJ7fh+t5ulnBnrsVybOtjhjJf3fje0Bf7yil?= =?us-ascii?Q?vlk/lNn6dsCJbr88fjyTupLEN2SxglEzDJ/ctyx7HXTO9fFJIdtSfzLD/ChE?= =?us-ascii?Q?tb3vwy4GZLdkOHG5zcpO9TbU2Q9p7//kBoVwtq+gnXTqJZ3pPrU/KPiBThBh?= =?us-ascii?Q?5f3tsnnDTVinYluzSeYfqVJ2qouZSVPQjDAoJcZgIx17LTokGm+00JqM5KHC?= =?us-ascii?Q?IajxC+IzsxRJncar0bSqel0VLEBppw6N5otVK+VbmquoOD9zhb1qk76AD92a?= =?us-ascii?Q?/2vrGuYYEhj3P15jii0sb1KhR7MRSkqC/2MTJJuyj4R2Y28A2SCxy6L3Sxg+?= =?us-ascii?Q?4sO0W59Iz7ITp+LjELtRcbgGCH1uaCP6l92FFINntmnsnjCOXr3XnzxC/xlB?= =?us-ascii?Q?EOTznjl6KGOw/EpYjnZV5sllT/SLVjSVUp+9Nnykg3Twdp51jJOlUrv2IgQZ?= =?us-ascii?Q?lZKg7jw58lnacTcLbExRUkcbV9x1LXpkADQQw088xbpsdkcpA1MtB1d8nRFL?= =?us-ascii?Q?LlC85S5kKcrOEUucp3SWRYiLxd1DDFUi+t+YFVziAU3uxFvF/nu/pSBCiTmT?= =?us-ascii?Q?ggfekn7Mzd7JruETlXgliFriBhQju7DY3yM3pwDlW3IZBYMrat/9IkK5rSOV?= =?us-ascii?Q?WJgi0BmIySSwaOtz5j2cAzVSZYacj720hcr9RcxA662w6JPDh488nrocdy6+?= =?us-ascii?Q?di2FYIsxszNlCkXtF+Kx55YR+rgWMVShFL2/ZxVjecQvmd/4s5YuiG0EaeWO?= =?us-ascii?Q?BpI/m0KaFh/2akc6JjgdO8bqPp33yDlb3FEBAQqER3d0gdz2BemB7b6lZUOq?= =?us-ascii?Q?impQP9V99XmmrrhYVRAPHR6uSKjozG5T2whEeNpx?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6466.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff1a8d5b-3dc9-4ee8-3225-08db29b86e94 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2023 03:00:30.8828 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N9BPrT6bRFQ6IWHH+vPm6QqskVRnemesJPNS3c6X3nZ/3YbazHECouMCMZlu58jsJjttLxsCvpuqJvTZSZHlgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5879 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi Leif, AMD/BoardPkg will implements modules specific to boards(one or more= motherboards). It will not contain any module specific to Platform or Silicon, which are p= art of MinPlatformPkg. How about just Min prefix? AMD/MinBoardPkg (I am avoiding the Amd prefix because its already in AMD fo= lder). AMD board package for MinPlatformPkg F: Platform/AMD/MinBoardPkg M: Maintainer1 M: Maintainer2 Thanks AbduL -----Original Message----- From: Leif Lindholm Sent: 20 March 2023 23:33 To: Attar, AbdulLateef (Abdul Lateef) Cc: devel@edk2.groups.io; Chang, Abner ; Ard Biesheuve= l ; Michael D Kinney Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/B= oardPkg and AMD/PlatformPkg maintainers Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abdul, On Mon, Mar 20, 2023 at 14:09:11 +0000, Attar, AbdulLateef (Abdul Lateef) w= rote: > AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg = framework. > BoardPkg will be generic across all AMD boards which are based on MinP= latformPkg framework. > It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg". > We will gradually add modules and libraries to it. So, if the purpose is exclusively to support MinPlatformPkg platforms, I th= ink that should be part of the name. Like Platform/AMD/AmdMinPlatformPkg (for example). > AMD/PlatformPkg will contain the modules/drivers which are generic to fut= ure AMD platform. > Currently we don't have complete platform, we can drop > PlatformPkg for now till we have complete(reasonable modules) > solution. It will certainly be easier to reason about what the preferred naming/layou= t should be once there is code to look at for examples. It may be that parts of it would live more naturally under Silicon/AMD, for= example. > It's better to not touch existing AMD/OverdriveBoard, restructuring > requires changes to .dsc and .fdf files, might break backward > compatibility. No problem. Config files occasionally need to be revamped, but that's simpl= y a mechanical exercise. > How about having just BoardPkg like below? That, too, is a completely generic name that conveys no information about *= what* boards one can expect to find in there. Regards, Leif > AMD board package > F: Platform/AMD/BoardPkg > M: Maintainer1 > M: Maintainer2 > > Please let me know your thoughts. > > Thanks > AbduL > > > > > -----Original Message----- > From: Leif Lindholm > Sent: 20 March 2023 18:35 > To: devel@edk2.groups.io; Chang, Abner > Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard > Biesheuvel ; Michael D Kinney > > Subject: Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > AMD/BoardPkg and AMD/PlatformPkg maintainers > > Caution: This message originated from an External Source. Use proper caut= ion when opening attachments, clicking links, or responding. > > > Hi Abner, > > On Sat, Mar 18, 2023 at 09:16:17 +0000, Chang, Abner via groups.io wrote: > > I don't see any modules under OverdriveBoard, is this package still > > The code is split between Platform/AMD and Silicon/AMD/Styx, the latter a= lso being used by SoftIron/Overdrive1000 and LeMaker Cello (although that o= ne is pretty much defunct and should probably be dropped). > > > in use? Do you still remember where is FDF and DSC come from (as > > there is AMD copyright 2014-2016) back to the moment when you was > > introduced this package? > > As the git history tells you: > --- > commit f4d38e50c0f24eb78eb003a94f583025621c63db > Author: Leif Lindholm > Date: Thu Aug 3 12:24:22 2017 +0100 > > Platform,Silicon: import AMD Styx SoC support and platforms > > Common files for AMD Overdrive, SoftIron Overdrive 1000 > and LeMaker Cello, as well as actual platform support. > Imported from commit efd798c1eb of > https://git.linaro.org/uefi/OpenPlatformPkg.git > --- > > and the initial commit of the platform in that repository is: > --- > From: Leo Duran > Date: Thu, 20 Aug 2015 13:30:24 -0500 > > Subject: Platforms/AMD: add support for AMD Overdrive and Lemaker > Cello > > This adds support for the AMD Seattle based Overdrive and Husky > platforms, > and the Lemaker Cello which is derived from it. > > This code was tested with upstream EDK2 commit 758ea94651. > > The binaries in this branch are based on SeattleFDK 1.0.0.2 > (Linaro SeattleFDK commit 4b419f2ef2) > --- > > Regards, > > Leif > > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Leif Lindholm > > > Sent: Saturday, March 18, 2023 12:09 AM > > > To: Attar, AbdulLateef (Abdul Lateef) > > > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > > > ; Ard Biesheuvel > > > ; Chang, Abner ; > > > Michael D Kinney > > > Subject: Re: [PATCH v2 RESEND 4/4] Maintainers.txt: Adds > > > AMD/BoardPkg and AMD/PlatformPkg maintainers > > > > > > Caution: This message originated from an External Source. Use > > > proper caution when opening attachments, clicking links, or respondin= g. > > > > > > > > > On Fri, Mar 17, 2023 at 12:20:07 +0530, Abdul Lateef Attar wrote: > > > > From: Abdul Lateef Attar > > > > > > > > Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg. > > > > > > > > Signed-off-by: Abdul Lateef Attar > > > > Cc: Ard Biesheuvel > > > > Cc: Leif Lindholm > > > > Cc: Abner Chang > > > > Cc: Michael D Kinney > > > > --- > > > > Maintainers.txt | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index > > > > 747191366070..bb8ab643e090 100644 > > > > --- a/Maintainers.txt > > > > +++ b/Maintainers.txt > > > > @@ -91,6 +91,12 @@ F: Silicon/AMD/Styx/ > > > > M: Ard Biesheuvel > > > > M: Leif Lindholm > > > > > > > > +AMD Platform > > > > > > Annoyingly, I'm now going to ask the question I have been avoiding > > > up until now. What does "AMD Platform" mean? > > > I mean, you've placed this straight after the entry for the Seattle p= latforms. > > > I think the name, and package names, are too generic. > > > > > > / > > > Leif > > > > > > > +F: Platform/AMD/BoardPkg > > > > +F: Platform/AMD/PlatformPkg > > > > +M: Abner Chang > > > > +M: Abdul Lateef Attar > > > > + > > > > Ampere Computing > > > > F: Platform/Ampere > > > > F: Silicon/Ampere > > > > -- > > > > 2.25.1 > > > > > > > > > >=20 > > > >