[edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Rebecca Cran]

Now that edk2 has been using PRs for a few weeks, I'd like to propose 
enabling the same workflow for edk2-platfoms.

As maintainers or reviewers of platforms in the edk2-platforms repo, I'd 
like to get any feedback on moving from email-based reviews to GitHub 
Pull Requests and any concerns or issues people might have with it.

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119747): https://edk2.groups.io/g/devel/message/119747
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Paul via groups.io]

[AMD Official Use Only - AMD Internal Distribution Only]

I support this.

Thanks,
Paul

-----Original Message-----
From: Rebecca Cran <rebecca@bsdio.com>
Sent: Monday, July 1, 2024 12:17 PM
To: devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; Xing, Eric <Eric.Xing@amd.com>; Yao, Ken <Ken.Yao@amd.com>; Zhai, MingXin (Duke) <duke.zhai@amd.com>; Fu, Igniculus <Igniculus.Fu@amd.com>; Nhi Pham <nhi@os.amperecomputing.com>; Chuong Tran <chuong@os.amperecomputing.com>; Thomas Abraham <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>; Ray Ni <ray.ni@intel.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>; Andy Hayes <andy.hayes@displaylink.com>; Wenyi Xie <xiewenyi2@huawei.com>; Pedro Falcato <pedro.falcato@gmail.com>; Marvin Häuser <mhaeuser@posteo.de>; Sai Chaganty <rangasai.v.chaganty@intel.com>; Nate DeSimone <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Eric Dong <eric.dong@intel.com>; Dandan Bi <dandan.bi@intel.com>; Nickle Wang <nicklew@nvidia.com>; Kelly Steele <kelly.steele@intel.com>; Zailiang Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Chasel Chiu <chasel.chiu@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com>; Jeremy Soller <jeremy@system76.com>; Daniel Schaefer <git@danielschaefer.me>; Sunil V L <sunilvl@ventanamicro.com>; Yuwei Chen <yuwei.chen@intel.com>; Jeremy Linton <jeremy.linton@arm.com>; Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>; Graeme Gregory <graeme@xora.org.uk>; Pedro Falcato <pedro.falcato@gmail.com>
Subject: Moving edk2-platforms reviews to GitHub Pull Requests

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


Now that edk2 has been using PRs for a few weeks, I'd like to propose enabling the same workflow for edk2-platfoms.

As maintainers or reviewers of platforms in the edk2-platforms repo, I'd like to get any feedback on moving from email-based reviews to GitHub Pull Requests and any concerns or issues people might have with it.

--
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119748): https://edk2.groups.io/g/devel/message/119748
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Chang, Abner via groups.io]

[AMD Official Use Only - AMD Internal Distribution Only]

Yes, and AMD moved to GitHub PR already.

Regards,
Abner

> -----Original Message-----
> From: Grimes, Paul <Paul.Grimes@amd.com>
> Sent: Tuesday, July 2, 2024 3:20 AM
> To: Rebecca Cran <rebecca@bsdio.com>; devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Xing, Eric <Eric.Xing@amd.com>; Yao, Ken
> <Ken.Yao@amd.com>; Zhai, MingXin (Duke) <duke.zhai@amd.com>; Fu,
> Igniculus <Igniculus.Fu@amd.com>; Nhi Pham
> <nhi@os.amperecomputing.com>; Chuong Tran
> <chuong@os.amperecomputing.com>; Thomas Abraham
> <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>;
> Ray Ni <ray.ni@intel.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>;
> Andy Hayes <andy.hayes@displaylink.com>; Wenyi Xie
> <xiewenyi2@huawei.com>; Pedro Falcato <pedro.falcato@gmail.com>; Marvin
> Häuser <mhaeuser@posteo.de>; Sai Chaganty
> <rangasai.v.chaganty@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>; Dandan Bi <dandan.bi@intel.com>; Nickle
> Wang <nicklew@nvidia.com>; Kelly Steele <kelly.steele@intel.com>; Zailiang
> Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Chasel Chiu
> <chasel.chiu@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com>;
> Jeremy Soller <jeremy@system76.com>; Daniel Schaefer
> <git@danielschaefer.me>; Sunil V L <sunilvl@ventanamicro.com>; Yuwei Chen
> <yuwei.chen@intel.com>; Jeremy Linton <jeremy.linton@arm.com>; Marcin
> Juszkiewicz <marcin.juszkiewicz@linaro.org>; Graeme Gregory
> <graeme@xora.org.uk>; Pedro Falcato <pedro.falcato@gmail.com>
> Subject: RE: Moving edk2-platforms reviews to GitHub Pull Requests
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> I support this.
>
> Thanks,
> Paul
>
> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Monday, July 1, 2024 12:17 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; Xing,
> Eric <Eric.Xing@amd.com>; Yao, Ken <Ken.Yao@amd.com>; Zhai, MingXin
> (Duke) <duke.zhai@amd.com>; Fu, Igniculus <Igniculus.Fu@amd.com>; Nhi
> Pham <nhi@os.amperecomputing.com>; Chuong Tran
> <chuong@os.amperecomputing.com>; Thomas Abraham
> <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>;
> Ray Ni <ray.ni@intel.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>;
> Andy Hayes <andy.hayes@displaylink.com>; Wenyi Xie
> <xiewenyi2@huawei.com>; Pedro Falcato <pedro.falcato@gmail.com>; Marvin
> Häuser <mhaeuser@posteo.de>; Sai Chaganty
> <rangasai.v.chaganty@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>; Dandan Bi <dandan.bi@intel.com>; Nickle
> Wang <nicklew@nvidia.com>; Kelly Steele <kelly.steele@intel.com>; Zailiang
> Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Chasel Chiu
> <chasel.chiu@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com>;
> Jeremy Soller <jeremy@system76.com>; Daniel Schaefer
> <git@danielschaefer.me>; Sunil V L <sunilvl@ventanamicro.com>; Yuwei Chen
> <yuwei.chen@intel.com>; Jeremy Linton <jeremy.linton@arm.com>; Marcin
> Juszkiewicz <marcin.juszkiewicz@linaro.org>; Graeme Gregory
> <graeme@xora.org.uk>; Pedro Falcato <pedro.falcato@gmail.com>
> Subject: Moving edk2-platforms reviews to GitHub Pull Requests
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Now that edk2 has been using PRs for a few weeks, I'd like to propose enabling
> the same workflow for edk2-platfoms.
>
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd like to
> get any feedback on moving from email-based reviews to GitHub Pull Requests
> and any concerns or issues people might have with it.
>
> --
> Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119752): https://edk2.groups.io/g/devel/message/119752
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Leif Lindholm]

(Dropping direct cc:s)

On 2024-07-01 20:16, Rebecca Cran wrote:
> Now that edk2 has been using PRs for a few weeks, I'd like to propose 
> enabling the same workflow for edk2-platfoms.
> 
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd 
> like to get any feedback on moving from email-based reviews to GitHub 
> Pull Requests and any concerns or issues people might have with it.

My only concern is wrt reviewer assignment.

There are a few ways we can consider that - for example:
- leave contribution workflow up to each maintainer (for now)
- switch fully and expect maintainers to dutifully trawl the PR queue
- Move to CODEOWNERS for edk2-platforms (which has less complex wildcard
   use than edk2)

Best Regards,

Leif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119749): https://edk2.groups.io/g/devel/message/119749
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Marvin Häuser]

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

Hi Rebecca,

Sounds good to me!

Best regards,
Marvin

> On 1. Jul 2024, at 21:16, Rebecca Cran <rebecca@bsdio.com> wrote:
> 
> Now that edk2 has been using PRs for a few weeks, I'd like to propose enabling the same workflow for edk2-platfoms.
> 
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd like to get any feedback on moving from email-based reviews to GitHub Pull Requests and any concerns or issues people might have with it.
> 
> --
> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119755): https://edk2.groups.io/g/devel/message/119755
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2422 bytes --]

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Rebecca Cran]

On 7/1/24 13:16, Rebecca Cran via groups.io wrote:
> Now that edk2 has been using PRs for a few weeks, I'd like to propose 
> enabling the same workflow for edk2-platfoms.
> 
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd 
> like to get any feedback on moving from email-based reviews to GitHub 
> Pull Requests and any concerns or issues people might have with it.
As Leif pointed out, the other question is around assigning reviewers.

Would people be okay with moving to CODEOWNERS as a method of assigning 
reviewers, moving away from Maintainers.txt?
It's less flexible because it doesn't have the concept of maintainers vs 
reviewers, so the idea would be to add both to CODEOWNERS but only allow 
maintainers to set the 'push' label or otherwise write to the repository.

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119787): https://edk2.groups.io/g/devel/message/119787
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

[Chang, Abner via groups.io]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Rebecca,
Having GitHub CODEOWNERS to assign reviewers for the PR is fine to me, as well as only maintainers have the privilege to set "Push" label. I would suggest we use only one CODEOWNERS file on the repo so we can easily find the code owner from that file.
I think community should be able to create a PR for updating the CODEOWNERS under any folder on the repo, right?  But how can we determine the role of maintainers and reviewers in CODEOWNERS? As only maintainers can set "push" label. Also, how can we identify the newly added code owner has the "push" privilege in the PR against the CODEOWNERS file.

Thanks
Abner

> -----Original Message-----
> From: Rebecca Cran <rebecca@bsdio.com>
> Sent: Wednesday, July 3, 2024 10:20 PM
> To: devel@edk2.groups.io; rebecca@bsdio.com
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Chang, Abner <Abner.Chang@amd.com>; Attar, AbdulLateef (Abdul Lateef)
> <AbdulLateef.Attar@amd.com>; Grimes, Paul <Paul.Grimes@amd.com>; Xing,
> Eric <Eric.Xing@amd.com>; Yao, Ken <Ken.Yao@amd.com>; Zhai, MingXin
> (Duke) <duke.zhai@amd.com>; Fu, Igniculus <Igniculus.Fu@amd.com>; Nhi
> Pham <nhi@os.amperecomputing.com>; Chuong Tran
> <chuong@os.amperecomputing.com>; Thomas Abraham
> <thomas.abraham@arm.com>; Sami Mujawar <sami.mujawar@arm.com>;
> Ray Ni <ray.ni@intel.com>; Ilias Apalodimas <ilias.apalodimas@linaro.org>;
> Andy Hayes <andy.hayes@displaylink.com>; Wenyi Xie
> <xiewenyi2@huawei.com>; Pedro Falcato <pedro.falcato@gmail.com>; Marvin
> Häuser <mhaeuser@posteo.de>; Sai Chaganty
> <rangasai.v.chaganty@intel.com>; Nate DeSimone
> <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Eric Dong <eric.dong@intel.com>; Dandan Bi <dandan.bi@intel.com>; Nickle
> Wang <nicklew@nvidia.com>; Kelly Steele <kelly.steele@intel.com>; Zailiang
> Sun <zailiang.sun@intel.com>; Yi Qian <yi.qian@intel.com>; Chasel Chiu
> <chasel.chiu@intel.com>; Benjamin Doron <benjamin.doron00@gmail.com>;
> Jeremy Soller <jeremy@system76.com>; Daniel Schaefer
> <git@danielschaefer.me>; Sunil V L <sunilvl@ventanamicro.com>; Yuwei Chen
> <yuwei.chen@intel.com>; Jeremy Linton <jeremy.linton@arm.com>; Marcin
> Juszkiewicz <marcin.juszkiewicz@linaro.org>; Graeme Gregory
> <graeme@xora.org.uk>
> Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull
> Requests
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On 7/1/24 13:16, Rebecca Cran via groups.io wrote:
> > Now that edk2 has been using PRs for a few weeks, I'd like to propose
> > enabling the same workflow for edk2-platfoms.
> >
> > As maintainers or reviewers of platforms in the edk2-platforms repo, I'd
> > like to get any feedback on moving from email-based reviews to GitHub
> > Pull Requests and any concerns or issues people might have with it.
> As Leif pointed out, the other question is around assigning reviewers.
>
> Would people be okay with moving to CODEOWNERS as a method of
> assigning
> reviewers, moving away from Maintainers.txt?
> It's less flexible because it doesn't have the concept of maintainers vs
> reviewers, so the idea would be to add both to CODEOWNERS but only allow
> maintainers to set the 'push' label or otherwise write to the repository.
>
> --
> Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119788): https://edk2.groups.io/g/devel/message/119788
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-