From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.7155.1643470524529661105 for ; Sat, 29 Jan 2022 07:35:25 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=kTg14wot; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0028bfb66c=abner.chang@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20TErmjl023972; Sat, 29 Jan 2022 15:35:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=yEO80NkZomGtSz09fh7jk46pn1Aw7yXB1NydEa8bJig=; b=kTg14wotG0Y0yQhHOR+7mQ1XxNKbbx7IkKOiVk0QHuyy6G8Sajys13khsoRWjzkp38pV wji/G1IBSJtLffLC4kga3aHmqJ4rRqdEAKJQ4I337z97bt2XaTPrtgnSHwHdd0hdJnmE +aM2D9ipMyLWN93pirNtz4yovdAB81RjDxpznuasOl+Jt9wnmVmo5sSOVhMPPHI1rXrM aP9S9RwtigBPsaDJg0JaS8HL28k3y7BoAKnAwV6k6T/rL57E4YumxEeFK1ncuxgqLgpS NwL79Gd0zSsxFJ3urPSXIhGqakNXlGgfkRVpgYvgFVrUCeuFNuQaIMXSGekqiVI9oEXR YQ== Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3dvvpxtuhu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 29 Jan 2022 15:35:20 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 750699C; Sat, 29 Jan 2022 15:35:19 +0000 (UTC) Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Sat, 29 Jan 2022 15:35:19 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W9336.americas.hpqcorp.net (2002:10d0:2156::10d0:2156) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Sat, 29 Jan 2022 15:35:19 +0000 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Sat, 29 Jan 2022 15:35:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bw3hHE+O+v/b1t0hYMI6odkdUKKqCbMvZhqM04fCGDrg6z5/zQoYLm4pZOYF0pUC1hnJbveDIhmzHUl7uYRxFszS3ca4cDiRanRA//Uawj+MjEUhoBSUroPDQCdKenzFuQBR0buPuEPwYWCGBLLBLpSqvbnS3msazJ1hIVY/WX6MlSz26RXXbR22VX/nI8EhqEVy6cYLOtPas0QjF0LxdJinuqBQas0+Pbv3l768wJ1HG4WwfP4ng3HdR8mCfvWJ/Wi8fuzQwmslWG6jZ1oJII2oyCrBNbiHtNCljX6A8pnvOQ8VOhqIbD72qjRSFxPaZ+QwphDxj9BxEavQ3VZXWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEO80NkZomGtSz09fh7jk46pn1Aw7yXB1NydEa8bJig=; b=YUC0yKOa+I9snVeNuB4fH0rLx9a14hQmUQ5c4SZohvp1lZBhlIp7cFAs0exdHiJera3llh67I+JsfQK+UzZjFX5GxJWwO6AJQadrUZKbWGBeS6z7uw08lZuGZCokpf5/BBXeeTBtGUKFfdWPbyopSgQT0+9oC7s+vI8rVybgIBU/cNEfycu6XU99Nl1ZebwHdz7LYwn9QWoc7+ELXeuobglpN1tyUtvio1D03Og0+4CAZ0yEWw0fj2bBJGr8r1dfVz7+4v2g2kUILu2XGysVmwDN5OFec6eB2tMRuqINOuIn0hh3TMeOr91WmKM6DtlT0/r3PH0YzcdZMvNKzfy1Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:154::18) by PH7PR84MB2224.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:15a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Sat, 29 Jan 2022 15:35:17 +0000 Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55]) by PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55%6]) with mapi id 15.20.4930.017; Sat, 29 Jan 2022 15:35:16 +0000 From: "Abner Chang" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: "Schaefer, Daniel (ROM Janitor)" , Sunil V L , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Leif Lindholm , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib Thread-Topic: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg BaseCachingPciExpressLib Thread-Index: AQHYETIyRMtD/Q3V90K+9knqgBbI16x23tSAgANH0sA= Date: Sat, 29 Jan 2022 15:35:16 +0000 Message-ID: References: <20220124135209.8371-1-abner.chang@hpe.com> <20220127132011.36dcsj5hx4jtjdvx@sirius.home.kraxel.org> In-Reply-To: <20220127132011.36dcsj5hx4jtjdvx@sirius.home.kraxel.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ee8ce551-a237-4c04-5224-08d9e33cf354 x-ms-traffictypediagnostic: PH7PR84MB2224:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j5LgEsI+gPZjSpCRFa9m/RQjqfhx00t6+0UrTg5VIOaLoIxEvzfrjqEzi4VXxMw8qusSsgwPiI+H8CDmHLLmgHwdyOEsYkthUkMahC0GkGJ3zNR90i4L5yCGmrA4giqy7qN9JlbiG2Cw7N4TWViVWHfOQm4dAQHVs3YbVBqAoxMF8wRKlZWd806KrWwtAAq9tH8aMxg+AJmW3OKwbSgYlqDFdWSeeh85CoaamVi4iKUgRDn2NFiqVa7lRkRaZhz1SA96XanPrMtbDR6Kfl5mRhzinmqXgHTa31c5easn1CxX1XzZskLJHvGrC69OokG71i0/BQiVgmZA4zHnjytBKnb1pGJ0jqqQKdYgeiEDBx9S7WjvTI/s1sOk6fQZtb8g29Y/qNaKrBfkgfhc4PEFcjcf27uHj+1XCmZkCeaey7G8MYUr0kIIvaotjaJUy3NnzBRg1h1vbwbqlRWQ65gnFoh+1vRhgO4AfW/MK2zjOKU8Tmq5ynVgAdb6jN2qh80N45rTiV2jr8a0oniBZrZnMhw9NS/6rGTIZ3ZYJV4WhqdfClTQxfbs7v0DhpeOs7oM3TIiTPNVrkVVw6hMBIH4R1vhZD97AGr8k6Ov+f6j+svXfifteG1wj/I84bVWdk1gRRvEdUhvPLkhdxAhZ8flC/FsGIEXX3c+5maWUbjjINJZTX83e9fJy1qWJvinIt4ZM64Hon5VmVJ9t5TWYDwWYn+ZnpcWrnz2vsTW6L+b2Fg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(366004)(71200400001)(52536014)(26005)(2906002)(6506007)(7696005)(53546011)(9686003)(54906003)(186003)(33656002)(110136005)(316002)(4326008)(66446008)(8936002)(64756008)(38070700005)(5660300002)(83380400001)(66946007)(76116006)(508600001)(8676002)(86362001)(122000001)(55016003)(66556008)(66476007)(38100700002)(82960400001)(213903007)(20210929001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HqnIJVtpmQ7eQRA9wPwpFYBR0/zoDXKqZiBQ3BfFnFZnlyUhpkvKcUxCdTdG?= =?us-ascii?Q?unoJe/b9puJJU38npDG7Pv9UtHhVXT03cjKyZ9rp+V6xhmFVSsGmNnuBYdLB?= =?us-ascii?Q?YK90BZd0J56E+/qp7hWaFpC7XuT00F7cyj9Fz8+ovQQ6M5vrluciMHPvpEiW?= =?us-ascii?Q?k57RoEuto8GjrHLwITURZ2l+8x+PAFEQiB8eKknEZviKJhJqL8976sCLDeDD?= =?us-ascii?Q?NV9UOPpLTb3MJKEJgPpW8VNa14dxsrJSLr3cHGClsQwwnKz2qLWVNy6SGf46?= =?us-ascii?Q?oEbvdO4LKOqZnoFNtbDN0kY+bhl7NAkKI8Gy5/9OXnO7uDwbHDsE/7+5zdQe?= =?us-ascii?Q?fdNicMpq0GWcZfRxPFHMwAK7UdKCdZQnWM1loO7cmEJUBSKui08U6+JoVGXW?= =?us-ascii?Q?nwSUtW7qg7ig/zCxB2AsRwdC6pnNUClz6l/1kX//xVMnBQY7gogiEVVjWXGf?= =?us-ascii?Q?hGNtvh1bUCqeVLwM73W69i2CebOpshttfutG7c2YIeFYds9OZzl4qEcod5YC?= =?us-ascii?Q?oiicEeetcdcGQlX3iAw0hN2QKRexDN5bZIOUZLOsH0vFwEvW9b3i6kMmAhTW?= =?us-ascii?Q?BpWQBdTa0RrXRxxrK7cN5Uyw8Rtz12Xpi0Bo6s/ZNI+bFKFJcq5UzDzP4OKE?= =?us-ascii?Q?mlbIc77Zv+js2Z12FDQDVcrl92EL/R8IE+9YDGsP5osCee4JH6/qytaUGr4c?= =?us-ascii?Q?qVVmuXo6mCwiazxL20Rria6WErDAirUtTVPGYyO31+VKpCbWgFeYixw1gzEY?= =?us-ascii?Q?MZuhZlcYgtl6bI0OxhDfk51RLm5aLwYUrOESFQGVIMJFSWbiFA+my3WuVjgQ?= =?us-ascii?Q?3Kg53rw35a4uGJlQ9osjMHcjV9SVUC9f8DVmduaru/h0bfY51KR26QQpgN4+?= =?us-ascii?Q?id3pn2do03npJaXxxP80v3b+amQ5PPILJ+fnnc2G1KzmafLm1DyHaXjBlwwY?= =?us-ascii?Q?iAkXIZ8qCWAFL/KEMEkskwj583aU2DJag2AGn0KuT1qLg1oh292YXDLI7Qgg?= =?us-ascii?Q?qlkd0+Bwl+8SDgkHOE0Ec1UcFuvGKjfyQ/zzWSGHDuObE3sD2hUILtt/++kk?= =?us-ascii?Q?/o51fpKduoIFMPrJx2Lan10rw+2Lrg/jqdyetCiRt806Fn4erO+sky03Z739?= =?us-ascii?Q?By3DPHUjQPKh6NT8SQgdE9N4ZtagM3pW4NNEB2FP9o0nEE6klHGmib2fgZXh?= =?us-ascii?Q?MJlLYsqtXmXVlYF8yM1QETIbxu5/fsQUcln2upAb57UcdjFlCkRNovL53zds?= =?us-ascii?Q?NypHKrwEKfvPJJRiZH7x+ni3LzTyKC3z5UEW07hV5Abz0ENLI52kJ3OIJnF5?= =?us-ascii?Q?jRDznsqDEOrRrOZpGjLZ6n24IduPS2N+LW0J4T8EpUDzdnJ3eNwsAqcPUQUQ?= =?us-ascii?Q?wmnkh0mEGsXY0Lxy6aysygJnL+hbdlt2Ud6HZxbGg3z9rr601GHq5xq00VJ0?= =?us-ascii?Q?xAS6h8UUS/Ud09DIGx1WEDTFzugCL94k03t+BWjH/MeHPNqxjh0QA9G6RLwi?= =?us-ascii?Q?/R8LWWWr++7De6fERHvtU6oQm/17NHZZsEkQGwTx9N2JqBFRzUgYziPVRJyl?= =?us-ascii?Q?TlJinZUTlo2ohltI+4C12iv78i5xYEGgGenwUrZdlI77r22WxYP0j11r7ICL?= =?us-ascii?Q?jYamVlYsfaK75hjM3vxG2uo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: ee8ce551-a237-4c04-5224-08d9e33cf354 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2022 15:35:16.8162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Khj7FZXi9+W8sAL9oWw1mwEPiNR1d1bKodCZ50rC+IqpEanf348DIYmakEJlzpyDp5Ei/JI22WwghWtxxDXmKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB2224 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: c1X6Vwb9e5Us-umLDRaJsQJAwrX8lwE6 X-Proofpoint-ORIG-GUID: c1X6Vwb9e5Us-umLDRaJsQJAwrX8lwE6 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-29_09,2022-01-28_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=691 suspectscore=0 malwarescore=0 bulkscore=0 mlxscore=0 clxscore=1015 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201290099 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gerd Hoffmann > Sent: Thursday, January 27, 2022 9:20 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Schaefer, Daniel (ROM Janitor) ; Sunil V L > ; Ard Biesheuvel ; > Jiewen Yao ; Jordan Justen > ; Leif Lindholm ; Sami > Mujawar > Subject: Re: [edk2-devel] [PATCH 0/2] Migrate ArmVirtPkg > BaseCachingPciExpressLib >=20 > On Mon, Jan 24, 2022 at 09:52:07PM +0800, Abner Chang wrote: > > Clone BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg= . > > RISC-V Virt platform can leverage the same library to access PCI Expres= s > > registers through PCI Express base address set in > PcdPciExpressBaseAddress > > and cached in a global variable. Also remove the one under ArmVirtPkg. > > > > Signed-off-by: Abner Chang > > Cc: Daniel Schaefer > > Cc: Sunil V L > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Gerd Hoffmann > > Cc: Leif Lindholm > > Cc: Sami Mujawar >=20 > Given you are mostly moving code around as git noticed ... >=20 > > rename {ArmVirtPkg =3D> > OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf > (87%) > > rename {ArmVirtPkg =3D> > OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%) >=20 > ... it doesn't make sense to split that into two patches. Hi Gerd, I missed this message. Because the movement impacts two packages thus I split this change into two= patches. I just realized that you are the reviewer of these two packages, = I will send the v2 that keeps the git history. Thanks Abner >=20 > Just using "git mv" instead has the additional advantage to keep the git > history intact (using 'git log --follow'). >=20 > take care, > Gerd