From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.8113.1643123363447455096 for ; Tue, 25 Jan 2022 07:09:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=SiRA1UPR; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0024b0253a=abner.chang@hpe.com) Received: from pps.filterd (m0134422.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20PAvpAT005168 for ; Tue, 25 Jan 2022 15:09:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=LSI+iqTBMZcj6gheqRBAiBjgoU3L/S3NSC1xb4X49M4=; b=SiRA1UPRQVfjNoyMzfP2MJTtlVSr4MnQbWGsHuj2WwS5Se74yJ/cm60VgTcnbzapK9Qw DxFVKfa/KDA0Yknls/SN62yDtr4s6vTCFDI5pPqylhu/rOdluVlimqXbfeVFAiyBIMsf 4MywiFMErC0pLVDHbphRYh2KVfh4Jo3BDAHVXqDrUhP2R22yVGJ59jBvU+x0vU/vwZRk NcO9J5KskW3dvtHhQTPPHtB8NIRzqB8oY0Z8naAgHzJ+BKlEjgELiXv+ZfldEHs2pFrm jC5RCR28J1+kVJljM0LAkqiF9yVRBQIZscZ48VUlaoNq+dOHF3EIz/sVJOcTndyLJVzj hg== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3dtfwgsyh1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 25 Jan 2022 15:09:21 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id C3F725C for ; Tue, 25 Jan 2022 15:09:20 +0000 (UTC) Received: from G4W9334.americas.hpqcorp.net (16.208.32.120) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 25 Jan 2022 15:09:14 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W9334.americas.hpqcorp.net (2002:10d0:2078::10d0:2078) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 25 Jan 2022 15:09:14 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Tue, 25 Jan 2022 15:09:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N9gZ/BNxA3IPv9qJMqzBrTND97N4D2cd1qwcnr1aoxpLw0nqfb6zEtvyyi2fuw4QHdWgXSwnFQEa9EwPMlE5YeRbT6poaX5AsVJjjo9kO0nc7+nvwxVBTcr7MhCTZuTJXg1NlRPbHRRBOo5t+5haXLfSKrfHgHmKyjSphBTEgPJ6ikYXZkZP3BhdMXKfgPW3ULctvpBLR4HAULq0bYW4BhxZpwVyY/BQN4jFotEdH/TGBfDEzIrbY2Y7mRKxp+gA8nUcqx7ec8/gGq/LCPfCx78AmXIUMNksoCn7/uPx6YJAh+yG575yuh83xlu6KSDCFtSqwi0yjeefo4cZNbcQUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aEOQGHibcOcR3qJY27drywkk1eZRSQEkPr42m85AAI0=; b=YrbRlzNGo1MEXAQVGoeX5OH8Sf9o6bXw7OxKp9//JxbBO5AYC9xpyoEMyUdn3DYngwlaANVaWzIuRL42WPruk+wWgbpgZdJfux/mAv+QBQkHtivjwct4xQ1uJqABA0JIdSibjqs+z9MUXqHugs83u03OyHbmA3S8qo77Dvaw0R/md50VKL40tKXy8EqYHr4ZQravJcrZtJyLfGByi9Ix7gjLvefyRaYMW5Yk2B2caIr1fn+3O3fAHaTXJPoi4VBSU3NQ+gHMwnW07z+CuMzMyGjguhMEFpWdnoGXAkWcFJ3h9pW/vov1HufftVEVoVqrEJ9cGIkSLttwlUEkX3SYow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:154::18) by PH7PR84MB2224.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:15a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.17; Tue, 25 Jan 2022 15:09:11 +0000 Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55]) by PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55%7]) with mapi id 15.20.4867.011; Tue, 25 Jan 2022 15:09:11 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "min.m.xu@intel.com" Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Topic: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Index: AQHYEbXhwREv1NaLr0CCeQJp4pIybqxz1x4w Date: Tue, 25 Jan 2022 15:09:11 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-2-min.m.xu@intel.com> In-Reply-To: <20220125063318.862-2-min.m.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f6fa101a-8be1-49bf-f260-08d9e014a48f x-ms-traffictypediagnostic: PH7PR84MB2224:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +kYNlZSTvD4Q7bwbzg4EQTxvj/CVPfTsRDgXigHpZErKjg6i0oYhrjA9mBHVhnUFoFc5jzUfaJbt3NHYYQDccHEeKSZjM4CwvBKbCZvXckTeak8gi8hjJJkm7QIl6qLYawTu74UtE5SDEYkJJoCZ/7z/IzNR1joX8cf3blOym0915d6z97E8BG9qYHK+GkWDQZz0VpikBmt6wA18oklNDgNmlSIZB/Bi/+PecsWDLF8lAx6Zq4qsXt83USvtW/TqVsj9/C+VCqqoz8dKnvnqBWZXxM6Qzo80RWqfU4vTnUaP2r35QISE54Iyfo78PP5S7MKOycG79XxSwNfb9vOKZpBIK5zdp72nKwWxrpdm15QXUaeCV0z54NISP4IfX7AjYDFb7jIwlnnP/MXXgIa5R8p/fYJP8Cozly1HFz5g3kFClDN7wI0GZdmoYWBH4v9E6dtbx26m7aFUOZIKj2a8ozeTsycuSo8V7vugykbJFSdL5VHkOcQlyFFVj7mo0tbagxI5Eu7xkWfUuVYJoC7rRol7sr8sfrizm20gUwSCsNHMo9LofXugrCOVlIpQuR5FouuuyDZOFBuY+faRSaXK0IKQ7q6Lczn8du0fiE94Iut4GcXkA+NR7Ods4BwBKNuZmGo4YCFtuxj+1ucun9vbTRE+d4zQLyo0RhVmX2kfwKjDTAx8t1K+VEdDkuh7m0VbnkdaPw9Dd7o5RgdEBGcOxiqLpK6xlIyldM1gtaQcL5KUjsV7XKs9Ne7oku3BzWdLpPBEmEgVf3HwJwOCjhbDPBPDRJVhsnHgaLCXgiojgm5gUp06ZAam0WZhtjueLJdbS1el+FY7pmttHHfKP1YDrQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(366004)(8936002)(966005)(9686003)(316002)(76116006)(55016003)(66946007)(82960400001)(122000001)(52536014)(8676002)(86362001)(64756008)(33656002)(38100700002)(71200400001)(83380400001)(66556008)(66446008)(66476007)(508600001)(110136005)(2906002)(6506007)(53546011)(38070700005)(7696005)(186003)(26005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NLZM7/1u3TQNk5Cxj3P9G+apzYw5bDv0dOOIpq06oufXrWeDg9TvOI+Qzh5e?= =?us-ascii?Q?iCM4ia9yVKHt7ZGrQF2tj7zrm+RCvpH7fUPNuUCnzK3lZwr39g13M6AQpzve?= =?us-ascii?Q?K6shq/d3jyjsjQm4VH53nxtU/CS17q/pE5ZZcqsa2zMfZXurOWO9Obvd/S8+?= =?us-ascii?Q?bp/7pRGzCy68U8tqvmuYP+0S+mtcTE9q+hcUCiyZRGTvw0BTBYa0tjY++9UA?= =?us-ascii?Q?sqzPUrEBAcfepahFViqEGB2JROdax4gYDx+wTIcLegUO8a0dIstIAM2xeAHl?= =?us-ascii?Q?iHyreK8PDeS7fN73TwJrBkga3gAnRro6OeqQAhRmO+KUvmclMnWS0fQAL8d4?= =?us-ascii?Q?FUGq4w0RyG0sy2wA7014UYbYtPb7r74vCvY+IJPDysNrwmxKHgObZ9ZBm/BL?= =?us-ascii?Q?EAn2MeCFkccIVfxp/CbxuZlEm8Ln76eog5CZUjFfgIJ1k+MyLgz/uKVD6Hd7?= =?us-ascii?Q?aVk6a2J2fFuyWN1BCf98qWvt4UxAbhHx+aNMGI7rqFLy9P8mC4a7o6b8Yj2F?= =?us-ascii?Q?SmjVYkmWoVWfgA2DnDwSdgT6izDI5TbBwuFRZJt34AUEQ5X0oZ00UgsPVZm2?= =?us-ascii?Q?BIx21ru64pknUR6A9ZIxiYhEFLSOUTLWSGuETtEPa2oFRX/7+3rFXrT/7YmS?= =?us-ascii?Q?OMgwY4FPhtrIIZK/I/1Flel542jozuTc4VwTwlsyiUgZkYkmdB2EJ33jh7h7?= =?us-ascii?Q?6jVXxJkeRXttbpvbuv794nm4HeTKOXZyvVxmqmcwE8TSDoy2At/0zl6x9JAo?= =?us-ascii?Q?DJB1ftt1Fa0RbFM5uRLBPWnzFgqeNxoyvlgfT3K/baESVdGPALYHfumXwG3T?= =?us-ascii?Q?fCfm1j8mzZ28x1wIuRmj/N8E9mUESW4GbLterU7WTToaYrh8Ia00PKH4VUVL?= =?us-ascii?Q?lDpR1hEb4RE/QudMl2Z6YpNV4jxfJf4Ol//CSABMK1BDFGldXWWhqqRIdEU4?= =?us-ascii?Q?YEDK6BXEg7XN650KeXSutJ6OWaIVdM1z/SToHnTop4sq6EanQjaGaNiQrEx+?= =?us-ascii?Q?g0faIXPcyJfO14gG/Li1F0vHLQkFrkfDHIyVDQbU0AXHDGGivuQ/NgWxm3IC?= =?us-ascii?Q?JWa8xelaFMkIC2asciEhpRtmwb59rvHkHCNfvjNv2Bl/fEI0ZY1samuuPmXM?= =?us-ascii?Q?QObPGKc3ZVlMHY33SKY+hux8/PsiUBs0KWat5jtqlktqF1PIXSifHsLtapy7?= =?us-ascii?Q?swNdWtOANmMxJm1KZY75EXV2G1FUEcgJAWwrUMyEuS6yiTr3QS1u0ozY4rZo?= =?us-ascii?Q?SkVbAsN0eYsgHYe//VZVRBFvgSFr4o71HJjEdFPHwlAydhwATppaJn/ahkwV?= =?us-ascii?Q?AaE9C+564NsfV4dKFJrjPla7pi312X8enoLJEFs40cUbtmsw/kU75W4/7yfa?= =?us-ascii?Q?aBYEw99SCoBvscC8fEc6GjRsuu7vFT3I+I6nMAzTrW83KUSPWfax9ofspOXX?= =?us-ascii?Q?YmGL/XsicKqI/RNQqQALkJcUIo40tS5Tx4OLNTXYhS4GQFOLgh0Tn2hfU1H6?= =?us-ascii?Q?HXUNz8o2UM8jRawVnMv77adqniedPe6aNGT6QfDEYH7cNaYVfN6ltw4stpzT?= =?us-ascii?Q?ymXD1JZQ1/rNcf7A/xuHoxMFCwNRH24gxqdlBKE27t+kEJScW2ZSyzqTTkJZ?= =?us-ascii?Q?x55iQS2DXjipAFbbEz2ohmY=3D?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: f6fa101a-8be1-49bf-f260-08d9e014a48f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 15:09:11.2938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MXOa3QV8GbsYyX6DNY4yNMz5ZLofIBquQMnJQgA5RXp2ZpvZPCrzv9JSlnqLMrSQ2TODkggUCftagClhPw47Hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR84MB2224 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: N7tjv2tdS8ZP9hFq7VcfDrRz6Qn8VlB4 X-Proofpoint-ORIG-GUID: N7tjv2tdS8ZP9hFq7VcfDrRz6Qn8VlB4 X-Proofpoint-UnRewURL: 2 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-25_02,2022-01-25_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 mlxscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201250098 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Abner Chang > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Min Xu > Sent: Tuesday, January 25, 2022 2:33 PM > To: devel@edk2.groups.io > Cc: Min Xu ; Leif Lindholm ; Ard > Biesheuvel ; Chang, Abner (HPS SW/FW > Technologist) ; Schaefer, Daniel (ROM Janitor) > > Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in > FwVol.c in X64 arch >=20 > RFC: > INVALID URI REMOVED > d=3D3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W > WWyZKgREYswYM1Tz0$ >=20 > CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. > But the second parameter of UefiDecompressGetInfo() is declared as > UINT32. So a build error is triggered. To declare CompressedDataLength > as UINT32 to fix the build error. >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Signed-off-by: Min Xu > --- > EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c > b/EmbeddedPkg/Library/PrePiLib/FwVol.c > index 92ae68f0d382..0a6d6925b7ea 100644 > --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c > +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c > @@ -291,7 +291,7 @@ FfsProcessSection ( > UINT16 SectionAttribute; > UINT32 AuthenticationStatus; > CHAR8 *CompressedData; > - UINTN CompressedDataLength; > + UINT32 CompressedDataLength; >=20 > *OutputBuffer =3D NULL; > ParsedLength =3D 0; > @@ -320,7 +320,7 @@ FfsProcessSection ( > } >=20 > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION2 > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > } else { > CompressionSection =3D (EFI_COMPRESSION_SECTION *)Section; > SectionLength =3D SECTION_SIZE (Section); > @@ -330,7 +330,7 @@ FfsProcessSection ( > } >=20 > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > } >=20 > Status =3D UefiDecompressGetInfo ( > -- > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20