From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web09.2991.1646982227698760272 for ; Thu, 10 Mar 2022 23:03:48 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=LbFYNAr6; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0069e0a9d6=abner.chang@hpe.com) Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 22B6fmXg031106; Fri, 11 Mar 2022 07:03:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=fCWTheIg/tAkLg9y4L5GPEWbky9M04OGF12XGVzX21k=; b=LbFYNAr6H43HTVVx29I6arWJ+vVDkHGCBDemYl4VDhFQBgZHMJyeVZUmzd/gsCPvu9tp VKG6BEUfNKr8qFDcQ5R9ejqJiO00DMFancy0l7nXqyaVm40SZNCxJE/kjgw3jf4bqnnb zx8PbpbyY76KZ7sbM3zb9hdIUe7a7chuAUkQ0by/0QFqvPM4f1EQxT6XYKHzQbngF032 y4Gwtz7HDZKbeZ45At5uCrW1sF6PR1jlW4Ykdkdh3TcQULrI2SvHj/0A+zZCVsofOF43 d3T0SjjjL0sLGHCr3ERZaTcwyqrISpzkwOXUJ1KSWfRG+1HhFOf8llt7DEN/NJd9qDK3 4g== Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3eqvc2a995-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Mar 2022 07:03:46 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 05D0470; Fri, 11 Mar 2022 07:03:45 +0000 (UTC) Received: from G9W8672.americas.hpqcorp.net (16.220.49.31) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 11 Mar 2022 07:03:39 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G9W8672.americas.hpqcorp.net (2002:10dc:311f::10dc:311f) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Fri, 11 Mar 2022 07:03:38 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Fri, 11 Mar 2022 07:03:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jc/9zQXzL5IThyNWYLiBz0OvG/8cRnMuw09oSH/arnNUYtW0i18qzNyQYA1Icly7msQTtkYnCyx5APj5IUUzEtBMp7/baA1evavrQQfRRygGfafLaVx7u96xOxiN8Sjf+lGSMqwI+PCKMkdkZI8ulyExeV8GZdp4lOsRJK7QoPYpHGOq/Poh3cbBgTW6jD3TLI7uqJCYfn04bFgx3ar8yNr04s4jUYPGMtN7l0t5AJir3nh4AE99kAzA2jkICI9aXY2W2KjbmYE3Gu7fkLcwPETmVBA5UkarxG2C230hL0NbN3NsXb1wPQk9u7QUHBLbfizjAqrgDSWEvUwHlNxm+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fCWTheIg/tAkLg9y4L5GPEWbky9M04OGF12XGVzX21k=; b=MycaNex+18TcfI2skWeF6RgGglTnEME40PV3eWSNcCV0UmxRoub/ZwY+/ErX0JZamoRzGbe64vHNwNd96zjWwD5Hnxoqtpjf0y88LOc6elRj55IuGe/oRi39WXOKuchmLrTLBQ3Ywf9nHJBBBk5O5lGoLD5n1OmZf4PlJMvLSXUqDGuFenF0Z0PsTaejH0TX86A8NB5Y4BLtUR+HlLyhKDCInajZkAhsUMo8FS1wkdz2XLUpTA+S+gLf9BWb/ulUZ6rXeDY3zkHSFJT551XGs3RIWEOzgGAGQ7gGMC0Bc+J2lYNazgFkvWwH/VX/5x417FO9OMwPhKDmzZKTBpv7mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:154::18) by DM4PR84MB3006.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:8:42::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Fri, 11 Mar 2022 07:03:37 +0000 Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2053:811f:bd4a:7c21]) by PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2053:811f:bd4a:7c21%7]) with mapi id 15.20.5061.021; Fri, 11 Mar 2022 07:03:37 +0000 From: "Abner Chang" To: Wenyi Xie , "devel@edk2.groups.io" , "Wang, Nickle (Server BIOS)" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue Thread-Topic: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue Thread-Index: AQHYNHHDHSXpfuBS4UOBxK3Ve9Tn7qy5rkvAgAAUefQ= Date: Fri, 11 Mar 2022 07:03:37 +0000 Message-ID: References: <20220310112534.2952545-1-xiewenyi2@huawei.com> <20220310112534.2952545-2-xiewenyi2@huawei.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 2c3fa72c-c9e3-c0b7-59b5-c5ed2452c9b2 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf8d6c66-1a1d-408b-aae9-08da032d43d7 x-ms-traffictypediagnostic: DM4PR84MB3006:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YPHH200jxkXwVqL9LOc05g/oEysDRN72iT4Gj8Kh58ZESOh34HF6PpGrJvhW9O0HOmwP8iSzPlaTHb0DhD8yTo6E4uwfp0bbdou8vDCOwcq+SJjraDF+MuGoLDJtZs1sQiNyR2HVLxZyVhs+ciP9GKf/1RlWHNDLHYNzvddXrYN7mqJyIqbwiO+yllvVYjXFX8l+CjLN0xWa3rnSlZbrhhBwNScNT7+XjGv2yFHu/rDZLKw3bKLeIxInimK9aLQpocFrdboyB60emdZ3znNGdB8TU4W5HYo0gn9MVtZRvHnO/cU+HRYoRKqnnoru69mEyIP9jEdey6Dp38xiU4OnRCOjnP82Hb5CtGn/L7x7/BQZeobssOBv2vZpByscPtPytbswztBLKm8lTXoSlQ3hoylyU1v1epva3ybOev/VjqAg5XUrqMKn+EwerXfugUSEKpkOLQ3AWiiRfyOXa1VJfGLlQj4pRxkWiwbbhL/HTqtbSdJ/5L8mW5L9sxUXhGUr/Muck5YahNdkThr5Pjy/hRPafAxKzBYVFR0jKMhYBWENh8dV3LXS34ryhiewQYJLtcXYQiRueLspHVrJpAX/JRueUvX3f9ee0KTltyoTjsZdeZJzzjq60seVoF2o+fwr6okuI98ViJEiGM8YFIKky4+aeLFHdwdAHGK9LEwE6HJACkYYXXFX1PQPJoaHf10poFMfFFBlDwqhSoaK0n8qJg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(366004)(91956017)(38070700005)(4326008)(64756008)(66556008)(7696005)(66946007)(86362001)(66446008)(6506007)(76116006)(122000001)(9686003)(55016003)(33656002)(508600001)(66476007)(6636002)(316002)(8936002)(71200400001)(110136005)(2940100002)(8676002)(53546011)(83380400001)(82960400001)(19627405001)(52536014)(38100700002)(26005)(186003)(5660300002)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XhNU7dexIUlePUTJ6Xw4q4OEK8K2aH52auRBNJVJEwPwR5XBlntRgOpNd6ZP?= =?us-ascii?Q?OOmWXispVsZoUJh4zJmllxyiX0kiv28X0q5ti24a4e9NYz66XHomblcohoju?= =?us-ascii?Q?6JKqFI8BN6x8Sn8S3YnqBD0n6K5KK6t3J8dR4Eg4JU2kPbqlBNpeXDpATMUC?= =?us-ascii?Q?PrVd8ms0NUyqNaX5n4G+c7zKQ7lBMXRVj4BQ7rIKubXprJ6j3SZcWBT4nrn7?= =?us-ascii?Q?yl0IL9CsWEfnvj7PV09zmoe+Lg6RmzHZ5AaZfbF5xRHijcn1MlMBfZfuKvvp?= =?us-ascii?Q?GrLN+gIthGqAHOyhmpQOkEQD84oLSyDThY00C/34EN/OOXa6RS+sVzBWopvf?= =?us-ascii?Q?d6WDayB/oKIh5rcqoC+FQL8n45dGP9GMNWW0oZVrJ8D8kWxy4FGr/7zK7jfe?= =?us-ascii?Q?fu0ZovkM7PwXL5jTGQTuzroryEHR3cQ/BcuvtNK5fmvJZ9ycYHQfGUDF3G1P?= =?us-ascii?Q?6e/PfJXcNDvrqCHTRCEVJ5ke6qFf0ghpSIpMNbo4wC+sW7PouvNhEfHsWTUh?= =?us-ascii?Q?2xKPOngzLMwRS4BJsEuqNcFURZphkzn2NPI4O08tF2B8ku3FGcWICOEhackA?= =?us-ascii?Q?WSpM77fTDD4gHuj8Kh0MNjjdYcS9t3n0p5+cFph+92kNvBfooVl72ZkLFqwr?= =?us-ascii?Q?wB5Z/JUbHj7PlJGYLaUj2lSv0r2T8L83Pd2wRGj0mxnQHm54ZKoILrqkQGrB?= =?us-ascii?Q?PnMfwHmZG2PMpbhdiAxKmkhPxJuQu16+odEsYP4bzuXP59W82WlyyamQSKVP?= =?us-ascii?Q?EVU9HOc4F44RqwBuadcLdekaYa5CPMUn6F7C8PxCGEilAiR7Zx1tOa7CX2lZ?= =?us-ascii?Q?vx0kD2WSuWT+1OzP26KR4u0r3VsjS4BfbaWcah/egs4roGZSDWa3x988Mj+T?= =?us-ascii?Q?u8jgWMOljcpfVWwG5SCkY/laDUj8lZpqBalM4/4LpxfMNgjDLfybxrXqoVhZ?= =?us-ascii?Q?DTZIcIhALd1WndcnOmFBeyssfPGpvOXb0avk9r+4gE352uxNvjHQp7ULj52D?= =?us-ascii?Q?ulYAf6s7WM39PDKvMk6Y0kWchaZFpSPiLGx4uZ5VhJz34NoMt9JmB93wOOWK?= =?us-ascii?Q?bspHV6nELXOWcpT6qm+oWPEuP58c3rpg7YtO2HFP2svh+pjlgD+8z9D5AtGE?= =?us-ascii?Q?omITPq9GUyiYRLhrEFvEB/IJhugqehKHP/KOOAI7MutID+TqzSWRMhX1WzWT?= =?us-ascii?Q?irNOplRecJi8XkdHeZ+cQZrDNOWCt7ujiCBWHyXiu+4M8k/ZDGWlp4oTqYVw?= =?us-ascii?Q?XyX6TE3kyMmL0TWBvDrrqjQiI90BNIEPpPEUlQyBcfG1HrNfKn8tmvMLYKzk?= =?us-ascii?Q?oDX/dlWvbNyOmZVldKJVekEQgOl2+syH/d1ttExQVYMy7tZqPCK9OZRxZJbL?= =?us-ascii?Q?4d6C8RibyIRebpSKM1LnWtGzS+a3ovJ07ARNF6dKcGTjzBiasdfTtvE/tPmP?= =?us-ascii?Q?i3mErU705Stght5x02aoLWwJQdZXZhLKpRXyP9XYqY3kkKxxhsqAM7TNlAwW?= =?us-ascii?Q?rb9NrLDRagUMnY9apDnwxyXo3fPTMaTt9MPC2f/G0jxsgpJJ+L+yqX5kwgsW?= =?us-ascii?Q?0vQv94rC7ueMW2NEzb5g6L6MGV7rEc61aXqfHkSfDN1c8vjsJ/K7tqST0Yoc?= =?us-ascii?Q?cg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: bf8d6c66-1a1d-408b-aae9-08da032d43d7 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2022 07:03:37.1715 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cr2kYJLS5+C2XWNS1f2oa/zeyY97lsJwbpIhOAkta0U2NDC9cIWdXuQdd0SQ6mab3MA53nd4Jz/j27stglp+bQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR84MB3006 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: 7SN2Hv-aLNtOzygFt81GZuCYI4SXExM1 X-Proofpoint-ORIG-GUID: 7SN2Hv-aLNtOzygFt81GZuCYI4SXExM1 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-11_03,2022-03-11_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 mlxlogscore=981 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203110029 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR84MB1885B4738B63F1EB8253314BFF0C9PH7PR84MB1885NAMP_" --_000_PH7PR84MB1885B4738B63F1EB8253314BFF0C9PH7PR84MB1885NAMP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Wenyi, Please add my RB in the commit message and create the PR against edk2, let = me know the link to PR as well. Thanks, Abner ________________________________ From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, March 11, 2022 1:48 PM To: Wenyi Xie ; devel@edk2.groups.io ; Wang, Nickle (Server BIOS) Cc: songdongkuang@huawei.com Subject: RE: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue Thanks for catching this. Reviewed-by: Abner Chang > -----Original Message----- > From: Wenyi Xie > Sent: Thursday, March 10, 2022 7:26 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > ; Wang, Nickle (Server BIOS) > > Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com > Subject: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue > > The calloc memory is not free when function collectionEvalOp > return in the halfway. > > Cc: Abner Chang > Cc: Nickle Wang > Signed-off-by: Wenyi Xie > --- > RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16 > +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git > a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > index 3f2b83e834d0..6c6e2246abe3 100644 > --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > @@ -620,6 +620,7 @@ collectionEvalOp ( > if (((*StatusCode =3D=3D NULL) && (members =3D=3D NULL)) || > ((*StatusCode !=3D NULL) && ((**StatusCode < HTTP_STATUS_200_OK) |= | > (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT)))) > { > + free (valid); > return members; > } > > @@ -633,6 +634,7 @@ collectionEvalOp ( > if (((*StatusCode =3D=3D NULL) && (tmp =3D=3D NULL)) || > ((*StatusCode !=3D NULL) && ((**StatusCode < HTTP_STATUS_200_OK)= || > (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT)))) > { > + free (valid); > return tmp; > } > > @@ -658,19 +660,15 @@ collectionEvalOp ( > > cleanupPayload (members); > if (validCount =3D=3D 0) { > - free (valid); > - return NULL; > - } > - > - if (validCount =3D=3D 1) { > + ret =3D NULL; > + } else if (validCount =3D=3D 1) { > ret =3D valid[0]; > - free (valid); > - return ret; > } else { > ret =3D createCollection (payload->service, validCount, valid); > - free (valid); > - return ret; > } > + > + free (valid); > + return ret; > } > > static redfishPayload * > -- > 2.20.1.windows.1 --_000_PH7PR84MB1885B4738B63F1EB8253314BFF0C9PH7PR84MB1885NAMP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Wenyi,
Please add my RB in the commit message and create the PR against edk2, let = me know the link to PR as well.

Thanks,
Abner
From: Chang, Abner (HPS SW/= FW Technologist)
Sent: Friday, March 11, 2022 1:48 PM
To: Wenyi Xie <xiewenyi2@huawei.com>; devel@edk2.groups.io <= ;devel@edk2.groups.io>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.c= om>
Cc: songdongkuang@huawei.com <songdongkuang@huawei.com>
Subject: RE: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue
 
Thanks for catching this.

Reviewed-by: Abner Chang <abner.chang@hpe.com>

> -----Original Message-----
> From: Wenyi Xie <xiewenyi2@huawei.com>
> Sent: Thursday, March 10, 2022 7:26 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>; Wang, Nickle (Server BIOS)
> <nickle.wang@hpe.com>
> Cc: songdongkuang@huawei.com; xiewenyi2@huawei.com
> Subject: [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue
>
> The calloc memory is not free when function collectionEvalOp
> return in the halfway.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
> ---
>  RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.= c | 16
> +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
>
> diff --git
> a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c > index 3f2b83e834d0..6c6e2246abe3 100644
> --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.= c
> +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.= c
> @@ -620,6 +620,7 @@ collectionEvalOp (
>    if (((*StatusCode =3D=3D NULL) && (members = =3D=3D NULL)) ||
>        ((*StatusCode !=3D NULL) &am= p;& ((**StatusCode < HTTP_STATUS_200_OK) ||
> (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT))))
>    {
> +    free (valid);
>      return members;
>    }
>
> @@ -633,6 +634,7 @@ collectionEvalOp (
>      if (((*StatusCode =3D=3D NULL) &&= ; (tmp =3D=3D NULL)) ||
>          ((*StatusCode != =3D NULL) && ((**StatusCode < HTTP_STATUS_200_OK) ||
> (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT))))
>      {
> +      free (valid);
>        return tmp;
>      }
>
> @@ -658,19 +660,15 @@ collectionEvalOp (
>
>    cleanupPayload (members);
>    if (validCount =3D=3D 0) {
> -    free (valid);
> -    return NULL;
> -  }
> -
> -  if (validCount =3D=3D 1) {
> +    ret =3D NULL;
> +  } else if (validCount =3D=3D 1) {
>      ret =3D valid[0];
> -    free (valid);
> -    return ret;
>    } else {
>      ret =3D createCollection (payload->se= rvice, validCount, valid);
> -    free (valid);
> -    return ret;
>    }
> +
> +  free (valid);
> +  return ret;
>  }
>
>  static redfishPayload *
> --
> 2.20.1.windows.1

--_000_PH7PR84MB1885B4738B63F1EB8253314BFF0C9PH7PR84MB1885NAMP_--