From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.6486.1642645946228114363 for ; Wed, 19 Jan 2022 18:32:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=EoLLt3Hp; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0019e26fbe=abner.chang@hpe.com) Received: from pps.filterd (m0148663.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20JNKEMk012669; Thu, 20 Jan 2022 02:32:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=9ecLyARYz+i9GtcRHgFF2f3i8j0QgQXVEcZCPXrioIQ=; b=EoLLt3Hp3Cj1aBGcNLXYZqniFQpQdO8XInbQeSvG9+9eswGIk0QT4qHo1YmBWN7xBPei 22Mw4jWhd2anuuycjZOjdyBAEc9kJep45MLLMxFk4FtyVX/ucwB2ZV6ZbqO/vD9KTOSj 8+uMBd7noSiXapP4TyMUb+noKPRTz4U1WMlMwJ75oY3vmDfXU2IkQKHLCMneSgsnZ3Hh Jv6vW1rAOqFtoYwbCSbYxIHuW8CjHgLXPGshuDfeihS5dJ8Q5XcBTsAVvLK0J5BUMdV8 Eav4gTh2iYu17taTEe/EqjZ/tKfLhsWYm2PvEuqvzRQIy6HRctuF9ER/kWknUVH/UjvG yQ== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com (PPS) with ESMTPS id 3dpk4b6cfj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Jan 2022 02:32:24 +0000 Received: from G4W10204.americas.hpqcorp.net (g4w10204.houston.hpecorp.net [16.207.82.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 059C672; Thu, 20 Jan 2022 02:32:22 +0000 (UTC) Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 20 Jan 2022 02:30:37 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.12) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Thu, 20 Jan 2022 02:30:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDHiFick3e+qGnPt/DuDbI9moFMOaLoOBZ+8yzxwqAcSQXX+UXViSLzDhSmszzVKDbKtyHhaofzJPc055UhIEa3GH98NkcHcBFA/QhpJi7XcaE89EVgRwgKDbv5py9LRv0+ruudLMSqxsaFXwVhL6RpdTDPIMmY90flxKECNBA12RxPAqADUbS8TF4JyqZpmrAP8fLTLgiHt/gTUY8lPtOXUT45RUgt7doYSvHmIU6mA60iPOiX1zz4dHdkDZp8H6pXqHG2TzGRD25djhHKjmT2EIfem4MCRhN2oQCOCD1Z1ONeJVYi/Kll0+xRzVfJHm+IvsNeQ9Vkbgq/xDcWaSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9ecLyARYz+i9GtcRHgFF2f3i8j0QgQXVEcZCPXrioIQ=; b=YIbsgzPNlgXF++jR955LdZQ4s/oq81I0Uh2RE1EITnH2sRWTJF/YQ3iBATABGUS9DHsieb7dXj2u9mfkMDSUHF4pAqEtCW0AxhPLkR+IqWlRi+//WhaeqIwT4snRxbrELdroy7Z7LAyYVI3/0kjo5YcMEvgLzoZLDmnYSXPdUIVVe5CYquISclRhhzA/7Nm1gGq3zlJZ80gEe/YZwJJz+rLKVcAY2VLPuoqSxTyxjmQnuDkToodlpAoBQ1C5z18M7huFRIoE+wKMdlOn2xbXv5mMOWLB10B7i+9KkfSrc+lr6Y+CaqGT0jnxKyHRxHqg+qlTwQ5fGWywRv74dJitew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:154::18) by PH0PR84MB1432.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:173::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Thu, 20 Jan 2022 02:30:35 +0000 Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55]) by PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55%7]) with mapi id 15.20.4867.011; Thu, 20 Jan 2022 02:30:35 +0000 From: "Abner Chang" To: "xiewenyi (A)" , "devel@edk2.groups.io" , "Wang, Nickle (Server BIOS)" CC: "songdongkuang@huawei.com" Subject: Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check Thread-Topic: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check Thread-Index: AQHYDPufJok6EBnR9kePYjVXhmZhPKxp8E6YgAAFHwCAATtCTw== Date: Thu, 20 Jan 2022 02:30:35 +0000 Message-ID: References: <20220119061241.686837-1-xiewenyi2@huawei.com> <6857ef5e-87b8-efd4-752a-6d2697e003ea@huawei.com> In-Reply-To: <6857ef5e-87b8-efd4-752a-6d2697e003ea@huawei.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: e108b539-6239-c29b-14e1-49d99fd87819 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57d80928-0336-4088-469b-08d9dbbcd720 x-ms-traffictypediagnostic: PH0PR84MB1432:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xxbl7iufKIAyDvMZQYqHxNvsQy8zk731WcB3zOIpeid/vryjgX+4S73JM8qIzP8hAznkt+N7F5j8Qoa8iyTIv9BOLEd8r9c/+KruZGF3VLfMkipaahIgPJh4d8xo9wCqa+N4BfUbZCPfVyxxEiJQ1O3pJEg1a8xNrzkL0r8eWrgtqVMGjb7h4RiPbODrLR+KZx9O/mHxzasp9rqF2rZarK9ollPUXOfqZbxXtLDD69j8Kjf+IGVA2ry/M8coQV/PpDvI06DGGPpwZemJjTUG1bhajVz690ka+FZFr9SwE3PsnodBHicTUyCfbL2a2S7fZwIePjvY9XLm1qeeR84wPJw8jgdVdvonRJ/tKd9h+0LpuJyKqXhtkhpZXZV9lToVbZa+QXdUnG9fMaGyWn1D4MM8r0VyZtw21ep4i0lw+7HFDVBs6pxDbkyFk8OLD3CzYzBfKBXu6A+OxTT0aPdeKifrq6dMjNCmxFZNgshbCxpGpqX1RYOx+XMK/WwOyknH6pCwcfYxC85Om/1DUyDEOE43osnICjxypde8z/2VAI/d1l3ROPX2yZBdmn2x65HrhzawCBhPhFjAD+ko94ZOt1APX70mROdiS4S68sBE4Llp6UWJ/Ro9hQ76cRG0xbspBUo7uOQMSz+rfwhUUe9AfeT4IjrDst3p/UXNJYRLi9l2iay4HSkqAAO/IIBvLKNBEawxHPBS/XsBrBxEdiwbpg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(6029001)(366004)(8676002)(52536014)(66556008)(2906002)(66476007)(55016003)(91956017)(66946007)(9686003)(83380400001)(66446008)(38070700005)(110136005)(82960400001)(64756008)(38100700002)(26005)(4326008)(71200400001)(316002)(122000001)(8936002)(19627405001)(5660300002)(76116006)(7696005)(6636002)(6506007)(55236004)(53546011)(508600001)(33656002)(186003)(86362001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qFKVxdN39/IWnHgIFDH9U7hIMiNE/yXkfYKo5GiD3tnRM1rC+CqKytTllB2c?= =?us-ascii?Q?jvBWia8W+pJHNYPpYRvLKtAcLM9SvGNM9xk3/Sc3QIeI2jBpc0LD1VaMfUlU?= =?us-ascii?Q?EUeAM+GxS1avvpADnpr2XWxqYWJ8eL5riXm9e6tdp9YFjo0Kh+T+vfHFttJq?= =?us-ascii?Q?na71+QDfLMwhue6LunVaCEPYZgpLgVUB2GS0yNHs77qA2VgjgukOvCLugAom?= =?us-ascii?Q?mzYYsqEuU7aOVD6Bg5TnxXu0mT8l2V7r54l94YnwpWHFlSBOjXqUFVwGRbeU?= =?us-ascii?Q?DDERR442AXzScZ7horGrF4YrLYZmXQvqNlil3XsHu5YQb+wagpZEE0PWcNXY?= =?us-ascii?Q?hjB0KS0MSBipn9h7oQ1+MfGdpcjfNk7TE/g+B0twoUm5fQTKaDIdqN4WRzii?= =?us-ascii?Q?mgF/3AhS8L1PwjJQFkJgmkod/lNUXD267wFbU+mokf7lcf4X3dt1Kxj7msiR?= =?us-ascii?Q?JDbx/9GrosnwyiXSC+eBOgzXGCELDOhC47O4NlUBXybdFdyTD/EFPoo+m6ln?= =?us-ascii?Q?vuu5v2KtpFpYFye38Z8MHKnZY+6yQLd5PiXyjDdvcteCAxdpyTtQsA6wZwWV?= =?us-ascii?Q?zV/5VpByTxMzRAqfFrWVNGC9xgcLRF9G98j4hcuaXat0kmq9SZX+6KeLbEp0?= =?us-ascii?Q?sGGHJ5NnP3RaEEMTiye0jYWziFkKzRkMuyr2TzEhFfNb1u5BUzlQDMkxAOcr?= =?us-ascii?Q?1Jw8fI8khNX4eC/lUT3omAlrBcRR7LX4zpYgRAomcyKrsEALOPET6TLwrp8g?= =?us-ascii?Q?ktq/WxdilgtqlPjAXj0nHPOpr6ZmfZPGB8O14SPb4Vgkoq/gUwjdwSrO9nkI?= =?us-ascii?Q?T+gwKMIPDY68DnOQc4jp2szkt7jVUV0Ab+7n47Zf7EdkvMGoEEwXeWnqEQDy?= =?us-ascii?Q?pXYzVv1FuI+/4muQ5vJDXvp0ljJUyAmA1FbxMJf3SGHlPDTjNgryZhgcxJcu?= =?us-ascii?Q?KfDZE9A9xmz9c4C2ula0g7R8nKx/G2cfICjhcbr1EkelOIO+TCka+wUI9MXt?= =?us-ascii?Q?jQzwAhVkk0092vNXLvSGoWxZ5JN7CWK3UdEAWqMJKNYbAg8w8ZI4WH2ePvAJ?= =?us-ascii?Q?cQ0aj/Sv3e7SMgC7vXYqiDEU8wImxV+2iwzqOl3d/Bgzkkv7A/9HJi0qbQoy?= =?us-ascii?Q?Rz3DDUQ+5YlKbKbHvxxbHZGUvL4Sq//VQUMBptJXN6eeLrvaN2yvCCNCxtdc?= =?us-ascii?Q?WdmU0rshVuvFsSftQV8+paVml8q6EejFIXAWd6zOswEb3CB1b/61icVhKtCm?= =?us-ascii?Q?PkqwjJEZhmrya0ETMDAU+S4+0mlInHX48GfKEsYg8OdMmBj0R9bdEZH6OiJK?= =?us-ascii?Q?xSAs07kLgYsaaHvejweonDasKtan73orfK1eG9q6uKcAGjv2qPNJYZGwnd1E?= =?us-ascii?Q?j9UIBg1NRAVy5xgDx7o6FOgp/ytdlZ2A0khbQ6dSPHcZnC573ORwWFq6veER?= =?us-ascii?Q?+VUnxZV6/IvCLiZDSgeZ/MugKZmaIiZ0hZmWnD/YGmPCrWmZs4wqNgtKRDCB?= =?us-ascii?Q?yjsWlK3xaPIhj1MkeswG0T/MtqBlKB9b7lhhoLlCotNWn5whlYqiGd2P6Wdj?= =?us-ascii?Q?/m0B13PpBAT920Oi0L+sjIU7+5wTAmMoURlvQNO+5eToG+jsl13JOD5vk6XE?= =?us-ascii?Q?+gvQDFNT7PRh7Bipsfd9XEk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 57d80928-0336-4088-469b-08d9dbbcd720 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2022 02:30:35.7948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4q8iqGIUZA3TgfEibI4AZc2WNSQ4XD6kq1lK9C8+Tbq2epNF0K1JhLxmC5W5vNGVR9wlRJ7pimqMUpea4juugw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR84MB1432 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: l6uJRz4lt334Y_7MPL3D0IVGWXDNLXOR X-Proofpoint-GUID: l6uJRz4lt334Y_7MPL3D0IVGWXDNLXOR X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-19_12,2022-01-19_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 clxscore=1015 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201200012 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR84MB1885C8781C634D38B77E1811FF5A9PH7PR84MB1885NAMP_" --_000_PH7PR84MB1885C8781C634D38B77E1811FF5A9PH7PR84MB1885NAMP_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Wenyi, Could you please create PR for this change? So we can have core CI on this = patch and I can also merge this patch later when the core CI is finished su= ccessfully. Just send me the link to PR once you create it. Thanks Abner ________________________________ From: xiewenyi (A) Sent: Wednesday, January 19, 2022 3:39 PM To: Chang, Abner (HPS SW/FW Technologist) ; devel@edk2= .groups.io ; Wang, Nickle (Server BIOS) Cc: songdongkuang@huawei.com Subject: Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify statu= s check On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Wenyi, > May I know what is the problem you encountered and what environment cause= s the issue? Is that under edk2 emulation or the real Redfish service? > Hi Abner, I didn't encounter any issue and there's no functional change in this patch= , just try to simplify the code. Please review whether it's OK or not. Thanks Wenyi > Thanks > Abner > -------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ----------------- > *From:* Wenyi Xie > *Sent:* Wednesday, January 19, 2022 2:12 PM > *To:* devel@edk2.groups.io ; Chang, Abner (HPS SW/F= W Technologist) ; Wang, Nickle (Server BIOS) > *Cc:* songdongkuang@huawei.com ; xiewenyi2@huaw= ei.com > *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify statu= s check > > Main Changes : > 1.Remove redundant if statement. > > Wenyi Xie (1): > RedfishPkg/RedfishRestExDxe:Simplify status check > > RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++----------= - > 1 file changed, 17 insertions(+), 21 deletions(-) > > -- > 2.20.1.windows.1 > --_000_PH7PR84MB1885C8781C634D38B77E1811FF5A9PH7PR84MB1885NAMP_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Wenyi,
Could you please create PR for this change? So we can have core CI on this = patch and I can also merge this patch later when the core CI is finished su= ccessfully.
Just send me the link to PR once you create it.

Thanks
Abner
From: xiewenyi (A) <xiew= enyi2@huawei.com>
Sent: Wednesday, January 19, 2022 3:39 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>= ;; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (Server = BIOS) <nickle.wang@hpe.com>
Cc: songdongkuang@huawei.com <songdongkuang@huawei.com>
Subject: Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplif= y status check
 


On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> May I know what is the problem you encountered and what environment ca= uses the issue? Is that under edk2 emulation or the real Redfish service? >
Hi Abner,
I didn't encounter any issue and there's no functional change in this patch= , just try to simplify the code. Please review whether it's OK or not.

Thanks
Wenyi
> Thanks
> Abner
> ----------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= --------------------
> *From:* Wenyi Xie <xiewenyi2@huawei.com>
> *Sent:* Wednesday, January 19, 2022 2:12 PM
> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner = (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server = BIOS) <nickle.wang@hpe.com>
> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewe= nyi2@huawei.com <xiewenyi2@huawei.com>
> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify st= atus check
>  
> Main Changes :
> 1.Remove redundant if statement.
>
> Wenyi Xie (1):
>   RedfishPkg/RedfishRestExDxe:Simplify status check
>
>  RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++--= ---------
>  1 file changed, 17 insertions(+), 21 deletions(-)
>
> --
> 2.20.1.windows.1
>
--_000_PH7PR84MB1885C8781C634D38B77E1811FF5A9PH7PR84MB1885NAMP_--