* [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch [not found] <cover.1643254453.git.min.m.xu@intel.com> @ 2022-01-27 3:36 ` Min Xu 2022-01-27 3:45 ` Abner Chang 0 siblings, 1 reply; 4+ messages in thread From: Min Xu @ 2022-01-27 3:36 UTC (permalink / raw) To: devel; +Cc: Min Xu, Leif Lindholm, Ard Biesheuvel, Abner Chang, Daniel Schaefer BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build error. Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Abner Chang <abner.chang@hpe.com> Cc: Daniel Schaefer <daniel.schaefer@hpe.com> Signed-off-by: Min Xu <min.m.xu@intel.com> --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index 92ae68f0d382..0a6d6925b7ea 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -291,7 +291,7 @@ FfsProcessSection ( UINT16 SectionAttribute; UINT32 AuthenticationStatus; CHAR8 *CompressedData; - UINTN CompressedDataLength; + UINT32 CompressedDataLength; *OutputBuffer = NULL; ParsedLength = 0; @@ -320,7 +320,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION2 *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION2); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION2); } else { CompressionSection = (EFI_COMPRESSION_SECTION *)Section; SectionLength = SECTION_SIZE (Section); @@ -330,7 +330,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION); } Status = UefiDecompressGetInfo ( -- 2.29.2.windows.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch 2022-01-27 3:36 ` [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Min Xu @ 2022-01-27 3:45 ` Abner Chang 2022-01-27 4:39 ` [edk2-devel] " Min Xu 0 siblings, 1 reply; 4+ messages in thread From: Abner Chang @ 2022-01-27 3:45 UTC (permalink / raw) To: Min Xu, devel@edk2.groups.io Cc: Leif Lindholm, Ard Biesheuvel, Schaefer, Daniel (ROM Janitor) [-- Attachment #1: Type: text/plain, Size: 2707 bytes --] Reviewed-by: Abner Chang <abner.chang@hpe.com> Please create a PR (give me the link) for running Core CI, I will merge it once it gets passed through. Thanks Abner ________________________________ From: Min Xu <min.m.xu@intel.com> Sent: Thursday, January 27, 2022 11:36 AM To: devel@edk2.groups.io <devel@edk2.groups.io> Cc: Min Xu <min.m.xu@intel.com>; Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Schaefer, Daniel (ROM Janitor) <daniel.schaefer@hpe.com> Subject: [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build error. Cc: Leif Lindholm <leif@nuviainc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Abner Chang <abner.chang@hpe.com> Cc: Daniel Schaefer <daniel.schaefer@hpe.com> Signed-off-by: Min Xu <min.m.xu@intel.com> --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index 92ae68f0d382..0a6d6925b7ea 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -291,7 +291,7 @@ FfsProcessSection ( UINT16 SectionAttribute; UINT32 AuthenticationStatus; CHAR8 *CompressedData; - UINTN CompressedDataLength; + UINT32 CompressedDataLength; *OutputBuffer = NULL; ParsedLength = 0; @@ -320,7 +320,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION2 *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION2); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION2); } else { CompressionSection = (EFI_COMPRESSION_SECTION *)Section; SectionLength = SECTION_SIZE (Section); @@ -330,7 +330,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION); } Status = UefiDecompressGetInfo ( -- 2.29.2.windows.2 [-- Attachment #2: Type: text/html, Size: 7704 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch 2022-01-27 3:45 ` Abner Chang @ 2022-01-27 4:39 ` Min Xu 2022-01-27 6:22 ` Abner Chang 0 siblings, 1 reply; 4+ messages in thread From: Min Xu @ 2022-01-27 4:39 UTC (permalink / raw) To: devel@edk2.groups.io, Chang, Abner Cc: Leif Lindholm, Ard Biesheuvel, Schaefer, Daniel [-- Attachment #1: Type: text/plain, Size: 3576 bytes --] This is the PR: https://github.com/tianocore/edk2/pull/2444 From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 11:46 AM To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Schaefer, Daniel <daniel.schaefer@hpe.com> Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Reviewed-by: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> Please create a PR (give me the link) for running Core CI, I will merge it once it gets passed through. Thanks Abner ________________________________ From: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>> Sent: Thursday, January 27, 2022 11:36 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; Schaefer, Daniel (ROM Janitor) <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>> Subject: [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build error. Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>> Cc: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>> Signed-off-by: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>> --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index 92ae68f0d382..0a6d6925b7ea 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -291,7 +291,7 @@ FfsProcessSection ( UINT16 SectionAttribute; UINT32 AuthenticationStatus; CHAR8 *CompressedData; - UINTN CompressedDataLength; + UINT32 CompressedDataLength; *OutputBuffer = NULL; ParsedLength = 0; @@ -320,7 +320,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION2 *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION2); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION2); } else { CompressionSection = (EFI_COMPRESSION_SECTION *)Section; SectionLength = SECTION_SIZE (Section); @@ -330,7 +330,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION); } Status = UefiDecompressGetInfo ( -- 2.29.2.windows.2 [-- Attachment #2: Type: text/html, Size: 9398 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch 2022-01-27 4:39 ` [edk2-devel] " Min Xu @ 2022-01-27 6:22 ` Abner Chang 0 siblings, 0 replies; 4+ messages in thread From: Abner Chang @ 2022-01-27 6:22 UTC (permalink / raw) To: devel@edk2.groups.io, min.m.xu@intel.com Cc: Leif Lindholm, Ard Biesheuvel, Schaefer, Daniel (ROM Janitor) [-- Attachment #1: Type: text/plain, Size: 4183 bytes --] Merged. ________________________________ From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Min Xu <min.m.xu@intel.com> Sent: Thursday, January 27, 2022 12:39 PM To: devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com> Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Schaefer, Daniel (ROM Janitor) <daniel.schaefer@hpe.com> Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch This is the PR: https://github.com/tianocore/edk2/pull/2444 From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 11:46 AM To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io Cc: Leif Lindholm <leif@nuviainc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Schaefer, Daniel <daniel.schaefer@hpe.com> Subject: Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Reviewed-by: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> Please create a PR (give me the link) for running Core CI, I will merge it once it gets passed through. Thanks Abner ________________________________ From: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>> Sent: Thursday, January 27, 2022 11:36 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> Cc: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>; Schaefer, Daniel (ROM Janitor) <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>> Subject: [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814<https://bugzilla.tianocore.org/show_bug.cgi?id=3814> CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build error. Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org<mailto:ardb+tianocore@kernel.org>> Cc: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> Cc: Daniel Schaefer <daniel.schaefer@hpe.com<mailto:daniel.schaefer@hpe.com>> Signed-off-by: Min Xu <min.m.xu@intel.com<mailto:min.m.xu@intel.com>> --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/PrePiLib/FwVol.c index 92ae68f0d382..0a6d6925b7ea 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -291,7 +291,7 @@ FfsProcessSection ( UINT16 SectionAttribute; UINT32 AuthenticationStatus; CHAR8 *CompressedData; - UINTN CompressedDataLength; + UINT32 CompressedDataLength; *OutputBuffer = NULL; ParsedLength = 0; @@ -320,7 +320,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION2 *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION2); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION2); } else { CompressionSection = (EFI_COMPRESSION_SECTION *)Section; SectionLength = SECTION_SIZE (Section); @@ -330,7 +330,7 @@ FfsProcessSection ( } CompressedData = (CHAR8 *)((EFI_COMPRESSION_SECTION *)Section + 1); - CompressedDataLength = (UINT32)SectionLength - sizeof (EFI_COMPRESSION_SECTION); + CompressedDataLength = SectionLength - sizeof (EFI_COMPRESSION_SECTION); } Status = UefiDecompressGetInfo ( -- 2.29.2.windows.2 [-- Attachment #2: Type: text/html, Size: 9244 bytes --] ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-27 6:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1643254453.git.min.m.xu@intel.com>
2022-01-27 3:36 ` [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Min Xu
2022-01-27 3:45 ` Abner Chang
2022-01-27 4:39 ` [edk2-devel] " Min Xu
2022-01-27 6:22 ` Abner Chang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox