* [PATCH v2 0/2] Migrate BaseCachingPciExpressLib
@ 2022-01-29 16:03 Abner Chang
2022-01-29 16:03 ` [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: " Abner Chang
2022-01-29 16:03 ` [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf Abner Chang
0 siblings, 2 replies; 6+ messages in thread
From: Abner Chang @ 2022-01-29 16:03 UTC (permalink / raw)
To: devel
Cc: abner.chang, Daniel Schaefer, Sunil V L, Ard Biesheuvel,
Jiewen Yao, Jordan Justen, Gerd Hoffmann, Leif Lindholm,
Sami Mujawar
Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
RISC-V Virt platform can leverage the same library to access PCI Express
registers through PCI Express base address set in PcdPciExpressBaseAddress
and cached in a global variable.
In V2: One patch for movement and ArmVirtPkg DSC file changes.
The patch [2/2] updates BaseCachingPciExpressLib.inf. Remove the
dependency with ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Abner Chang (2):
OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib
OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +++---
.../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++--
.../Library/BaseCachingPciExpressLib/PciExpressLib.c | 0
4 files changed, 6 insertions(+), 6 deletions(-)
rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (89%)
rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
--
2.31.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib
2022-01-29 16:03 [PATCH v2 0/2] Migrate BaseCachingPciExpressLib Abner Chang
@ 2022-01-29 16:03 ` Abner Chang
2022-01-29 18:42 ` [edk2-devel] " Ard Biesheuvel
2022-01-29 16:03 ` [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf Abner Chang
1 sibling, 1 reply; 6+ messages in thread
From: Abner Chang @ 2022-01-29 16:03 UTC (permalink / raw)
To: devel
Cc: abner.chang, Daniel Schaefer, Sunil V L, Ard Biesheuvel,
Jiewen Yao, Jordan Justen, Gerd Hoffmann
Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
RISC-V Virt platform can leverage the same library to access PCI Express
registers through PCI Express base address set in PcdPciExpressBaseAddress
and cached in a global variable.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +++---
.../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 0
.../Library/BaseCachingPciExpressLib/PciExpressLib.c | 0
4 files changed, 4 insertions(+), 4 deletions(-)
rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (100%)
rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 5a1598d90c..4db8ad5a79 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -141,7 +141,7 @@
# PCI Libraries
PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
- PciExpressLib|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
+ PciExpressLib|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf
PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
index 9d23072d8f..4a54d13735 100644
--- a/ArmVirtPkg/ArmVirtKvmTool.dsc
+++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
@@ -339,17 +339,17 @@
ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf {
<LibraryClasses>
NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
- NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
+ NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
}
MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
<LibraryClasses>
NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
- NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
+ NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
}
MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf {
<LibraryClasses>
NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
- NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
+ NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
}
OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
OvmfPkg/Virtio10Dxe/Virtio10.inf
diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
similarity index 100%
rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
rename to OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c b/OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
similarity index 100%
rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
rename to OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
2022-01-29 16:03 [PATCH v2 0/2] Migrate BaseCachingPciExpressLib Abner Chang
2022-01-29 16:03 ` [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: " Abner Chang
@ 2022-01-29 16:03 ` Abner Chang
2022-01-29 17:16 ` [edk2-devel] " Ard Biesheuvel
1 sibling, 1 reply; 6+ messages in thread
From: Abner Chang @ 2022-01-29 16:03 UTC (permalink / raw)
To: devel
Cc: abner.chang, Daniel Schaefer, Sunil V L, Ard Biesheuvel,
Jiewen Yao, Jordan Justen, Gerd Hoffmann, Leif Lindholm,
Sami Mujawar
Remove the dependency with ArmVirtPkg and add RISCV64 in VALID_ARCHITECTURES.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Sunil V L <sunilvl@ventanamicro.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
---
.../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
index 33568f568f..0383a37cbf 100644
--- a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
+++ b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
@@ -21,15 +21,15 @@
CONSTRUCTOR = PciExpressLibInitialize
#
-# VALID_ARCHITECTURES = ARM AARCH64
+# VALID_ARCHITECTURES = ARM AARCH64 RISCV64
#
[Sources]
PciExpressLib.c
[Packages]
- ArmVirtPkg/ArmVirtPkg.dec
MdePkg/MdePkg.dec
+ OvmfPkg/OvmfPkg.dec
[LibraryClasses]
BaseLib
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
2022-01-29 16:03 ` [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf Abner Chang
@ 2022-01-29 17:16 ` Ard Biesheuvel
2022-01-30 3:38 ` Abner Chang
0 siblings, 1 reply; 6+ messages in thread
From: Ard Biesheuvel @ 2022-01-29 17:16 UTC (permalink / raw)
To: edk2-devel-groups-io, Abner Chang
Cc: Daniel Schaefer, Sunil V L, Ard Biesheuvel, Jiewen Yao,
Jordan Justen, Gerd Hoffmann, Leif Lindholm, Sami Mujawar
On Sat, 29 Jan 2022 at 18:05, Abner Chang <abner.chang@hpe.com> wrote:
>
> Remove the dependency with ArmVirtPkg and add RISCV64 in VALID_ARCHITECTURES.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> ---
> .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> index 33568f568f..0383a37cbf 100644
> --- a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> +++ b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> @@ -21,15 +21,15 @@
> CONSTRUCTOR = PciExpressLibInitialize
>
> #
> -# VALID_ARCHITECTURES = ARM AARCH64
> +# VALID_ARCHITECTURES = ARM AARCH64 RISCV64
> #
>
I am going to fold the above hunk into patch #1, given that
> [Sources]
> PciExpressLib.c
>
> [Packages]
> - ArmVirtPkg/ArmVirtPkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
this change is unnecessary - either package reference is unnecessary
so I will just drop the reference to ArmVirtPkg/ArmVirtPkg.dec when
moving it.
> [LibraryClasses]
> BaseLib
> --
> 2.31.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86214): https://edk2.groups.io/g/devel/message/86214
> Mute This Topic: https://groups.io/mt/88770183/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: Migrate BaseCachingPciExpressLib
2022-01-29 16:03 ` [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: " Abner Chang
@ 2022-01-29 18:42 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2022-01-29 18:42 UTC (permalink / raw)
To: edk2-devel-groups-io, Abner Chang
Cc: Daniel Schaefer, Sunil V L, Ard Biesheuvel, Jiewen Yao,
Jordan Justen, Gerd Hoffmann
On Sat, 29 Jan 2022 at 18:05, Abner Chang <abner.chang@hpe.com> wrote:
>
> Move BaseCachingPciExpressLib library from ArmVirtPkg to under OvmfPkg.
> RISC-V Virt platform can leverage the same library to access PCI Express
> registers through PCI Express base address set in PcdPciExpressBaseAddress
> and cached in a global variable.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
> ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
> ArmVirtPkg/ArmVirtKvmTool.dsc | 6 +++---
> .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 0
> .../Library/BaseCachingPciExpressLib/PciExpressLib.c | 0
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf (100%)
> rename {ArmVirtPkg => OvmfPkg}/Library/BaseCachingPciExpressLib/PciExpressLib.c (100%)
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Pushed as #2456
with the INF [Packages] reference to ArmVirtPkg.dec dropped, and
RISCV64 added to the INF VALID_ARCHITECTURES declaration.
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 5a1598d90c..4db8ad5a79 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -141,7 +141,7 @@
>
> # PCI Libraries
> PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf
> - PciExpressLib|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> + PciExpressLib|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> PciCapLib|OvmfPkg/Library/BasePciCapLib/BasePciCapLib.inf
> PciCapPciSegmentLib|OvmfPkg/Library/BasePciCapPciSegmentLib/BasePciCapPciSegmentLib.inf
> PciCapPciIoLib|OvmfPkg/Library/UefiPciCapPciIoLib/UefiPciCapPciIoLib.inf
> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc
> index 9d23072d8f..4a54d13735 100644
> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc
> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc
> @@ -339,17 +339,17 @@
> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf {
> <LibraryClasses>
> NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> }
> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf {
> <LibraryClasses>
> NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> }
> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf {
> <LibraryClasses>
> NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> - NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> + NULL|OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> }
> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
> OvmfPkg/Virtio10Dxe/Virtio10.inf
> diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> similarity index 100%
> rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> rename to OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> diff --git a/ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c b/OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
> similarity index 100%
> rename from ArmVirtPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
> rename to OvmfPkg/Library/BaseCachingPciExpressLib/PciExpressLib.c
> --
> 2.31.1
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#86212): https://edk2.groups.io/g/devel/message/86212
> Mute This Topic: https://groups.io/mt/88770178/5717338
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb+tianocore@kernel.org]
> ------------
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
2022-01-29 17:16 ` [edk2-devel] " Ard Biesheuvel
@ 2022-01-30 3:38 ` Abner Chang
0 siblings, 0 replies; 6+ messages in thread
From: Abner Chang @ 2022-01-30 3:38 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel-groups-io
Cc: Schaefer, Daniel (ROM Janitor), Sunil V L, Ard Biesheuvel,
Jiewen Yao, Jordan Justen, Gerd Hoffmann, Leif Lindholm,
Sami Mujawar
> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Sunday, January 30, 2022 1:17 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Chang, Abner (HPS
> SW/FW Technologist) <abner.chang@hpe.com>
> Cc: Schaefer, Daniel (ROM Janitor) <daniel.schaefer@hpe.com>; Sunil V L
> <sunilvl@ventanamicro.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>;
> Jiewen Yao <jiewen.yao@intel.com>; Jordan Justen
> <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Leif
> Lindholm <leif@nuviainc.com>; Sami Mujawar <sami.mujawar@arm.com>
> Subject: Re: [edk2-devel] [PATCH v2 2/2]
> OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf
>
> On Sat, 29 Jan 2022 at 18:05, Abner Chang <abner.chang@hpe.com> wrote:
> >
> > Remove the dependency with ArmVirtPkg and add RISCV64 in
> VALID_ARCHITECTURES.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> > Cc: Sunil V L <sunilvl@ventanamicro.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Sami Mujawar <sami.mujawar@arm.com>
> > ---
> > .../BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> > index 33568f568f..0383a37cbf 100644
> > ---
> a/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> > +++
> b/OvmfPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf
> > @@ -21,15 +21,15 @@
> > CONSTRUCTOR = PciExpressLibInitialize
> >
> > #
> > -# VALID_ARCHITECTURES = ARM AARCH64
> > +# VALID_ARCHITECTURES = ARM AARCH64 RISCV64
> > #
> >
>
> I am going to fold the above hunk into patch #1, given that
>
> > [Sources]
> > PciExpressLib.c
> >
> > [Packages]
> > - ArmVirtPkg/ArmVirtPkg.dec
> > MdePkg/MdePkg.dec
> > + OvmfPkg/OvmfPkg.dec
> >
>
> this change is unnecessary - either package reference is unnecessary
> so I will just drop the reference to ArmVirtPkg/ArmVirtPkg.dec when
> moving it.
[Abner]
Thanks.
Yes, adding OvmfPkg is redundant.
BTW, I saw CI reported the errors on this merge. However, those errors seem irrelevant to the code changes. Does that matter?
https://github.com/tianocore/edk2/runs/4992385347
Abner
>
> > [LibraryClasses]
> > BaseLib
> > --
> > 2.31.1
> >
> >
> >
> > ------------
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#86214):
> https://edk2.groups.io/g/devel/message/86214
> > Mute This Topic: https://groups.io/mt/88770183/5717338
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [ardb+tianocore@kernel.org]
> > ------------
> >
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-30 3:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-29 16:03 [PATCH v2 0/2] Migrate BaseCachingPciExpressLib Abner Chang
2022-01-29 16:03 ` [PATCH v2 1/2] OvmfPkg/BaseCachingPciExpressLib: " Abner Chang
2022-01-29 18:42 ` [edk2-devel] " Ard Biesheuvel
2022-01-29 16:03 ` [PATCH v2 2/2] OvmfPkg/BaseCachingPciExpressLib: Update BaseCachingPciExpressLib.inf Abner Chang
2022-01-29 17:16 ` [edk2-devel] " Ard Biesheuvel
2022-01-30 3:38 ` Abner Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox