From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.23905.1643252471282911322 for ; Wed, 26 Jan 2022 19:01:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=FErHCY9k; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=00263292e4=abner.chang@hpe.com) Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20R1WXQp006263 for ; Thu, 27 Jan 2022 03:01:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pps0720; bh=KMMKPCOf7AVFYDMX+mdqNCMGV+GUm6tgSsboJ2fxRfg=; b=FErHCY9kSNL9u65RnHxv64dSMETRWNJUaA0q+Na0e6JUQXytuhit1zic+JMqgBtCH89T +eeflKrUJ6UBcxx+UKdASw63EJYnMO9P8+1g1uDEcgpr/kkv9BRRTMAcVB4nTWnOnOE3 etIMLlqcOPuiwB2tMfmTBiLjm8jbz7vXSPC67zJ4X0hORYtbXXLjKXjLpSqRU27aAcNW jm+Ti4O7JIDgjGHilRdDfpLjuENMqOSb7+MyRdGQbrGXj/G3dBwUFMegYu30UmaI2Of3 VY9d5MDaz0zvHL0DZhQ1xArRHGk2VgiGe6TfEziE4adD+QwQ5k+D2c6iUHFdMk71e3hv pg== Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3du4pxy576-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 27 Jan 2022 03:01:09 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 26BA574 for ; Thu, 27 Jan 2022 03:01:08 +0000 (UTC) Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 27 Jan 2022 03:01:08 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W9336.americas.hpqcorp.net (2002:10d0:2156::10d0:2156) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Thu, 27 Jan 2022 03:01:07 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Thu, 27 Jan 2022 03:01:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J6f2OR8E8M6K268vM9JGzij8Qt+TFS2svYT0KKyZTvnMKfYNN+0lkbMz70d858fLBpIL/TO50IKhoh/ydTwa72mC4FNvb04Ukaay/Kn0hwt5wA5bUl1xx3zkChhTFmXNlCyNn6munoj59s88EhHYEeoZI7zLBTsF9Qxgcr7xDh3vxhOQVj+P6wRzPzqeoBdilh1Bj7pZkelzwn10dX6bgL6dZX/sFYtB78+BhJd4tDJ8sGh4rlQNEEj1bp6RC+hqAdkaR3vLzsmoO5QXTqdNZmUT5/2yot4IdBQe830kCbVa8Z+eGOQvFhc3ZU1fS4KxFoHcwKxCnfmnwZsmn8gF7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fOGm0LiuU9swPTuqKqWW6OJVkEQ4phjeq6em8GwS8Lw=; b=R+HjXdSoM4ccNxKHkSVBduJ9vhNa+eV8y/pHGECHPLypSrz8aXLYYA6PuZk8kbJdkasEQHt9kcXIXFy7m1X8gJPOu1UhDSLxs2B9dmakEWEImHXBcTl6XrL3EVUQg0yd47l+etrFQG7h+x31VQYEiJ7uZk/CS52Be3H4qf7icOhCbcK/bJeklMUpnRB6B3ld4JUSTWF9GC/PvLr+xEnNQf3hrGbzLzhLZP8Zqkws9ki7ExA+wDMVli96AwLQBHNjn0DghouJ8E9mbT6MIWO9YUgukGrk0jFVpzySfcyLA8wKm19bO/x7VEjd5rrUVllNukHYOakOCDhR0weBmWVGGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:510:154::18) by MW5PR84MB2083.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1c5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Thu, 27 Jan 2022 03:01:05 +0000 Received: from PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55]) by PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM ([fe80::29fe:6cc2:38e0:4b55%6]) with mapi id 15.20.4867.011; Thu, 27 Jan 2022 03:01:05 +0000 From: "Abner Chang" To: "Xu, Min M" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Topic: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch Thread-Index: AQHYEbXhwREv1NaLr0CCeQJp4pIybqxz1x4wgAIywW+AAAS2gIAAD6pqgAAMpoCAAAUnSw== Date: Thu, 27 Jan 2022 03:01:05 +0000 Message-ID: References: <20220125063318.862-1-min.m.xu@intel.com> <20220125063318.862-2-min.m.xu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: 9adcfe48-52b7-fb7c-e433-bc912c216ece x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9bad280-e808-4a82-a1a8-08d9e14142b0 x-ms-traffictypediagnostic: MW5PR84MB2083:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RS4fnUclcen5q0oyROTp9Mg24cIthez8jKumPlGwkUISGukte8qEb8cbiNIAD7OmWxEb3w/tMPSj75L0m9pazhuK6KT4umx7bXYScZBhPzNFUx40OkYhzF82C4z/6TBMkbmLpKqUXVSabm+AgXMsbvak4UU75xhRqP3G+2qp8w5Vp/Wm6dFAozF9C5KDf6ER5TdVB0UPxGj8w5Y32ovrxvyCFBN7wyUE2MpYfVZisPDVP/6YSI9i4reTv7HVriHOQ/dJawsKd93jm9afO9UQ5eTtpcQNIIAjm9GiEzMBuCz0oPuZ+1cb8qz/G6DIIj/mpzreAckv2eDxjbOagT9eL3y+bMAlS2sqRduGRxnkzYVhplMpuC+s70+q78ezR2zN06wVx7hpHvxvnvsTNCDbWy6IVce5qz6x0Qb4fVFx1a5ks2TnATM1F+9SrSdaqbXru8i6ylY1nCj/D5mqLEB06PI+KrdyoojF3TDF2EkUeT2kwl4wPb/mtgrqFi/JIgSIFTO5tF4Vg+TGB1/6G7n0TweZGlCc9fNKdWZ2wCY5Gr8mCjkkVX8hul6vr3fzhIpaHcuu9n6BD9Tiy/oH0Gp2g3zGPzW6zKCmueX1Kbe1p0iABwFa0o6uuQRB3lSPtuf6F1aQ2+2QBvzsWTxjHqH+KTkjlRz+LDV+j0OVZaQEiKelyNh2HYTq1mYf9UOInWrO+Qinlx8fyxzpbWo6vYo4QPbCBsa2Cxk+fAQqifXwF0vXI6f2oeLl4CZxjWp5J4EScvTUcF4xEIhHzvA0qDUKWvRVcEATI+nVBw0HtZqR4G5Aax3O5auElUUscC49amm9JkbmBQ6cw3W6ypJ0LpFEZA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(6029001)(366004)(508600001)(122000001)(966005)(19627405001)(55016003)(2906002)(166002)(19627235002)(110136005)(38070700005)(82960400001)(38100700002)(8676002)(8936002)(76236003)(64756008)(91956017)(66446008)(316002)(66476007)(33656002)(66946007)(66556008)(76116006)(83380400001)(86362001)(186003)(26005)(71200400001)(52536014)(53546011)(9686003)(7696005)(5660300002)(6506007)(55236004)(20210929001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?NKw0Yd99sTVZ2+usIADT09kUqp9gWXkwTyFk2Yy1ct5Okg+RiBYJ4u/C?= =?Windows-1252?Q?tfGRYnR9zwanqfrverdy5Qka9TAyUxQSmHg2yC8z32QWeMe7yosOzSM0?= =?Windows-1252?Q?p+RJMbjo9KRNWnj7mBDqFrpq8tgEhIdX0QIA3oo7/iROKBfjSOFnpSuC?= =?Windows-1252?Q?g/LJ+noZykFUNJCT599EdjBUgTNihw+8DbM2+MjivvGFA6X5P/q+q3eS?= =?Windows-1252?Q?PRXLHyjDSt5LLwgvEUFNAekQH3ryzJj7XVPX6RYdbCv/KxsG3crQdL8C?= =?Windows-1252?Q?JynOXzFmRxRfwrpUux6aZOxT6NAMHDy2L61W7VXrcfMo36Jqych+Tmj0?= =?Windows-1252?Q?lQzRci0pKuV8XFEuBriGsX+5W+tq5r6kyN9/a/cfWdnpcsgahz8nRGMH?= =?Windows-1252?Q?MBLId9qtD3YSysROcA459+vdceinBiD/Q0SQAbfbmh3BdlhiMFnFZru9?= =?Windows-1252?Q?UuSCicmHmMi3ikiizSDhcAAJqRnF/oYhqGcU08eyiKZM2rEEHMaDO22M?= =?Windows-1252?Q?59Tq8tWDlUpLL3RErOUDpAjgkQewXZJU4/FFfuqD06lcsAlZcG4Rt+Xw?= =?Windows-1252?Q?07hfuNOkDDcMYkkYGRmRDbFYGTq/Sa3sYY9J+Gu85r/0q4ovl6uohw9p?= =?Windows-1252?Q?HA0lDUWNotQCg6LPMWfBEYNO+9Z3y27vDdK6jgfPiZw/CGEVjufUPXAM?= =?Windows-1252?Q?XnszGfXdrs/6jrKQDGzCz/RADe3d0gSZEdI+/4LQudZXPFKsM+bv2v63?= =?Windows-1252?Q?pJEKXlusd50x0yxHJkwA+K+mqyqfQQbs3o4AyoNOsc4G3X78lFP17DRX?= =?Windows-1252?Q?FaETbbofZC3/YFZZJAjdZ7+SLTp4Sxm/W6wxHa8Y7iwMogfszjNur5Ga?= =?Windows-1252?Q?Os5gFS2o3Bf2P8mWJ4Xxp6KpaduaaYe9jHoma0HphorVKyu3OWbN0GCl?= =?Windows-1252?Q?erFx7q7O5MKmFAvxcnNs1KQWS7D8EbJwvo1CeZtwv8FAoaCqOE5LW1t6?= =?Windows-1252?Q?a+eE1zJV8yDop4o7Gom9GPRAonkBmxpqMuYxlRBwVh2ZKfd0jy1LTXaP?= =?Windows-1252?Q?0aga3TrQ8hEgcDMqoyAASQLTEaq6X4V5+HWsEGAjerU3eHcbmFZYUHzx?= =?Windows-1252?Q?BnsArE6Y1xF/5V0OQ/4GFOVhXi+c5XijO1Ps/U+4AUn2rKeI51EImiRX?= =?Windows-1252?Q?n0r044P6stDYn8RAyh9tEazbaWkz4Ti48QVAoltXZc9vjGBSkgJVgTov?= =?Windows-1252?Q?u0igXJfURF6Sge+6zndZWbBGa767V1f+Uz/3LHWVsVrIbm3IZmSGsAa1?= =?Windows-1252?Q?bYqFIMO3HghZBdqdy5ZBpfnzYBIz7WePmNY4t0VU1792FshWqUuvPbpj?= =?Windows-1252?Q?xsQJOC8+1nh6Ei9uXdFi3PTzgdQs0jDnf7Lq9SLxtmq/QpGFUTFoDBA2?= =?Windows-1252?Q?B0K2DBthFRqEBatrz7HQlGBepO8EHT/ufcoEperBgSFsIXWp3UCesA7Q?= =?Windows-1252?Q?GTQVVF6P1gfYDDbVu4My6N0kArV7yFEbl35DQVZUv+UDmANikR0ZVmLw?= =?Windows-1252?Q?vndt+XgLpYxGnFozz8EgW6FJF0uaZdep4f44luLgsWnT1f+Lkrp6yBaq?= =?Windows-1252?Q?jXNdR5MTwxjiGBqqKlE5GrhPDWYga6ixkc4N2dbfI5E78OVUcuGijljz?= =?Windows-1252?Q?QX7ktfHzVMpclMVFzvPeLkixRGG0HdqZkUBmYSK/FWCcR0Mi5wPi3EI5?= =?Windows-1252?Q?ahVGf6GI6ZgBq2Z/Py8=3D?= X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: c9bad280-e808-4a82-a1a8-08d9e14142b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2022 03:01:05.6225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r5tDdvzakOlftkmRA9ULmVKsVxiPVdAIwoml3sJfdKr+HB3KZSzbb8WDbMpmGnfVCek+0iJwVYHelPR+9BCEAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB2083 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: qfB0B9Hr32hSJ7urHvSorU0i3OEBEmPH X-Proofpoint-ORIG-GUID: qfB0B9Hr32hSJ7urHvSorU0i3OEBEmPH X-Proofpoint-UnRewURL: 10 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-26_09,2022-01-26_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 spamscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201270016 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_PH7PR84MB1885FE6DA845378C19F16E36FF219PH7PR84MB1885NAMP_" --_000_PH7PR84MB1885FE6DA845378C19F16E36FF219PH7PR84MB1885NAMP_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable yes, I can do that if you separate it to a standalone patch. This change do= esn't hurt others. Abner ________________________________ From: Xu, Min M Sent: Thursday, January 27, 2022 10:39 AM To: Chang, Abner (HPS SW/FW Technologist) ; devel@edk2= .groups.io Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi, Abner Other patches are still in review. I am thinking if this patch can be in a = separate patch-sets so that you can merge it to EmbeddedPkg? What=92s your = thought? Thanks Min From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, January 27, 2022 9:56 AM To: Xu, Min M ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi Min, Did you get the reviewed-by for other patches? Just let me know when the re= view process is done, I can then merge the patch to EmbeddedPkg. Regards, Abner ________________________________ From: Xu, Min M > Sent: Thursday, January 27, 2022 8:58 AM To: devel@edk2.groups.io >; Chang, Abner (HPS SW/FW Technologist) > Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi, Abner This is the PR of the patch-sets. https://github.com/tianocore/edk2/pull/2313 Thanks Min From: devel@edk2.groups.io > On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 8:43 AM To: devel@edk2.groups.io; Xu, Min M > Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Hi Min, Would you please create a PR for this and point me to the link? Thanks Abner ________________________________ From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, January 25, 2022 11:09 PM To: devel@edk2.groups.io >; min.m.xu@intel.com > Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error i= n FwVol.c in X64 arch Reviewed-by: Abner Chang > > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Min Xu > Sent: Tuesday, January 25, 2022 2:33 PM > To: devel@edk2.groups.io > Cc: Min Xu >; Leif Lindholm= >; Ard > Biesheuvel >;= Chang, Abner (HPS SW/FW > Technologist) >; Schaefer= , Daniel (ROM Janitor) > > > Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in > FwVol.c in X64 arch > > RFC: > INVALID URI REMOVED > d=3D3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W > WWyZKgREYswYM1Tz0$ > > CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. > But the second parameter of UefiDecompressGetInfo() is declared as > UINT32. So a build error is triggered. To declare CompressedDataLength > as UINT32 to fix the build error. > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Abner Chang > > Cc: Daniel Schaefer > > Signed-off-by: Min Xu > > --- > EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c > b/EmbeddedPkg/Library/PrePiLib/FwVol.c > index 92ae68f0d382..0a6d6925b7ea 100644 > --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c > +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c > @@ -291,7 +291,7 @@ FfsProcessSection ( > UINT16 SectionAttribute; > UINT32 AuthenticationStatus; > CHAR8 *CompressedData; > - UINTN CompressedDataLength; > + UINT32 CompressedDataLength; > > *OutputBuffer =3D NULL; > ParsedLength =3D 0; > @@ -320,7 +320,7 @@ FfsProcessSection ( > } > > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION2 > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION2); > } else { > CompressionSection =3D (EFI_COMPRESSION_SECTION *)Section; > SectionLength =3D SECTION_SIZE (Section); > @@ -330,7 +330,7 @@ FfsProcessSection ( > } > > CompressedData =3D (CHAR8 *)((EFI_COMPRESSION_SECTION > *)Section + 1); > - CompressedDataLength =3D (UINT32)SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > + CompressedDataLength =3D SectionLength - sizeof > (EFI_COMPRESSION_SECTION); > } > > Status =3D UefiDecompressGetInfo ( > -- > 2.29.2.windows.2 > > > > > --_000_PH7PR84MB1885FE6DA845378C19F16E36FF219PH7PR84MB1885NAMP_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
yes, I can do that if you separate it to a standalone patch. This change do= esn't hurt others.

Abner
From: Xu, Min M <min.m.x= u@intel.com>
Sent: Thursday, January 27, 2022 10:39 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>= ;; devel@edk2.groups.io <devel@edk2.groups.io>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch
 

Hi, Abner

Other patches are still in review. I am thinking i= f this patch can be in a separate patch-sets so that you can merge it to Em= beddedPkg? What=92s your thought?

 

Thanks

Min

From: Chang, Abner (HPS SW/FW Technologist)= <abner.chang@hpe.com>
Sent: Thursday, January 27, 2022 9:56 AM
To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Hi Min,

Did you get the reviewed-by for other patches? Just = let me know when the review process is done, I can then merge the patch to = EmbeddedPkg.

 

Regards,

Abner

From: Xu, Min M <min.m.xu@intel.com>
Sent: Thursday, January 27, 2022 8:58 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; = Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Hi, Abner

This is the PR of the patch-sets.

https://github.com/tianocore/edk2/pull/2313

 

Thanks

Min

 

Hi Min,

Would you please create a PR for this and point me = to the link?

 

Thanks

Abner

From: Chang, Abner (HPS SW/FW Technologist)
Sent: Tuesday, January 25, 2022 11:09 PM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; min.m.xu@intel.com <min.m.xu@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build = error in FwVol.c in X64 arch

 

Reviewed-by: Abner= Chang <abner.chang@hpe.com&g= t;

> -----Original Message-----
> From: devel@edk2.groups.io= <devel@edk2.groups.io> O= n Behalf Of Min Xu
> Sent: Tuesday, January 25, 2022 2:33 PM
> To: devel@edk2.groups.io > Cc: Min Xu <min.m.xu@intel.co= m>; Leif Lindholm <leif@nuvi= ainc.com>; Ard
> Biesheuvel <ardb+tiano= core@kernel.org>; Chang, Abner (HPS SW/FW
> Technologist) <abner.chang@h= pe.com>; Schaefer, Daniel (ROM Janitor)
> <daniel.schaefer@hpe.com= >
> Subject: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error = in
> FwVol.c in X64 arch
>
> RFC:
> INVALID URI REMOVED
> d=3D3429__;!!NpxR!xMRxJim2LXdgV0CClUrT7jWBUouLzrVwMc5fB_wt1PT17W
> WWyZKgREYswYM1Tz0$
>
> CompressedDataLength is declared as UINTN which is UINT64 in X64 arch.=
> But the second parameter of UefiDecompressGetInfo() is declared as
> UINT32. So a build error is triggered. To declare CompressedDataLength=
> as UINT32 to fix the build error.
>
> Cc: Leif Lindholm <leif@nuviai= nc.com>
> Cc: Ard Biesheuvel <ar= db+tianocore@kernel.org>
> Cc: Abner Chang <abner.chang= @hpe.com>
> Cc: Daniel Schaefer <dan= iel.schaefer@hpe.com>
> Signed-off-by: Min Xu <min.m.= xu@intel.com>
> ---
>  EmbeddedPkg/Library/PrePiLib/FwVol.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> index 92ae68f0d382..0a6d6925b7ea 100644
> --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c
> +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c
> @@ -291,7 +291,7 @@ FfsProcessSection (
>    UINT16       &nbs= p;            Sectio= nAttribute;
>    UINT32       &nbs= p;            Authen= ticationStatus;
>    CHAR8        = ;             *= CompressedData;
> -  UINTN         &nb= sp;           CompressedD= ataLength;
> +  UINT32         &n= bsp;          CompressedDataLe= ngth;
>
>    *OutputBuffer =3D NULL;
>    ParsedLength  =3D 0;
> @@ -320,7 +320,7 @@ FfsProcessSection (
>            } >
>            Comp= ressedData       =3D (CHAR8 *)((EFI_COMPRESSI= ON_SECTION2
> *)Section + 1);
> -          CompressedData= Length =3D (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
> +          CompressedData= Length =3D SectionLength - sizeof
> (EFI_COMPRESSION_SECTION2);
>          } else {
>            Comp= ressionSection =3D (EFI_COMPRESSION_SECTION *)Section;
>            Sect= ionLength      =3D SECTION_SIZE (Section);
> @@ -330,7 +330,7 @@ FfsProcessSection (
>            } >
>            Comp= ressedData       =3D (CHAR8 *)((EFI_COMPRESSI= ON_SECTION
> *)Section + 1);
> -          CompressedData= Length =3D (UINT32)SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
> +          CompressedData= Length =3D SectionLength - sizeof
> (EFI_COMPRESSION_SECTION);
>          }
>
>          Status =3D UefiD= ecompressGetInfo (
> --
> 2.29.2.windows.2
>
>
>
>
>

--_000_PH7PR84MB1885FE6DA845378C19F16E36FF219PH7PR84MB1885NAMP_--