* [edk2-devel] [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
@ 2024-05-02 11:15 Praveen Sankar N via groups.io
2024-05-06 2:23 ` [edk2-devel] 回复: " gaoliming via groups.io
0 siblings, 1 reply; 6+ messages in thread
From: Praveen Sankar N via groups.io @ 2024-05-02 11:15 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: gaoliming@byosoft.com.cn, Srinivasan Mani, Sundaresan S,
michael.d.kinney@intel.com, zhiguang.liu@intel.com,
Felix Polyudov, Rabisha R
In SPCR table, 4 structure members have been added newly as per SPCR
table Revision 4, which has to be added in
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
Signed-off-by: Praveen Sankar N praveensankarn@ami.com
Cc: michael.d.kinney@intel.com
Cc: gaoliming@byosoft.com.cn
Cc: zhiguang.liu@intel.com
Cc: Felixp@ami.com
Cc: srinivasanm@ami.com
Cc: sundaresans@ami.com
Cc: rabishar@ami.com
---
.../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
index eb5ae28390..bf967880ab 100644
--- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
+++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
@@ -23,6 +23,7 @@
///
#define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
+#define EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x04
///
/// Serial Port Console Redirection Table Format
///
@@ -50,6 +51,37 @@ typedef struct {
UINT32 Reserved3;
} EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
+///
+/// Serial Port Console Redirection Table Format Revision 4
+///
+typedef struct {
+ EFI_ACPI_DESCRIPTION_HEADER Header;
+ UINT8 InterfaceType;
+ UINT8 Reserved1[3];
+ EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
+ UINT8 InterruptType;
+ UINT8 Irq;
+ UINT32 GlobalSystemInterrupt;
+ UINT8 BaudRate;
+ UINT8 Parity;
+ UINT8 StopBits;
+ UINT8 FlowControl;
+ UINT8 TerminalType;
+ UINT8 Reserved2;
+ UINT16 PciDeviceId;
+ UINT16 PciVendorId;
+ UINT8 PciBusNumber;
+ UINT8 PciDeviceNumber;
+ UINT8 PciFunctionNumber;
+ UINT32 PciFlags;
+ UINT8 PciSegment;
+ UINT32 UartClockFrequency;
+ UINT32 PreciseBaudRate;
+ UINT16 NameSpaceStrLength;
+ UINT16 NameSpaceStrOffset;
+ CHAR8 NameSpaceString[0];
+} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
+
#pragma pack()
//
--
2.38.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118695): https://edk2.groups.io/g/devel/message/118695
Mute This Topic: https://groups.io/mt/105984701/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
2024-05-02 11:15 [edk2-devel] [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure Praveen Sankar N via groups.io
@ 2024-05-06 2:23 ` gaoliming via groups.io
2024-05-09 6:33 ` Praveen Sankar N via groups.io
0 siblings, 1 reply; 6+ messages in thread
From: gaoliming via groups.io @ 2024-05-06 2:23 UTC (permalink / raw)
To: 'Praveen Sankar N', devel
Cc: 'Srinivasan Mani', 'Sundaresan S',
michael.d.kinney, zhiguang.liu, 'Felix Polyudov',
'Rabisha R'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Praveen Sankar N <praveensankarn@ami.com>
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; Srinivasan Mani <srinivasanm@ami.com>;
> Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> <rabishar@ami.com>
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
>
> Signed-off-by: Praveen Sankar N praveensankarn@ami.com
>
> Cc: michael.d.kinney@intel.com
>
> Cc: gaoliming@byosoft.com.cn
>
> Cc: zhiguang.liu@intel.com
>
> Cc: Felixp@ami.com
>
> Cc: srinivasanm@ami.com
>
> Cc: sundaresans@ami.com
>
> Cc: rabishar@ami.com
> ---
> .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
>
>
>
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
>
> ///
>
> /// Serial Port Console Redirection Table Format
>
> ///
>
> @@ -50,6 +51,37 @@ typedef struct {
> UINT32 Reserved3;
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> +///
>
> +/// Serial Port Console Redirection Table Format Revision 4
>
> +///
>
> +typedef struct {
>
> + EFI_ACPI_DESCRIPTION_HEADER Header;
>
> + UINT8 InterfaceType;
>
> + UINT8 Reserved1[3];
>
> + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
>
> + UINT8 InterruptType;
>
> + UINT8 Irq;
>
> + UINT32
> GlobalSystemInterrupt;
>
> + UINT8 BaudRate;
>
> + UINT8 Parity;
>
> + UINT8 StopBits;
>
> + UINT8 FlowControl;
>
> + UINT8 TerminalType;
>
> + UINT8 Reserved2;
>
> + UINT16 PciDeviceId;
>
> + UINT16 PciVendorId;
>
> + UINT8 PciBusNumber;
>
> + UINT8 PciDeviceNumber;
>
> + UINT8 PciFunctionNumber;
>
> + UINT32 PciFlags;
>
> + UINT8 PciSegment;
>
> + UINT32 UartClockFrequency;
>
> + UINT32 PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
> +
>
> #pragma pack()
>
>
>
> //
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118578): https://edk2.groups.io/g/devel/message/118578
Mute This Topic: https://groups.io/mt/105933234/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
2024-05-06 2:23 ` [edk2-devel] 回复: " gaoliming via groups.io
@ 2024-05-09 6:33 ` Praveen Sankar N via groups.io
2024-05-09 6:34 ` Praveen Sankar N via groups.io
2024-05-10 0:46 ` 回复: " gaoliming via groups.io
0 siblings, 2 replies; 6+ messages in thread
From: Praveen Sankar N via groups.io @ 2024-05-09 6:33 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: Srinivasan Mani, Sundaresan S, michael.d.kinney@intel.com,
zhiguang.liu@intel.com, Felix Polyudov, Rabisha R
Hi Liming,
Pull request is done and pipelines are built successfully and the patch is ready to push to the master.
Thanks,
Praveen Sankar
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Monday, May 6, 2024 7:53 AM
To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Praveen Sankar N <praveensankarn@ami.com>
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; Srinivasan Mani <srinivasanm@ami.com>;
> Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> <rabishar@ami.com>
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
>
> Signed-off-by: Praveen Sankar N praveensankarn@ami.com
>
> Cc: michael.d.kinney@intel.com
>
> Cc: gaoliming@byosoft.com.cn
>
> Cc: zhiguang.liu@intel.com
>
> Cc: Felixp@ami.com
>
> Cc: srinivasanm@ami.com
>
> Cc: sundaresans@ami.com
>
> Cc: rabishar@ami.com
> ---
> .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
>
>
>
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
>
> ///
>
> /// Serial Port Console Redirection Table Format
>
> ///
>
> @@ -50,6 +51,37 @@ typedef struct {
> UINT32 Reserved3;
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> +///
>
> +/// Serial Port Console Redirection Table Format Revision 4
>
> +///
>
> +typedef struct {
>
> + EFI_ACPI_DESCRIPTION_HEADER Header;
>
> + UINT8 InterfaceType;
>
> + UINT8 Reserved1[3];
>
> + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
>
> + UINT8 InterruptType;
>
> + UINT8 Irq;
>
> + UINT32
> GlobalSystemInterrupt;
>
> + UINT8 BaudRate;
>
> + UINT8 Parity;
>
> + UINT8 StopBits;
>
> + UINT8 FlowControl;
>
> + UINT8 TerminalType;
>
> + UINT8 Reserved2;
>
> + UINT16 PciDeviceId;
>
> + UINT16 PciVendorId;
>
> + UINT8 PciBusNumber;
>
> + UINT8 PciDeviceNumber;
>
> + UINT8 PciFunctionNumber;
>
> + UINT32 PciFlags;
>
> + UINT8 PciSegment;
>
> + UINT32 UartClockFrequency;
>
> + UINT32 PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
> +
>
> #pragma pack()
>
>
>
> //
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118774): https://edk2.groups.io/g/devel/message/118774
Mute This Topic: https://groups.io/mt/105933234/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
2024-05-09 6:33 ` Praveen Sankar N via groups.io
@ 2024-05-09 6:34 ` Praveen Sankar N via groups.io
2024-05-10 0:46 ` 回复: " gaoliming via groups.io
1 sibling, 0 replies; 6+ messages in thread
From: Praveen Sankar N via groups.io @ 2024-05-09 6:34 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: Srinivasan Mani, Sundaresan S, michael.d.kinney@intel.com,
zhiguang.liu@intel.com, Felix Polyudov, Rabisha R
Liming,
Please refer the below link for reference to view the pipelines results.
https://github.com/tianocore/edk2/pull/5641
Thanks,
Praveen Sankar
-----Original Message-----
From: Praveen Sankar N
Sent: Thursday, May 9, 2024 12:03 PM
To: 'gaoliming' <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
Subject: RE: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
Hi Liming,
Pull request is done and pipelines are built successfully and the patch is ready to push to the master.
Thanks,
Praveen Sankar
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Monday, May 6, 2024 7:53 AM
To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Praveen Sankar N <praveensankarn@ami.com>
> 发送时间: 2024年5月2日 19:16
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; Srinivasan Mani <srinivasanm@ami.com>;
> Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> <rabishar@ami.com>
> 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
>
> In SPCR table, 4 structure members have been added newly as per SPCR
> table Revision 4, which has to be added in
> MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
>
> Signed-off-by: Praveen Sankar N praveensankarn@ami.com
>
> Cc: michael.d.kinney@intel.com
>
> Cc: gaoliming@byosoft.com.cn
>
> Cc: zhiguang.liu@intel.com
>
> Cc: Felixp@ami.com
>
> Cc: srinivasanm@ami.com
>
> Cc: sundaresans@ami.com
>
> Cc: rabishar@ami.com
> ---
> .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> index eb5ae28390..bf967880ab 100644
> ---
> a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> +++
> b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> @@ -23,6 +23,7 @@
> ///
>
> #define
> EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
>
>
>
> +#define
> EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> 0x04
>
> ///
>
> /// Serial Port Console Redirection Table Format
>
> ///
>
> @@ -50,6 +51,37 @@ typedef struct {
> UINT32 Reserved3;
>
> } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
>
>
> +///
>
> +/// Serial Port Console Redirection Table Format Revision 4
>
> +///
>
> +typedef struct {
>
> + EFI_ACPI_DESCRIPTION_HEADER Header;
>
> + UINT8 InterfaceType;
>
> + UINT8 Reserved1[3];
>
> + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
>
> + UINT8 InterruptType;
>
> + UINT8 Irq;
>
> + UINT32
> GlobalSystemInterrupt;
>
> + UINT8 BaudRate;
>
> + UINT8 Parity;
>
> + UINT8 StopBits;
>
> + UINT8 FlowControl;
>
> + UINT8 TerminalType;
>
> + UINT8 Reserved2;
>
> + UINT16 PciDeviceId;
>
> + UINT16 PciVendorId;
>
> + UINT8 PciBusNumber;
>
> + UINT8 PciDeviceNumber;
>
> + UINT8 PciFunctionNumber;
>
> + UINT32 PciFlags;
>
> + UINT8 PciSegment;
>
> + UINT32 UartClockFrequency;
>
> + UINT32 PreciseBaudRate;
>
> + UINT16
> NameSpaceStrLength;
>
> + UINT16
> NameSpaceStrOffset;
>
> + CHAR8
> NameSpaceString[0];
>
> +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
>
> +
>
> #pragma pack()
>
>
>
> //
>
> --
> 2.38.1.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118775): https://edk2.groups.io/g/devel/message/118775
Mute This Topic: https://groups.io/mt/105933234/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
2024-05-09 6:33 ` Praveen Sankar N via groups.io
2024-05-09 6:34 ` Praveen Sankar N via groups.io
@ 2024-05-10 0:46 ` gaoliming via groups.io
2024-05-13 4:34 ` Praveen Sankar N via groups.io
1 sibling, 1 reply; 6+ messages in thread
From: gaoliming via groups.io @ 2024-05-10 0:46 UTC (permalink / raw)
To: devel, praveensankarn
Cc: 'Srinivasan Mani', 'Sundaresan S',
michael.d.kinney, zhiguang.liu, 'Felix Polyudov',
'Rabisha R'
It has been merged.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen Sankar
> N via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com;
> Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
> Hi Liming,
> Pull request is done and pipelines are built successfully and the patch is
> ready to push to the master.
>
> Thanks,
> Praveen Sankar
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
> Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com;
> Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
>
> **CAUTION: The e-mail below is from an external source. Please exercise caution
> before opening attachments, clicking links, or following guidance.**
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: Praveen Sankar N <praveensankarn@ami.com>
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaoliming@byosoft.com.cn; Srinivasan Mani <srinivasanm@ami.com>;
> > Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com;
> > zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> > <rabishar@ami.com>
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> >
> > Cc: michael.d.kinney@intel.com
> >
> > Cc: gaoliming@byosoft.com.cn
> >
> > Cc: zhiguang.liu@intel.com
> >
> > Cc: Felixp@ami.com
> >
> > Cc: srinivasanm@ami.com
> >
> > Cc: sundaresans@ami.com
> >
> > Cc: rabishar@ami.com
> > ---
> > .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
> > @@ -23,6 +23,7 @@
> > ///
> >
> > #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> > ///
> >
> > /// Serial Port Console Redirection Table Format
> >
> > ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> > UINT32 Reserved3;
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> >
> > + UINT8 InterfaceType;
> >
> > + UINT8 Reserved1[3];
> >
> > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
> >
> > + UINT8 InterruptType;
> >
> > + UINT8 Irq;
> >
> > + UINT32
> > GlobalSystemInterrupt;
> >
> > + UINT8 BaudRate;
> >
> > + UINT8 Parity;
> >
> > + UINT8 StopBits;
> >
> > + UINT8 FlowControl;
> >
> > + UINT8 TerminalType;
> >
> > + UINT8 Reserved2;
> >
> > + UINT16 PciDeviceId;
> >
> > + UINT16 PciVendorId;
> >
> > + UINT8 PciBusNumber;
> >
> > + UINT8 PciDeviceNumber;
> >
> > + UINT8 PciFunctionNumber;
> >
> > + UINT32 PciFlags;
> >
> > + UINT8 PciSegment;
> >
> > + UINT32 UartClockFrequency;
> >
> > + UINT32 PreciseBaudRate;
> >
> > + UINT16
> > NameSpaceStrLength;
> >
> > + UINT16
> > NameSpaceStrOffset;
> >
> > + CHAR8
> > NameSpaceString[0];
> >
> > +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> > +
> >
> > #pragma pack()
> >
> >
> >
> > //
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
> > you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply e-mail
> > or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
>
>
> -The information contained in this message may be confidential and proprietary
> to American Megatrends (AMI). This communication is intended to be read only
> by the individual or entity to whom it is addressed or by their designee. If the
> reader of this message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then
> delete or destroy all copies of the transmission.
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118777): https://edk2.groups.io/g/devel/message/118777
Mute This Topic: https://groups.io/mt/106013229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
2024-05-10 0:46 ` 回复: " gaoliming via groups.io
@ 2024-05-13 4:34 ` Praveen Sankar N via groups.io
0 siblings, 0 replies; 6+ messages in thread
From: Praveen Sankar N via groups.io @ 2024-05-13 4:34 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: Srinivasan Mani, Sundaresan S, michael.d.kinney@intel.com,
zhiguang.liu@intel.com, Felix Polyudov, Rabisha R
Thanks you so much Liming.
Regards,
Praveen Sankar
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, May 10, 2024 6:16 AM
To: devel@edk2.groups.io; Praveen Sankar N <praveensankarn@ami.com>
Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R <rabishar@ami.com>
Subject: [EXTERNAL] 回复: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**
It has been merged.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Praveen Sankar N
> via groups.io
> 发送时间: 2024年5月9日 14:33
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> <rabishar@ami.com>
> 主题: Re: [edk2-devel] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
> Hi Liming,
> Pull request is done and pipelines are built successfully and
> the patch is ready to push to the master.
>
> Thanks,
> Praveen Sankar
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, May 6, 2024 7:53 AM
> To: Praveen Sankar N <praveensankarn@ami.com>; devel@edk2.groups.io
> Cc: Srinivasan Mani <srinivasanm@ami.com>; Sundaresan S
> <sundaresans@ami.com>; michael.d.kinney@intel.com;
> zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> <rabishar@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH v4 1/1] MdePkg: Added new SPCR table
> Revision 4 structure
>
>
> **CAUTION: The e-mail below is from an external source. Please
> exercise caution before opening attachments, clicking links, or
> following guidance.**
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> > -----邮件原件-----
> > 发件人: Praveen Sankar N <praveensankarn@ami.com>
> > 发送时间: 2024年5月2日 19:16
> > 收件人: devel@edk2.groups.io
> > 抄送: gaoliming@byosoft.com.cn; Srinivasan Mani <srinivasanm@ami.com>;
> > Sundaresan S <sundaresans@ami.com>; michael.d.kinney@intel.com;
> > zhiguang.liu@intel.com; Felix Polyudov <Felixp@ami.com>; Rabisha R
> > <rabishar@ami.com>
> > 主题: [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure
> >
> > In SPCR table, 4 structure members have been added newly as per SPCR
> > table Revision 4, which has to be added in
> > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h.
> >
> > Signed-off-by: Praveen Sankar N praveensankarn@ami.com
> >
> > Cc: michael.d.kinney@intel.com
> >
> > Cc: gaoliming@byosoft.com.cn
> >
> > Cc: zhiguang.liu@intel.com
> >
> > Cc: Felixp@ami.com
> >
> > Cc: srinivasanm@ami.com
> >
> > Cc: sundaresans@ami.com
> >
> > Cc: rabishar@ami.com
> > ---
> > .../SerialPortConsoleRedirectionTable.h | 32 +++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > index eb5ae28390..bf967880ab 100644
> > ---
> > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > +++
> > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.
> > h
> > @@ -23,6 +23,7 @@
> > ///
> >
> > #define
> > EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION 0x02
> >
> >
> >
> > +#define
> > EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION
> > 0x04
> >
> > ///
> >
> > /// Serial Port Console Redirection Table Format
> >
> > ///
> >
> > @@ -50,6 +51,37 @@ typedef struct {
> > UINT32 Reserved3;
> >
> > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> >
> >
> > +///
> >
> > +/// Serial Port Console Redirection Table Format Revision 4
> >
> > +///
> >
> > +typedef struct {
> >
> > + EFI_ACPI_DESCRIPTION_HEADER Header;
> >
> > + UINT8 InterfaceType;
> >
> > + UINT8 Reserved1[3];
> >
> > + EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE BaseAddress;
> >
> > + UINT8 InterruptType;
> >
> > + UINT8 Irq;
> >
> > + UINT32
> > GlobalSystemInterrupt;
> >
> > + UINT8 BaudRate;
> >
> > + UINT8 Parity;
> >
> > + UINT8 StopBits;
> >
> > + UINT8 FlowControl;
> >
> > + UINT8 TerminalType;
> >
> > + UINT8 Reserved2;
> >
> > + UINT16 PciDeviceId;
> >
> > + UINT16 PciVendorId;
> >
> > + UINT8 PciBusNumber;
> >
> > + UINT8 PciDeviceNumber;
> >
> > + UINT8 PciFunctionNumber;
> >
> > + UINT32 PciFlags;
> >
> > + UINT8 PciSegment;
> >
> > + UINT32 UartClockFrequency;
> >
> > + UINT32 PreciseBaudRate;
> >
> > + UINT16
> > NameSpaceStrLength;
> >
> > + UINT16
> > NameSpaceStrOffset;
> >
> > + CHAR8
> > NameSpaceString[0];
> >
> > +} EFI_ACPI_4_0_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE;
> >
> > +
> >
> > #pragma pack()
> >
> >
> >
> > //
> >
> > --
> > 2.38.1.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or
> > by
> their
> > designee. If the reader of this message is not the intended
> > recipient, you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply
> > e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
>
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended to be read only by the individual or entity to whom it is
> addressed or by their designee. If the reader of this message is not
> the intended recipient, you are on notice that any distribution of
> this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
>
>
>
>
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118867): https://edk2.groups.io/g/devel/message/118867
Mute This Topic: https://groups.io/mt/106013229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-05-13 15:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 11:15 [edk2-devel] [PATCH v4 1/1] MdePkg: Added new SPCR table Revision 4 structure Praveen Sankar N via groups.io
2024-05-06 2:23 ` [edk2-devel] 回复: " gaoliming via groups.io
2024-05-09 6:33 ` Praveen Sankar N via groups.io
2024-05-09 6:34 ` Praveen Sankar N via groups.io
2024-05-10 0:46 ` 回复: " gaoliming via groups.io
2024-05-13 4:34 ` Praveen Sankar N via groups.io
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox