From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6D22D940F6D for ; Tue, 31 Oct 2023 04:13:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DFgy/GDOKE+MMsxtogK0ji2mqIMWQkTwlc7eMxG+wvg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698725599; v=1; b=nLHEaC0+IMazVKMm7VJVajwgAqwfCUkwaApyZJEranVYkf3HeAlXhw+05dORCiSG95Fh3MbT YaISl31UwYk4RIkDJXMkDxStgrHCBiMBLio6INhDJUfK8W2riTJnCaEjvwTDTnL2ciiYSolP0fJ +Ko+i9gGi2nPDMP8EfWa+jpk= X-Received: by 127.0.0.2 with SMTP id HpJIYY7687511xzymMo8GSDd; Mon, 30 Oct 2023 21:13:19 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.179449.1698725598580276556 for ; Mon, 30 Oct 2023 21:13:18 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="452485579" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="452485579" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2023 21:13:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10879"; a="760502284" X-IronPort-AV: E=Sophos;i="6.03,264,1694761200"; d="scan'208";a="760502284" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Oct 2023 21:13:17 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 30 Oct 2023 21:13:17 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 30 Oct 2023 21:13:17 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 30 Oct 2023 21:13:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lP0KT09Uidx4YnJXECwCHIRGwLbf1zKW2UWERGCowyhCkelMXxqzwqFLeX+eHH+tA7kRrktaahvybSioYs+7g1JtHj7Y/J0PQO2c4ZTUzzx8zwVm+59rs7KXeWKHVxlEUs9d2rL22fju4oTX3HwJGor7SPJk0KQKNa6YwHRa5ITDxmwzfnE5VjZhfGJyGnYaHpR8vqds4Z+3+vZhxkeD42cgeJTHEmq+/GPBDu80u+tUeAJn2EJCCDy0zO4EhLORS2ygbjpBbIJUDwLpTRRgwp+ijjl3GgXZUG1KTrstwOA3sbKpa94WgBxWHoggoIc9D6CPl/uyfyO3osMLJcA+mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f2TWyErDSNc0ET0f5Efz26zEy3HxoSWep2KuMxwK4jQ=; b=dHlASwmChuvTZm9KGvViZ30wnbzYXLdD3al54n+NczEIw7DA7q4xKT4LWt0RQOlvkCCJMi3MIt0d0sXZCgMbqRHbBAR5DyYzbmhdkJANIhhbJ2GvBP1NPLWgeFDuNbhqYUq8DtGGCVEQ1dSYBcTlRPLVhB7KPiqoQizEb/N1koHi1r/ls/K4zm/JrogwAquZ05RBaKqThquNVb9fdGudbMe4AVRKAowJYCEVpTvbMsgdx5BOTD7C2KZzGR7aLBKNkZJFxqxHO5ylRfcQZRI0gXApzWSeLRHQvLJHOiSzB63UkLN/CGDOx7Y/AiqKXsifS64XX2yx6MjbGwrKLODIpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by MW4PR11MB6761.namprd11.prod.outlook.com (2603:10b6:303:20d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Tue, 31 Oct 2023 04:13:10 +0000 X-Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::2659:597c:90a6:1fc0]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::2659:597c:90a6:1fc0%7]) with mapi id 15.20.6933.028; Tue, 31 Oct 2023 04:13:08 +0000 From: "Andrei Warkentin" To: Dhaval , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" , "Gerd Hoffmann" , Sunil V L , "Laszlo Ersek" Subject: Re: [edk2-devel] [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features Thread-Topic: [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features Thread-Index: AQHaCnbADvj7XHdl1E+Nm9SiRbIsa7BjS6XQ Date: Tue, 31 Oct 2023 04:13:08 +0000 Message-ID: References: <20231029144613.150580-1-dhaval@rivosinc.com> <20231029144613.150580-6-dhaval@rivosinc.com> In-Reply-To: <20231029144613.150580-6-dhaval@rivosinc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|MW4PR11MB6761:EE_ x-ms-office365-filtering-correlation-id: 870ba2d0-48de-4f1a-b061-08dbd9c7b0a2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: bud70eUlMYus8DjhbeH3BqIgiYXzW8MP3s2Ud97E2FyxDwHwsZ0Jn6hairNfSY0g/glRtTkJhNaSPHDWTxR1rt2mO4OqRyv0J8yxG2uilMwKDsCmK5VuUQuwA8v7kmOb103wawMns7VXgNwRMeXexC4yYVuoqrX4b8ecTItXNgk0aDfSzqGSgmESBKWJkO+rz2Rb7K8PRxtCmZlefQwXwRs4WpF8/kKu4159MCg+OK7SReCW1SyqQ4pvTsVOz+xAyx3cvbhbK2EoYMmKfMZXu+sCGiJqvpa+qF+0p5KPLSfQ6BCISGn/k39YNUS0PkphtbJh0gM32HYPwbNJR7qIoUITtNmW8IyUia84gPc19VcLTSHtk0JLApLIuwgTHkEVmtrmzsNPPbZ6qWndFU0c6p8OxvlM16qdBCXLStG+sQyXJAr3YorAgnbIDkoQ0e2JQYvEGaY2oup5phQldqvmeieVSSJV9dQCIgIoXkN91X3oUl94bCS1NQLKfpoZucpFrUfTscA/6zqoS6g/VxXIsqIKDFOXQ3IyzzJHaAlsGifgI87H64xIr4etFY34FrZgupPYmNuVHV7c4hhijXBKv9AbAGYPM0Ph2k0KcRXKo3r5Zn3pHyjr9DUnUQgjDu8F x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fz3YDsO+xy5Gs6Dyiyn8FpTT8qWX5EYDogW1HRQJdexOvgHFdpLOkteBMha5?= =?us-ascii?Q?S6s/WuuPv1TCa1c18t4LgnjVThzbiNgFN6Of9kaINRBIXkRR+eH7XLNs95Hu?= =?us-ascii?Q?8TxZ2FyyucfddEwANjllylG81wMF8lhXGg8uB2nbDKvHt4ZBN0Hj9LZe9CS0?= =?us-ascii?Q?emqLrm70Z7+TiF8dXTW00u4tvSusupCPXROhUnhRaP19kOsDQv1o0RdYAIll?= =?us-ascii?Q?0jQZhx0zaiBAcWB5pJQ4Fo/6RSj1PKZ3zibq7J2NLBqSPlkbL88Vaeu94YO9?= =?us-ascii?Q?/Dp2sXyhIAl3rKRsNeky0OYH6iJIjavX26ppLVYjhhqyCwL22ySbucsWmar7?= =?us-ascii?Q?JfivHY8+xur9P1MxxVDZNNwAQPcKkDPcCOXeP9ANiWVMxqrny7ho9KrOdZIp?= =?us-ascii?Q?ctUdLubMcujdmmMA59umjzKS2oO0SdeX9NjTKKP2ZgLiZw/LdmIqJ8vRx9XS?= =?us-ascii?Q?pK8O3DsSm/QL5LAgSS8jYzSA8bEBPUbzrJCfq6Ec3eySLqR7yKP8H9BH7kx0?= =?us-ascii?Q?/BLw8Wm0v6p5cVSApfYBlO/WwgUgVAfI9HqoI6b51pugL++0UfTs2kTU6qM9?= =?us-ascii?Q?sfly6ubTQlmcl+/0YPRtitQY8eZjVVaZt4ZrC4n+yhHiCHI1pou7INejjdnh?= =?us-ascii?Q?2M4dZS66wdhnyqojq+NV5stZD1TCRqFyk0BY2oXMU/NvlqT6EvMiCsLWIDpe?= =?us-ascii?Q?gxZTFCzIsCpmFI9R61DIVOtydxAknOihjcfc/3LzEhL0r6+yIxa81ARNjjEx?= =?us-ascii?Q?AKgP+xMqV0YQ4mxvbSkCBVVNCr60aTNbZODzrtis82lfmfiUd9aQsksAqdrn?= =?us-ascii?Q?2EidVs4ue0PCpfigHqP65YsLhYmSaVLxCx/R1B0Z7IU0fqshlnwTG4oEo764?= =?us-ascii?Q?6VkCYUdFVUvgbiNuNwhwbe32RRwVDw2N5Qu/aro4VaE3Tt0P3xsUXWUYpAJx?= =?us-ascii?Q?8+rt2J6hH8yD23GAj/1CFrCYvmX8mAvK2VcmEUIOD81spzib2XRluHHI4uNb?= =?us-ascii?Q?lliqPoLIHEimKFNGMFLGAja5jdCUb7u8pp2p+BDzAy0yHa0DcdnHc3GDvIwQ?= =?us-ascii?Q?oIS6RFp5AtIih1CHoUHF28rZDp+9UzZN2C3lLqzNixmtfwEon88NK2HW3jPB?= =?us-ascii?Q?OHvP0Uyg+5bhtYtShy4dCQ/FDRr2POYPqruRMBiiWVJMkdVx5g70mF1Raxv2?= =?us-ascii?Q?lm/hGwe7dVpGLkvYVXaEEdxV6aBMAvzQcLYnj2qUC546GeZ6bjDsQMITV+N5?= =?us-ascii?Q?++Nf654XCA0Zen/jgh92AWK+FvJL2cfLPPE884V9BCwmgdmdQ4tSTplVaacg?= =?us-ascii?Q?BEMQCQAf4jJswnmlgUpuMBD9F2zesLgL3wjLutKuAxF0yJOBzx9n+WdVvr6U?= =?us-ascii?Q?Eza/XMvaQMAF2yAIjROQOHpd3LlU3t/5sS2qzPTbiN1nUxQSXjTO60wxT24x?= =?us-ascii?Q?s/6/9ASCnDWZrSaLO+4XPihxEZFRHubhGgR/vq+0mPjrxqGlA1ii+b+iyvaa?= =?us-ascii?Q?c/qllcSSM7Wx/0mhXSJ3MogPeMyauHyaBxTmFllAfpDkmR+gAKZwwmlCM3CR?= =?us-ascii?Q?XPTi5k8ctw1FFGenirNHJSrfKotIiTZ+b57TvAWsyYRsNQ7vgGCKoAnvVycB?= =?us-ascii?Q?jw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 870ba2d0-48de-4f1a-b061-08dbd9c7b0a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2023 04:13:08.7673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VSYD5xP40qDoyGKUrPasepwtHwKeWjfeOsLcEE0ddK3NgJK7xE7mTQrI4FVmqq8azGY9IrUzKP0b3CFMKACaR+ttORofIqosHyDtlBrS6tE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6761 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,andrei.warkentin@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hyk7jZJOSjfCyW4fmPw56l2Ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nLHEaC0+; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Looks fine to me. While it's not necessary to add a default value PCD to ev= ery platform DSC, it might me a good idea to do so for "example" platforms = like RiscVVirt, so that folks who borrow code are aware of the feature? Reviewed-by: Andrei Warkentin =20 > -----Original Message----- > From: Dhaval > Sent: Sunday, October 29, 2023 9:46 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Ger= d > Hoffmann ; Sunil V L ; > Warkentin, Andrei ; Laszlo Ersek > > Subject: [PATCH v7 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features >=20 > This PCD provides a way for platform to override any HW features that are > default enabled by previous stages of FW (like OpenSBI). For the case whe= re > previous/prev stage has disabled the feature, this override is not useful= and > its usage should be avoided. >=20 > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Sunil V L > Cc: Andrei Warkentin > Cc: Laszlo Ersek >=20 > Signed-off-by: Dhaval Sharma > Acked-by: Laszlo Ersek > --- >=20 > Notes: > V7: > - Added RB tag > v6: > - Modify PCD name according to changes made in Baselib implementation > V5: > - Introduce PCD for platform >=20 > OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > index fe320525153f..5d66f7fe6ae6 100644 > --- a/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > +++ b/OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc > @@ -203,6 +203,7 @@ [PcdsFeatureFlag] > gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > [PcdsFixedAtBuild.common]+ > gEfiMdePkgTokenSpaceGuid.PcdRiscVFeatureOverride|0 > gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumAsciiStringLength|1000000 > gEfiMdePkgTokenSpaceGuid.PcdMaximumLinkedListLength|0-- > 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110362): https://edk2.groups.io/g/devel/message/110362 Mute This Topic: https://groups.io/mt/102256471/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-