From: "Andrei Warkentin" <andrei.warkentin@intel.com>
To: Tuan Phan <tphan@ventanamicro.com>,
"sunilvl@ventanamicro.com" <sunilvl@ventanamicro.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"gaoliming@byosoft.com.cn" <gaoliming@byosoft.com.cn>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"lersek@redhat.com" <lersek@redhat.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
"Ni, Ray" <ray.ni@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>
Subject: Re: [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension
Date: Sat, 2 Mar 2024 03:36:10 +0000 [thread overview]
Message-ID: <PH8PR11MB685623FD6AD76B2E157396FE835D2@PH8PR11MB6856.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CABYABGTB4AQxWcesWEFUpNbhqYsTDySZ6qsyQBte0K_-0w+y6g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3586 bytes --]
I don’t think a warning message around EFI_MEMORY_UC is useful… it’s typical to request such a mapping for device MMIO (e.g. PciHostBridgeDxe, NonDiscoverablePciDeviceDxe, etc). On a system without PBMT yeah the M mode firmware will have to enforce the correct type, but that’s been true until now as well. Warning for _WC may make sense as it’s definitely not a “typical” mapping.
A
From: Tuan Phan <tphan@ventanamicro.com>
Sent: Monday, February 26, 2024 10:34 PM
To: Warkentin, Andrei <andrei.warkentin@intel.com>; sunilvl@ventanamicro.com
Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>; kraxel@redhat.com; lersek@redhat.com; Kumar, Rahul R <rahul.r.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; ardb+tianocore@kernel.org
Subject: Re: [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension
Hi Sunil/ Andrei,
Any comments on this series?
Regards,
On Wed, Feb 14, 2024 at 10:16 PM Tuan Phan via groups.io<http://groups.io> <tphan=ventanamicro.com@groups.io<mailto:ventanamicro.com@groups.io>> wrote:
On Wed, Feb 14, 2024 at 9:43 PM Warkentin, Andrei <andrei.warkentin@intel.com<mailto:andrei.warkentin@intel.com>> wrote:
Do you mind sharing a GH branch with the patch set?
https://github.com/pttuan/edk2/tree/tphan/riscv_mmu_svpbmt
Tuan
A
> -----Original Message-----
> From: Tuan Phan <tphan@ventanamicro.com<mailto:tphan@ventanamicro.com>>
> Sent: Tuesday, February 6, 2024 7:29 PM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>;
> gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com<mailto:zhiguang.liu@intel.com>>;
> kraxel@redhat.com<mailto:kraxel@redhat.com>; lersek@redhat.com<mailto:lersek@redhat.com>; Kumar, Rahul R
> <rahul.r.kumar@intel.com<mailto:rahul.r.kumar@intel.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>;
> sunilvl@ventanamicro.com<mailto:sunilvl@ventanamicro.com>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Warkentin,
> Andrei <andrei.warkentin@intel.com<mailto:andrei.warkentin@intel.com>>; ardb+tianocore@kernel.org<mailto:ardb%2Btianocore@kernel.org>; Tuan Phan
> <tphan@ventanamicro.com<mailto:tphan@ventanamicro.com>>
> Subject: [PATCH v2 0/3] RISC-V: Support Svpbmt extension
>
> This patchset adds support for RISC-V Svpbmt extension.
>
> The GCD EFI_MEMORY_UC and EFI_MEMORY_WC attributes will be mapped to
> IO and NC mode defined in PBMT field.
>
> v2:
> - Generated patch for each package.
>
> Tuan Phan (3):
> MdePkg.dec: RISC-V: Define override bit for Svpbmt extension
> UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension
> OvmfPkg/RiscVVirt: Override Svpbmt extension
>
> MdePkg/MdePkg.dec | 2 ++
> OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
> .../Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 25 ++++++++++++++++++-
> .../BaseRiscVMmuLib/BaseRiscVMmuLib.inf | 1 +
> 4 files changed, 28 insertions(+), 2 deletions(-)
>
> --
> 2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116290): https://edk2.groups.io/g/devel/message/116290
Mute This Topic: https://groups.io/mt/104211191/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
[-- Attachment #2: Type: text/html, Size: 8452 bytes --]
prev parent reply other threads:[~2024-03-02 3:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 1:29 [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension Tuan Phan
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 1/3] MdePkg.dec: RISC-V: Define override bit for " Tuan Phan
2024-02-07 18:01 ` Laszlo Ersek
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 2/3] UefiCpuPkg: RISC-V: MMU: Support " Tuan Phan
2024-02-07 18:15 ` Laszlo Ersek
2024-02-28 18:00 ` Tuan Phan
2024-02-07 1:29 ` [edk2-devel] [PATCH v2 3/3] OvmfPkg/RiscVVirt: Override " Tuan Phan
2024-02-07 20:02 ` Laszlo Ersek
2024-02-07 20:08 ` Tuan Phan
2024-02-15 5:42 ` [edk2-devel] [PATCH v2 0/3] RISC-V: Support " Andrei Warkentin
2024-02-15 6:16 ` Tuan Phan
[not found] ` <17B3F4C51A165C5A.28807@groups.io>
2024-02-27 4:34 ` Tuan Phan
2024-02-28 4:42 ` Sunil V L
2024-02-28 17:22 ` Tuan Phan
2024-03-02 3:36 ` Andrei Warkentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH8PR11MB685623FD6AD76B2E157396FE835D2@PH8PR11MB6856.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox