I don’t think a warning message around EFI_MEMORY_UC is useful… it’s typical to request such a mapping for device MMIO (e.g. PciHostBridgeDxe, NonDiscoverablePciDeviceDxe, etc). On a system without PBMT yeah the M mode firmware will have to enforce the correct type, but that’s been true until now as well. Warning for _WC may make sense as it’s definitely not a “typical” mapping.

From: Tuan Phan <tphan@ventanamicro.com>
Sent: Monday, February 26, 2024 10:34 PM
To: Warkentin, Andrei <andrei.warkentin@intel.com>; sunilvl@ventanamicro.com
Cc: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>; gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>; kraxel@redhat.com; lersek@redhat.com; Kumar, Rahul R <rahul.r.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; ardb+tianocore@kernel.org
Subject: Re: [edk2-devel] [PATCH v2 0/3] RISC-V: Support Svpbmt extension

Hi Sunil/ Andrei,

Any comments on this series?

Regards,

On Wed, Feb 14, 2024 at 10:16 PM Tuan Phan via groups.io <tphan=ventanamicro.com@groups.io> wrote:

On Wed, Feb 14, 2024 at 9:43 PM Warkentin, Andrei <andrei.warkentin@intel.com> wrote:

Do you mind sharing a GH branch with the patch set?

https://github.com/pttuan/edk2/tree/tphan/riscv_mmu_svpbmt

Tuan

A

> -----Original Message-----
> From: Tuan Phan <tphan@ventanamicro.com>
> Sent: Tuesday, February 6, 2024 7:29 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>;
> kraxel@redhat.com; lersek@redhat.com; Kumar, Rahul R
> <rahul.r.kumar@intel.com>; Ni, Ray <ray.ni@intel.com>;
> sunilvl@ventanamicro.com; Yao, Jiewen <jiewen.yao@intel.com>; Warkentin,
> Andrei <andrei.warkentin@intel.com>; ardb+tianocore@kernel.org; Tuan Phan
> <tphan@ventanamicro.com>
> Subject: [PATCH v2 0/3] RISC-V: Support Svpbmt extension
>
> This patchset adds support for RISC-V Svpbmt extension.
>
> The GCD EFI_MEMORY_UC and EFI_MEMORY_WC attributes will be mapped to
> IO and NC mode defined in PBMT field.
>
> v2:
> - Generated patch for each package.
>
> Tuan Phan (3):
> MdePkg.dec: RISC-V: Define override bit for Svpbmt extension
> UefiCpuPkg: RISC-V: MMU: Support Svpbmt extension
> OvmfPkg/RiscVVirt: Override Svpbmt extension
>
> MdePkg/MdePkg.dec | 2 ++
> OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 2 +-
> .../Library/BaseRiscVMmuLib/BaseRiscVMmuLib.c | 25 ++++++++++++++++++-
> .../BaseRiscVMmuLib/BaseRiscVMmuLib.inf | 1 +
> 4 files changed, 28 insertions(+), 2 deletions(-)
>
> --
> 2.25.1