From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.13755.1681834168335086864 for ; Tue, 18 Apr 2023 09:09:28 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=n00dzPsH; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: andrei.warkentin@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681834168; x=1713370168; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uYJFNoOdiHcDmU5J9ed6ghKBZDpwvgf2LRIJ4ci4rSo=; b=n00dzPsHcx7cDRAxqk1H0sXDv8iiRm+Fl+Ixinz1atXXeDF2fkOw7yWQ QOlosHjiYFKBSX1GL6kIrnk/aR3Ah6UnO1p4drM69WDkusFk978iqFclP 3NW3UrnBwAm7EfYncOplQAItm3xZTx/b42/G1lPbGely/sM5YPZkxFAul vWIo7I6KtqTipxfutjbTP4xMKsSSSKnhdN0KQ7ZGSb/P+XW7BSARcXDGU gaHY0Ax3qMOosq5BE2/VakAa4s7ZCh5RpZW8FdJZtFU0LnR7FG1fWdnAS ws5VQ+EtS4QC1UC+ghClYdi+uvitU4UD7iB/N7GP0QnMwTMTM+IsTw/vq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="410440410" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="410440410" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2023 09:05:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10684"; a="641403895" X-IronPort-AV: E=Sophos;i="5.99,207,1677571200"; d="scan'208";a="641403895" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 18 Apr 2023 09:05:48 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 09:05:47 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 18 Apr 2023 09:05:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 18 Apr 2023 09:05:47 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 18 Apr 2023 09:05:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=govOqAh29xncCMnWGYdxyZwBklf9C4NVMnRmrK32hPtjLowZ8x3whe06ZIlQ+FUbpqU/FS97qmvC6JfPvfuLNjJGYUL+HxEtakT/NtYes58GGNw3oya6Yr6YISJLpl9++IZm/wffDVRVQAAcv0Qz/hcFb3NBayFVEOcbU+wfrFFvSTS5B9EY00W8A0Of+EDXf4+/W3xxTedpj8YGc+2ok9pdJg9HsHrPdelU1q3MYA9/kOdAXh+bg0PfXPJgR5K78Fn9tATRUlivN0saURMgGbffxt2tosK0pM0R/d7Pj2jUqF8/okEhTuEapBgFVjUuky2dgjvWt9xW2DAqaOWg7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ht/1nLLVRKANvKYtL/60eVVBNLem5pzxxpFWxnEjkkg=; b=GaO7dAA8cO0ZFUBntNqlh/xPr/D3NPt4QyupnlS9kPH3gu9i247jbi0fO8RsPA1Ti6b/Xb7HX6rO8kvp4MbooAWeIBIhtqfHTqoPMVG8gWr02apil9+THCEpmq+yPwtHm96QqMuhHSAX20dBPKzJ27yTL9rziuScHv5MbpOOjffKABAJY0bYGl0/b70jNe5Gb3NmjCBM0whdGDIKzZu/tfKK+BpuXM2wN0x4tAxcebaX4JluFqv22hOFc9Mf/FSDfLZ4SCe2BAwcvPMvzLGpoc5A9OGsdMAWAaFQxLWneSOyQDSwajwMoNsa27eUPB9e3eEOrsit8HMcCLZkbIeIzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by PH8PR11MB6879.namprd11.prod.outlook.com (2603:10b6:510:229::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 18 Apr 2023 16:05:44 +0000 Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f794:46bc:90a:c3a3]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f794:46bc:90a:c3a3%6]) with mapi id 15.20.6298.045; Tue, 18 Apr 2023 16:05:44 +0000 From: "Andrei Warkentin" To: Tuan Phan , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "sunilvl@ventanamicro.com" , "git@danielschaefer.me" Subject: Re: [PATCH v2 2/6] MdePkg/Register: RISC-V: Add satp mode bits shift definition Thread-Topic: [PATCH v2 2/6] MdePkg/Register: RISC-V: Add satp mode bits shift definition Thread-Index: AQHZbwMndgJOCW4GdE21pcZNlbziW68xQSDw Date: Tue, 18 Apr 2023 16:05:44 +0000 Message-ID: References: <20230414185815.2994-1-tphan@ventanamicro.com> <20230414185815.2994-3-tphan@ventanamicro.com> In-Reply-To: <20230414185815.2994-3-tphan@ventanamicro.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|PH8PR11MB6879:EE_ x-ms-office365-filtering-correlation-id: c7a6a2c1-ba5e-4cbd-0ca3-08db4026c428 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cR4AuKy95iIY/oWAr4spvg++Zdfc1NkBYOPs4mwEuei1c/cafRTQA6/SHjXCOSNZm0/JQ0iXzDj6tx3b3U9UOcGVJwsGbuxrZfHKhTiYroQSMCR2+3/ClgW1i9tMJwYkMs/qsmqJOVtAbuizjjuuKH+Fru3pPybYAHOQnEiX0E+uElE1IghWTuYr5jGTdz4aMbePOVj5z6vuIVVaOLnhtWPILVXMIp7ULrOM+SIAY6oOWkqv/HFaBRQf3EHeCAXLWEn14GWdPclQQLDWnQG5Kw1QLoHZn7H1/1Ex0BTOUG2CFMjBURqHb+iNeZ4JOqPVOjrqMetRxl4ussoS/1YOgVGLRcAnvHy30h7QGQjm4+vwRrYkrxq3wQkKXMWsHyPUvy8jcI7JXE7Uc+T0lXjZSFEnMHFl+8TfnpsB5lWZhNuPh2O0N/ujKnnHkRjT/lP+6XBto7yXpVe6cpew+318UNU4fsPPZo75QtxwS9c91QvM8r4+g5uwkZ9W78MJpUcn710fBmYafOvdbvy5pnnhhWHVofkg3u0FVorIUmXPfS8Cu12ok7ycnezPoCdAjFRi6d+Zs3IT+0Zx+kwxcu2B0KJvAPPg2tCwxtGoKjxUKy0EaJxRIis6owMgBV89Kp8G x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB6856.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(366004)(376002)(346002)(396003)(136003)(451199021)(478600001)(71200400001)(7696005)(82960400001)(55016003)(122000001)(83380400001)(33656002)(38070700005)(86362001)(38100700002)(316002)(2906002)(66446008)(19627235002)(53546011)(9686003)(54906003)(26005)(110136005)(6506007)(186003)(66476007)(5660300002)(76116006)(66946007)(52536014)(41300700001)(8936002)(66556008)(8676002)(4326008)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p9erzZP/zc80AuSnY+c6ebKDdTNUwc8Aph6HdiTOjRghX7xEyW75F+CBEiIi?= =?us-ascii?Q?9dge4HSh9yPyvWE0+7UaRSgNF/Fc8JGA5Rra4PCfYOQln/tcsf2BFDylbBWn?= =?us-ascii?Q?3p4qJbqL8Jc0YFWsWeLhS7CjaYoL7xFTa31pRUS2duXp2QfhSZfc7Ns0OCTR?= =?us-ascii?Q?ZD7SycT09T+mlrlK0A9kPDEZ9JhkUVR2rN/MzQiVBHf/rsYKF0RXm/UDrUvw?= =?us-ascii?Q?5NeRyMaOToflBoqQ1Hrg03zPk1Kb4gQwc4pb1zbTORhjL7uFPUR742f08us2?= =?us-ascii?Q?pdCdo0JY7J2/WqVd4ya170bYVlFF0zoWp2U9Gzz5BFS9qI08dAHshAAqBisk?= =?us-ascii?Q?IxGF7vNg6/Fd813SB75w08mUZh+TroC9EQXfO5yW6suCNIeEBJHPemRsD+0z?= =?us-ascii?Q?RSIet99k/JeV4IMmLInTVDtaSt6u63m/xCOrYVixGaD6WYhBPuIlCL/ZsR22?= =?us-ascii?Q?3GD+8Mca10IpYdNQPailiElWQdxVUx+jgT9eQ76vTQq4hnO0CbW948mQmAnx?= =?us-ascii?Q?MSaqZemX+VvWdb87nSIBIlJm4fmB7YoyXVkEKul6zTiHU6gFClYNCYaItdFH?= =?us-ascii?Q?ZVwIxLaJsIhZrHd9+1DNrNUoRG4qe6sD5C3B7BD05H6VydvvkRgHGWdc6Poj?= =?us-ascii?Q?4Jn82d6gC9/PfHR7DhjliUilQiPUykXhmWtwT3CjrYWt9Grhgt5VC43MTh0c?= =?us-ascii?Q?JPZCIqzmRk4aS01K1oH46t7rzww8m/WOpH2/mpN/G2sMVBjFMs8VM3b+p2xr?= =?us-ascii?Q?Z/avS7Bg5zMrDx4+tAGy0AZZGP0TD9Jn2bQT7J34z1q0iGNj38QxF8JjLqq3?= =?us-ascii?Q?BgpXA7NCI8+AIZxoZDnz+pBuPVNGE0SFaKa/XC94sbN+7bbFGu1JHVH1ypVy?= =?us-ascii?Q?8G6EBzz6hmiGPGrarMjBlHob2KhK6Xssi2FLq4/gWlYC3OxqzufRc9Qk80Aa?= =?us-ascii?Q?Zc0/mbbcvVaeflYNY9FXo6oduQ5p/3TsI9/080F4LbhuQ69lGepot9uRRhQH?= =?us-ascii?Q?UKzDiwOsNhWDESkgyxmLYqO2pvX4SIOWY5ETbDx04hPAn25P5b7NB0C8Jck7?= =?us-ascii?Q?xN2GKQmgg786RTSkzdbirY4mKIgTmtKPRH3PBaZY2/MbZxxiRuWYLd/+r9vN?= =?us-ascii?Q?6bkFsGpmdNeayltew6Sjw/THsE8mQKH+pHKQXmBlYP7uqcH4n887dJhGrrEb?= =?us-ascii?Q?WH0QlU1AoiSOl3r8nVWKzULFr6K5KHN4Ti4RXF4aAKWunVedcBEK6E6i1inQ?= =?us-ascii?Q?sRgZQHX6f0ZCjbp/FXe8wVUJA67LY1bmZ43BUX6Hq+D6mfgArngJd1HLwZE7?= =?us-ascii?Q?GmIRbLs4S1gH+Pg7VbE2nGoQaN+Uth54AnmHwN74Mn7ZGV4Ltw539aDOA/wI?= =?us-ascii?Q?Le1Jxgxiy9jjMixi3GC6UMWOQo++6ILuuqT5a26Azb0J1N31/gE/C6bVDEUY?= =?us-ascii?Q?tP9oWj2NuHmAODrXX/NdukUHnkKxGMhTykoEf9ot/JHCxKjzj+VWPubfU14q?= =?us-ascii?Q?NuyVKopLw4yJimA7jsamOeej50N8cfxGpcdOkmjwPdmaUtJj9+ahuE2QG9cT?= =?us-ascii?Q?NvMUGah5fkmuarESlOQ0FjEvahu5UFrHhO/3Vz6QtzADM9nOqgcCwJ2NiVHU?= =?us-ascii?Q?0A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7a6a2c1-ba5e-4cbd-0ca3-08db4026c428 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2023 16:05:44.6376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l2VgauYOJTc6tjhnEzhfA0AUxGOca8LAlVfEIIXf+lxshPnnfRTe3zPETb+HhonHbsPSZc5ZYlvVSaP32RGqkECAbil6mqQeC5RH3yH8KqE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6879 Return-Path: andrei.warkentin@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks reasonable to me (but my email view of the patch is corrupted... so p= lease follow up with a link to a Github branch) Reviewed-by: Andrei Warkentin > -----Original Message----- > From: Tuan Phan > Sent: Friday, April 14, 2023 1:58 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; > sunilvl@ventanamicro.com; git@danielschaefer.me; Warkentin, Andrei > ; Tuan Phan > Subject: [PATCH v2 2/6] MdePkg/Register: RISC-V: Add satp mode bits shift > definition >=20 > The satp mode bits shift is used cross modules. It should be defined in o= ne > place. >=20 > Signed-off-by: Tuan Phan > --- > MdePkg/Include/Register/RiscV64/RiscVEncoding.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/Register/RiscV64/RiscVEncoding.h > b/MdePkg/Include/Register/RiscV64/RiscVEncoding.h > index 5c2989b797bf..2bde8db478ff 100644 > --- a/MdePkg/Include/Register/RiscV64/RiscVEncoding.h > +++ b/MdePkg/Include/Register/RiscV64/RiscVEncoding.h > @@ -58,9 +58,10 @@ > #define PRV_S 1UL #define PRV_M 3UL -#define SATP64_MODE > 0xF000000000000000ULL-#define SATP64_ASID 0x0FFFF00000000000ULL- > #define SATP64_PPN 0x00000FFFFFFFFFFFULL+#define SATP64_MODE > 0xF000000000000000ULL+#define SATP64_MODE_SHIFT 60+#define > SATP64_ASID 0x0FFFF00000000000ULL+#define SATP64_PPN > 0x00000FFFFFFFFFFFULL #define SATP_MODE_OFF 0UL #define > SATP_MODE_SV32 1UL-- > 2.25.1