From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.15159.1677763963285566691 for ; Thu, 02 Mar 2023 05:32:43 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=UfGJDT+h; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: andrei.warkentin@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677763963; x=1709299963; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=dZoBQl/2oCi9RLqTWmHwxCDdmmoTn5La34Nw1zEQOFc=; b=UfGJDT+hT/xB0NKasFuXYz0ugiHmdDE2PuM4Iuf86252/VgViUQBj29t DpGOIbGYa4RFSB+Vbzo280jSTB/5EvCacLxWwQ45vQ6yRrvrd1lJERvsy eE/Yvnf1DT4Vem4iTbFx8rBi4YHq7ek/ERaXGDrZ7nWwrcn+NGC5Y108M yBj/PPLo8eZGhFzZpPDGAee3xacEeBXCyqtTWl5ZEi0ab/M1CW2kYHOUe GD7z2ncxzfhc+DM1KaMmjqYEEvuYwc4NHr3hWZVw5wfnVMivwNdAugVID QsC1LYX+XZoqu6pqCFuynjM9C1TTyZsPJtaYbzzDoJKjtRvp+aX6wD3aZ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="336220224" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208,217";a="336220224" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2023 05:32:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10636"; a="818016002" X-IronPort-AV: E=Sophos;i="5.98,227,1673942400"; d="scan'208,217";a="818016002" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 02 Mar 2023 05:32:33 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 05:32:33 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 2 Mar 2023 05:32:33 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 2 Mar 2023 05:32:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oVd1OtmfuhGQkzVYdmg1TrF3dVlyRBZqJizP6lWt0b7EYpMDh1uLBOkxL0SBJE9FOhNm7BMHjnVKpDbSDD1+bNn9T9JUdCQ88b8nbT+yGRqn+7D/UhoIINIoPdcgKS2D6VlLv8zTsbRGvrQwFjt5ElnLD0VnLp3RWgQOMPIiGrWDSv5a+rgN4qROMFKTUuakiKc2iwV7w07knrWGLrCYefY414T4anWd4vbphaXD1vZZ+ZNRhTHz19c8HVB5R3STGyPJ3ty6gLWZ8pDHYU7PJVWkAKtAqDEBBlNELnBVviVGwjoUMR1pcradECozh+e9hw/87V3pcF2QR8gIRSGYcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKcLsmpxWmDvW3yCihIIOxMNiN+dZqB3ZGmBL5LRIF8=; b=iBfc+iaUttz/Ppa27f980pDnZyqQyXVO5Z3pO54LN9IJiYFkAuedLrfM3WtO71Wd2OGjggz7UARjFX5I5Y6iHARtWRGsap48p0R64frYMTTrkFVfTHyOTFIN9nhAEballOlF5spdlq4y2hbSMdN8QF4bTJy4W0kq2eSJ0tHEDvEDZCWUYNSI8FKveTfxLWLNkJgbO7juqp6/flN2Ap9ZUelWuDcJ7lC/zRbMmvVSR58sXTmqBZD/PVTjNR3XnaTVY/8fJ9nYd5xl2N/FMVSAmhoWvvvaph9bzY+UwZp3el34nKbsBfr20kkisGF5QroAQeMs9hPPO4YGJE1c1XYHwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH8PR11MB6856.namprd11.prod.outlook.com (2603:10b6:510:22b::7) by PH8PR11MB6976.namprd11.prod.outlook.com (2603:10b6:510:223::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Thu, 2 Mar 2023 13:32:31 +0000 Received: from PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1]) by PH8PR11MB6856.namprd11.prod.outlook.com ([fe80::f480:22ed:c915:13f1%4]) with mapi id 15.20.6156.019; Thu, 2 Mar 2023 13:32:31 +0000 From: "Andrei Warkentin" To: Sunil V L , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "kraxel@redhat.com" , Daniel Schaefer Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi Thread-Topic: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi Thread-Index: AQHZTBGktsGAlJgxMk25oICBgpdT/K7lk0kAgAAJLs2AAAXHAIAAguSAgAAHMxCAAAhOAIAAACuQgAEYVYCAADEs4w== Date: Thu, 2 Mar 2023 13:32:31 +0000 Message-ID: References: <20230301074358.26356-1-andrei.warkentin@intel.com> <20230301074358.26356-3-andrei.warkentin@intel.com> <20230301081332.lzb5v7enjfillnfb@sirius.home.kraxel.org> <20230301090704.essvs54b2glrsjmd@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH8PR11MB6856:EE_|PH8PR11MB6976:EE_ x-ms-office365-filtering-correlation-id: d4b145fa-a9ee-4953-5757-08db1b2292f7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Rse3Ffvk1DE9lHD0kiSVIRfbB4j6wmxjAtss4232LzlRQv1B2U47plOIbtYRv43PMu2fVZbczJwGa3xX2JRrfxQuhEsO7CEjvHwA68AM80SEF0IjiRtkR0fbrskIwvtcvXeus0/84RkSfvu7mReQGILZVLY5WKEnqmr7f7PU83sV7bMiFLZG+6SJGydC0mzbMHBUpR1dEAyqK4HXaMfD7M++lGGCeExwT1Oz5q8hFT0IvJuc0D+7iZMWwTHg6wc67cwhG5Qnyh7l9Ju1Ivmdf2P/t23tDzg2S7ZzCc1Tmd3gABI0Msab2BTPMA83tip0qHVJonORXzfKGM18jl823+bTp22YOM675MrySpziD0Yh1QwhhuQXV6h30pXaBhIT/Gc6v1fJiQ+8MhZKzyls+oaCmHToUMp4xBNTj00w+ceNGltxSA8YllyPhfwWXxT1uwm2mQ3bkc3HeJWhPmCWn1zIumnb/M5bmnZbLe8jYEgnDb0eh6456jkvSzy573HfdraohTTJkffJCJHivE+Mq9D6P3K9hcS//UYkadQGay9zQf/xnEYbUz3WedBGuEH2HvICbSScqhTLdgk0fUDmlONBcXy1b8KABg05LpjTZSZAchcekYje7TO3TiF9aefEuilPY9RB4jpJAye1A8dJDE3U8n977rYvCoi9AimmeJ6lm0/4O2j2ANT/8DLPmzdyzjm9cPdxr3jtoHnpLZLlFFXKBq5lal0C4YcSfDByMMQVNuSrKjaFA/ChYMslF6ws7jfBRbmzRCKkB64aVbDNmzzZWvWY6cJDmWAzg89XBos= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR11MB6856.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(366004)(346002)(136003)(396003)(451199018)(86362001)(33656002)(9686003)(55016003)(53546011)(186003)(76116006)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(4326008)(41300700001)(8936002)(52536014)(54906003)(966005)(110136005)(478600001)(122000001)(316002)(71200400001)(7696005)(6506007)(26005)(91956017)(5660300002)(38100700002)(82960400001)(38070700005)(166002)(83380400001)(2906002)(66899018)(145603002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?udBYia+S7k53t0rnQu4GepyBDwKMlPjcSeVSpHlw0zltFKRxRR6NCLIQY6h9q6?= =?koi8-r?Q?grMIM6YzeJfoY/YwZ1SivQIb+EMn7AGns3l0tB9o3HAvu7h9VGOpmiCmJwKifG?= =?koi8-r?Q?oshKhFdwwz1ce0VEokXjcO8C8DfQCMWmE29O6FASSV3CyCj6WRd1n3uuSB6+Ng?= =?koi8-r?Q?8xpi0KgALuai/jRRWm4yUwBNWTauR6HK66XwT7s+gMpAZRUPegTM4LNQZipiMw?= =?koi8-r?Q?GU3Hjx27byN624hmSBeIjFOElEnzm+f8QGMpMar6c0IMD6GjbNdS7jCde5zVKQ?= =?koi8-r?Q?X/cbat8RIbiiMxlMWZ+nLvfJjTDdTp2G+ael+OvIH09vqFOj6H9B8yFLQs2YJC?= =?koi8-r?Q?dhLXYVDrGIL1ihQP+djU86VxjztEzh/6rIOs2Q5GAbDGy1okSPyA7Ji/zDssqD?= =?koi8-r?Q?4tUvYDTaPOkoB5L8FL7wVXCnVF7W1YiGF1wUjgofoVPMDgxJmzdCn16r9KVg+e?= =?koi8-r?Q?fQPPkGyusxShFw9zgL5+slEIAx/EvpHsNIz8q5iJ2NjqmdSIy0y+/27dBZyVvt?= =?koi8-r?Q?7hY9SUWDhP8b5DKUxVkIWud4ufddGbq3HFyNfALF2q9G7hJzAJjQTV7B6eb6dS?= =?koi8-r?Q?11CwvrRMOlpreLKFK+2MUrxYKxvdtOrrBGe5vWEjx5MS9LY/OZ/yov5P02PZYu?= =?koi8-r?Q?bOa4kk02A42S5iiB6/5cZvLPaN4mWAjpZ3DPLSibwZQCnaw9I7VXZ7wecqTOzx?= =?koi8-r?Q?+HG8TlDRY1Tbrce9FJ3V0ZjXEr5iXmaGIBlt8sVKy0NgAx1D3EI8lyGZI3bTtY?= =?koi8-r?Q?Ag9ThVjtubcVZtOZgl/TF1E3hXoikQm7RrWCN0mN1zvEhp0jX78JaBqpChVrJy?= =?koi8-r?Q?XIcsuM5OZYjHcLwvT7k5sgwaED9rH42FAyK2hFtJmg7uUq+83WRCAHvs3jVLsv?= =?koi8-r?Q?/mUAy4bc/0vAhWkCTYCmYkUP8dLVpCdzsZeSWOUuuxVpNt0RBJzODc5i7Cs0KX?= =?koi8-r?Q?EkOd8PANfg6FAcAlwTcQ2ZpEMhmPWbDkEsKFToAlueuunfArHT+hfV1pSvGwRB?= =?koi8-r?Q?UVFTWgBeiAunGBnyBbz+nzYQCiRwnpwqAS6snVowSPw9kc9CQQW5gpseQ98bf2?= =?koi8-r?Q?WQReUItk37Ypt/GRMx3Rutj2TDo2D1PXUGp6as+O9iMH5FLy5QYu/S4gUKkBg1?= =?koi8-r?Q?ov2wOfcji+tRmEme+mDRWdM4IGVUjvoNWY1I/whB/VrhT+vOwL4q6GznTHen8T?= =?koi8-r?Q?bsF/GLPRrAUlL6hDQE1UppuELqRURl7X4csfUcS32d2cGBk4r6BY4kwtclUmLH?= =?koi8-r?Q?2/EnWF+UXgDnB4dClkdM2syi+ggGi3U7zX1Bv4+KrbQ01+6AfCKHX91WhnzQDV?= =?koi8-r?Q?62u1waqqNMY/EW4A0Ugdlx0rjZFGkelhAjKtqC2ARBTjDWUWG/j/j+jROv+awn?= =?koi8-r?Q?jFPzGrvEQrfIlqNNFLTbZAi5xTFGdtUD+15Ejxv32W2KPUCibTDAmjNwHWUmxA?= =?koi8-r?Q?Lx7uLHdfEG+VxBDihj9KH/V57WRtOWI7LvFDEeugGeCZoHkPdvdE/5OXFMHs1D?= =?koi8-r?Q?05athEGbwKle0b054oX1Qt4Nk9AUqWEgYLaPqH11hupzLNSgi8C56KRitOB/p1?= =?koi8-r?Q?1JtDby6qLqGfCdVBuYoBHoxS070K+2c=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6856.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4b145fa-a9ee-4953-5757-08db1b2292f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2023 13:32:31.1422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Dbqx3qW3K4QST8kUED+lJRTHKK+a0mZyQJhIjdHRF1NlRZ+agw6YVhg0k6TBp0zwEKsVdrzYrTp2ueZlzpUsiimT/sBxjg4RKnA5t+IzmYs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6976 Return-Path: andrei.warkentin@intel.com X-OriginatorOrg: intel.com Content-Language: ru-RU Content-Type: multipart/alternative; boundary="_000_PH8PR11MB6856713BFE699C0B1961656783B29PH8PR11MB6856namp_" --_000_PH8PR11MB6856713BFE699C0B1961656783B29PH8PR11MB6856namp_ Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable That's exactly what I did. The SecPei variant has no globals and always pro= bes (but can't read, only writes) Will send an updated patch set later today. A ________________________________ =EF=D4: Sunil V L =EF=D4=D0=D2=C1=D7=CC=C5=CE=CF: =DE=C5=D4=D7=C5=D2=C7, =CD=C1=D2=D4=C1 2, 2= 023 4:35 AM =EB=CF=CD=D5: devel@edk2.groups.io ; Warkentin, Andre= i =EB=CF=D0=C9=D1: Kinney, Michael D ; kraxel@red= hat.com ; Daniel Schaefer =F4=C5=CD=C1: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRisc= VSbi Hi Andrei, It is not just mLastGetChar but mHaveDbcn also will have the same issue with XIP. So, I am wondering why not probe for the extension in every write for the SecPei case? I understand the performance concerns but does it real= ly matter for debug output? I believe it is minor compared to the flexibility it provides for not having a fixed serial port implementation. Thanks, Sunil On Wed, Mar 01, 2023 at 05:56:36PM +0000, Andrei Warkentin wrote: > Thanks... let me go a different route. > > I'll have 1 more variant that can be used in classical SEC and PEI - only= capable of output (input doesn't matter) and rename the one I already shar= ed. I'll name these SecPeiSerialPortLibRiscVSbi and PrePiDxeSerialPortLibR= iscVSbi, respectively. > > Does this sound acceptable? > > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, March 1, 2023 11:51 AM > To: Warkentin, Andrei ; devel@edk2.groups.io;= kraxel@redhat.com > Cc: Daniel Schaefer ; Sunil V L ; Kinney, Michael D > Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSb= i > > If a dependency on MdePkg\Include\Library\ BaseRiscVSbiLib.h and SBI serv= ices assumed memory is available and code loaded is loaded into RAM and not= XIP, then BASE is ok for this component. > > You may want to make sure the library class header file and INF file head= er for BaseRiscVSbiLib describe that environment assumption and the INF for= BaseSerialPortLibRiscVSbi also describes that environment assumption. > > Mike > > > -----Original Message----- > > From: Warkentin, Andrei > > Sent: Wednesday, March 1, 2023 9:26 AM > > To: Kinney, Michael D ; > > devel@edk2.groups.io; kraxel@redhat.com > > Cc: Daniel Schaefer ; Sunil V L > > > > Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add > > BaseSerialPortLibRiscVSbi > > > > Hi Michael, > > > > What module type should I use instead? The reason being this > > SerialPortLib implementation specifically fits into the class of UEFI > > implementations, where RAM is always available (initialized by somethin= g else prior to Tiano) and non-const globals can be used (e.g. PrePi). > > > > A > > > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Wednesday, March 1, 2023 10:56 AM > > To: devel@edk2.groups.io; kraxel@redhat.com; Warkentin, Andrei > > > > Cc: Daniel Schaefer ; Sunil V L > > ; Kinney, Michael D > > > > Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add > > BaseSerialPortLibRiscVSbi > > > > Using a global is not compatible with XIP code where only const globals= are supported. > > > > A module of type BASE is considered compatible with XIP components. > > > > > > Mike > > > > > -----Original Message----- > > > From: devel@edk2.groups.io On Behalf Of Gerd > > > Hoffmann > > > Sent: Wednesday, March 1, 2023 1:07 AM > > > To: Warkentin, Andrei > > > Cc: devel@edk2.groups.io; Daniel Schaefer ; > > > Sunil V L > > > Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add > > > BaseSerialPortLibRiscVSbi > > > > > > On Wed, Mar 01, 2023 at 08:50:38AM +0000, Warkentin, Andrei wrote: > > > > The library caller could call Poll() first, > > > > > > Ah, Poll is part of the library API, not just an internal helper. > > > Ok, makes sense then. > > > > > > series: > > > Acked-by: Gerd Hoffmann > > > > > > take care, > > > Gerd > > > > > > > > > > > > > > > > > > >=20 > > --_000_PH8PR11MB6856713BFE699C0B1961656783B29PH8PR11MB6856namp_ Content-Type: text/html; charset="koi8-r" Content-Transfer-Encoding: quoted-printable
That's exactly what I did. The SecPei variant has no globals and alway= s probes (but can't read, only writes)

Will send an updated patch set later today.

A
=EF=D4: Sunil V L <sunilvl@ventanamicro.com>
=EF=D4=D0=D2=C1=D7=CC=C5=CE=CF: =DE=C5=D4=D7=C5=D2=C7, =CD=C1=D2=D4= =C1 2, 2023 4:35 AM
=EB=CF=CD=D5: devel@edk2.groups.io <devel@edk2.groups.io>; War= kentin, Andrei <andrei.warkentin@intel.com>
=EB=CF=D0=C9=D1: Kinney, Michael D <michael.d.kinney@intel.com>= ;; kraxel@redhat.com <kraxel@redhat.com>; Daniel Schaefer <git@dan= ielschaefer.me>
=F4=C5=CD=C1: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPort= LibRiscVSbi
 
Hi Andrei,

It is not just mLastGetChar but mHaveDbcn also will have the same issue
with XIP. So, I am wondering why not probe for the extension in every write=
for the SecPei case? I understand the performance concerns but does it real= ly
matter for debug output? I believe it is minor compared to the
flexibility it provides for not having a fixed serial port
implementation.

Thanks,
Sunil

On Wed, Mar 01, 2023 at 05:56:36PM +0000, Andrei Warkentin wrote:
> Thanks... let me go a different route.
>
> I'll have 1 more variant that can be used in classical SEC and PEI - o= nly capable of output (input doesn't matter) and rename the one I already s= hared.  I'll name these SecPeiSerialPortLibRiscVSbi and PrePiDxeSerial= PortLibRiscVSbi, respectively.
>
> Does this sound acceptable?
>
> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, March 1, 2023 11:51 AM
> To: Warkentin, Andrei <andrei.warkentin@intel.com>; devel@edk2.g= roups.io; kraxel@redhat.com
> Cc: Daniel Schaefer <git@danielschaefer.me>; Sunil V L <sunil= vl@ventanamicro.com>; Kinney, Michael D <michael.d.kinney@intel.com&g= t;
> Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRisc= VSbi
>
> If a dependency on MdePkg\Include\Library\ BaseRiscVSbiLib.h and SBI s= ervices assumed memory is available and code loaded is loaded into RAM and = not XIP, then BASE is ok for this component.
>
> You may want to make sure the library class header file and INF file h= eader for BaseRiscVSbiLib describe that environment assumption and the INF = for BaseSerialPortLibRiscVSbi also describes that environment assumption. >
> Mike
>
> > -----Original Message-----
> > From: Warkentin, Andrei <andrei.warkentin@intel.com>
> > Sent: Wednesday, March 1, 2023 9:26 AM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io; kraxel@redhat.com
> > Cc: Daniel Schaefer <git@danielschaefer.me>; Sunil V L
> > <sunilvl@ventanamicro.com>
> > Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add
> > BaseSerialPortLibRiscVSbi
> >
> > Hi Michael,
> >
> > What module type should I use instead? The reason being this
> > SerialPortLib implementation specifically fits into the class of = UEFI
> > implementations, where RAM is always available (initialized by so= mething else prior to Tiano) and non-const globals can be used (e.g. PrePi)= .
> >
> > A
> >
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, March 1, 2023 10:56 AM
> > To: devel@edk2.groups.io; kraxel@redhat.com; Warkentin, Andrei > > <andrei.warkentin@intel.com>
> > Cc: Daniel Schaefer <git@danielschaefer.me>; Sunil V L
> > <sunilvl@ventanamicro.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [edk2 2/2] MdePkg: add
> > BaseSerialPortLibRiscVSbi
> >
> > Using a global is not compatible with XIP code where only const g= lobals are supported.
> >
> > A module of type BASE is considered compatible with XIP component= s.
> >
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On B= ehalf Of Gerd
> > > Hoffmann
> > > Sent: Wednesday, March 1, 2023 1:07 AM
> > > To: Warkentin, Andrei <andrei.warkentin@intel.com>
> > > Cc: devel@edk2.groups.io; Daniel Schaefer <git@danielscha= efer.me>;
> > > Sunil V L <sunilvl@ventanamicro.com>
> > > Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add
> > > BaseSerialPortLibRiscVSbi
> > >
> > > On Wed, Mar 01, 2023 at 08:50:38AM +0000, Warkentin, Andrei = wrote:
> > > > The library caller could call Poll() first,
> > >
> > > Ah, Poll is part of the library API, not just an internal he= lper.
> > > Ok, makes sense then.
> > >
> > > series:
> > > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > >
> > > take care,
> > >   Gerd
> > >
> > >
> > >
> > >
> > >
>
>
>
>
>
>
--_000_PH8PR11MB6856713BFE699C0B1961656783B29PH8PR11MB6856namp_--